Re: [PATCH 0/8] Add support for Qualcomm SA8155-ADP board

2024-03-04 Thread Konrad Dybcio
On 3/4/24 16:51, Volodymyr Babchuk wrote: Hi Stephan, Stephan Gerhold writes: On Fri, Mar 01, 2024 at 06:25:39PM +, Volodymyr Babchuk wrote: Caleb Connolly writes: On 29/02/2024 14:21, Volodymyr Babchuk wrote: This patch series adds support for Qualcomm SA8155-ADP development

Re: [PATCH 4/8] clk: qcom: add support for power domains uclass

2024-03-01 Thread Konrad Dybcio
On 29.02.2024 15:21, Volodymyr Babchuk wrote: > Now sub-drivers for particular SoCs can register them as power domain > drivers. This is needed for upcoming SM8150 support, because it needs > to power up the Ethernet module. > > Signed-off-by: Volodymyr Babchuk > --- > >

Re: [PATCH 2/6] serial: msm-geni: remove redundant includes

2023-03-30 Thread Konrad Dybcio
dimir Zapolskiy > --- Reviewed-by: Konrad Dybcio Konrad > drivers/serial/serial_msm_geni.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/drivers/serial/serial_msm_geni.c > b/drivers/serial/serial_msm_geni.c > index 3943ca43e49e..df61ae04df0a 100644 > --- a/drivers/s

Re: [PATCH 6/6] serial: msm-geni: correct oversampling value based on QUP hardware revision

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 21:47, Vladimir Zapolskiy wrote: > Starting from QUP v2.5 the value of oversampling is changed from 32 > to 16, keeping the old value on newer platforms results on wrong set > UART IP clock divider, thus the asked baudrate does not correspond to > the actually set with all the

Re: [PATCH 5/6] serial: msm-geni: fix a compile time warning from msm_serial_setbrg()

2023-03-30 Thread Konrad Dybcio
y > --- Fixes: 324df15a292e ("serial: qcom: add support for GENI serial driver") Reviewed-by: Konrad Dybcio Konrad > drivers/serial/serial_msm_geni.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/serial/serial_msm_geni.c >

Re: [PATCH 4/6] serial: msm-geni: fix code indentation

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 21:47, Vladimir Zapolskiy wrote: > This a cosmetic change, which corrects code indentation in a few places. > > Signed-off-by: Vladimir Zapolskiy > --- Reviewed-by: Konrad Dybcio Konrad > drivers/serial/serial_msm_geni.c | 11 +-- > 1 file changed,

Re: [PATCH 3/6] serial: msm-geni: remove invalid se-clk clock name

2023-03-30 Thread Konrad Dybcio
t; "se-clk" clock name is invalid, if added, it shall get "se" value like > it's already described in Linux device tree documentation. > > Signed-off-by: Vladimir Zapolskiy > --- OK this is even better than my approach of using "se", didn't know we could jus

Re: [PATCH 1/6] misc: add Qualcomm GENI SE QUP device driver

2023-03-30 Thread Konrad Dybcio
e > +#include > +#include > +#include > + > +static int geni_se_qup_read(struct udevice *dev, int offset, > + void *buf, int size) > +{ > + fdt_addr_t base = dev_read_addr(dev); > + > + if (size != sizeof(u32)) > + return -EINVA

Re: [PATCH 7/7] arm: Migrate Apple M1 to save_prev_bl_data

2023-03-28 Thread Konrad Dybcio
On 27.03.2023 21:31, Mark Kettenis wrote: >> From: Konrad Dybcio >> Date: Fri, 24 Mar 2023 01:40:40 +0100 > > Hi Konrad, > >> Mark's and Dzmitry's approaches come down to the same thing.. Let's >> unify them by first removing the static keyword from the com

[PATCH v2 9/9] arm: Migrate Apple M1 to save_prev_bl_data

2023-03-27 Thread Konrad Dybcio
mach-apple implementation of this very thing and enable the common approach in the respective defconfig. Only build-tested. Signed-off-by: Konrad Dybcio --- arch/arm/lib/save_prev_bl_data.c| 14 +++--- arch/arm/mach-apple/Makefile| 1 - arch/arm/mach-apple/lowlevel_i

[PATCH v2 5/9] arch: snapdragon: clock: Always bind before relocation

2023-03-27 Thread Konrad Dybcio
In preparation for supporting upstream Linux device trees on Qualcomm platforms, make this the default behavior. Signed-off-by: Konrad Dybcio --- arch/arm/dts/dragonboard410c-uboot.dtsi | 4 arch/arm/dts/dragonboard820c-uboot.dtsi | 4 arch/arm/dts/dragonboard845c-uboot.dtsi

[PATCH v2 7/9] serial: msm_geni: Always bind before relocation

2023-03-27 Thread Konrad Dybcio
In preparation for supporting upstream Linux device trees on Qualcomm platforms, make this the default behavior. Signed-off-by: Konrad Dybcio --- arch/arm/dts/dragonboard845c-uboot.dtsi | 4 arch/arm/dts/starqltechn-uboot.dtsi | 3 --- drivers/serial/serial_msm_geni.c| 1 + 3

[PATCH v2 6/9] arm: snapdragon: pinctrl: Always bind before relocation

2023-03-27 Thread Konrad Dybcio
In preparation for supporting upstream Linux device trees on Qualcomm platforms, make this the default behavior. Signed-off-by: Konrad Dybcio --- arch/arm/dts/dragonboard410c-uboot.dtsi | 8 arch/arm/dts/dragonboard820c-uboot.dtsi | 8 arch/arm/dts/dragonboard845c

[PATCH v2 2/9] serial: msm: Match clocks through "clocks" property

2023-03-27 Thread Konrad Dybcio
"clocks" is the standard property used in Linux, "clock" seems to be an U-Boot invention. Use the one that's more standardized. Signed-off-by: Konrad Dybcio --- arch/arm/dts/dragonboard410c.dts | 2 +- arch/arm/dts/dragonboard820c.dts | 2 +- arch/arm/dts/qcom-ipq4019.dts

[PATCH v2 4/9] serial: msm: Always bind before relocation

2023-03-27 Thread Konrad Dybcio
In preparation for supporting upstream Linux device trees on Qualcomm platforms, make this the default behavior. Signed-off-by: Konrad Dybcio --- arch/arm/dts/dragonboard410c-uboot.dtsi | 4 arch/arm/dts/dragonboard820c-uboot.dtsi | 4 arch/arm/dts/qcom-ipq4019.dtsi | 1

[PATCH v2 8/9] arm: dts: qcom*: Don't specify u-boot,dm-pre-reloc redundantly

2023-03-27 Thread Konrad Dybcio
The simple-bus driver assigns the pre-reloc flag, which means it's not necessary to do it again in the device tree. Clean it up. Signed-off-by: Konrad Dybcio --- arch/arm/dts/dragonboard410c-uboot.dtsi | 4 arch/arm/dts/dragonboard820c-uboot.dtsi | 4 arch/arm/dts/dragonboard845c

[PATCH v2 3/9] serial: msm_geni: Use upstream Linux bindings

2023-03-27 Thread Konrad Dybcio
The name "se" is used in upstream Linux device trees and has been for ages, long before this U-Boot-ism was introduced. Same goes for the existing compatible. Get rid of that. Signed-off-by: Konrad Dybcio --- arch/arm/dts/sdm845.dtsi| 4 ++-- doc/device-tre

[PATCH v2 1/9] mmc: msm_sdhci: Match clocks through "clocks" property

2023-03-27 Thread Konrad Dybcio
"clocks" is the standard property used in Linux, "clock" seems to be an U-Boot invention. Use the one that's more standardized. Signed-off-by: Konrad Dybcio --- arch/arm/dts/dragonboard410c.dts | 4 ++-- arch/arm/dts/dragonboard820c.dts | 2 +- arch/arm/dts/qcs404-evb.dts

[PATCH v2 0/9] Qualcomm cleanups / preparations

2023-03-27 Thread Konrad Dybcio
rm CROSS_COMPILE=aarch64-linux-gnu- -j$(nproc) $1 } compile () { do_make mrproper do_make $1_defconfig do_make } set -e for board in "${boards[@]}"; do compile $board done Signed-off-by: Konrad Dybcio --- Konrad Dybcio (9): mmc: msm_sdhci: Match clocks thr

Re: [PATCH 6/7] serial: msm_geni: Use upstream Linux bindings

2023-03-24 Thread Konrad Dybcio
On 24.03.2023 07:13, Sumit Garg wrote: > On Fri, 24 Mar 2023 at 06:10, Konrad Dybcio wrote: >> >> The name "se" is used in upstream Linux device trees and has been for >> ages, long before this U-Boot-ism was introduced. Same goes for the >> existing comp

Re: [PATCH 3/7] serial: msm: Always bind before relocation

2023-03-24 Thread Konrad Dybcio
On 24.03.2023 07:04, Sumit Garg wrote: > On Fri, 24 Mar 2023 at 07:27, Konrad Dybcio wrote: >> >> In preparation for supporting upstream Linux device trees on Qualcomm >> platforms, make this the default behavior. >> >> Signed-off-by: Konrad Dybcio >>

Re: [PATCH 2/7] serial: msm: Match clocks through "clocks" property

2023-03-24 Thread Konrad Dybcio
On 24.03.2023 07:00, Sumit Garg wrote: > On Fri, 24 Mar 2023 at 06:10, Konrad Dybcio wrote: >> >> "clocks" is the standard property used in Linux, "clock" seems to be >> an U-Boot invention. Use the one that's more standardized. >> >> Sig

[PATCH 7/7] arm: Migrate Apple M1 to save_prev_bl_data

2023-03-23 Thread Konrad Dybcio
mach-apple implementation of this very thing and enable the common approach in the respective defconfig. Only build-tested. Signed-off-by: Konrad Dybcio --- arch/arm/lib/save_prev_bl_data.c| 14 +++--- arch/arm/mach-apple/Makefile| 1 - arch/arm/mach-apple/lowlevel_i

[PATCH 6/7] serial: msm_geni: Use upstream Linux bindings

2023-03-23 Thread Konrad Dybcio
The name "se" is used in upstream Linux device trees and has been for ages, long before this U-Boot-ism was introduced. Same goes for the existing compatible. Get rid of that. Signed-off-by: Konrad Dybcio --- arch/arm/dts/sdm845.dtsi | 4 ++-- drivers/serial/serial_msm_

[PATCH 5/7] arm: snapdragon: pinctrl: Always bind before relocation

2023-03-23 Thread Konrad Dybcio
In preparation for supporting upstream Linux device trees on Qualcomm platforms, make this the default behavior. Signed-off-by: Konrad Dybcio --- arch/arm/mach-snapdragon/pinctrl-snapdragon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-snapdragon/pinctrl-snapdragon.c b

[PATCH 4/7] arch: snapdragon: clock: Always bind before relocation

2023-03-23 Thread Konrad Dybcio
In preparation for supporting upstream Linux device trees on Qualcomm platforms, make this the default behavior. Signed-off-by: Konrad Dybcio --- arch/arm/mach-snapdragon/clock-snapdragon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-snapdragon/clock-snapdragon.c b/arch

[PATCH 3/7] serial: msm: Always bind before relocation

2023-03-23 Thread Konrad Dybcio
In preparation for supporting upstream Linux device trees on Qualcomm platforms, make this the default behavior. Signed-off-by: Konrad Dybcio --- drivers/serial/serial_msm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c index

[PATCH 2/7] serial: msm: Match clocks through "clocks" property

2023-03-23 Thread Konrad Dybcio
"clocks" is the standard property used in Linux, "clock" seems to be an U-Boot invention. Use the one that's more standardized. Signed-off-by: Konrad Dybcio --- arch/arm/dts/qcom-ipq4019.dtsi | 2 +- drivers/serial/serial_msm.c| 3 +-- 2 files changed, 2 insertions(+),

[PATCH 1/7] mmc: msm_sdhci: Match clocks through "clocks" property

2023-03-23 Thread Konrad Dybcio
"clocks" is the standard property used in Linux, "clock" seems to be an U-Boot invention. Use the one that's more standardized. Signed-off-by: Konrad Dybcio --- drivers/mmc/msm_sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/msm_s