Re: [RESEND 0/3] rockchip: Fix RAM training on RK3399 based platforms (Rock Pi 4)

2022-09-28 Thread Lee Jones
On Wed, 28 Sep 2022, Michal Suchánek wrote: > On Wed, Sep 28, 2022 at 10:26:35AM +0100, Lee Jones wrote: > > On Fri, 09 Sep 2022, Kever Yang wrote: > > > > > Hi Lee Jones, > > > > > > On 2022/9/8 15:44, Lee Jones wrote: > > > > On Thu, 11

Re: [RESEND 0/3] rockchip: Fix RAM training on RK3399 based platforms (Rock Pi 4)

2022-09-28 Thread Lee Jones
On Fri, 09 Sep 2022, Kever Yang wrote: > Hi Lee Jones, > > On 2022/9/8 15:44, Lee Jones wrote: > > On Thu, 11 Aug 2022, Lee Jones wrote: > > > > > This set fixes several issues found on the Rock Pi 4. > > > > > > For

Re: [RESEND 0/3] rockchip: Fix RAM training on RK3399 based platforms (Rock Pi 4)

2022-09-09 Thread Lee Jones
On Fri, 09 Sep 2022, Kever Yang wrote: > Hi Lee Jones, > > On 2022/9/8 15:44, Lee Jones wrote: > > On Thu, 11 Aug 2022, Lee Jones wrote: > > > > > This set fixes several issues found on the Rock Pi 4. > > > > > > For

Re: [RESEND 0/3] rockchip: Fix RAM training on RK3399 based platforms (Rock Pi 4)

2022-09-08 Thread Lee Jones
On Thu, 11 Aug 2022, Lee Jones wrote: > This set fixes several issues found on the Rock Pi 4. > > For full context, please see this initial bug report: > > "There appear to be a number of issues with the Rockchip rk3399 DDR RAM > > initialis

[PATCH 3/3] ram: rk3399: Conduct memory training at 400MHz

2022-08-11 Thread Lee Jones
before ramping up to the final value running value of 800MHz after everything has been successfully configured. Link: https://lore.kernel.org/u-boot/yo4v3juehxtov...@google.com/ Suggested-by: YouMin Chen Signed-off-by: Lee Jones Tested-by: Xavier Drudis Ferran Reviewed-by: Kever Yang --- drivers

[PATCH 2/3] ram: rk3399: Fix faulty frequency change reports

2022-08-11 Thread Lee Jones
Frequency changes to 400MHz are presently reported as: lpddr4_set_rate_0: change freq to 4 mhz 0, 1 This is obviously wrong by 6 orders of magnitude. Ensure frequency changes are reported accurately. Signed-off-by: Lee Jones Tested-by: Xavier Drudis Ferran Reviewed-by: Kever Yang

[PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling

2022-08-11 Thread Lee Jones
Functions pointed to by this op pointer can return non-zero values indicating an error. Ensure any error value is propagated back up the call-chain. Signed-off-by: Lee Jones Tested-by: Xavier Drudis Ferran Reviewed-by: Kever Yang --- drivers/ram/rockchip/sdram_rk3399.c | 4 +++- 1 file

[PATCH 0/3] rockchip: Fix RAM training on RK3399 based platforms (Rock Pi 4)

2022-08-11 Thread Lee Jones
d -22 So my question is; does Rockchip, or anyone else for that matter, have any plans on updating Mainline U-Boot with the upgraded/working LPDDR4 initialisation sequence?" Lee Jones (3): ram: rk3399: Fix .set_rate_ind

Re: [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling

2022-07-04 Thread Lee Jones
On Mon, 04 Jul 2022, Kever Yang wrote: > Hi > > On 2022/7/4 17:23, Lee Jones wrote: > > On Fri, 01 Jul 2022, Kever Yang wrote: > > > > > Hi Lee Jones, > > > > > > > > > On 2022/6/27 16:39, Lee Jones wrote: > > > > On Tu

Re: [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling

2022-07-04 Thread Lee Jones
On Fri, 01 Jul 2022, Kever Yang wrote: > Hi Lee Jones, > > > On 2022/6/27 16:39, Lee Jones wrote: > > On Tue, 21 Jun 2022, Lee Jones wrote: > > > > > Functions pointed to by this op pointer can return non-zero values > > > indicating an error. En

Re: [PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling

2022-06-27 Thread Lee Jones
On Tue, 21 Jun 2022, Lee Jones wrote: > Functions pointed to by this op pointer can return non-zero values > indicating an error. Ensure any error value is propagated back up the > call-chain. > > Signed-off-by: Lee Jones > --- > drivers/ram/rockchip/sdram_rk3399.c | 4 +

[PATCH 3/3] ram: rk3399: Conduct memory training at 400MHz

2022-06-21 Thread Lee Jones
before ramping up to the final value running value of 800MHz after everything has been successfully configured. Link: https://lore.kernel.org/u-boot/yo4v3juehxtov...@google.com/ Suggested-by: YouMin Chen Signed-off-by: Lee Jones --- drivers/ram/rockchip/sdram_rk3399.c | 36

[PATCH 2/3] ram: rk3399: Fix faulty frequency change reports

2022-06-21 Thread Lee Jones
Frequency changes to 400MHz are presently reported as: lpddr4_set_rate_0: change freq to 4 mhz 0, 1 This is obviously wrong by 6 orders of magnitude. Ensure frequency changes are reported accurately. Signed-off-by: Lee Jones --- drivers/ram/rockchip/sdram_rk3399.c | 4 ++-- 1 file

[PATCH 1/3] ram: rk3399: Fix .set_rate_index() error handling

2022-06-21 Thread Lee Jones
Functions pointed to by this op pointer can return non-zero values indicating an error. Ensure any error value is propagated back up the call-chain. Signed-off-by: Lee Jones --- drivers/ram/rockchip/sdram_rk3399.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers

Re: Re: [Rock Pi 4+] Mainline LPDDR4 RAM initialisation is not sufficient to boot successfully

2022-06-17 Thread Lee Jones
problem. Thank you so much! Would you like to submit this into upstream U-boot yourself, or would you like me to do that for you? If the former, please Cc me on the patch and add my: Tested-by Lee Jones If the latter, please let me know and I'll do what I can to help. -- Lee Jones

Re: [Rock Pi 4+] Mainline LPDDR4 RAM initialisation is not sufficient to boot successfully

2022-06-16 Thread Lee Jones
On Wed, 25 May 2022, Lee Jones wrote: > Good afternoon, > > > > There appear to be a number of issues wi

[Rock Pi 4+] Mainline LPDDR4 RAM initialisation is not sufficient to boot successfully

2022-05-25 Thread Lee Jones
[0] https://github.com/rockchip-linux/rkbin/blob/master/bin/rk33/rk3399_ddr_933MHz_v1.25.bin -- Lee Jones [李琼斯] Principal

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
On Thu, 19 May 2022, Peter Geis wrote: > On Thu, May 19, 2022 at 1:36 PM Peter Geis wrote: > > > > On Thu, May 19, 2022 at 1:23 PM Lee Jones wrote: > > > > > > On Thu, 19 May 2022, Lee Jones wrote: > > > > > > > On Thu, 19 May 2022, Peter Ge

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
On Thu, 19 May 2022, Lee Jones wrote: > On Thu, 19 May 2022, Peter Geis wrote: > > > On Thu, May 19, 2022 at 11:47 AM Lee Jones wrote: > > > > > > On Thu, 19 May 2022, Lee Jones wrote: > > > > > > > On Thu, 19 May 2022, Peter Geis wrote: >

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
On Thu, 19 May 2022, Peter Geis wrote: > On Thu, May 19, 2022 at 11:47 AM Lee Jones wrote: > > > > On Thu, 19 May 2022, Lee Jones wrote: > > > > > On Thu, 19 May 2022, Peter Geis wrote: > > > > > > > On Thu, May 19, 2022 at 10:56 AM Lee Jones

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
On Thu, 19 May 2022, Lee Jones wrote: > On Thu, 19 May 2022, Peter Geis wrote: > > > On Thu, May 19, 2022 at 10:56 AM Lee Jones wrote: > > > > > > > > > > It's not clear how this issue (present 3 years ago) was finally > > > > > > >

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
On Thu, 19 May 2022, Peter Geis wrote: > On Thu, May 19, 2022 at 10:56 AM Lee Jones wrote: > > > > > > > > It's not clear how this issue (present 3 years ago) was finally > > > > > > resolved. From the thread, it looks as if the fix might have m

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
result I had was using our downstream u-boot with Mainline TF-A. It booted perfectly from cold, but managed to get stuck in the TPL on soft reboot in a very similar way to the one I reported earlier when not booting with TF-A ("Channel 1: col error"): https://pastebin.ubuntu.com/p/hwmBzxDBgc/ Thanks again for your insight. Kind regards, Lee -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-19 Thread Lee Jones
On Wed, 18 May 2022, Peter Geis wrote: > On Wed, May 18, 2022 at 7:56 AM Lee Jones wrote: > > > > Looping int a few relevant/active kernel people/lists for full coverage. > > > > On Sun, 01 Dec 2019, Hugh Cole-Baker wrote: > > > > On 29 Nov 2019, at 01:06, V

Re: [U-Boot] [PATCH 2/2] rockchip: rk3399: rockpro64: enable force power on reset workaround

2022-05-18 Thread Lee Jones
][C5] _regmap_bus_reg_read+0x3c/0x90 [0.702614][C5] _regmap_read+0xb0/0x24c [0.702623][C5] rockchip_pd_power+0x6c4/0xbc0 [0.702638][C5] rockchip_pd_power_off+0x18/0x28 [0.702652][C5] _genpd_power_off+0x178/0x388 [0.702663][C5] genpd_power_off+0x188/0

Re: [U-Boot] [PATCH 3/8] boottime: Add core boottime measurement support

2012-11-27 Thread Lee Jones
Hi Simon, On Tue, Nov 20, 2012 at 6:33 AM, Lee Jones lee.jo...@linaro.org wrote: Boottime is a tool which can be used for full system booting time measurement. Bootloader boot time is passed to the kernel component though ATAGS. The kernel-side driver then uses this information

Re: [U-Boot] [PATCH 3/8] boottime: Add core boottime measurement support

2012-11-27 Thread Lee Jones
On Tue, 27 Nov 2012, Wolfgang Denk wrote: Dear Lee Jones, In message 20121127085548.gc7...@gmail.com you wrote: By the way, if Wolfgang didn't want these tracepoints in DT, then how was your implementations upstreamed into u-boot? Because I don;t manage a 100% review coverage over

Re: [U-Boot] [PATCH 3/8] boottime: Add core boottime measurement support

2012-11-26 Thread Lee Jones
Hi Simon, On Tue, Nov 20, 2012 at 6:33 AM, Lee Jones lee.jo...@linaro.org wrote: Boottime is a tool which can be used for full system booting time measurement. Bootloader boot time is passed to the kernel component though ATAGS. The kernel-side driver then uses this information

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-23 Thread Lee Jones
consider it a design flaw to do such statictics stuff in the kernel. It does not belong there. Such functions belong to user space. I don't agree. But as mentioned before, this is actually off topic here. Then stop mentioning it. ;) -- Lee Jones Linaro ST-Ericsson Landing Team Lead

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-22 Thread Lee Jones
stopped to ask me about it at kernel conferences. Let's find a nice, long lasting way to solve it. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ___ U-Boot mailing

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-22 Thread Lee Jones
, that's why ATAGs were brought about wasn't it? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-21 Thread Lee Jones
. Please come up with a solution that works for all architectures instead. So I guess Device Tree it is then. Kind regards, Lee -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [U-Boot] [PATCH 4/8] boottime: Apply some key boottime tags into common code

2012-11-21 Thread Lee Jones
On Tue, 20 Nov 2012, Wolfgang Denk wrote: Dear Lee Jones, In message 1353422034-28107-5-git-send-email-lee.jo...@linaro.org you wrote: Here we add boottime tags to the start of the main loop and just before the opportunity to break into the u-boot shell. This will provide a more verbose

Re: [U-Boot] [PATCH 3/8] boottime: Add core boottime measurement support

2012-11-21 Thread Lee Jones
reams of otherwise useless logging scrawled throughout their bootlog. We'd also have a write a text parser to obtain the information for processing. It would be easier to either pass in a struct, as we do with the ATAG mechanism, or though Device Tree as previously discussed. -- Lee Jones Linaro ST

Re: [U-Boot] [PATCH 1/8] u8500: Correct unnecessary mathematical roll-over

2012-11-21 Thread Lee Jones
be able to lend a hand here, as I'm no mathematician? What are the correct arithmetics? Kind regards, Lee -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ___ U

Re: [U-Boot] [PATCH 0/8] Adding boottime support

2012-11-21 Thread Lee Jones
regards, Lee -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-21 Thread Lee Jones
then have to write a text parser to process this information? Sounds horrendous. Hopefully, I have missed something and it's actually easier than what I've mentioned. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-21 Thread Lee Jones
you're suggesting that we create a userland portion of the driver too? I don't think this is acceptable. This tool will be used by kernel engineers, who would be more happy taking the information from debugfs. At least I know I would. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org

Re: [U-Boot] [PATCH 1/8] u8500: Correct unnecessary mathematical roll-over

2012-11-21 Thread Lee Jones
be needed here. As above. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 3/8] boottime: Add core boottime measurement support

2012-11-21 Thread Lee Jones
. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 4/8] boottime: Apply some key boottime tags into common code

2012-11-21 Thread Lee Jones
. It looked to me as though it took an integer identifier, which isn't going to mean anything to anyone. Unless there is a way to change the semantics of the function so that it would take a string, but then how would it play with the existing show_boot_progress() calls? -- Lee Jones Linaro ST

Re: [U-Boot] [PATCH 3/8] boottime: Add core boottime measurement support

2012-11-21 Thread Lee Jones
On Wed, 21 Nov 2012, Wolfgang Denk wrote: Dear Lee Jones, In message 20121121150332.gc28...@gmail.com you wrote: Neither ATAGS not the device tree are intended nor designed for passing logfile information. Yes, you can use them like that, and it will actually work. ATAGs were

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-21 Thread Lee Jones
. This is the solution to that problem. 1. Enable boottime config 2. Enable debugfs config (if it's not already) 3. Mount debugfs (if it's not already) 4. cat /sys/kernel/debug/[summary|bootgraph] Simples. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source

[U-Boot] [PATCH 0/8] Adding boottime support

2012-11-20 Thread Lee Jones
In this patch-set we're attempting to add boottime measurement support to u-boot. A patch-set has already hit the kernel MLs which intends to solve the other half of the puzzle. This new tool allows an engineer to apply tags into key areas around the bootloader, which are then passed to the Linux

[U-Boot] [PATCH 1/8] u8500: Correct unnecessary mathematical roll-over

2012-11-20 Thread Lee Jones
, the issue vanishes. Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/cpu/armv7/u8500/timer.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv7/u8500/timer.c b/arch/arm/cpu/armv7/u8500/timer.c index 79aad99..40326d8 100644 --- a/arch/arm/cpu/armv7

[U-Boot] [PATCH 2/8] u8500: Add utimer support

2012-11-20 Thread Lee Jones
Provide support for microsecond level timer support. Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/cpu/armv7/u8500/timer.c |5 + include/common.h |1 + 2 files changed, 6 insertions(+) diff --git a/arch/arm/cpu/armv7/u8500/timer.c b/arch/arm/cpu/armv7

[U-Boot] [PATCH 3/8] boottime: Add core boottime measurement support

2012-11-20 Thread Lee Jones
by Jonas Aaberg. Signed-off-by: Lee Jones lee.jo...@linaro.org --- common/Makefile|1 + common/boottime.c | 146 include/boottime.h | 86 +++ 3 files changed, 233 insertions(+) create mode 100644 common

[U-Boot] [PATCH 4/8] boottime: Apply some key boottime tags into common code

2012-11-20 Thread Lee Jones
Here we add boottime tags to the start of the main loop and just before the opportunity to break into the u-boot shell. This will provide a more verbose bootgraph when viewed within debugfs. Signed-off-by: Lee Jones lee.jo...@linaro.org --- common/main.c |5 + 1 file changed, 5

[U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-20 Thread Lee Jones
This patch adds support for passing boot time information to the Linus kernel using ATAGS when booting on ARM based devices. Based heavily on the original driver by Jonas Aaberg. Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/include/asm/setup.h | 18 + arch/arm

[U-Boot] [PATCH 7/8] href: Enable boottime functionality

2012-11-20 Thread Lee Jones
Allow the bootloader to pass bootloader specific boot-up time information to the Linux kernel via ATAGs when booting the db8500 based HREF development board. Signed-off-by: Lee Jones lee.jo...@linaro.org --- include/configs/u8500_href.h |2 ++ 1 file changed, 2 insertions(+) diff --git

[U-Boot] [PATCH 8/8] snowball: Enable boottime functionality

2012-11-20 Thread Lee Jones
Allow the bootloader to pass bootloader specific boot-up time information to the Linux kernel via ATAGs when booting the db8500 based Snowball development board. Signed-off-by: Lee Jones lee.jo...@linaro.org --- include/configs/snowball.h |2 ++ 1 file changed, 2 insertions(+) diff --git

[U-Boot] [PATCH 6/8] arm: Add some boottime tags into prime booting locations

2012-11-20 Thread Lee Jones
This will provide a more verbose bootgraph when viewed within debugfs. It will also ensure that we have a tag at the latest possible point in the bootloader, right before we pass the ATAGs though to the kernel. Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/lib/board.c |3

Re: [U-Boot] [PATCH 5/8] arm: Add boottime support for the ARM architecture

2012-11-20 Thread Lee Jones
On Tue, 20 Nov 2012, Otavio Salvador wrote: On Tue, Nov 20, 2012 at 12:33 PM, Lee Jones lee.jo...@linaro.org wrote: This patch adds support for passing boot time information to the Linus kernel using ATAGS when booting on ARM based devices. Linus or Linux? Linux. I'll fix-up when