Re: [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD

2023-01-30 Thread Mario Kicherer
On 2023-01-27 18:58, Tom Rini wrote: Okay, I think I understand your point now. I am not sure what's the best way to proceed here. Should I try to build all targets that contain BOOT_DEVICE_NOR and add a #define for BOOT_DEVICE_NOR2 if my patch really breaks the build? Or should I just add a

[PATCH] spl: spl_nor: use panic instead of hang if booting fails

2023-01-30 Thread Mario Kicherer
On systems without a watchdog, using hang() prevents a system to recover from an error. For example, a board could implement a boot counter to switch to an alternative load address after some failed tries. Signed-off-by: Mario Kicherer --- common/spl/spl.c | 7 +++ 1 file changed, 3

[PATCH] spl: spl-nor: return error if no valid image was loaded

2023-01-30 Thread Mario Kicherer
>>SPL: board_init_r() spl_init Trying to boot from NOR SPL: failed to boot from all boot devices (err=-6) .### ERROR ### Please RESET the board ### Signed-off-by: Mario Kicherer --- common/spl/spl_nor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/spl/spl_nor.c

Re: [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD

2023-01-27 Thread Mario Kicherer
On 2023-01-27 18:10, Tom Rini wrote: Yes, all of the platforms that define the value (since it roughly means "ROM set this value in something we can check") instead of enum'ing it still compile that file and now fail to build. Okay, I think I understand your point now. I am not sure what's the

Re: [PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD

2023-01-27 Thread Mario Kicherer
Hello Tom, On 2023-01-26 20:17, Tom Rini wrote: This breaks a lot of platforms, as it only covers a few of the cases where BOOT_DEVICE_NOR is listed. I would also really like to see how this ends up being used in the board specific case as I do wonder if we can't solve this some other way that

[PATCH] armv7: ls102xa: make QSPI clock selection optional during SoC init

2023-01-19 Thread Mario Kicherer
/docs/en/application-note/AN12279.pdf Signed-off-by: Mario Kicherer --- arch/arm/cpu/armv7/ls102xa/Kconfig | 9 + arch/arm/cpu/armv7/ls102xa/soc.c | 4 ++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/arch/arm/cpu/armv7/ls102xa/Kconfig b/arch/arm/cpu/armv7/ls102xa

[PATCH v2 2/2] spl: spl_nor: add spl_boot_device parameter to spl_nor_get_uboot_base()

2023-01-19 Thread Mario Kicherer
With this additional parameter, a board-specific implementation of this function can return an alternative address in case booting from the first address in the NOR flash fails. Signed-off-by: Mario Kicherer --- arch/arm/mach-imx/image-container.c| 2 +- arch/mips/mach-mtmips/mt7621/spl

[PATCH v2 1/2] spl: spl_nor: add BOOT_DEVICE_NOR2 as alternative SPL_LOAD_IMAGE_METHOD

2023-01-19 Thread Mario Kicherer
Add BOOT_DEVICE_NOR2 as a second SPL_LOAD_IMAGE_METHOD to enable a board-specific spl_nor_get_uboot_base() function to return an alternative address in the NOR flash in case booting from BOOT_DEVICE_NOR fails. Signed-off-by: Mario Kicherer --- arch/arm/include/asm/spl.h | 1 + arch/mips

[PATCH v2 0/2] spl: spl_nor: add alternative SPL_LOAD_IMAGE_METHOD

2023-01-19 Thread Mario Kicherer
Add a second SPL_LOAD_IMAGE_METHOD BOOT_DEVICE_NOR2 to enable booting from an alternative NOR address in case loading from the first address fails - e.g., if no valid header is found. Changes since v1: - addressed right email recipients Mario Kicherer (2): spl: spl_nor: add BOOT_DEVICE_NOR2