Register the IMMR region as a PCI region when PCI is used on MPC83xx.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
No changes
---
drivers/pci/pci-uclass.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclas
This patch adds a driver for the bus associated with a IHS FPGA.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
* Switched to correct uclass for IHS FPGA driver (now in MISC uclass)
---
drivers/misc/Kconfig | 6 -
drivers/misc/Makefile| 1 +
drivers/misc/gd
Add a driver for the ICS8N3QV01 Quad-Frequency Programmable VCXO.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
* Expanded documentation
* Switched to u8 for I2C register reading
---
drivers/clk/Kconfig | 8 ++
drivers/clk/Makefile | 1 +
drivers/clk/ics
Add generic enable/disable function to the misc uclass.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
* Merged the two functions into one function
* Explained the semantics of enabling/disabling more throughly
---
drivers/misc/misc-uclass.c | 10 ++
inclu
Some reset lines are implemented by toggling the line via a GPIO.
Add a driver to properly drive such reset lines.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
No changes
---
drivers/reset/Kconfig | 7
drivers/reset/Makefile | 1 +
drivers/reset/gpi
the uclass_{first,next}_device_check functions to
initialize as many ethernet devices as possible.
Signed-off-by: Mario Six <mario@gdsys.cc>
Acked-by: Joe Hershberger <joe.hershber...@ni.com>
---
v1 -> v2:
No changes
---
net/eth-uclass.c | 4 ++--
1 file changed, 2 insertions(
Add a PCIe driver for the MPC83xx architecture.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
No changes
---
arch/powerpc/cpu/mpc83xx/pcie.c | 4 +
drivers/pci/Kconfig | 16 ++
drivers/pci/Makefile| 1 +
drivers/pci/pcie_mpc83xx.c
Implement a set of functions to manipulate properties in a live device
tree:
* ofnode_set_property() to set generic properties of a node
* ofnode_write_string() to set string properties of a node
* ofnode_set_enabled() to either enable or disable a node
Signed-off-by: Mario Six <ma
Add a driver for gdsys IHS (Integrated Hardware Systems) FPGAs, which
supports initialization of the FPGA, as well as information gathering.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
New in v2
---
drivers/misc/Kconfig| 6 +
drivers/misc/Makefile | 1 +
dri
To prepare for DM conversion, encapsulate all register accesses in
function calls.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
No changes
---
board/gdsys/common/ihs_mdio.c | 41 ++---
1 file changed, 34 insertions(+), 7 deletions
Bus translations should be applied when reading the address of the sgmii
phy registers from the DT. Use ofnode_get_addr_index instead of the
plain ofnode_read_u32_default to fix this.
Signed-off-by: Mario Six <mario@gdsys.cc>
Acked-by: Joe Hershberger <joe.hershber...@ni.com>
-
parameter 'range_num'
that identifies the range to operate on.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
New in v2
---
drivers/core/regmap.c | 69 +++
include/regmap.h | 2 ++
2 files changed, 55 insertions(+), 16
.
Correct all current clients of the regmap API to use 32 bit width reads
and writes to keep backwards compatibility.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
New in v2
---
drivers/clk/at91/clk-utmi.c | 6 +++--
drivers/clk/clk_boston.c
Add a driver for RXAUI control on IHS FPGAs.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
* Switched to regmap usage (instead of fpgamap)
---
drivers/misc/Kconfig| 6 +++-
drivers/misc/Makefile | 1 +
drivers/misc/gdsys_rxaui_ct
Add tests for the dev_{enable,disable}_by_path functions.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
New in v2
---
test/dm/test-fdt.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/test/dm/test-fdt.c b/test/dm/test-fdt.c
index 3
Make the ihs_mdio driver DM-compatible, while retaining the old
functionality for not-yet-converted boards.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
* Switched to regmap usage (instead of fpgamap)
---
board/gdsys/common/ihs_md
Add tests for the ofnode_set_enabled, ofnode_write_string, and
ofnode_write_property functions.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
New in v2
---
test/dm/test-fdt.c | 53 +
1 file changed, 53 insertions(+)
d
-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
New in v2
---
include/regmap.h | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/include/regmap.h b/include/regmap.h
index bb7e947ce2..69cbe8a96a 100644
--- a/include/regmap.h
+++ b/include/regmap.h
@@ -49,
We cannot use device structures to disable devices, since getting
them with the API functions would bind and activate the device, which
would fail if the underlying device does not exist.
Hence, add a function to disable devices by path in a live device tree.
Signed-off-by: Mario Six <ma
Add driver for the IHS IO endpoint on IHS FPGAs.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
* Switched to regmap usage (instead of fpgamap)
---
drivers/misc/Kconfig | 5 ++
drivers/misc/Makefile | 1 +
drivers/misc/gdsys_ioe
Add tests for the new board uclass.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
New in v2
---
arch/sandbox/dts/test.dts | 4 ++
configs/sandbox64_defconfig| 2 +
configs/sandbox_defconfig | 2 +
configs/sandbox_flattree_defconfig | 2 +
ided by the
hardware.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
* Corrected description of dev parameter of devinfo_detect
* Added size parameter to devinfo_get_str
* Expanded uclass documentation
* Added function to get devinfo instance
* Renamed the uclass from devinfo t
Add a board driver for the upcoming gdsys Gazerbeam board.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
v1 -> v2:
* Improved error handling
* Renamed DT properties
* Moved the driver over to the board uclass
---
drivers/board/gazerbea
Hi Simon,
On Thu, Apr 26, 2018 at 4:40 PM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 26 April 2018 at 00:07, Mario Six <mario@gdsys.cc> wrote:
>> Hi Simon,
>>
>> On Tue, Apr 24, 2018 at 11:53 PM, Simon Glass <s...@chromium.org>
unless you recognize the sender and know the
>> content is safe.
>>
>>
>> On Thu, Apr 26, 2018 at 11:24 AM, Mario Six <mario@gdsys.cc> wrote:
>> > Hi Jagan,
>> >
>> > On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki <jagannadh.t...@gmail.com>
Since kirkwook SPI was recently converted to DM, add compatible strings
to the SPI flash devices to make them work with the new driver.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
arch/arm/dts/armada-38x-controlcenterdc.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Hi Simon,
On Tue, Apr 24, 2018 at 11:53 PM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 19 April 2018 at 01:50, Mario Six <mario@gdsys.cc> wrote:
>>
>> Hi Simon,
>>
>> On Wed, Apr 18, 2018 at 5:45 PM, Simon Glass <s...@chromium.
Hi Simon,
On Sun, Apr 22, 2018 at 10:13 PM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 18 April 2018 at 02:20, Mario Six <mario@gdsys.cc> wrote:
>> Hi Simon,
>>
>> On Thu, Apr 12, 2018 at 6:42 PM, Simon Glass <s...@chromium.org>
Hi Jagan,
On Thu, Apr 26, 2018 at 7:49 AM, Jagan Teki <ja...@amarulasolutions.com> wrote:
> On Thu, Apr 26, 2018 at 11:13 AM, Mario Six <mario@gdsys.cc> wrote:
>> Hi Jagan,
>>
>> On Thu, Apr 26, 2018 at 7:34 AM, Jagan Teki <jagannadh.t...@gmail.com> wro
Hi Jagan,
On Thu, Apr 26, 2018 at 7:30 AM, Jagan Teki <jagannadh.t...@gmail.com> wrote:
> On Thu, Apr 19, 2018 at 6:06 PM, Mario Six <mario@gdsys.cc> wrote:
>> This is v2 of a patch series that adds support for DM to the MPC8XXX SPI
>> driver, cleans up the dri
Hi Jagan,
On Thu, Apr 26, 2018 at 7:34 AM, Jagan Teki <jagannadh.t...@gmail.com> wrote:
> On Thu, Apr 19, 2018 at 6:06 PM, Mario Six <mario@gdsys.cc> wrote:
>> Support DM in the MPC8xxx SPI driver, and remove the legacy SPI
>> interface.
>>
>> Signe
Support DM in the MPC8xxx SPI driver, and remove the legacy SPI
interface.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 144 ++
1 file changed, 107 insertions(+), 37 deletions(-)
---
Changes v1 -> v2:
* Remov
Replace pre-processor defines with proper enums, and use the BIT macro
where applicable.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
None
---
drivers/spi/mpc8xxx_spi.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
d
ies).
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
None
---
drivers/spi/mpc8xxx_spi.c | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c
index 5bf84aaec6..af3762737
The variable "char_size" holds the number of bits to be transferred in
the current loop iteration. A better name would be "xfer_bitlen", which
we rename this variable to.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
None
---
drivers/spi/mpc8x
Replace the function name with a "%s" format string and the __func__
variable in debug statements (as proposed by checkpatch).
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
None
---
drivers/spi/mpc8xxx_spi.c | 9 +
1 file changed, 5 inserti
.
To correct this, use the standard get_timer functionality to properly
time out the loop after 1000 ms.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
None
---
drivers/spi/mpc8xxx_spi.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git
Instead of having a table right before the code implementing the length
setting for documentation, have inline comments for the if branches
actually implementing the length setting described table's entries
(which is readable thanks to the set_char_len function).
Signed-off-by: Mario Six <ma
Get rid of the is_read variable, and just keep the state of the "not
empty" and "not full" events in two boolean variables within the loop
body.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
None
---
drivers/spi/mpc8xxx_spi.c | 12 ++
s case the subsequent transmission is the last one regardless,
hence the additional bit length decrease and write data pointer increase
has no effect anyway.
Still, the correct check is the check for "bitlen > 32", so correct this
behavior.
Signed-off-by: Mario Six <mario@gdsys.cc&
We do nothing in the loop if the "not empty" event was not detected. To
simplify the logic, check if this is the case, and skip the execution of
the loop early to reduce the nesting level and flag checking.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
to be written.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
None
---
drivers/spi/mpc8xxx_spi.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c
index d22206f4b7..fe493f6d40 100644
--- a/dr
Fix all "superfluous space after case" style errors.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
None
---
drivers/spi/mpc8xxx_spi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/
Accesses to the register map are currently done by directly reading and
writing the structure.
Switch to the appropriate IO accessors instead.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
None
---
drivers/spi/mpc8xxx_spi.c | 38 +++-
Instead of having a nested if block, just have two branches within the
overarching if block to eliminate one nesting level.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
None
---
drivers/spi/mpc8xxx_spi.c | 12 +---
1 file changed, 5 insertions(+), 7
The function signatures in the driver are quite long as is. Use short
type names (uint etc.) to make them more readable.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
---
Changes v1 ->
actually used in the loop (instead of
the placeholder value 32).
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
None
---
drivers/spi/mpc8xxx_spi.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/spi/mpc8xxx_spi.c b/dr
, and can come later.
The legacy functionality is removed in this version, so old boards in
the tree might end up with broken SPI functionality.
Mario Six (18):
spi: mpc8xxx: Use short type names
spi: mpc8xxx: Fix comments
spi: mpc8xxx: Rename camel-case variables
spi: mpc8xxx: Fix space
There are some comments on the same line as the code they document. Put
comments above the code lines they document, so the line length is not
unnecessarily increased.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
None
---
drivers/spi/mpc8xxx_s
There are three variables that have camel-case names, which is not the
preferred naming style.
Give those variables more compliant names instead.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
Changes v1 -> v2:
None
---
drivers/spi/mpc8xxx_spi.c | 22 +++---
1 fil
On Thu, Apr 19, 2018 at 1:48 PM, Jagan Teki <jagannadh.t...@gmail.com> wrote:
> On Thu, Apr 19, 2018 at 5:15 PM, Mario Six <mario@gdsys.cc> wrote:
>> Hi Jagan,
>>
>> On Thu, Apr 19, 2018 at 1:32 PM, Jagan Teki <jagannadh.t...@gmail.com> wrote:
>>
Hi Jagan,
On Thu, Apr 19, 2018 at 1:32 PM, Jagan Teki <jagannadh.t...@gmail.com> wrote:
> On Tue, Apr 10, 2018 at 4:31 PM, Mario Six <mario@gdsys.cc> wrote:
>> Support DM for the MPC8XXX SPI driver.
>>
>> Signed-off-by: Mario Six <mario@gdsys.cc>
>
Hi Simon,
On Wed, Apr 18, 2018 at 5:45 PM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 18 April 2018 at 02:35, Mario Six <mario@gdsys.cc> wrote:
>> Hi Simon,
>>
>> On Thu, Apr 12, 2018 at 6:37 PM, Simon Glass <s...@chromium.org>
Hi Simon,
On Thu, Apr 12, 2018 at 6:42 PM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 10 April 2018 at 05:23, Mario Six <mario@gdsys.cc> wrote:
>> Hi Simon,
>>
>> On Fri, Mar 30, 2018 at 12:43 AM, Simon Glass <s...@chromium.org>
Hi Simon,
On Thu, Apr 12, 2018 at 6:31 PM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 11 April 2018 at 01:15, Mario Six <mario@gdsys.cc> wrote:
>> Hi Simon,
>>
>> On Fri, Mar 30, 2018 at 10:41 AM, Simon Glass <s...@chromium.org>
Hi Simon,
On Thu, Apr 12, 2018 at 6:38 PM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 11 April 2018 at 01:27, Mario Six <mario@gdsys.cc> wrote:
>> Hi Simon,
>>
>> On Fri, Mar 30, 2018 at 10:41 AM, Simon Glass <s...@chromium.org>
Hi Simon,
On Thu, Apr 12, 2018 at 6:37 PM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 11 April 2018 at 00:39, Mario Six <mario@gdsys.cc> wrote:
>> Hi Simon,
>>
>> On Fri, Mar 30, 2018 at 10:41 AM, Simon Glass <s...@chromium.org> wro
Hi Simon,
On Thu, Apr 12, 2018 at 6:36 PM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 11 April 2018 at 00:35, Mario Six <mario@gdsys.cc> wrote:
>> Hi Simon,
>>
>> On Fri, Mar 30, 2018 at 10:41 AM, Simon Glass <s...@chromium.org>
Hi Simon,
On Thu, Apr 12, 2018 at 6:42 PM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 10 April 2018 at 05:34, Mario Six <mario@gdsys.cc> wrote:
>> Hi Simon,
>>
>> On Fri, Mar 30, 2018 at 12:43 AM, Simon Glass <s...@chromium.org>
Hi Simon,
On Fri, Mar 30, 2018 at 10:41 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:40, Mario Six <mario@gdsys.cc> wrote:
>> Add a driver for the Xilinx LogiCORE DisplayPort IP core.
>>
>> Signed-off-by: Mario Six
Hi Simon,
On Fri, Mar 30, 2018 at 10:41 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:38, Mario Six <mario@gdsys.cc> wrote:
>> A lot of times one wants to cycle through the devices in a uclass, but
>> only certain
Hi Simon,
On Fri, Mar 30, 2018 at 10:41 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:40, Mario Six <mario@gdsys.cc> wrote:
>> Add test infrastructure and tests for the AXI uclass.
>>
>> Signed-off-by: Mario Six <
Hi Simon,
On Fri, Mar 30, 2018 at 10:41 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:38, Mario Six <mario@gdsys.cc> wrote:
>> Add generic enable/disable functions to the misc uclass.
>>
>> Signed-off-by: Mario Six
Hi Simon,
On Fri, Mar 30, 2018 at 10:41 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:40, Mario Six <mario@gdsys.cc> wrote:
>> Add a uclass for AXI (Advanced eXtensible Interface) busses, and a
>> driver for the gdsys IHS A
Hi Simon,
On Fri, Mar 30, 2018 at 10:41 AM, Simon Glass <s...@chromium.org> wrote:
> Hi,
>
> On 28 March 2018 at 20:38, Mario Six <mario@gdsys.cc> wrote:
>> Add a cpu_print_info function to the CPU uclass to emulate the behavior
>> of some current non-DM dr
Hi Simon,
On Fri, Mar 30, 2018 at 10:40 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:36, Mario Six <mario@gdsys.cc> wrote:
>> Add a device information driver for the upcoming gdsys Gazerbeam board.
>>
>> Signe
Hi Simon,
On Fri, Mar 30, 2018 at 10:41 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:40, Mario Six <mario@gdsys.cc> wrote:
>> Add a power_on function to the display uclass to allow devices to be
>> probed and powered-on
Hi Simon,
On Fri, Mar 30, 2018 at 10:40 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:37, Mario Six <mario@gdsys.cc> wrote:
>> The FPGA (as a device) and the register map supplied by a FPGA are two
>> different e
Hi Simon,
On Fri, Mar 30, 2018 at 10:40 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:36, Mario Six <mario@gdsys.cc> wrote:
>> Some boards have encoded information, e.g. hard-wired GPIOs on a GPIO
>> expander, read
Hi Simon,
On Fri, Mar 30, 2018 at 12:42 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:39, Mario Six <mario@gdsys.cc> wrote:
>> Add a driver for IHS OSDs on IHS FPGAs.
>>
>> Signed-off-by: Mario Six <mario
Hi Simon,
On Fri, Mar 30, 2018 at 12:43 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:37, Mario Six <mario@gdsys.cc> wrote:
>> We cannot use device structures to disable devices, since getting
>> them with the API
Hi Simon,
On Fri, Mar 30, 2018 at 12:42 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:39, Mario Six <mario@gdsys.cc> wrote:
>> Some devices offer a text-based OSD (on-screen display) that can be
>> programmaticall
Hi Simon,
On Fri, Mar 30, 2018 at 12:43 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:37, Mario Six <mario@gdsys.cc> wrote:
>> It's sometimes useful to get the device associated with a given ofnode.
>> Implement a function t
Hi Simon,
On Fri, Mar 30, 2018 at 12:43 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:37, Mario Six <mario@gdsys.cc> wrote:
>> Implement a set of functions to manipulate properties in a live device
>> tree:
>>
&g
Hi Simon,
On Fri, Mar 30, 2018 at 12:42 AM, Simon Glass <s...@chromium.org> wrote:
> Hi Mario,
>
> On 28 March 2018 at 20:39, Mario Six <mario@gdsys.cc> wrote:
>> Add command to query information from and write text to IHS OSDs.
>>
>> Signe
.
To correct this, use the standard get_timer functionality to properly
time out the loop after 1000 ms.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/mpc8xxx_spi.c b/d
There are three variables that have camel-case names, which is not the
preferred naming style.
Give those variables more compliant names instead.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 22 +++---
1 file changed, 11 insertions(
s case the subsequent transmission is the last one regardless,
hence the additional bit length decrease and write data pointer increase
has no effect anyway.
Still, the correct check is the check for "bitlen > 32", so correct this
behavior.
Signed-off-by: Mario Six <mario@gdsy
ies).
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c
index 5bf84aaec6..af3762737f 100644
--- a/drivers/spi/
The variable "char_size" holds the number of bits to be transferred in
the current loop iteration. A better name would be "xfer_bitlen", which
we rename this variable to.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 8
1 file c
Instead of having a table right before the code implementing the length
setting for documentation, have inline comments for the if branches
actually implementing the length setting described table's entries
(which is readable thanks to the set_char_len function).
Signed-off-by: Mario Six <ma
To prepare DM conversion, move all driver functionality into separate
functions, and call them from the driver functions; these functions will
also be called from the DM-driver functions, so that we can keep the
legacy functions for the boards that still need them.
Signed-off-by: Mario Six <ma
Get rid of the is_read variable, and just keep the state of the "not
empty" and "not full" events in two boolean variables within the loop
body.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 12 +++-
1 file changed, 7 insertion
Fix all "superfluous space after case" style errors.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c
index 3ac9f2f8e8..0
We do nothing in the loop if the "not empty" event was not detected. To
simplify the logic, check if this is the case, and skip the execution of
the loop early to reduce the nesting level and flag checking.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mp
later.
The legacy functionality is retained, so older boards will still work
after the patches are applied.
Mario Six (19):
spi: mpc8xxx: Use short type names
spi: mpc8xxx: Fix comments
spi: mpc8xxx: Rename camel-case variables
spi: mpc8xxx: Fix space after cast
spi: mpc8xxx: Fix function
Support DM for the MPC8XXX SPI driver.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 135 +-
1 file changed, 133 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c
Replace pre-processor defines with proper enums, and use the BIT macro
where applicable.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/drivers/spi/mpc8xxx_spi.c b/d
to be written.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c
index d22206f4b7..fe493f6d40 100644
--- a/drivers/spi/mpc8xxx_spi.c
+++ b/drive
Accesses to the register map are currently done by directly reading and
writing the structure.
Switch to the appropriate IO accessors instead.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 38 +++---
1 file changed, 19 inse
There are some comments on the same line as the code they document. Put
comments above the code lines they document, so the line length is not
unnecessarily increased.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 22 ++
1 file chang
Replace the function name with a "%s" format string and the __func__
variable in debug statements (as proposed by checkpatch).
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --g
Instead of having a nested if block, just have two branches within the
overarching if block to eliminate one nesting level.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drive
The function signatures in the driver are quite long as is. Use short
type names (uint etc.) to make them more readable.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drive
actually used in the loop (instead of
the placeholder value 32).
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/spi/mpc8xxx_spi.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c
index 3024
Bus translations should be applied when reading the address of the sgmii
phy registers from the DT. Use ofnode_get_addr_index instead of the
plain ofnode_read_u32_default to fix this.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/net/tsec.c | 5 +++--
1 file changed, 3 inse
Make the cfi_flash driver compatible with a live device tree.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/mtd/cfi_flash.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index da44
Register the IMMR region as a PCI region when PCI is used on MPC83xx.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/pci/pci-uclass.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c
index ad43e8a27c..0778705f76
Add a power_on function to the display uclass to allow devices to be
probed and powered-on separately.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
drivers/video/display-uclass.c | 10 ++
include/display.h | 18 ++
2 files changed, 28 insertions(+)
Add test AXI drivers to the sandbox.
Signed-off-by: Mario Six <mario@gdsys.cc>
---
arch/sandbox/dts/sandbox.dts | 11 +++
arch/sandbox/dts/test.dts| 11 +++
configs/sandbox_defconfig| 3 +++
3 files changed, 25 insertions(+)
diff --git a/arch/sandbox/dts/sandb
501 - 600 of 1185 matches
Mail list logo
