Re: [PATCH v1 0/7] Add Starfive JH7110 Cadence USB driver

2024-05-20 Thread Minda Chen
> -邮件原件- > 发件人: E Shattow > 发送时间: 2024年5月20日 13:06 > 收件人: Minda Chen > 抄送: Marek Vasut ; Tom Rini ; Roger > Quadros ; Neil Armstrong ; > Alexey Romanov ; Sumit Garg > ; Mark Kettenis ; Nishanth > Menon ; Rick Chen ; Leo Yu-Chi Liang > ; u-boot@list

Re: [PATCH v1 7/7] MAINTAINERS: Update Starfive visionfive2 maintain files.

2024-05-17 Thread Minda Chen
> > On 5/4/24 5:03 PM, Minda Chen wrote: > > Add USB related files to Starfive visionfive2 MAINTAINERS. > > > > Signed-off-by: Minda Chen > > --- > > board/starfive/visionfive2/MAINTAINERS | 2 ++ > > 1 file changed, 2 insertions(+) > > > &g

回复: [PATCH 2/4] board: add support for Milk-V Mars CM

2024-05-06 Thread Minda Chen
> > On 30.04.24 11:59, E Shattow wrote: > > On Tue, Apr 30, 2024 at 12:18 AM Heinrich Schuchardt > > wrote: > >> > >> On 30.04.24 00:46, E Shattow wrote: > >>> On Sun, Apr 28, 2024 at 9:13 AM Emil Renner Berthing > >>> wrote: > > Heinrich Schuchardt wrote: > > We already support

[PATCH v1 7/7] MAINTAINERS: Update Starfive visionfive2 maintain files.

2024-05-04 Thread Minda Chen
Add USB related files to Starfive visionfive2 MAINTAINERS. Signed-off-by: Minda Chen --- board/starfive/visionfive2/MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/starfive/visionfive2/MAINTAINERS b/board/starfive/visionfive2/MAINTAINERS index d7f638f9b4..1faf83f581

[PATCH v1 6/7] dts: starfive: Add JH7110 Cadence USB dts node

2024-05-04 Thread Minda Chen
Add Jh7110 Cadence USB dts node, Visionfive2 default setting is USB 2.0 device. Signed-off-by: Minda Chen --- .../dts/jh7110-starfive-visionfive-2.dtsi | 5 ++ arch/riscv/dts/jh7110.dtsi| 52 +++ 2 files changed, 57 insertions(+) diff --git a/arch/riscv

[PATCH v1 5/7] configs: starfive: Add visionfive2 cadence USB configuration

2024-05-04 Thread Minda Chen
Add cadence USB confiuration. Signed-off-by: Minda Chen --- configs/starfive_visionfive2_defconfig | 9 + 1 file changed, 9 insertions(+) diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig index 3bbd1dbd67..444ddd508d 100644 --- a/configs

[PATCH v1 4/7] usb: cdns: starfive: Add cdns USB driver

2024-05-04 Thread Minda Chen
Add cdns USB3 wrapper driver. Signed-off-by: Minda Chen --- drivers/usb/cdns3/Kconfig | 7 ++ drivers/usb/cdns3/Makefile | 2 + drivers/usb/cdns3/cdns3-starfive.c | 184 + 3 files changed, 193 insertions(+) create mode 100644 drivers/usb/cdns3

[PATCH v1 3/7] phy: starfive: Add Starfive JH7110 PCIe 2.0 PHY driver

2024-05-04 Thread Minda Chen
Add Starfive JH7110 PCIe 2.0 PHY driver, which is generic PHY driver and can be used as USB 3.0 driver. Signed-off-by: Minda Chen --- drivers/phy/starfive/Kconfig | 6 + drivers/phy/starfive/Makefile | 1 + drivers/phy/starfive/phy-jh7110-pcie.c | 211

[PATCH v1 2/7] phy: starfive: Add Starfive JH7110 USB 2.0 PHY driver

2024-05-04 Thread Minda Chen
Add Starfive JH7110 USB 2.0 PHY driver, which is generic PHY driver. Signed-off-by: Minda Chen --- drivers/phy/Kconfig| 1 + drivers/phy/Makefile | 1 + drivers/phy/starfive/Kconfig | 13 +++ drivers/phy/starfive/Makefile | 6

[PATCH v1 1/7] usb: cdns3: Set USB PHY mode in cdns3_probe()

2024-05-04 Thread Minda Chen
USB PHY maybe need to set PHY mode in different USB dr mode. So translate to generic PHY mode and call generic_phy_set_mode(). Signed-off-by: Minda Chen --- drivers/usb/cdns3/core.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/usb/cdns3/core.c b/drivers/usb

[PATCH v1 0/7] Add Starfive JH7110 Cadence USB driver

2024-05-04 Thread Minda Chen
(usb 3.0) PHY drivier patch4: Cadence USB wrapper driver. patch5-7 dts, config and maintainers update. Minda Chen (7): usb: cdns3: Set USB PHY mode in cdns3_probe() phy: starfive: Add Starfive JH7110 USB 2.0 PHY driver phy: starfive: Add Starfive JH7110 PCIe 2.0 PHY driver usb: cdns: starfive

Re: [PATCH v2 4/6] board: starfive: support Milk-V Mars board

2024-04-01 Thread Minda Chen
> > On 4/1/24 17:28, Aurelien Jarno wrote: > > On 2024-03-28 17:01, Heinrich Schuchardt wrote: > >> On 24.03.24 16:00, Aurelien Jarno wrote: > >>> On 2024-03-21 19:11, Heinrich Schuchardt wrote: > The differences between the Milk-V Mars board and the VisionFive 2 > board are small

Re: [PATCH 1/1] riscv: starfive: MMC card detect

2024-03-29 Thread Minda Chen
rfive-visionfive-2.dtsi > @@ -298,7 +298,7 @@ > pinctrl-0 = <_pins>; > no-sdio; > no-mmc; > - broken-cd; > + cd-gpios = < 41 GPIO_ACTIVE_LOW>; > cap-sd-highspeed; > post-power-on-delay-ms = <200>; > status = "okay"; > -- > 2.43.0 Acked-by: Minda Chen

回复: [PATCH v2 0/6] riscv: add support for Milk-V Mars board

2024-03-24 Thread Minda Chen
> > The Milk-V Mars board is technically very close to the StarFive VisionFive 2 > board. > > With this patch series the VisionFive 2 U-Boot SPL will detect that it is > running on > a Milk-V board and patch the device-tree accordingly. > This is the same approach that has been taken to

[PATCH v1 2/2] board: starfive: maintainer: Add visionfive2 PCIe driver

2024-03-07 Thread Minda Chen
Add PCIe driver file to visionfive2 board MAINTAINERS list. Signed-off-by: Minda Chen --- board/starfive/visionfive2/MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/board/starfive/visionfive2/MAINTAINERS b/board/starfive/visionfive2/MAINTAINERS index 5056e9c713..d7f638f9b4

[PATCH v1 1/2] board: starfive: Update maintainer of VisionFive v2 board

2024-03-07 Thread Minda Chen
Update the maintainer of Starfive VisionFive v2 board. Signed-off-by: Minda Chen --- board/starfive/visionfive2/MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/starfive/visionfive2/MAINTAINERS b/board/starfive/visionfive2/MAINTAINERS index 600ff9575b

Re: [PATCH v1] usb: xhci: Check return value of wait for TRB_TRANSFER event

2023-10-18 Thread Minda Chen
On 2023/10/18 18:55, Marek Vasut wrote: > On 10/18/23 12:16, Minda Chen wrote: >> >> >> On 2023/10/18 18:11, Marek Vasut wrote: >>> On 10/18/23 05:46, Minda Chen wrote: >>>> >>>> >>>> On 2023/10/18 10:35, Marek Vasut wrote: >&

Re: [PATCH v1] usb: xhci: Check return value of wait for TRB_TRANSFER event

2023-10-18 Thread Minda Chen
On 2023/10/18 18:11, Marek Vasut wrote: > On 10/18/23 05:46, Minda Chen wrote: >> >> >> On 2023/10/18 10:35, Marek Vasut wrote: >>> On 10/18/23 03:22, Minda Chen wrote: >>>> >>>> >>>> On 2023/10/17 19:20, Marek Vasut wrote: >

Re: [PATCH v1] usb: xhci: Check return value of wait for TRB_TRANSFER event

2023-10-17 Thread Minda Chen
On 2023/10/18 10:35, Marek Vasut wrote: > On 10/18/23 03:22, Minda Chen wrote: >> >> >> On 2023/10/17 19:20, Marek Vasut wrote: >>> On 10/17/23 08:20, Minda Chen wrote: >>>> xhci_wait_for_event() waiting TRB_TRANSFER event may return >>&

Re: [PATCH v1] usb: xhci: Check return value of wait for TRB_TRANSFER event

2023-10-17 Thread Minda Chen
On 2023/10/17 19:20, Marek Vasut wrote: > On 10/17/23 08:20, Minda Chen wrote: >> xhci_wait_for_event() waiting TRB_TRANSFER event may return >> NULL. Checking the return value to avoid crash. >> >> Signed-off-by: Minda Chen > > How did you trigger this error

[PATCH v1] usb: xhci: Check return value of wait for TRB_TRANSFER event

2023-10-17 Thread Minda Chen
xhci_wait_for_event() waiting TRB_TRANSFER event may return NULL. Checking the return value to avoid crash. Signed-off-by: Minda Chen --- drivers/usb/host/xhci-ring.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index

[RESEND,v1 2/4] riscv: dts: starfive: Enable pcie0 dts node

2023-08-07 Thread Minda Chen
In StarFive VF2 board. pcie0 connect to VTI usb controller. Enable it to support usb host. Signed-off-by: Minda Chen --- arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi b/arch

[RESEND, v1 3/4] riscv: starfive: Add SYS_CACHE_SHIFT_6 to enable SYS_CACHELINE_SIZE

2023-08-07 Thread Minda Chen
Some device driver need SYS_CACHELINE_SIZE macro. Add StarFive SYS_CACHE_SHIFT_6 to enable it. Signed-off-by: Minda Chen --- arch/riscv/cpu/jh7110/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/riscv/cpu/jh7110/Kconfig b/arch/riscv/cpu/jh7110/Kconfig index 4d9581165b

[RESEND, v1 4/4] configs: riscv: starfive: Add VF2 PCIe USB3 XHCI support

2023-08-07 Thread Minda Chen
Add XHCI_PCI to enable usb3-host functions. Also add usb command and keyboard config. Signed-off-by: Minda Chen --- configs/starfive_visionfive2_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig

[RESEND,v1 0/4] Add StarFive VF2 USB host support.

2023-08-07 Thread Minda Chen
StarFive VF2 VLI usb-host controller connect to pcie0 RC. Enable pcie0 first the enable USB function. patch1 is Get the correct ECAM offset in multiple PCIe RC. patch2 is enable pcie0 dts node. patch3 is enable SYS_CACHELINE_SIZE patch4 is Add VF2 USB related configuration. Minda Chen (4): pci

[RESEND, v1 1/4] pci: plda: Get correct ECAM offset in multiple PCIe RC case

2023-08-07 Thread Minda Chen
Get the correct ECAM offset and record the secondary bus number in Multiple RC case. Signed-off-by: Minda Chen --- drivers/pci/pcie_plda_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pcie_plda_common.c b/drivers/pci/pcie_plda_common.c index

Re: [PATCH v1 3/4] riscv: starfive: Add SYS_CACHE_SHIFT_6 to enable SYS_CACHE_LINE_SIZE

2023-08-02 Thread Minda Chen
On 2023/8/3 12:49, Bin Meng wrote: > On Thu, Aug 3, 2023 at 11:22 AM Minda Chen > wrote: >> >> Some devices need SYS_CACHE_LINE_SIZE macro. Add StarFive >> SYS_CACHE_SHIFT_6 to enable it. >> >> Signed-off-by: Minda Chen >> --- >> arch/ris

[PATCH v1 0/4] Add VF2 USB host support.

2023-08-02 Thread Minda Chen
StarFive VF2 VTI usb-host controller connect to pcie0 RC. Enable pcie0 first the enable USB function. patch1 is Get the correct ECAM offset in multiple PCIe RC. patch2 is enable pcie0 dts node. patch3 is enable SYS_CACHE_LINE_SIZE patch4 is Add VF2 USB related configuration. Minda Chen (4

[PATCH v1 4/4] configs: riscv: starfive: Add VF2 PCIe XHCI config support

2023-08-02 Thread Minda Chen
Add PCI_XHCI support to enable usb3-host functions. Also add usb command and keyboard config. Signed-off-by: Minda Chen --- configs/starfive_visionfive2_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/configs/starfive_visionfive2_defconfig b/configs

[PATCH v1 3/4] riscv: starfive: Add SYS_CACHE_SHIFT_6 to enable SYS_CACHE_LINE_SIZE

2023-08-02 Thread Minda Chen
Some devices need SYS_CACHE_LINE_SIZE macro. Add StarFive SYS_CACHE_SHIFT_6 to enable it. Signed-off-by: Minda Chen --- arch/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index 867cbcbe74..15da2a8559 100644 --- a/arch/riscv/Kconfig

[PATCH v1 1/4] pci: plda: Get correct ECAM offset in multiple PCIe RC case

2023-08-02 Thread Minda Chen
Get the correct ECAM offset and record the secondary bus number in Multiple RC case. Signed-off-by: Minda Chen --- drivers/pci/pcie_plda_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pcie_plda_common.c b/drivers/pci/pcie_plda_common.c index

[PATCH v1 2/4] riscv: dts: starfive: Enable pcie0 dts node

2023-08-02 Thread Minda Chen
In StarFive VF2 board. pcie0 connect to VTI usb controller. Enable it to support usb host. Signed-off-by: Minda Chen --- arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi b/arch

Re: [PULL] u-boot-riscv/master

2023-08-02 Thread Minda Chen
; > >> > Heinrich Schuchardt (2): >> > riscv: sifive: initialize PCI on Unmatched >> > acpi: Add missing RISC-V acpi_table header >> > >> > Mason Huo (3): >> > starfive: pci: Add StarFive JH7110 pcie driver >> >

Re: [PATCH v8 1/4] i2c: designware: Add Kconfig for designware_i2c_pci.c

2023-08-01 Thread Minda Chen
On 2023/7/26 11:07, Leo Liang wrote: > On Tue, Jul 25, 2023 at 05:46:47PM +0800, Minda Chen wrote: >> As the Designware_i2c_pci.c uses ACPI APIs, If some SoCs (StarFive >> JH7110) contain Designware i2c and PCI but do not use ACPI, >> This file will be can't be compiled.

[PATCH v7 0/4] Add StarFive JH7110 PCIe drvier support

2023-07-25 Thread Minda Chen
host driver riscv: dts: starfive: Enable PCIe host controller Minda Chen (1): i2c: designware: Add Kconfig for designware_i2c_pci.c .../dts/jh7110-starfive-visionfive-2.dtsi | 11 + arch/riscv/dts/jh7110.dtsi| 74 configs/starfive_visionfive2_defconfig

[PATCH v8 1/4] i2c: designware: Add Kconfig for designware_i2c_pci.c

2023-07-25 Thread Minda Chen
As the Designware_i2c_pci.c uses ACPI APIs, If some SoCs (StarFive JH7110) contain Designware i2c and PCI but do not use ACPI, This file will be can't be compiled. So add a new Kconfig for designware_i2c_pci.c, which depends on ACPIGEN Signed-off-by: Minda Chen --- drivers/i2c/Kconfig | 9

[PATCH v8 4/4] riscv: dts: starfive: Enable PCIe host controller

2023-07-25 Thread Minda Chen
From: Mason Huo Enable and add pinctrl configuration for PCIe host controller. Signed-off-by: Mason Huo Signed-off-by: Minda Chen Reviewed-by: Leo Yu-Chi Liang --- .../dts/jh7110-starfive-visionfive-2.dtsi | 11 +++ arch/riscv/dts/jh7110.dtsi| 74

[PATCH v8 2/4] starfive: pci: Add StarFive JH7110 pcie driver

2023-07-25 Thread Minda Chen
From: Mason Huo Add pcie driver for StarFive JH7110, Also add PLDA PCIe controller common driver functions. Several devices are tested: a) M.2 NVMe SSD b) Realtek 8169 Ethernet adapter. Signed-off-by: Mason Huo Signed-off-by: Minda Chen Acked-by: Pali Rohár Reviewed-by: Leo Yu-Chi Liang

[PATCH v8 3/4] configs: starfive-jh7110: Add support for PCIe host driver

2023-07-25 Thread Minda Chen
From: Mason Huo Add PCIe host driver and nvme driver in configure file. Signed-off-by: Mason Huo Signed-off-by: Minda Chen Reviewed-by: Leo Yu-Chi Liang --- configs/starfive_visionfive2_defconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/configs

Re: [PATCH v7 1/4] i2c: designware: Add CONFIG_ACPIGEN limitation to designware_i2c_pci.c

2023-07-20 Thread Minda Chen
On 2023/7/21 3:42, Simon Glass wrote: > Hi, > > On Thu, 20 Jul 2023 at 05:24, Minda Chen wrote: >> >> As the designware_i2c_pci.c uses ACPI APIs, If some SoCs (StarFive >> JH7110) contain designware i2c and PCI but do not use ACPI, >> This file will be

[PATCH v2 3/4] net: rtl8169: Add one device ID 0x8161

2023-07-20 Thread Minda Chen
Add rtl8169 NIC device ID and reorder the device ID. Signed-off-by: Minda Chen --- drivers/net/rtl8169.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c index 34e4cff1e9..963702777c 100644 --- a/drivers/net/rtl8169.c +++ b

[PATCH v2 0/4] Fix rtl8169 compile warning and add a new device ID

2023-07-20 Thread Minda Chen
aligned size warning patch 3 add new device ID patch 4 enable 8169 in JH7110 SoC configs file. Minda Chen (4): net: rtl8169: Fix compile warning in rtl8169 net: rtl8169: Fix DMA minimal aligned compile warning in RISC-V net: rtl8169: Add one device ID 0x8161 configs: starfive-jh7110: Add

[PATCH v2 4/4] configs: starfive-jh7110: Add CONFIG_RTL8169

2023-07-20 Thread Minda Chen
Add PCIe device rtl8169 net adapter driver support. Signed-off-by: Minda Chen --- configs/starfive_visionfive2_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig index 59e39c6f9b..7fc1569b59 100644

[PATCH v2 1/4] net: rtl8169: Fix compile warning in rtl8169

2023-07-20 Thread Minda Chen
While compiling rtl8169.c, There are many "make pointer from integer without a cast" compile warnings. fix them with adding cast. Signed-off-by: Minda Chen --- drivers/net/rtl8169.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/rtl8169.c

[PATCH v2 2/4] net: rtl8169: Fix DMA minimal aligned compile warning in RISC-V

2023-07-20 Thread Minda Chen
For RISC-V architeture, hardware maintain the dcache coherency. Software do not flush the cache. So even cache-line size larger than descriptor size, driver can work. Signed-off-by: Minda Chen --- drivers/net/rtl8169.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH v7 2/4] starfive: pci: Add StarFive JH7110 pcie driver

2023-07-20 Thread Minda Chen
From: Mason Huo Add pcie driver for StarFive JH7110, Also add PLDA PCIe controller common driver functions. Several devices are tested: a) M.2 NVMe SSD b) Realtek 8169 Ethernet adapter. Signed-off-by: Mason Huo Signed-off-by: Minda Chen Acked-by: Pali Rohár --- drivers/pci/Kconfig

[PATCH v7 1/4] i2c: designware: Add CONFIG_ACPIGEN limitation to designware_i2c_pci.c

2023-07-20 Thread Minda Chen
As the designware_i2c_pci.c uses ACPI APIs, If some SoCs (StarFive JH7110) contain designware i2c and PCI but do not use ACPI, This file will be can't be compiled. So add ACPIGEN to designware_i2c_pci.c Signed-off-by: Minda Chen --- drivers/i2c/Makefile | 2 ++ 1 file changed, 2 insertions

[PATCH v7 4/4] riscv: dts: starfive: Enable PCIe host controller

2023-07-20 Thread Minda Chen
From: Mason Huo Enable and add pinctrl configuration for PCIe host controller. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- .../dts/jh7110-starfive-visionfive-2.dtsi | 11 +++ arch/riscv/dts/jh7110.dtsi| 74 +++ 2 files changed, 85 insertions

[PATCH v7 3/4] configs: starfive-jh7110: Add support for PCIe host driver

2023-07-20 Thread Minda Chen
From: Mason Huo Add PCIe host driver and nvme driver in configure file. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- configs/starfive_visionfive2_defconfig | 8 1 file changed, 8 insertions(+) diff --git a/configs/starfive_visionfive2_defconfig b/configs

[PATCH v7 0/4] Add StarFive JH7110 PCIe drvier support

2023-07-20 Thread Minda Chen
been included in [1]. Mason Huo (3): starfive: pci: Add StarFive JH7110 pcie driver configs: starfive-jh7110: Add support for PCIe host driver riscv: dts: starfive: Enable PCIe host controller Minda Chen (1): i2c: designware: Add CONFIG_ACPIGEN limitation to designware_i2c_pci.c ...

Re: [PATCH v1 0/4] Fix rtl8169 compile warning and add a new device ID

2023-07-04 Thread Minda Chen
Hi Joe and Ramon Sorry to disturb you. Could you please review this patchset. Thanks On 2023/6/21 17:05, Minda Chen wrote: > StarFive JH7110 uboot support PCIe and using rtl8169 network adapter > PCIe device. But compile warning in rtl8169 driver cause CI test fail. > So commit this

[PATCH v1 3/4] net: rtl8169: Add one more device ID

2023-06-21 Thread Minda Chen
Add the NIC device ID and adjust the PCI bar regions. Signed-off-by: Minda Chen --- drivers/net/rtl8169.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c index 34e4cff1e9..963702777c 100644 --- a/drivers/net/rtl8169.c +++ b

[PATCH v1 4/4] configs: starfive-jh7110: Add CONFIG_RTL8169

2023-06-21 Thread Minda Chen
Add PCIe device rtl8169 net adapter driver support. Signed-off-by: Minda Chen --- configs/starfive_visionfive2_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig index ffbc4b9476..360160200f 100644

[PATCH v1 2/4] net: rtl8169: Fix DMA min aligned compile warning in riscv

2023-06-21 Thread Minda Chen
Fix rtl8169 descriptor less the DMA min aligned compile warning for RISC-V SoC platform. Signed-off-by: Minda Chen --- drivers/net/rtl8169.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c index dcba51590d..34e4cff1e9 100644

[PATCH v1 0/4] Fix rtl8169 compile warning and add a new device ID

2023-06-21 Thread Minda Chen
-conversion] patch 2 fix RISC-V 8169 descriptor less than DMA min aligned size warning patch 3 add new device ID patch 4 enable 8169 in JH7110 SoC configs file. Minda Chen (4): net: rtl8169: Fix compile warning in rtl8169 network adapter net: rtl8169: Fix DMA min aligned compile warning in riscv

[PATCH v1 1/4] net: rtl8169: Fix compile warning in rtl8169 network adapter

2023-06-21 Thread Minda Chen
Fix make pointer from integer without a cast compile warning. Signed-off-by: Minda Chen --- drivers/net/rtl8169.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c index 2276a465e7..dcba51590d 100644 --- a/drivers/net

Re: [PATCH v6 0/3] Add StarFive JH7110 PCIe drvier support

2023-06-16 Thread Minda Chen
On 2023/6/16 16:42, Leo Liang wrote: > Hi Minda, > > On Thu, Jun 01, 2023 at 09:07:14AM +0800, Minda Chen wrote: >> >> Hi Rick and Leo >> Could you review these series patches? Thanks. >> Since patch 1 was acked by Pali, Does it mean patch 1 is accep

Re: [PATCH v6 0/3] Add StarFive JH7110 PCIe drvier support

2023-05-31 Thread Minda Chen
Hi Rick and Leo Could you review these series patches? Thanks. Since patch 1 was acked by Pali, Does it mean patch 1 is accepted? On 2023/5/9 16:26, Minda Chen wrote: > These PCIe series patches are based on the JH7110 RISC-V SoC and VisionFive > V2 board. > > The PCIe driver dep

[PATCH v6 3/3] riscv: dts: starfive: Enable PCIe host controller

2023-05-09 Thread Minda Chen
From: Mason Huo Enable and add pinctrl configuration for PCIe host controller. Also add JH7110 stg syscon configuration. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- .../dts/jh7110-starfive-visionfive-2.dtsi | 11 +++ arch/riscv/dts/jh7110.dtsi| 74

[PATCH v6 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-05-09 Thread Minda Chen
From: Mason Huo Add pcie driver for StarFive JH7110, Also add PLDA PCIe controller common driver functions. Several devices are tested: a) M.2 NVMe SSD b) Realtek 8169 Ethernet adapter. Signed-off-by: Mason Huo Signed-off-by: Minda Chen Acked-by: Pali Rohár --- drivers/pci/Kconfig

[PATCH v6 0/3] Add StarFive JH7110 PCIe drvier support

2023-05-09 Thread Minda Chen
These PCIe series patches are based on the JH7110 RISC-V SoC and VisionFive V2 board. The PCIe driver depends on gpio, pinctrl, clk and reset driver to do init. The PCIe dts configuation includes all these setting. The PCIe drivers codes has been tested on the VisionFive V2 boards. The test

[PATCH v6 2/3] configs: starfive-jh7110: Add support for PCIe host driver

2023-05-09 Thread Minda Chen
From: Mason Huo also add the nvme driver and rtl8169 support. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- configs/starfive_visionfive2_defconfig | 10 ++ 1 file changed, 10 insertions(+) diff --git a/configs/starfive_visionfive2_defconfig b/configs

[PATCH v5 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-04-23 Thread Minda Chen
From: Mason Huo Add pcie driver for StarFive JH7110, Also add PLDA PCIe controller common driver functions. Several devices are tested: a) M.2 NVMe SSD b) Realtek 8169 Ethernet adapter. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- drivers/pci/Kconfig| 13

[PATCH v5 3/3] riscv: dts: starfive: Enable PCIe host controller

2023-04-23 Thread Minda Chen
From: Mason Huo Enable and add pinctrl configuration for PCIe host controller. Also add JH7110 stg syscon configuration. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- .../dts/jh7110-starfive-visionfive-2.dtsi | 11 +++ arch/riscv/dts/jh7110.dtsi| 88

[PATCH v5 2/3] configs: starfive-jh7110: Add support for PCIe host driver

2023-04-23 Thread Minda Chen
From: Mason Huo also add the nvme driver and rtl8169 support. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- configs/starfive_visionfive2_12a_defconfig | 10 ++ configs/starfive_visionfive2_13b_defconfig | 10 ++ 2 files changed, 20 insertions(+) diff --git a/configs

[PATCH v5 0/3] Add StarFive JH7110 PCIe drvier support

2023-04-23 Thread Minda Chen
This patchset needs to apply after patchset in [1]. These PCIe series patches are based on the JH7110 RISC-V SoC and VisionFive V2 board. [1] https://patchwork.ozlabs.org/project/uboot/cover/20230329034224.26545-1-yanhong.w...@starfivetech.com The PCIe driver depends on gpio, pinctrl, clk and

Re: [PATCH v4 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-04-12 Thread Minda Chen
On 2023/4/12 5:29, Pali Rohár wrote: > Hello! > > On Tuesday 11 April 2023 09:02:07 Minda Chen wrote: >> +int starfive_pcie_config_write(struct udevice *udev, pci_dev_t bdf, >> + uint offset, ulong value, >> +

Re: [PATCH v4 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-04-12 Thread Minda Chen
On 2023/4/11 13:20, Bin Meng wrote: > On Tue, Apr 11, 2023 at 11:53 AM Minda Chen > wrote: >> >> >> >> On 2023/4/11 10:55, Bin Meng wrote: >> > On Tue, Apr 11, 2023 at 9:03 AM Minda Chen >> > wrote: >> >> >> >> From

Re: [PATCH v4 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-04-10 Thread Minda Chen
On 2023/4/11 10:55, Bin Meng wrote: > On Tue, Apr 11, 2023 at 9:03 AM Minda Chen > wrote: >> >> From: Mason Huo >> >> Add pcie driver for StarFive JH7110, the driver depends on >> starfive gpio, pinctrl, clk and reset driver to do init. >> >>

[PATCH v4 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-04-10 Thread Minda Chen
From: Mason Huo Add pcie driver for StarFive JH7110, the driver depends on starfive gpio, pinctrl, clk and reset driver to do init. Several devices are tested: a) M.2 NVMe SSD b) Realtek 8169 Ethernet adapter. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- drivers/pci/Kconfig

[PATCH v4 3/3] riscv: dts: starfive: Enable PCIe host controller

2023-04-10 Thread Minda Chen
From: Mason Huo Enable and add pinctrl configuration for PCIe host controller. Also add JH7110 stg syscon configuration. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- .../dts/jh7110-starfive-visionfive-2.dtsi | 11 +++ arch/riscv/dts/jh7110.dtsi| 74

[PATCH v4 0/3] Add StarFive JH7110 PCIe drvier support

2023-04-10 Thread Minda Chen
This patchset needs to apply after patchset in [1]. These PCIe series patches are based on the JH7110 RISC-V SoC and VisionFive V2 board. [1] https://patchwork.ozlabs.org/project/uboot/cover/20230329034224.26545-1-yanhong.w...@starfivetech.com The PCIe driver depends on gpio, pinctrl, clk and

[PATCH v4 2/3] configs: starfive-jh7110: Add support for PCIe host driver

2023-04-10 Thread Minda Chen
From: Mason Huo also add the nvme driver and rtl8169 support. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- configs/starfive_visionfive2_12a_defconfig | 10 ++ configs/starfive_visionfive2_13b_defconfig | 10 ++ 2 files changed, 20 insertions(+) diff --git a/configs

Re: [PATCH v3 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-04-07 Thread Minda Chen
On 2023/3/31 20:59, Pali Rohár wrote: > On Friday 31 March 2023 18:35:00 Minda Chen wrote: >> On 2023/3/30 1:27, Pali Rohár wrote: >> > Hello! >> > >> > On Wednesday 29 March 2023 18:01:41 Minda Chen wrote: >> >> + /* PCIe PCI Standard Configu

Re: [PATCH v3 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-03-31 Thread Minda Chen
On 2023/3/30 1:27, Pali Rohár wrote: > Hello! > > On Wednesday 29 March 2023 18:01:41 Minda Chen wrote: >> From: Mason Huo >> >> Add pcie driver for StarFive JH7110, the driver depends on >> starfive gpio, pinctrl, clk and reset driver to do init. >> &

[PATCH v3 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-03-29 Thread Minda Chen
From: Mason Huo Add pcie driver for StarFive JH7110, the driver depends on starfive gpio, pinctrl, clk and reset driver to do init. Several devices are tested: a) M.2 NVMe SSD b) Realtek 8169 Ethernet adapter. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- drivers/pci/Kconfig

[PATCH v3 3/3] riscv: dts: starfive: Enable PCIe host controller

2023-03-29 Thread Minda Chen
From: Mason Huo Enable and add pinctrl configuration for PCIe host controller. Also add JH7110 stg syscon configuration. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- .../dts/jh7110-starfive-visionfive-2.dtsi | 11 +++ arch/riscv/dts/jh7110.dtsi| 74

[PATCH v3 2/3] configs: starfive-jh7110: Add support for PCIe host driver

2023-03-29 Thread Minda Chen
From: Mason Huo also add the nvme driver and rtl8169 support. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- configs/starfive_visionfive2_12a_defconfig | 9 + configs/starfive_visionfive2_13b_defconfig | 9 + 2 files changed, 18 insertions(+) diff --git a/configs

[PATCH v3 0/3] Add StarFive JH7110 PCIe drvier support

2023-03-29 Thread Minda Chen
This patchset needs to apply after patchset in [1]. These PCIe series patches are based on the JH7110 RISC-V SoC and VisionFive V2 board. [1] https://patchwork.ozlabs.org/project/uboot/cover/20230329034224.26545-1-yanhong.w...@starfivetech.com The PCIe driver depends on gpio, pinctrl, clk and

Re: [PATCH v2 3/3] riscv: dts: starfive: Enable PCIe host controller

2023-03-26 Thread Minda Chen
On 2023/3/25 21:22, Pali Rohár wrote: > On Wednesday 08 March 2023 13:48:33 Minda Chen wrote: >> From: Mason Huo >> >> Enable and add pinctrl configuration for PCIe host controller. >> Also add JH7110 stg syscon configuration. >> >> Signed-off-by:

Re: [PATCH v2 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-03-26 Thread Minda Chen
On 2023/3/25 20:31, Pali Rohár wrote: > On Friday 24 March 2023 18:57:33 Minda Chen wrote: >> On 2023/3/24 2:19, Pali Rohár wrote: >> > On Thursday 23 March 2023 18:51:38 Minda Chen wrote: >> >> On 2023/3/11 1:42, Pali Rohár wrote: >> >> > On F

Re: [PATCH v2 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-03-24 Thread Minda Chen
On 2023/3/24 2:19, Pali Rohár wrote: > On Thursday 23 March 2023 18:51:38 Minda Chen wrote: >> On 2023/3/11 1:42, Pali Rohár wrote: >> > On Friday 10 March 2023 18:36:44 Minda Chen wrote: >> >> On 2023/3/8 15:31, Pali Rohár wrote: >>

Re: [PATCH v2 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-03-23 Thread Minda Chen
On 2023/3/11 1:42, Pali Rohár wrote: > On Friday 10 March 2023 18:36:44 Minda Chen wrote: >> On 2023/3/8 15:31, Pali Rohár wrote: >> > Hello! See few comments below. >> > >> > On Wednesday 08 March 2023 13:48:31 Minda Chen wrote: >> >> From: Maso

Re: [PATCH v2 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-03-10 Thread Minda Chen
On 2023/3/8 15:31, Pali Rohár wrote: > Hello! See few comments below. > > On Wednesday 08 March 2023 13:48:31 Minda Chen wrote: >> From: Mason Huo >> >> Add pcie driver for StarFive JH7110, the driver depends on >> starfive gpio, pinctrl, clk and reset

[PATCH v2 1/3] starfive: pci: Add StarFive JH7110 pcie driver

2023-03-07 Thread Minda Chen
From: Mason Huo Add pcie driver for StarFive JH7110, the driver depends on starfive gpio, pinctrl, clk and reset driver to do init. Several devices are tested: a) M.2 NVMe SSD b) Realtek 8169 Ethernet adapter. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- drivers/pci/Kconfig

[PATCH v2 2/3] configs: starfive-jh7110: Add support for PCIe host driver

2023-03-07 Thread Minda Chen
From: Mason Huo also add the nvme driver and rtl8169 support. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- configs/starfive_visionfive2_defconfig | 9 + 1 file changed, 9 insertions(+) diff --git a/configs/starfive_visionfive2_defconfig b/configs

[PATCH v2 0/3] Add StarFive JH7110 PCIe drvier support

2023-03-07 Thread Minda Chen
This patchset needs to apply after patchset in [1]. These PCIe series patches are based on the JH7110 RISC-V SoC and VisionFive V2 board. [1] https://patchwork.ozlabs.org/project/uboot/cover/20230303032432.7837-1-yanhong.w...@starfivetech.com/ The PCIe driver depends on gpio, pinctrl, clk and

[PATCH v2 3/3] riscv: dts: starfive: Enable PCIe host controller

2023-03-07 Thread Minda Chen
From: Mason Huo Enable and add pinctrl configuration for PCIe host controller. Also add JH7110 stg syscon configuration. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- .../dts/jh7110-starfive-visionfive-2.dtsi | 99 +++ arch/riscv/dts/jh7110.dtsi

[PATCH 3/4] configs: starfive-jh7110: Add support for PCIe host driver

2023-02-23 Thread Minda Chen
From: Mason Huo also add the nvme driver and rtl8169 support. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- configs/starfive_visionfive2_defconfig | 9 + 1 file changed, 9 insertions(+) diff --git a/configs/starfive_visionfive2_defconfig b/configs

[PATCH 4/4] riscv: dts: starfive: Enable PCIe host controller

2023-02-23 Thread Minda Chen
From: Mason Huo Enable and add pinctrl configuration for PCIe host controller. Also add JH7110 stg syscon configuration. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- arch/riscv/dts/jh7110.dtsi | 79 ++ arch/riscv/dts/starfive_visionfive2.dts | 104

[PATCH 1/4] starfive: pci: Add StarFive JH7110 pcie driver

2023-02-23 Thread Minda Chen
From: Mason Huo Add pcie driver for StarFive JH7110, the driver depends on starfive gpio, pinctrl, clk and reset driver to do init. Several devices are tested: a) M.2 NVMe SSD b) Realtek 8169 Ethernet adapter. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- drivers/pci/Kconfig

[PATCH 2/4] clk: starfive: Add PCIe clocks for PCIe controller

2023-02-23 Thread Minda Chen
From: Mason Huo Add the stg clocks for StarFive JH7110 PCIe controller. Signed-off-by: Mason Huo Signed-off-by: Minda Chen --- drivers/clk/starfive/clk-jh7110.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/clk/starfive/clk-jh7110.c b/drivers/clk

[PATCH 0/4] Add StarFive JH7110 PCIe drvier support

2023-02-23 Thread Minda Chen
This patchset needs to apply after patchset in [1]. These PCIe series patches are based on the JH7110 RISC-V SoC and VisionFive V2 board. The PCIe driver depends on gpio, pinctrl, clk and reset driver to do init. The PCIe dts configuation includes all these setting. The PCIe drivers codes has