Re: [PATCH v1 0/3] board: amlogic: jethubj100: small updates

2024-03-25 Thread Neil Armstrong
Hi, On Tue, 27 Feb 2024 09:54:03 +0300, Viacheslav Bocharov wrote: > Update JetHub D1/D1+ board support files. > > Viacheslav Bocharov (3): > board: amlogic: jethubj100: fix common config header > board: amlogic: jethubj100: update MAINTAINERS > board: amlogic: jethubj100: update docs > >

Re: [PATCH 0/4] arm: meson: Switch to using upstream DT for GXL, GXM, AXG, G12A, G12B & SM1 SoCs

2024-03-22 Thread Neil Armstrong
Hi Viacheslav, On 19/03/2024 15:42, Neil Armstrong wrote: Enable OF_UPSTREAM to use upstream DT and add amlogic/ prefix to the DEFAULT_DEVICE_TREE. And thereby directly build DTB from dts/upstream/src/ including *-u-boot.dtsi files from arch/$(ARCH)/dts/ directory and drop redundant files from

[PATCH v2] board: amlogic: fix buffler overflow in seria, mac & usid read

2024-03-20 Thread Neil Armstrong
While meson_sm_read_efuse() doesn't overflow, the string is not zero terminated and env_set*() will buffer overflow and add random characters to environment. Signed-off-by: Neil Armstrong --- Changes in v2: - Also fix mac_addr - Link to v1: https://lore.kernel.org/r/20240319-u-boot-fix-p200

Re: [PATCH] board: amlogic: fix buffler overflow in serial & usid read

2024-03-20 Thread Neil Armstrong
On 20/03/2024 06:28, Dan Carpenter wrote: On Tue, Mar 19, 2024 at 03:53:24PM +0100, Neil Armstrong wrote: While meson_sm_read_efuse() doesn't overflow, the string is not zero terminated and env_set() will buffer overflow and add random characters to environment. In the Linux kernel we would

[PATCH] board: amlogic: fix buffler overflow in serial & usid read

2024-03-19 Thread Neil Armstrong
While meson_sm_read_efuse() doesn't overflow, the string is not zero terminated and env_set() will buffer overflow and add random characters to environment. Signed-off-by: Neil Armstrong --- board/amlogic/jethub-j80/jethub-j80.c | 6 -- board/amlogic/p200/p200.c | 3 ++- board

[PATCH 3/4] dts: meson-g12a: Switch to using upstream DT

2024-03-19 Thread Neil Armstrong
Enable OF_UPSTREAM to use upstream DT and add amlogic/ prefix to the DEFAULT_DEVICE_TREE. And thereby directly build DTB from dts/upstream/src/ including *-u-boot.dtsi files from arch/$(ARCH)/dts/ directory. Cc: Sumit Garg Signed-off-by: Neil Armstrong --- arch/arm/mach-meson/Kconfig

[PATCH 1/4] dts: meson: Switch GXL, GXM & AXG to using upstream DT

2024-03-19 Thread Neil Armstrong
Enable OF_UPSTREAM to use upstream DT and add amlogic/ prefix to the DEFAULT_DEVICE_TREE. And thereby directly build DTB from dts/upstream/src/ including *-u-boot.dtsi files from arch/$(ARCH)/dts/ directory. Cc: Sumit Garg Signed-off-by: Neil Armstrong --- arch/arm/mach-meson/Kconfig

[PATCH 0/4] arm: meson: Switch to using upstream DT for GXL, GXM, AXG, G12A, G12B & SM1 SoCs

2024-03-19 Thread Neil Armstrong
/arm/dts directory for these boards. Keep A1 DTs locally since the architecture is still young. CI built & tested at: https://gitlab.com/amlogic-foss/amlogic-u-boot-autotest/-/pipelines/1219273552 Signed-off-by: Neil Armstrong --- Neil Armstrong (4): dts: meson: Switch GXL, GXM &

Re: [PATCH 3/3] configs: amlogic: set board family to avoid random MAC on WeTek Hub/Play2

2024-03-18 Thread neil . armstrong
Hi, On 16/03/2024 14:54, Christian Hewitt wrote: Add CONFIG_SYS_BOARD="p200" to the Hub/Play2 board configs to ensure the factory programmed MAC is correctly read from efuse. Signed-off-by: Christian Hewitt --- configs/wetek-hub_defconfig | 1 + configs/wetek-play2_defconfig | 1 + 2

Re: [PATCH 2/3] ARM: board: meson: update efuse MAC reading code

2024-03-18 Thread neil . armstrong
Hi, On 16/03/2024 14:54, Christian Hewitt wrote: Current code used for reading the factory programmed MAC from efuse on p200 boards does not appear to work resulting in a random MAC being generated. Update the p200 board data reusing the function from the VIM3 source. I'm pretty sure this code

Re: [PATCH 1/3] ARM: dts: fix Ethernet on WeTek Hub/Play2

2024-03-18 Thread neil . armstrong
si @@ -0,0 +1,13 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2019 BayLibre, SAS. + * Author: Neil Armstrong + */ + +#include "meson-gx-u-boot.dtsi" + + { + snps,reset-gpio = < GPIOZ_14 0>; + snps,reset-delays-us = <0 1 100>; +

Re: [PATCH v2 14/14] qcom_defconfig: enable USB

2024-03-15 Thread Neil Armstrong
On 15/03/2024 16:10, Caleb Connolly wrote: Enable support for the DWC3 USB controller and required dependencies for Qualcomm boards, specifically the DB845c: * IOMMU / SMMU * USB high-speed PHYs * Mass storage and ACM gadgets I don't see configs for ACM ? Neil Signed-off-by: Caleb Connolly

Re: [PATCH v2 13/14] qcom_defconfig: enable livetree

2024-03-15 Thread Neil Armstrong
=y CONFIG_CMD_LOG=y +CONFIG_OF_LIVE=y +# CONFIG_NET is not set +# CONFIG_OFNODE_MULTI_TREE is not set CONFIG_BUTTON_QCOM_PMIC=y CONFIG_CLK=y CONFIG_CLK_QCOM_QCS404=y CONFIG_CLK_QCOM_SDM845=y Reviewed-by: Neil Armstrong

Re: [PATCH v2 09/14] serial: msm-geni: support livetree

2024-03-15 Thread Neil Armstrong
_VAL(DEBUG_UART_BASE) Reviewed-by: Neil Armstrong

Re: [PATCH v2 06/14] clk/qcom: sdm845: add gdscs

2024-03-15 Thread Neil Armstrong
, .num_clks = ARRAY_SIZE(sdm845_clks), + .power_domains = sdm845_gdscs, + .num_power_domains = ARRAY_SIZE(sdm845_gdscs), .enable = sdm845_clk_enable, .set_rate = sdm845_clk_set_rate, }; Reviewed-by: Neil Armstrong

Re: [PATCH v2 01/14] mailmap: update Bhupesh's email address

2024-03-15 Thread Neil Armstrong
@@ -29,8 +29,9 @@ Ashok Reddy Soma Atish Patra Bharat Kumar Gogada Bharat Kumar Gogada Bhargava Sreekantappa Gayathri +Bhupesh Sharma Bin Meng Boris Brezillon Boris Brezillon Christian Kohn Reviewed-by: Neil Armstrong

Re: [PATCH v2 0/5] Qualcomm DWC3 USB support

2024-03-15 Thread Neil Armstrong
drivers/usb/gadget/storage_common.c | 12 +++-- include/usb_mass_storage.h | 1 - 8 files changed, 156 insertions(+), 55 deletions(-) --- base-commit: e03a71b2cefd86ba58df166d4ea820a215ebb655 // Caleb (they/them) LGTM Reviewed-by: Neil Armstrong

Re: [PATCH RFC 00/26] Drop DT upstream compatible dt-binding headers

2024-03-11 Thread Neil Armstrong
arduous (as is the case with Qualcomm). To: Tom Rini To: Neil Armstrong To: Sumit Garg To: Patrice Chotard To: Patrick Delaunay To: Jagan Teki To: Simon Glass To: Philipp Tomsich To: Kever Yang To: Lukasz Majewski To: Sean Anderson To: Sam Protsenko To: Matthias Brugger To: Peter

Re: [PATCH RFC 07/26] amlogic: drop dt-binding headers

2024-03-11 Thread Neil Armstrong
/meson-aiu.h | 18 --- include/dt-bindings/sound/meson-g12a-toacodec.h| 10 -- include/dt-bindings/sound/meson-g12a-tohdmitx.h| 13 -- 31 files changed, 2212 deletions(-) Reviewed-by: Neil Armstrong

Re: [PATCH v6 00/11] An effort to bring DT bindings compliance within U-Boot

2024-03-01 Thread neil . armstrong
On 01/03/2024 14:30, Sumit Garg wrote: On Fri, 1 Mar 2024 at 18:27, Tom Rini wrote: On Thu, 22 Feb 2024 15:05:56 +0530, Sumit Garg wrote: Changes in v6: -- - v6_dt: https://github.com/b49020/u-boot/tree/v6_dt - Patch #3: Incorporate fix for sandbox CI failure. - Patch #6:

Re: [PATCH v1 0/3] board: amlogic: jethubj100: small updates

2024-02-27 Thread Neil Armstrong
/MAINTAINERS | 2 +- doc/board/amlogic/jethub-j100.rst | 9 ++--- include/configs/jethub.h | 2 +- 3 files changed, 8 insertions(+), 5 deletions(-) base-commit: d49fa3defa50c6d3f04acbb52fd486c13c14ab6a Reviewed-by: Neil Armstrong

[PULL] Please pull u-boot-amlogic-fixes-20240223

2024-02-23 Thread neil . armstrong
From: Neil Armstrong Please pull this simple config fixes for the Khadas VIM3 Android setup to fix an Out Of Memory error for AVB. Thanks, Neil The following changes since commit 5e4a0c7f4a2c9d4670b75a6a2056243b1a56512b: Merge branch 'qcom-fixes-2024.04' of https://gitlab.denx.de/u-boot

Re: [PATCH] configs: khadas-vim3*_android: fix AVB oom error

2024-02-23 Thread Neil Armstrong
Hi, On Fri, 09 Feb 2024 09:58:35 +0100, Mattijs Korpershoek wrote: > When booting Android with AVB enabled, an OOM is observed: > > => avb init ${mmcdev} > => avb verify _a > ## Android Verified Boot 2.0 version 1.1.0 > read_is_device_unlocked not supported yet > read_rollback_index

Re: [PATCH v4 10/39] gpio: qcom_pmic: add a quirk to skip GPIO configuration

2024-02-21 Thread Neil Armstrong
On 20/02/2024 06:56, Sumit Garg wrote: On Fri, 16 Feb 2024 at 02:22, Caleb Connolly wrote: Some platforms hard reset when attempting to configure PMIC GPIOs. Add support for quirks specified in match data with a single quirk to skip this configuration. We rely on the GPIO already be

Re: [PATCH v4 11/39] gpio: qcom_pmic: add pinctrl driver

2024-02-19 Thread Neil Armstrong
e = qcom_pmic_pinctrl_get_pin_name, + .set_state = pinctrl_generic_set_state, + .pinconf_num_params = ARRAY_SIZE(qcom_pmic_pinctrl_conf_params), + .pinconf_params = qcom_pmic_pinctrl_conf_params, + .pinconf_set = qcom_pmic_pinctrl_pinconf_set, + .get_function_name = qcom_pmic_pinctrl_get_function_name, + .get_functions_count = qcom_pmic_pinctrl_generic_get_functions_count, + .pinmux_set = qcom_pmic_pinctrl_generic_pinmux_set_mux, +}; + +U_BOOT_DRIVER(qcom_pmic_pinctrl) = { + .name = "qcom_pmic_pinctrl", + .id = UCLASS_PINCTRL, + .ops= _pmic_pinctrl_ops, +}; Reviewed-by: Neil Armstrong

Re: [PATCH v4 26/39] doc: board/qualcomm: link to APQ8016 TRM

2024-02-19 Thread Neil Armstrong
://developer.qualcomm.com/qfile/35259/lm80-p0436-100_d_snapdragon_410e_apq8016e_tech_reference_manual_revd.pdf + Installation First, setup ``CROSS_COMPILE`` for aarch64. Then, build U-Boot for ``dragonboard410c``:: Reviewed-by: Neil Armstrong

Re: [PATCH v4 21/39] mach-snapdragon: dynamic load addresses

2024-02-19 Thread Neil Armstrong
ard410c.c index 0136cc2237de..fbbfc0e65e24 100644 --- a/board/qualcomm/dragonboard410c/dragonboard410c.c +++ b/board/qualcomm/dragonboard410c/dragonboard410c.c @@ -88,7 +88,7 @@ int misc_init_r(void) return 0; } -int board_late_init(void) +int qcom_late_init(void) { char serial[16]; Reviewed-by: Neil Armstrong

Re: [PATCH v4 14/39] pinctrl: qcom: fix DT compatibility

2024-02-19 Thread Neil Armstrong
ns. +*/ }; static const char *qcs404_get_function_name(struct udevice *dev, @@ -49,7 +87,7 @@ static const char *qcs404_get_pin_name(struct udevice *dev, unsigned int selector) { if (selector < 120) { - snprintf(pin_name, MAX_PIN_NAME_LEN, "GPIO_%u", selector); + snprintf(pin_name, MAX_PIN_NAME_LEN, "gpio%u", selector); return pin_name; } else { return msm_pinctrl_pins[selector - 120]; @@ -62,7 +100,7 @@ static unsigned int qcs404_get_function_mux(unsigned int selector) } static struct msm_pinctrl_data qcs404_data = { - .pin_data = { .pin_count = 126, }, + .pin_data = { .pin_count = 126, .pin_offsets = qcs404_pin_offsets, .special_pins_start = 120, }, .functions_count = ARRAY_SIZE(msm_pinctrl_functions), .get_function_name = qcs404_get_function_name, .get_function_mux = qcs404_get_function_mux, Reviewed-by: Neil Armstrong

Re: [PATCH v4 13/39] pinctrl: qcom: stub support for special GPIOs

2024-02-19 Thread Neil Armstrong
all pins as special pins. */ + if (!data->pin_data.special_pins_start) + data->pin_data.special_pins_start = data->pin_data.pin_count; + drv = lists_driver_lookup_name("pinctrl_qcom"); if (!drv) return -ENOENT; Reviewed-by: Neil Armstrong

Re: [PATCH v4 15/39] pinctrl: qcom: apq8016: init pre-reloaction

2024-02-19 Thread Neil Armstrong
= msm_pinctrl_bind, + .flags = DM_FLAG_PRE_RELOC, }; Reviewed-by: Neil Armstrong

Re: [PATCH v4 12/39] sandbox: dts: fix qcom pmic gpio

2024-02-19 Thread Neil Armstrong
-ranges = <_gpios 0 0 4>; #gpio-cells = <2>; - gpio-bank-name="spmi"; }; }; }; Reviewed-by: Neil Armstrong

Re: [PATCH v4 08/39] serial: msm: fix clock handling and pinctrl

2024-02-19 Thread Neil Armstrong
ice *dev) if (ret) return ret; - pinctrl_select_state(dev, "uart"); uart_dm_init(priv); return 0; @@ -251,6 +235,7 @@ U_BOOT_DRIVER(serial_msm) = { .priv_auto = sizeof(struct msm_serial_data), .probe = msm_serial_probe, .ops= _serial_ops, + .flags = DM_FLAG_PRE_RELOC, }; #ifdef CONFIG_DEBUG_UART_MSM Reviewed-by: Neil Armstrong

Re: [PATCH v4 07/39] serial: msm: add debug UART

2024-02-19 Thread Neil Armstrong
se + UARTDM_ISR) & UARTDM_ISR_TX_READY)) + ; + + writel(UARTDM_CR_CMD_RESET_TX_READY, priv->base + UARTDM_CR); + + writel(1, priv->base + UARTDM_NCF_TX); + writel(ch, priv->base + UARTDM_TF); +} + +DEBUG_UART_FUNCS + +#endif Reviewed-by: Neil Armstrong

Re: [PATCH v4 06/39] clock/qcom: qcs404: fix clk_set_rate

2024-02-19 Thread Neil Armstrong
set_rate(priv->base, _qup4_i2c_apps_regs, 0, CFG_CLK_SRC_CXO); break; + case GCC_SDCC1_AHB_CLK: + clk_enable_cbc(priv->base + SDCC_AHB_CBCR(1)); + break; default: return 0; } Reviewed-by: Neil Armstrong

Re: [PATCH] button: qcom-pmic: demote "unknown button" message to debug

2024-02-12 Thread Neil Armstrong
quot;Unknown button node '%s' should be 'pwrkey' or 'resin'\n", ofnode_get_name(node)); device_unbind(dev); } Reviewed-by: Neil Armstrong

Re: [PATCH] configs: khadas-vim3*_android: fix AVB oom error

2024-02-12 Thread Neil Armstrong
base-commit: 076529725f16f07a5cb2d5feba25d62b5f5a5872 change-id: 20240209-vim3-avb-malloc-aa3de534d6a0 Best regards, Reviewed-by: Neil Armstrong

[GIT PULL] Please pull u-boot-amlogic-fixes-20240201

2024-02-01 Thread Neil Armstrong
) - stop printing board model twice after sysinfo update Neil Armstrong (1): ARM: meson: stop printing board model after sysinfo update arch/arm/mach-meson/board-info.c | 10 -- 1 file changed, 10 deletions(-)

Re: [PATCH] ARM: meson: stop printing board model after sysinfo update

2024-01-30 Thread Neil Armstrong
Hi, On Wed, 24 Jan 2024 13:47:25 +0100, Neil Armstrong wrote: > After the sysinfo update, Model is printed twice, remove > the now duplicate Model print from mach-meson/board-info. > > Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-amlogic (u-boot-amlogic

[PATCH] ARM: meson: stop printing board model after sysinfo update

2024-01-24 Thread Neil Armstrong
After the sysinfo update, Model is printed twice, remove the now duplicate Model print from mach-meson/board-info. Signed-off-by: Neil Armstrong --- arch/arm/mach-meson/board-info.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/arch/arm/mach-meson/board-info.c b/arch/arm/mach

Re: [UBOOT PATCH v4] test/py: net: Add dhcp abort test

2024-01-18 Thread neil . armstrong
Hi, On 21/11/2023 14:02, Love Kumar wrote: Abort the dhcp request in the middle by pressing ctrl + c on u-boot prompt and validate the abort status. Signed-off-by: Love Kumar --- Changes in v2: - Mark CMD_MII command dependency Changes in v3: - Skip the test if PHY device not present

Re: [PATCH v3 03/17] video: dw_hdmi: Extend the HPD detection

2024-01-17 Thread Neil Armstrong
hdmi_phy_init(struct dw_hdmi *hdmi); int dw_hdmi_enable(struct dw_hdmi *hdmi, const struct display_timing *edid); int dw_hdmi_read_edid(struct dw_hdmi *hdmi, u8 *buf, int buf_size); void dw_hdmi_init(struct dw_hdmi *hdmi); +int dw_hdmi_detect_hpd(struct dw_hdmi *hdmi); #endif Reviewed-by: Neil Armstrong

Re: [PATCH v3 05/17] video: dw_hdmi: Add setup_hpd hook

2024-01-17 Thread Neil Armstrong
6 +539,7 @@ struct dw_hdmi; struct dw_hdmi_phy_ops { int (*phy_set)(struct dw_hdmi *hdmi, uint mpixelclock); void (*read_hpd)(struct dw_hdmi *hdmi, bool hdp_status); + void (*setup_hpd)(struct dw_hdmi *hdmi); }; struct dw_hdmi { Reviewed-by: Neil Armstrong

Re: [PATCH v3 04/17] video: dw_hdmi: Add read_hpd hook

2024-01-17 Thread Neil Armstrong
dmi_phy_ops { int (*phy_set)(struct dw_hdmi *hdmi, uint mpixelclock); + void (*read_hpd)(struct dw_hdmi *hdmi, bool hdp_status); }; struct dw_hdmi { Reviewed-by: Neil Armstrong

Re: [PATCH v3 02/17] video: dw_hdmi: Add Vendor PHY handling

2024-01-17 Thread Neil Armstrong
struct udevice *ddc_bus; + const struct dw_hdmi_phy_ops *ops; - int (*phy_set)(struct dw_hdmi *hdmi, uint mpixelclock); void (*write_reg)(struct dw_hdmi *hdmi, u8 val, int offset); u8 (*read_reg)(struct dw_hdmi *hdmi, int offset); }; That's much better! Thanks! Reviewed-by: Neil Armstrong

Re: [PATCH] sandbox_flattree: enable button support

2024-01-16 Thread Neil Armstrong
Reviewed-by: Neil Armstrong

Re: [PATCH 2/2] MAINTAINERS: add Mattijs for Android AVB

2024-01-12 Thread neil . armstrong
/tests/test_android/test_ab.py ANDROID AVB M:Igor Opaniuk +M: Mattijs Korpershoek S:Maintained F:cmd/avb.c F:common/avb_verify.c Reviewed-by: Neil Armstrong

Re: [PATCH 1/2] MAINTAINERS: add Mattijs for Android AB

2024-01-12 Thread neil . armstrong
/ ANDROID AB M:Igor Opaniuk +M: Mattijs Korpershoek R:Sam Protsenko S:Maintained F:boot/android_ab.c Reviewed-by: Neil Armstrong

Re: [PATCH v3] clk: meson: add Hardware Clock measure driver

2024-01-10 Thread neil . armstrong
On 10/01/2024 16:41, Sean Anderson wrote: On 1/10/24 04:23, Neil Armstrong wrote: Hi Sean, On 18/12/2023 10:47, Neil Armstrong via groups.io wrote: Amlogic SoCs embeds an hardware clock measure block, port it from Linux and implement it as a UCLK_CLK with only the dump op and fail-only xlate

Re: [PATCH v3] clk: meson: add Hardware Clock measure driver

2024-01-10 Thread Neil Armstrong
Hi Sean, On 18/12/2023 10:47, Neil Armstrong via groups.io wrote: Amlogic SoCs embeds an hardware clock measure block, port it from Linux and implement it as a UCLK_CLK with only the dump op and fail-only xlate. Based on the Linux driver introduced in [1]. [1] commit 2b45ebef39a2 (&quo

Re: [PATCH v2 02/17] video: dw_hdmi: Add Vendor PHY handling

2024-01-10 Thread neil . armstrong
On 09/01/2024 21:04, Jagan Teki wrote: Hi Neil, On Tue, Dec 19, 2023 at 5:21 PM Jagan Teki wrote: On Tue, Dec 19, 2023 at 2:34 PM Neil Armstrong wrote: On 18/12/2023 20:10, Jagan Teki wrote: From: Jagan Teki DW HDMI support Vendor PHY like Rockchip RK3328 Inno HDMI PHY. Extend

Re: [PATCH v2 8/8] dts: meson-gxbb: Drop redundant devicetree files

2023-12-22 Thread neil . armstrong
stdout-path = "serial0:115200n8"; - }; - - memory@0 { - device_type = "memory"; - reg = <0x0 0x0 0x0 0x4000>; - }; - - usb_pwr: regulator-usb-pwrs { - compatible = "regulator-fixed"; - -

Re: [PATCH v2 03/32] mmc: msm_sdhci: use modern clock handling

2023-12-21 Thread Neil Armstrong
et) { + printf("Couldn't set core clock rate: %d\n", ret); + return -EINVAL; + } return 0; } @@ -188,6 +209,8 @@ static int msm_sdc_remove(struct udevice *dev) if (!var_info->mci_removed) writel(0, priv->base + SDCC_MCI_HC_MODE); + clk_release_bulk(>clks); + return 0; } Looks better like this! Reviewed-by: Neil Armstrong

Re: [PATCH v2 06/32] serial: msm: add debug UART

2023-12-21 Thread Neil Armstrong
On 19/12/2023 17:04, Caleb Connolly wrote: Introduce support for early debugging. Signed-off-by: Caleb Connolly --- drivers/serial/Kconfig | 8 drivers/serial/serial_msm.c | 32 2 files changed, 40 insertions(+) diff --git

Re: [PATCH v2 32/32] MAINTAINERS: Qualcomm: add some missing paths

2023-12-21 Thread Neil Armstrong
8cd102eaa070..b41801078c94 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -571,18 +571,22 @@ M:Caleb Connolly M:Neil Armstrong R:Sumit Garg S:Maintained -F: arch/arm/mach-snapdragon/ -F: drivers/button/button-qcom-pmic.c -F: drivers/clk/qcom/ +F: arch/arm/dts

Re: [PATCH v2 31/32] board: qcs404-evb: drop board code

2023-12-21 Thread Neil Armstrong
INCTRL_QCOM_QCS404=y -CONFIG_DM_PMIC=y -CONFIG_PMIC_QCOM=y -CONFIG_MSM_SERIAL=y -CONFIG_SPMI_MSM=y -CONFIG_USB=y -CONFIG_USB_XHCI_HCD=y -CONFIG_USB_XHCI_DWC3=y -CONFIG_USB_DWC3=y -CONFIG_USB_DWC3_GENERIC=y -CONFIG_USB_STORAGE=y -CONFIG_LMB_MAX_REGIONS=64 Yeah ! code removal ! Reviewed-by: Neil Armstrong

Re: [PATCH v2 30/32] dts: qcs404-evb: replace with upstream DT

2023-12-21 Thread Neil Armstrong
/arm/dts/qcs404.dtsi | 1829 ++ 8 files changed, 2490 insertions(+), 421 deletions(-) Same as patch 19, with the commit id: Reviewed-by: Neil Armstrong

Re: [PATCH v2 29/32] dt-bindings: import headers for qcs404

2023-12-21 Thread Neil Armstrong
Same as patch 19, with the commit id: Reviewed-by: Neil Armstrong

Re: [PATCH v2 28/32] dts: msm8996: replace with upstream DTS

2023-12-21 Thread Neil Armstrong
/dragonboard820c_defconfig |2 +- 7 files changed, 5033 insertions(+), 187 deletions(-) Same as patch 19, with the commit id: Reviewed-by: Neil Armstrong

Re: [PATCH v2 27/32] dts: dragonboard820c: use correct bindings for clocks

2023-12-21 Thread Neil Armstrong
GCC_SDCC1_APPS_CLK: /* SDC1 */ return clk_init_sdc(priv, rate); break; - case 4: /*UART2*/ + case GCC_BLSP2_UART2_APPS_CLK: /*UART2*/ return clk_init_uart(priv); default: return 0; Reviewed-by: Neil Armstrong

Re: [PATCH v2 26/32] dts: msm8996: import PMIC dtsi files

2023-12-21 Thread Neil Armstrong
2 files changed, 217 insertions(+) Same as patch 19, with the commit id: Reviewed-by: Neil Armstrong

Re: [PATCH v2 25/32] dt-bindings: import headers for MSM8996

2023-12-21 Thread Neil Armstrong
+ .../dt-bindings/interconnect/qcom,msm8996-cbf.h| 12 + include/dt-bindings/interconnect/qcom,msm8996.h| 163 ++ include/dt-bindings/sound/qcom,wcd9335.h | 15 + 5 files changed, 845 insertions(+) Same as patch 19, with the commit id: Reviewed-by: Neil Armstrong

Re: [PATCH v2 24/32] dts: msm8916: replace with upstream DTS

2023-12-21 Thread Neil Armstrong
changed, 3472 insertions(+), 216 deletions(-) Same as patch 19, with the commit id: Reviewed-by: Neil Armstrong

Re: [PATCH v2 23/32] dts: msm8916: import PMIC dtsi files

2023-12-21 Thread Neil Armstrong
On 19/12/2023 17:04, Caleb Connolly wrote: Import the supporting pm8916.dtsi and msm8916-pm8916.dtsi files from upstream in preparation for switching boards over. Same as patch 19, with the commit id: Reviewed-by: Neil Armstrong

Re: [PATCH v2 22/32] dt-bindings: import headers for MSM8916

2023-12-21 Thread Neil Armstrong
-bindings/sound/qcom,lpass.h | 46 +++ 7 files changed, 572 insertions(+) Same as patch 19, with the commit id: Reviewed-by: Neil Armstrong

Re: [PATCH v2 21/32] dts: sdm845: replace with upstream DTS

2023-12-21 Thread Neil Armstrong
(+), 256 deletions(-) Same as patch 19, with the commit id: Reviewed-by: Neil Armstrong

Re: [PATCH v2 20/32] dts: sdm845: import supporting dtsi files

2023-12-21 Thread Neil Armstrong
+++ arch/arm/dts/pmi8998.dtsi| 98 + arch/arm/dts/sdm845-wcd9340.dtsi | 86 ++ 3 files changed, 314 insertions(+) Same as patch 19, with the commit id: Reviewed-by: Neil Armstrong

Re: [PATCH v2 19/32] dt-bindings: import headers for SDM845

2023-12-21 Thread Neil Armstrong
insertions(+) With the commit id: Reviewed-by: Neil Armstrong

Re: [PATCH v2 18/32] doc: board/qualcomm: document generic targets

2023-12-21 Thread Neil Armstrong
h boot.img using db845c fastboot method: - - .. code-block:: bash - - sudo fastboot flash boot boot.img - -More information can be found on the `DragonBoard 845c page`_. - -.. _Samsung S9 page: https://en.wikipedia.org/wiki/Samsung_Galaxy_S9 -.. _DragonBoard 845c page: https://www.96boards.org/product/rb3-platform/ Overall looks good, the debug hints are nice! Reviewed-by: Neil Armstrong

Re: [PATCH v2 17/32] mach-snapdragon: generate fdtfile automatically

2023-12-21 Thread Neil Armstrong
+env_get("soc"), env_get("board")); + env_set("fdtfile", dt_path); +} + void __weak qcom_late_init(void) { } @@ -142,6 +242,7 @@ int board_late_init(void) if (status) log_warning("%s: Failed to set run time variables\n", __func__); + configure_env(); qcom_late_init(); return 0; Nice, hope it will still fit for all future boards! Reviewed-by: Neil Armstrong

Re: [PATCH v2 15/32] mach-snapdragon: generalise board support

2023-12-21 Thread Neil Armstrong
15200, 230400, 460800, 921600 } - -#define CFG_EXTRA_ENV_SETTINGS \ - "bootm_size=0x500\0" \ - "bootm_low=0x8000\0" \ - "bootcmd=bootm $prevbl_initrd_start_addr\0" - -#endif diff --git a/include/configs/sdm845.h b/include/configs/sdm845.h deleted file mode 100644 index 5ad8569b2152.. --- a/include/configs/sdm845.h +++ /dev/null @@ -1,26 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Configuration file for boards, based on Qualcomm SDM845 chip - * - * (C) Copyright 2021 Dzmitry Sankouski - */ - -#ifndef __CONFIGS_SDM845_H -#define __CONFIGS_SDM845_H - -#include - -#define CFG_SYS_BAUDRATE_TABLE { 115200, 230400, 460800, 921600 } - -#define CFG_EXTRA_ENV_SETTINGS \ - "bootm_size=0x400\0" \ - "bootm_low=0x8000\0" \ - "stdin=serial,button-kbd\0" \ - "stdout=serial,vidconsole\0" \ - "stderr=serial,vidconsole\0" \ - "preboot=source $prevbl_initrd_start_addr:prebootscript\0" \ - "bootcmd=source $prevbl_initrd_start_addr:bootscript\0" - -/* Size of malloc() pool */ - -#endif Nice cleanup, the dynamic memory layout code is neat! It's looks good overall: Reviewed-by: Neil Armstrong

Re: [PATCH v2 14/32] board: dragonboard820c: use LINUX_KERNEL_IMAGE_HEADER

2023-12-21 Thread Neil Armstrong
D/ : { *(.dynamic*) } - /DISCARD/ : { *(.plt*) } - /DISCARD/ : { *(.interp*) } - /DISCARD/ : { *(.gnu*) } -} Easy code removal! Reviewed-by: Neil Armstrong

Re: [PATCH v2 13/32] board: dragonboard410c: import board code from mach-snapdragon

2023-12-21 Thread Neil Armstrong
o board/qualcomm/dragonboard410c/misc.h index c60e3e472470..fe44caf51b18 100644 --- a/arch/arm/mach-snapdragon/include/mach/misc.h +++ b/board/qualcomm/dragonboard410c/misc.h @@ -9,5 +9,6 @@ u32 msm_board_serial(void); void msm_generate_mac_addr(u8 *mac); +int msm_fixup_memory(void *blob); #endif With this fixed: Reviewed-by: Neil Armstrong

Re: [PATCH v2 12/32] board: dragonboard410c: upstream DT compat

2023-12-21 Thread Neil Armstrong
CLK 150 +#define GCC_ULTAUDIO_PCNOC_SWAY_CLK151 +#define GCC_ULTAUDIO_AVSYNC_XO_CLK 152 +#define GCC_ULTAUDIO_STC_XO_CLK153 +#define GCC_ULTAUDIO_AHBFABRIC_IXFABRIC_CLK154 +#define GCC_ULTAUDIO_AHBFABRIC_IXFABRIC_LPM_CLK155 +#define GCC_ULTA

Re: [PATCH v2 11/32] board: dragonboard410c: add chainloaded config fragment

2023-12-21 Thread Neil Armstrong
@@ -0,0 +1,7 @@ +# CONFIG_ENABLE_ARM_SOC_BOOT0_HOOK is not set +CONFIG_TEXT_BASE=0x0 +# CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR is not set +# CONFIG_REMAKE_ELF is not set +CONFIG_POSITION_INDEPENDENT=y +CONFIG_INIT_SP_RELATIVE=y +CONFIG_SYS_INIT_SP_BSS_OFFSET=524288 Reviewed-by: Neil Armstrong

Re: [PATCH v2 09/32] gpio: qcom_pmic: add a quirk to skip GPIO configuration

2023-12-21 Thread Neil Armstrong
On 19/12/2023 17:04, Caleb Connolly wrote: Some platforms hard reset when attempting to configure PMIC GPIOs. Add support for quirks specified in match data with a single quirk to skip this configuration. We rely on the GPIO already be configured correctly, which is always the case for volume up

Re: [PATCH v2 08/32] gpio: qcom_pmic: 1-based GPIOs

2023-12-21 Thread Neil Armstrong
= qcom_gpio_set_value, .get_function = qcom_gpio_get_function, + .xlate = qcom_gpio_xlate, }; static int qcom_gpio_probe(struct udevice *dev) Reviewed-by: Neil Armstrong

Re: [PATCH v2 07/32] serial: msm: fix clock handling

2023-12-21 Thread Neil Armstrong
On 19/12/2023 17:04, Caleb Connolly wrote: Use the modern helpers to fetch the clock and use the correct property ("clocks" instead of "clock") Signed-off-by: Caleb Connolly --- arch/arm/dts/dragonboard410c.dts | 3 ++- arch/arm/dts/dragonboard820c.dts | 3 ++-

Re: [PATCH v2 05/32] clk/qcom: use upstream compatible properties

2023-12-21 Thread Neil Armstrong
{ static const struct udevice_id gcc_apq8096_of_match[] = { { - .compatible = "qcom,gcc-apq8096", + .compatible = "qcom,gcc-msm8996", .data = (ulong)_clk_data, }, { } Reviewed-by: Neil Armstrong

Re: [PATCH v2 04/32] dt-bindings: drop msm_sdhci binding

2023-12-21 Thread Neil Armstrong
= <0x1>; - bus-width = <0x4>; - clock = < 1>; - clock-frequency = <2>; -}; Reviewed-by: Neil Armstrong

Re: [PATCH v2 02/32] usb: dwc3-generic: support external vbus regulator

2023-12-21 Thread Neil Armstrong
HC_LENGTH(xhci_readl(&(hccr)->cr_capbase))); @@ -256,6 +265,9 @@ static int dwc3_generic_host_remove(struct udevice *dev) if (rc) return rc; + if (priv->vbus_dev) + regulator_set_enable(priv->vbus_dev, false); + return dwc3_generic_remove(dev, >gen_priv); } Reviewed-by: Neil Armstrong

Re: [PATCH 0/2 v2] Provide a fallback to smbios tables

2023-12-21 Thread neil . armstrong
: Fallback to the default DT if sysinfo nodes are missing lib/smbios.c | 109 +++ 1 file changed, 92 insertions(+), 17 deletions(-) -- 2.40.1 I did it already offline, but: Reviewed-by: Neil Armstrong Tested-by: Neil Armstrong # on libretech

Re: [PATCH 7/8] dts: meson-gxbb: Switch to using upstream DT

2023-12-20 Thread neil . armstrong
c/meson-gxbb-wetek-play2.dtb + include $(srctree)/scripts/Makefile.dts targets += $(dtb-y) diff --git a/dts/arch/arm64/amlogic b/dts/arch/arm64/amlogic new file mode 12 index 000..73f7c3e7bd0 --- /dev/null +++ b/dts/arch/arm64/amlogic @@ -0,0 +1 @@ +../../../devicetree-rebasing/sr

[GIT PULL] Please pull u-boot-amlogic-next-20231220

2023-12-20 Thread Neil Armstrong
s up to 4d4fbf04158a5b2d4fff5a35ea0a2d6c18d250cb: ARM: dts: sync Amlogic GX DT to Linux v6.4 (2023-12-19 11:24:38 +0100) - Add support for new GXL MDIO mux, with driver and Linux DT sync from v6.4 ----

Re: [PATCH v2 0/2] ARM: meson: introduce GXL MDIO mux driver and switch to Linux v6.4 DT

2023-12-19 Thread Neil Armstrong
Hi, On Wed, 13 Dec 2023 10:30:11 +0100, Neil Armstrong wrote: > Linux v6.4 uses a new MDIO mux driver for GXL boards, let's port the driver > to U-Boot and sync the GXBB/GXL/GXM DT to make use of this driver. > > Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot

Re: [PATCH v2 02/17] video: dw_hdmi: Add Vendor PHY handling

2023-12-19 Thread Neil Armstrong
On 18/12/2023 20:10, Jagan Teki wrote: From: Jagan Teki DW HDMI support Vendor PHY like Rockchip RK3328 Inno HDMI PHY. Extend the vendor phy handling by adding platform phy hooks. Signed-off-by: Jagan Teki --- Changes for v2: - fix meson cfg drivers/video/dw_hdmi.c | 29

Re: [PATCH 2/2 v3] smbios: Fallback to the default DT if sysinfo nodes are missing

2023-12-18 Thread neil . armstrong
Hi, On 18/12/2023 16:01, Simon Glass wrote: Hi Neil, On Mon, 18 Dec 2023 at 02:54, wrote: On 17/12/2023 19:41, Tom Rini wrote: On Sat, Dec 16, 2023 at 11:46:18AM -0700, Simon Glass wrote: Hi Tom, On Thu, 14 Dec 2023 at 06:11, Tom Rini wrote: [..] And my point with the above is that

Re: [PATCH 2/2 v3] smbios: Fallback to the default DT if sysinfo nodes are missing

2023-12-18 Thread neil . armstrong
On 17/12/2023 19:41, Tom Rini wrote: On Sat, Dec 16, 2023 at 11:46:18AM -0700, Simon Glass wrote: Hi Tom, On Thu, 14 Dec 2023 at 06:11, Tom Rini wrote: On Wed, Dec 13, 2023 at 08:19:11PM -0700, Simon Glass wrote: [snip] The new DT nodes / SMBIOS binding [1] allows for the correct

[PATCH v3] clk: meson: add Hardware Clock measure driver

2023-12-18 Thread Neil Armstrong
n Anderson Signed-off-by: Neil Armstrong --- Changes in v3: - Fixed/extended Kconfig and commit message following Sean's advices - Link to v2: https://lore.kernel.org/r/20231212-uboot-meson-clk-msr-v2-1-1cd0addf4...@linaro.org Changes in v2: - remove common.h and include time.h instead - Link to

Re: [PATCH v2] clk: meson: add Hardware Clock measure driver

2023-12-18 Thread Neil Armstrong
Hi Sean, On 15/12/2023 18:52, Sean Anderson wrote: On 12/12/23 09:12, Neil Armstrong wrote: Amlogic SoCs embeds an hardware clock measure block, port it from Linux and implement it as a UCLK_CLK with only the dump op and fail-only xlate. Please include a short blurb describing the hardware

Re: [PATCH 0/8] An effort to bring DT bindings compliance within U-boot

2023-12-14 Thread neil . armstrong
On 14/12/2023 21:15, Tom Rini wrote: On Thu, Dec 14, 2023 at 01:48:42PM -0600, Rob Herring wrote: On Thu, Dec 14, 2023 at 12:23 PM Tom Rini wrote: On Thu, Dec 14, 2023 at 03:53:11PM +0100, neil.armstr...@linaro.org wrote: Hi, On 14/12/2023 14:50, Sumit Garg wrote: Prerquisite

Re: [PATCH 0/8] An effort to bring DT bindings compliance within U-boot

2023-12-14 Thread neil . armstrong
Hi, On 14/12/2023 14:50, Sumit Garg wrote: Prerquisite s/Prerquisite/Prerequisite/ --- This patch series requires devicetree-rebasing git repo to be added as a subtree to the main U-boot repo via: $ git subtree add --prefix devicetree-rebasing \

Re: [PATCH v12 00/24] Modernize U-Boot shell

2023-12-13 Thread neil . armstrong
pipermail/u-boot/2021-July/453848.html [5] https://lists.denx.de/pipermail/u-boot/2021-August/458569.html [6] https://lists.denx.de/pipermail/u-boot/2023-November/536768.html [7] https://lists.denx.de/pipermail/u-boot/2023-May/518140.html [8] https://lists.denx.de/pipermail/u-boot/2023-May/518147.html [9] https:/

[PATCH v2 2/2] ARM: dts: sync Amlogic GX DT to Linux v6.4

2023-12-13 Thread Neil Armstrong
Sync Amlogic GXBB, GXL & GXM DTs from Linux v6.4, and also switch to GXL MDIO MUX driver to adapt to DT change, Most of the changes are only cosmetic or doesn't concern U-Boot, the most important change for U-Boot is the GXL mdio mux compatible switch to amlogic,gxl-mdio-mux. Signed-off-by:

[PATCH v2 1/2] net: Add Amlogic GXL MDIO Mux driver

2023-12-13 Thread Neil Armstrong
Signed-off-by: Neil Armstrong --- drivers/net/Kconfig | 7 ++ drivers/net/Makefile | 1 + drivers/net/mdio_mux_meson_gxl.c | 138 +++ 3 files changed, 146 insertions(+) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index

[PATCH v2 0/2] ARM: meson: introduce GXL MDIO mux driver and switch to Linux v6.4 DT

2023-12-13 Thread Neil Armstrong
Linux v6.4 uses a new MDIO mux driver for GXL boards, let's port the driver to U-Boot and sync the GXBB/GXL/GXM DT to make use of this driver. Signed-off-by: Neil Armstrong --- Changes in v2: - Fixed copyright line in mdio mux driver - Link to v1: https://lore.kernel.org/r/20231212-u-boot-gxl

[PATCH v2] clk: meson: add Hardware Clock measure driver

2023-12-12 Thread Neil Armstrong
Amlogic SoCs embeds an hardware clock measure block, port it from Linux and implement it as a UCLK_CLK with only the dump op and fail-only xlate. Signed-off-by: Neil Armstrong --- Changes in v2: - remove common.h and include time.h instead - Link to v1: https://lore.kernel.org/r/20231113-uboot

Re: [PATCH v1] arm: dts: meson: add NAND controller node for AXG

2023-12-12 Thread Neil Armstrong
Hi, On 30/11/2023 13:27, Arseniy Krasnov wrote: Can you add a reference to the Linux patches that you submitted so we know it will be safe to sync the DT from Linux when they are merged ? Thanks, Neil Signed-off-by: Arseniy Krasnov --- arch/arm/dts/meson-axg.dtsi | 35

Re: [PATCH v7 0/8] clk: Switch from soc_clk_dump to clk_ops function

2023-12-12 Thread Neil Armstrong
Hi Igor, Sean, On 09/11/2023 11:55, Igor Prusov wrote: Currently clock providers may override default implementation of soc_clk_dump function to replace clk dump command output. This causes confusing behaviour when u-boot is built with one of such drivers enabled but still has clocks defined

[PATCH 2/2] ARM: dts: sync Amlogic GX DT to Linux v6.4

2023-12-12 Thread Neil Armstrong
Sync Amlogic GXBB, GXL & GXM DTs from Linux v6.4, and also switch to GXL MDIO MUX driver to adapt to DT change, Most of the changes are only cosmetic or doesn't concern U-Boot, the most important change for U-Boot is the GXL mdio mux compatible switch to amlogic,gxl-mdio-mux. Signed-off-by:

[PATCH 1/2] net: Add Amlogic GXL MDIO Mux driver

2023-12-12 Thread Neil Armstrong
Signed-off-by: Neil Armstrong --- drivers/net/Kconfig | 7 ++ drivers/net/Makefile | 1 + drivers/net/mdio_mux_meson_gxl.c | 138 +++ 3 files changed, 146 insertions(+) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index

<    1   2   3   4   5   6   7   8   9   10   >