Hi Marek,
On 18. 03. 24 22:48, Marek Vasut wrote:
> On 3/18/24 6:16 PM, Mathieu Othacehe wrote:
>> Enable both usbotg1 and usbotg2 ports.
>
> Drop fullstop from $subject end.
>
>> Signed-off-by: Mathieu Othacehe
>> ---
>> arch/arm/dts/imx93-phyboard-segin.dts | 13 +
>> 1 file
CONFIG_IMX_TMU=y
> +CONFIG_USB=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_GADGET=y
> +CONFIG_USB_GADGET_MANUFACTURER="FSL"
> +CONFIG_USB_GADGET_VENDOR_NUM=0x1fc9
> +CONFIG_USB_GADGET_PRODUCT_NUM=0x0152
> +CONFIG_CI_UDC=y
> CONF
Hi Mathieu,
Thanks for v4. I have no more remarks.
Also tested your v4 on the board.
Everything works, even eMMC booting which you were not able to test.
With that my Tested-by: can be applied.
Tested-by: Primoz Fiser
BR,
Primoz
On 30. 01. 24 15:50, Mathieu Othacehe wrote:
> Add init
Hi Mathieu,
On 30. 01. 24 14:37, Mathieu Othacehe wrote:
>
>> I am based on latest master 6faba41927bd (tag: v2024.04-rc1)
>
> That was it. I rebased from 043ca8c8a9b to 6faba41927bd and I now have
> the same behaviour as you. I cannot find which commit fixed the
> situation in that interval
Hi Mathieu,
On 30. 01. 24 13:49, Mathieu Othacehe wrote:
>
> Hey,
>
>> Can you re-check, please?
>>
>> Maybe check your include/generated/environment.h?
>
> Thanks for checking. It is strange that you do not reproduce that one.
>
> My include/generated/environment.h looks like:
>
>
is always returned from the function in such case.
Fix this by returning 0 (success) when FEC interface is primarily used
instead of EQOS interface on i.MX93.
Fixes: d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for
i.MX93")
Signed-off-by: Primoz Fiser
---
arch/arm/mach-
Hi Mathieu,
On 30. 01. 24 10:43, Mathieu Othacehe wrote:
>
> Hello,
>
>> Please remove findfdt script.
>>
>> Not needed when you set fdt_file to CONFIG_DEFAULT_FDT_FILE above.
>
> The reason I used findfdt is that CONFIG_DEFAULT_FDT_FILE is a string
> so, we end up with:
>
>
Hi Mathieu,
thanks for fixing my remarks.
Here are just a few left for v4.
On 25. 01. 24 17:45, Mathieu Othacehe wrote:
> Add initial support for the PHYTEC phyBOARD-Segin-i.MX93 board based on
> the PHYTEC phyCORE-i.MX93 SoM.
>
> Supported features:
> - 1GB LPDDR4 RAM
> - eMMC
> - external
Hi Mathieu,
First of all, thank you for the v2.
I was able quickly build & test on the actual board.
Here are my findings:
- FEC ethernet doesn't work
- distroboot doesn't work
Did you expirience the same?
Nonetheless, here are my comments for v2:
On 24. 01. 24 14:42, Mathieu Othacehe
Hi Mathieu,
I already gave my review on the kernel mailing list.
As first step, naming scheme is not compatible with PHYTEC naming
convention. Please fix it across the entire patch. Maybe reference
downstream u-boot for that?
Please also use "phyBOARD-Segin-i.MX93" when referencing the board as
,
Primoz
Primoz Fiser (1):
imx: imx9: fixup thermal trips from fuses
arch/arm/mach-imx/imx9/soc.c | 45
1 file changed, 45 insertions(+)
--
2.25.1
Read i.MX9 CPU temp grade from fuses and fixup thermal trips in Linux
device-tree accordingly.
Based on commit 0543a1ed2787 ("imx8m: fixup thermal trips")
Signed-off-by: Primoz Fiser
---
arch/arm/mach-imx/imx9/soc.c | 45
1 file changed, 45
12 matches
Mail list logo