[PATCH] clock: qcom: ipq4019: add I2C clocks

2024-05-28 Thread Robert Marko
I2C clocks are not initialized by the SBL, so lets add support for clocks required by both of the QUP I2C controllers. BLSP1 AHB clock is already initialized by SBL, but QUP I2C driver is requesting it so we have to add it to the enable list. Based off QCS404 clock driver. Signed-off-by: Robert

[PATCH v2 4/5] net: add Qualcomm ESS EDMA adapter

2024-05-23 Thread Robert Marko
This adds the driver for the ESS EDMA ethernet adapter found inside of Qualcomm IPQ40xx SoC series. This driver also integrates the built in modified QCA8337N switch support as they are tightly integrated. Co-Developed-by: Gabor Juhos Signed-off-by: Gabor Juhos Signed-off-by: Robert Marko

[PATCH v2 5/5] arm: dts: add IPQ4019 ESS EDMA U-Boot additions

2024-05-23 Thread Robert Marko
IPQ4019 ESS EDMA support is not yet in upstream Linux, so for now lets use the latest pending Linux DTS node for wired networking. Signed-off-by: Robert Marko --- Chanes in v2: * Use the latest pending Linux DT node for EDMA instead arch/arm/dts/qcom-ipq4019-u-boot.dtsi | 104

[PATCH v2 2/5] dt-bindings: clock: qcom: ipq4019: drop downstream file

2024-05-23 Thread Robert Marko
IPQ4019 clock dt-bindings are available in Linux upstream, and we can just use those instead of carrying a downstream file that matches the upstream one anyway. Signed-off-by: Robert Marko --- Changes in v2: * Drop the downstream dt-bindings header as it matches the upstream Linux one include

[PATCH v2 3/5] clock: qcom: ipq4019: add missing networking resets

2024-05-23 Thread Robert Marko
IPQ4019 has more networking related resets that will be required for future wired networking support, so lets add them. This syncs the driver with Linux. Signed-off-by: Robert Marko Reviewed-by: Caleb Connolly --- drivers/clk/qcom/clock-ipq4019.c | 6 ++ 1 file changed, 6 insertions

[PATCH v2 1/5] clock: qcom: ipq4019: add ESS clock

2024-05-23 Thread Robert Marko
ESS clock is the Ethernet Subsystem clock, so lets add it as its already configured by SBL1. Signed-off-by: Robert Marko Reviewed-by: Caleb Connolly --- drivers/clk/qcom/clock-ipq4019.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/qcom/clock-ipq4019.c b/drivers/clk/qcom

Re: [PATCH 5/5] arm: dts: add IPQ4019 ESS EDMA U-Boot additions

2024-05-22 Thread Robert Marko
On Wed, May 22, 2024 at 6:21 PM Caleb Connolly wrote: > > Hi Robert, > > Thanks for the patches. > > On 22/05/2024 12:13, Robert Marko wrote: > > IPQ4019 ESS EDMA support is not yet in upstream Linux, and even when > > eventually it is merged the node will not be

Re: [PATCH 2/5] dt-bindings: clock: qcom: ipq4019: add missing networking resets

2024-05-22 Thread Robert Marko
On Wed, May 22, 2024 at 6:22 PM Caleb Connolly wrote: > > Hi Robert, > > On 22/05/2024 12:13, Robert Marko wrote: > > Add bindings for the missing networking resets found in IPQ4019 GCC. > > This syncs the bindigs with Linux. > > These bindings are already syn

[PATCH 5/5] arm: dts: add IPQ4019 ESS EDMA U-Boot additions

2024-05-22 Thread Robert Marko
IPQ4019 ESS EDMA support is not yet in upstream Linux, and even when eventually it is merged the node will not be compatible with U-Boot driver as the Linux driver properly models the internal switch. So, lets add the U-Boot additions DTSI for ESS EDMA for now. Signed-off-by: Robert Marko

[PATCH 4/5] net: add Qualcomm ESS EDMA adapter

2024-05-22 Thread Robert Marko
This adds the driver for the ESS EDMA ethernet adapter found inside of Qualcomm IPQ40xx SoC series. This driver also integrates the built in modified QCA8337N switch support as they are tightly integrated. Co-Developed-by: Gabor Juhos Signed-off-by: Gabor Juhos Signed-off-by: Robert Marko

[PATCH 3/5] clock: qcom: ipq4019: add missing networking resets

2024-05-22 Thread Robert Marko
IPQ4019 has more networking related resets that will be required for future wired networking support, so lets add them. This syncs the driver with Linux. Signed-off-by: Robert Marko --- drivers/clk/qcom/clock-ipq4019.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/qcom

[PATCH 2/5] dt-bindings: clock: qcom: ipq4019: add missing networking resets

2024-05-22 Thread Robert Marko
Add bindings for the missing networking resets found in IPQ4019 GCC. This syncs the bindigs with Linux. Signed-off-by: Robert Marko --- include/dt-bindings/clock/qcom,gcc-ipq4019.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/dt-bindings/clock/qcom,gcc-ipq4019.h b/include

[PATCH 1/5] clock: qcom: ipq4019: add ESS clock

2024-05-22 Thread Robert Marko
ESS clock is the Ethernet Subsystem clock, so lets add it as its already configured by SBL1. Signed-off-by: Robert Marko --- drivers/clk/qcom/clock-ipq4019.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/qcom/clock-ipq4019.c b/drivers/clk/qcom/clock-ipq4019.c index

[PATCH 2/2] net: phy: add Qualcomm QCA807x driver

2024-05-22 Thread Robert Marko
-by: Robert Marko --- drivers/net/phy/Kconfig | 6 ++ drivers/net/phy/Makefile | 1 + drivers/net/phy/qca807x.c | 211 ++ 3 files changed, 218 insertions(+) create mode 100644 drivers/net/phy/qca807x.c diff --git a/drivers/net/phy/Kconfig b/drivers/net

[PATCH 1/2] net: phy: add PSGMII (Penta SGMII) mode

2024-05-22 Thread Robert Marko
. It is commonly used by Qualcomm with their QCA807x PHY series and modern WiSoC-s. Add definitions for the PHY layer to allow to express this type of connection between the MAC and PHY. This is basically a direct port from Linux which already supports this mode. Signed-off-by: Robert Marko --- include

[PATCH v2 3/3] arm: dts: drop downstream IPQ4019 DTSI

2024-05-14 Thread Robert Marko
We want to use OF_UPSTREAM on IPQ40XX as its well supported upstream, so lets drop our downstream DTSI. Signed-off-by: Robert Marko Acked-by: Caleb Connolly --- arch/arm/dts/qcom-ipq4019.dtsi | 202 - 1 file changed, 202 deletions(-) delete mode 100644 arch/arm

[PATCH v2 1/3] mach-ipq40xx: add CPU specific code

2024-05-14 Thread Robert Marko
Provide basic DRAM info population from DT, cache setting and the board_init stub. Signed-off-by: Robert Marko Acked-by: Caleb Connolly --- Changes in v2: * Drop arch/arm/mach-ipq40xx/Makefile | 7 ++ arch/arm/mach-ipq40xx/cpu.c| 43 ++ 2 files

[PATCH v2 2/3] mach-ipq40xx: use OF_UPSTREAM

2024-05-14 Thread Robert Marko
Now that drivers are compatible enough with the upstream DTS, there is no reason to not use the upstream DTS, so imply OF_UPSTREAM by default. Signed-off-by: Robert Marko Acked-by: Caleb Connolly --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/Kconfig b/arch

[PATCH v3] sysreset: add Qualcomm PSHOLD reset driver

2024-05-14 Thread Robert Marko
b/drivers/sysreset/sysreset_qcom-pshold.c new file mode 100644 index 00..4529047853 --- /dev/null +++ b/drivers/sysreset/sysreset_qcom-pshold.c @@ -0,0 +1,55 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Qualcomm PSHOLD reset driver + * + * Copyright (c) 2024 Sartura Ltd. + * + * Author: Ro

[RFC PATCH 5/5] sysreset: call .on_reset for UCLASS_SPI_FLASH before reset request

2024-05-07 Thread Robert Marko
that this does not fix a case where you remove the power while U-Boot is still running and in that case it will still be stuck in 4-byte mode. Signed-off-by: Robert Marko --- drivers/sysreset/sysreset-uclass.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/sysreset/sysreset

[RFC PATCH 4/5] mtd: spi: sf: implement .on_reset method

2024-05-07 Thread Robert Marko
to be in 3-byte adressing mode and will just hang otherwise. Note that this does not fix a case where you remove the power while U-Boot is still running and in that case it will still be stuck in 4-byte mode. Signed-off-by: Robert Marko --- drivers/mtd/spi/sf_probe.c | 10 ++ 1 file changed, 10

[RFC PATCH 3/5] mtd: spi-nor: rename and export 4-byte adressing mode function

2024-05-07 Thread Robert Marko
Currently 4-byte adressing mode function is not exported, but since we plan to use it outside of the SPI NOR core we need to export it. While we are here, rename it to align the naming with the rest of exported functions. Signed-off-by: Robert Marko --- drivers/mtd/spi/spi-nor-core.c | 7

[RFC PATCH 1/5] dm: core: add on_reset method

2024-05-07 Thread Robert Marko
Currently, we dont have a specific method that is intented to be called right before calling board reset. Intention for this method is to be able to exit 4-byte adressing mode on SPI-NOR devices before reset. Signed-off-by: Robert Marko --- include/dm/device.h | 2 ++ 1 file changed, 2

[RFC PATCH 2/5] dm: core: introduce uclass_id_on_reset()

2024-05-07 Thread Robert Marko
Implement a helper to call .on_reset method for every device in a certain uclass. Intention is to use this helper for UCLASS_SPI_FLASH before board reset to exit 4-byte adressing mode. Signed-off-by: Robert Marko --- drivers/core/uclass.c | 13 + include/dm/uclass.h | 8

[RFC PATCH 0/5] Implement exiting 4-byte adressing mode before reset

2024-05-07 Thread Robert Marko
is still running and in that case it will still be stuck in 4-byte mode. Robert Marko (5): dm: core: add on_reset method dm: core: introduce uclass_id_on_reset() mtd: spi-nor: rename and export 4-byte adressing mode function mtd: spi: sf: implement .on_reset method sysreset: call .on_reset

Re: [PATCH 0/2] qcom: ehci: enable core + iface clocks

2024-05-02 Thread Robert Marko
drivers/usb/host/ehci-msm.c | 37 > > +++-- > > 2 files changed, 66 insertions(+), 2 deletions(-) > > --- > > base-commit: ff0de1f0557ed7d2dab47ba976a37347a1fdc432 > > change-id: 20240502-msm8916-hs-usb-clocks-34bc22b03f3d > >

[PATCH 2/2] mtd: spi-nor-core: add 4-byte OPCODE support for Winbond W25Q256JV

2024-04-25 Thread Robert Marko
pport for w25q256"). Signed-off-by: Robert Marko --- drivers/mtd/spi/spi-nor-core.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c index 7615ba602f..8882b045ce 100644 --- a/drivers/mtd/spi/spi-

[PATCH 1/2] mtd: spi-nor-core: allow overriding 4-byte OPCODE support

2024-04-25 Thread Robert Marko
with the same JEDEC ID by differences in SFDP tables, so in order to be able to apply a fixup after they are parsed lets add a feature flag that we can override. Signed-off-by: Robert Marko --- drivers/mtd/spi/spi-nor-core.c | 6 -- include/linux/mtd/spi-nor.h| 1 + 2 files changed, 5 insertions

[PATCH v2] sysreset: add Qualcomm PSHOLD reset driver

2024-04-24 Thread Robert Marko
reset_qcom-pshold.c new file mode 100644 index 00..25231cf5e2 --- /dev/null +++ b/drivers/sysreset/sysreset_qcom-pshold.c @@ -0,0 +1,56 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Qualcomm PSHOLD reset driver + * + * Copyright (c) 2024 Sartura Ltd. + * + * Author: Robert Marko + * Based on

[PATCH 3/3] arm: dts: drop downstream IPQ4019 DTSI

2024-04-24 Thread Robert Marko
We want to use OF_UPSTREAM on IPQ40XX as its well supported upstream, so lets drop our downstream DTSI. Signed-off-by: Robert Marko --- arch/arm/dts/qcom-ipq4019.dtsi | 202 - 1 file changed, 202 deletions(-) delete mode 100644 arch/arm/dts/qcom-ipq4019.dtsi

[PATCH 2/3] mach-ipq40xx: use OF_UPSTREAM

2024-04-24 Thread Robert Marko
Now that drivers are compatible enough with the upstream DTS, there is no reason to not use the upstream DTS, so imply OF_UPSTREAM by default. Signed-off-by: Robert Marko --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index

[PATCH 1/3] mach-ipq40xx: add CPU specific code

2024-04-24 Thread Robert Marko
Provide basic DRAM info population from DT, cache setting and the board_init stub. Signed-off-by: Robert Marko --- arch/arm/mach-ipq40xx/Makefile | 7 ++ arch/arm/mach-ipq40xx/cpu.c| 44 ++ 2 files changed, 51 insertions(+) create mode 100644 arch/arm

[PATCH 4/4] MAINTAINERS: IPQ40XX: add pinctrl driver

2024-04-24 Thread Robert Marko
Pinctrl drivers were moved to a dedicated directory but the entry was never updated, so add the pinctrl-ipq4019 driver entry. Signed-off-by: Robert Marko --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 207c8b763f..382376b8e3 100644

[PATCH 3/4] MAINTAINERS: IPQ40XX: add clock-ipq4019 instead of reset driver

2024-04-24 Thread Robert Marko
The reset handling was added to the clock drivers but the entry was never updated, so add the clock-ipq4019 driver instead. Signed-off-by: Robert Marko --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index fdce7c8334..207c8b763f

[PATCH 2/4] MAINTAINERS: IPQ40XX: update GCC dt-bindings

2024-04-24 Thread Robert Marko
The separate clock and reset dt-bindings for IPQ40XX were merged into one recently, but the entry was not updated so do it now. Signed-off-by: Robert Marko --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8691500d28

[PATCH 1/4] MAINTAINERS: IPQ40XX: remove Luka Kovacic as maintainer

2024-04-24 Thread Robert Marko
Luka Kovacic is no longer at Sartura, so remove him as one of IPQ40xx maintainers. Signed-off-by: Robert Marko --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d0a4a28b40..8691500d28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -334,7 +334,6

[PATCH] sysreset: add Qualcomm PSHOLD reset driver

2024-04-23 Thread Robert Marko
b/drivers/sysreset/sysreset_msm-pshold.c @@ -0,0 +1,56 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Qualcomm PSHOLD reset driver + * + * Copyright (c) 2024 Sartura Ltd. + * + * Author: Robert Marko + * Based on the Linux msm-poweroff driver. + * + */ + +#include +#include +#include +#include

[PATCH] .gitignore: add LTO generated file

2024-04-23 Thread Robert Marko
Currently, keep-syms-lto.c is being generated if LTO is enabled but unlike keep-syms-lto.o it is not being ignored, so lets add keep-syms-lto.* to .gitignore. Signed-off-by: Robert Marko --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index be137040a2

[PATCH v2 5/5] pinctrl: qcom: ipq4019: support all pin functions

2024-04-22 Thread Robert Marko
SM8150 U-Boot pinctrl driver which also uses different function numbers pased on the exact pin number. Signed-off-by: Robert Marko --- drivers/pinctrl/qcom/pinctrl-ipq4019.c | 306 +++-- 1 file changed, 293 insertions(+), 13 deletions(-) diff --git a/drivers/pinctrl/qcom

[PATCH v2 4/5] pinctrl: qcom: ipq4019: enable DM_FLAG_PRE_RELOC

2024-04-22 Thread Robert Marko
as pinctrl provider is not available. So, lets enable DM_FLAG_PRE_RELOC for IPQ4019 pinctrl to fix this. Signed-off-by: Robert Marko --- drivers/pinctrl/qcom/pinctrl-ipq4019.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/qcom/pinctrl-ipq4019.c b/drivers/pinctrl/qcom

[PATCH v2 3/5] pinctrl: qcom: ipq4019: adapt pin name lookup to upstream DTS

2024-04-22 Thread Robert Marko
We want to use OF_UPSTREAM on IPQ40XX as its well supported upstream, so as a preparation update pinctrl driver to look for the upstream pin format. Signed-off-by: Robert Marko Reviewed-by: Caleb Connolly --- drivers/pinctrl/qcom/pinctrl-ipq4019.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 2/5] mach-ipq40xx: import GPIO header from mach-snapgradon

2024-04-22 Thread Robert Marko
Pinctrl driver was refactored and moved, but the required header that it depends on was not included. Fixes: 24d2908e987a ("pinctrl: qcom: move ipq4019 driver from mach-ipq40xx") Signed-off-by: Robert Marko --- arch/arm/mach-ipq40xx/include/mach/gpio.h | 37 +++--

[PATCH v2 1/5] pinctrl: qcom: allow selecting with ARCH_IPQ40XX

2024-04-22 Thread Robert Marko
Signed-off-by: Robert Marko Reviewed-by: Caleb Connolly --- drivers/pinctrl/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig index 2fe6398147..bd2019c866 100644 --- a/drivers/pinctrl/qcom/Kconfig +++ b/drivers/pi

Re: [PATCH 2/3] mach-ipq40xx: import GPIO header from mach-snapgradon

2024-04-19 Thread Robert Marko
On Thu, Apr 18, 2024 at 1:02 PM Caleb Connolly wrote: > > Hi Robert, > > On 18/04/2024 10:14, Robert Marko wrote: > > Pinctrl driver was refactored and moved, but the required header that > > it depends on was not included. > > Thanks for these patches! > >

[PATCH] arm: mach-ipq40xx: dont select SMEM by default

2024-04-18 Thread Robert Marko
IPQ40xx SoC-s dont have proper SMEM support like more modern Qualcomm SoC-s so there is no point in selecting the required drivers. Signed-off-by: Robert Marko --- arch/arm/Kconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 23ee25269a

[PATCH 3/3] pinctrl: qcom: ipq4019: adapt pin name lookup to upstream DTS

2024-04-18 Thread Robert Marko
We want to use OF_UPSTREAM on IPQ40XX as its well supported upstream, so as a preparation update pinctrl driver to look for the upstream pin format. Signed-off-by: Robert Marko --- drivers/pinctrl/qcom/pinctrl-ipq4019.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 2/3] mach-ipq40xx: import GPIO header from mach-snapgradon

2024-04-18 Thread Robert Marko
Pinctrl driver was refactored and moved, but the required header that it depends on was not included. Fixes: 24d2908e987a ("pinctrl: qcom: move ipq4019 driver from mach-ipq40xx") Signed-off-by: Robert Marko --- arch/arm/mach-ipq40xx/include/mach/gpio.h | 37 +++--

[PATCH 1/3] pinctrl: qcom: allow selecting with ARCH_IPQ40XX

2024-04-18 Thread Robert Marko
Signed-off-by: Robert Marko --- drivers/pinctrl/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig index 2fe6398147..bd2019c866 100644 --- a/drivers/pinctrl/qcom/Kconfig +++ b/drivers/pinctrl/qcom/Kconfig @@

Re: [PATCH 1/3] serial: allow selecting MSM debug UART with ARCH_IPQ40XX

2024-04-15 Thread Robert Marko
ager to learn more!). Well, IPQ40xx is quite a popular WiSoC family and its cheap but the stock bootloader limits any kind of custom use case, so here we are. Regards, Robert > > On 15/04/2024 11:49, Robert Marko wrote: > > Currently, DEBUG_UART_MSM depends on ARCH_SNAPDRAGON only, bu

Re: [PATCH 3/3] serial: msm: calculate bit clock divider

2024-04-15 Thread Robert Marko
On Mon, Apr 15, 2024 at 4:18 PM Caleb Connolly wrote: > > > > On 15/04/2024 14:05, Robert Marko wrote: > > On Mon, Apr 15, 2024 at 2:44 PM Caleb Connolly > > wrote: > >> > >> The driver currently requires the bit clock divider be hardcoded in > >

Re: [PATCH 3/3] serial: msm: calculate bit clock divider

2024-04-15 Thread Robert Marko
l DM UART, but debug UART prints junk since .clk_rate = 7372800 is not correct for IPQ40xx. I would suggest using .clk_rate = CONFIG_VAL(DEBUG_UART_CLOCK) instead to populate the value per board, this also avoids per ARCH ifdefs. Regards, Robert > --- > Cc: Robert Marko > --- > doc/device-

[PATCH v2] usb: dwc3-generic: fix support without DM_REGULATOR

2024-04-15 Thread Robert Marko
dwc3_generic_host_probe() return the same error thus breaking probe. So, check whether return code is -ENOSYS before erroring out. Fixes: de451d5d5b6f ("usb: dwc3-generic: support external vbus regulator") Signed-off-by: Robert Marko --- Changes in v2: * Drop #ifdefs and check f

Re: [PATCH 3/3] serial: msm_serial: set .clk_bit_rate in debug UART

2024-04-15 Thread Robert Marko
On Mon, Apr 15, 2024 at 1:46 PM Caleb Connolly wrote: > > > > On 15/04/2024 11:49, Robert Marko wrote: > > Currently, .clk_bit_rate is not being set in init_serial_data for debug > > UART, but its then used uart_dm_init() and this breaks debug UART on > > IPQ4

Re: [PATCH] usb: dwc3-generic: fix support without DM_REGULATOR

2024-04-15 Thread Robert Marko
On Mon, Apr 15, 2024 at 12:57 PM Caleb Connolly wrote: > > > > On 15/04/2024 11:53, Robert Marko wrote: > > Recent addition of vbus-supply support has broke platform which dont use > > controllable regulators for USB. > > > > Issue is that even withou DM_REGUL

[PATCH] usb: dwc3-generic: fix support without DM_REGULATOR

2024-04-15 Thread Robert Marko
dwc3_generic_host_probe() return the same error thus breaking probe. Fixes: de451d5d5b6f ("usb: dwc3-generic: support external vbus regulator") Signed-off-by: Robert Marko --- drivers/usb/dwc3/dwc3-generic.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/dwc3/dwc3

[PATCH 3/3] serial: msm_serial: set .clk_bit_rate in debug UART

2024-04-15 Thread Robert Marko
default to the same value that regular DM UART will use. Signed-off-by: Robert Marko --- drivers/serial/serial_msm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c index 8044d38518..80069f5cfb 100644 --- a/drivers/serial

[PATCH 2/3] serial: msm_serial: remove .clk_rate from debug UART

2024-04-15 Thread Robert Marko
MSM serial in DEBUG UART mode is trying to set .clk_rate, but the msm_serial_data structure does not have such property at all, so lets remove it as otherwise it will fail compiling. Fixes: 90023bdfe979 ("serial: msm: add debug UART") Signed-off-by: Robert Marko --- drivers/serial/se

[PATCH 1/3] serial: allow selecting MSM debug UART with ARCH_IPQ40XX

2024-04-15 Thread Robert Marko
Currently, DEBUG_UART_MSM depends on ARCH_SNAPDRAGON only, but IPQ40XX devices also use the same UART HW so they can also use the debug UART. So, allow selecting DEBUG_UART_MSM when using ARCH_IPQ40XX as well. Signed-off-by: Robert Marko --- drivers/serial/Kconfig | 2 +- 1 file changed, 1

Re: [PATCH v3 1/3] arm: mvebu: Espressobin: move FDT fixup into a separate function

2024-01-10 Thread Robert Marko
On Tue, Jan 9, 2024 at 4:34 PM Stefan Roese wrote: > > Hi Robert, > > On 1/9/24 14:16, Robert Marko wrote: > > On Wed, Nov 29, 2023 at 11:11 AM Robert Marko > > wrote: > >> > >> Currently, Esspresobin FDT is being fixed up directly in ft_board_setup

Re: [PATCH v3 1/3] arm: mvebu: Espressobin: move FDT fixup into a separate function

2024-01-09 Thread Robert Marko
On Wed, Nov 29, 2023 at 11:11 AM Robert Marko wrote: > > Currently, Esspresobin FDT is being fixed up directly in ft_board_setup() > which makes it hard to add support for any other board to be fixed up. > > So, lets just move the FDT fixup code to a separate function and call it

[PATCH v3 3/3] arm: mvebu: eDPU: support new board revision

2023-11-29 Thread Robert Marko
. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese --- Changes in v3: * Add check for DM_MDIO arch/arm/dts/armada-3720-eDPU-u-boot.dtsi | 13 ++- arch/arm/dts/armada-3720-eDPU.dts | 47 board/Marvell/mvebu_armada-37xx/board.c | 128 ++ configs

[PATCH v3 2/3] arm: mvebu: Espressobin: move network setup into a separate function

2023-11-29 Thread Robert Marko
-by: Robert Marko Reviewed-by: Stefan Roese --- Changes in v2: * Rebase on top of current master and resolve conflicts board/Marvell/mvebu_armada-37xx/board.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell

[PATCH v3 1/3] arm: mvebu: Espressobin: move FDT fixup into a separate function

2023-11-29 Thread Robert Marko
-by: Robert Marko Reviewed-by: Stefan Roese --- board/Marvell/mvebu_armada-37xx/board.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c index 04124d8014..1471caa9a6 100644 --- a/board

Re: [PATCH v2 1/3] arm: mvebu: Espressobin: move FDT fixup into a separate function

2023-11-29 Thread Robert Marko
On Tue, Nov 28, 2023 at 4:49 PM Stefan Roese wrote: > > Hi Robert, > > On 11/28/23 16:44, Stefan Roese wrote: > > Hi Robert, > > > > On 11/28/23 11:19, Robert Marko wrote: > >> On Fri, Oct 20, 2023 at 12:21 PM Robert Marko > >> wrote: > >

Re: [PATCH v2 1/3] arm: mvebu: Espressobin: move FDT fixup into a separate function

2023-11-28 Thread Robert Marko
On Fri, Oct 20, 2023 at 12:21 PM Robert Marko wrote: > > Currently, Esspresobin FDT is being fixed up directly in ft_board_setup() > which makes it hard to add support for any other board to be fixed up. > > So, lets just move the FDT fixup code to a separate function and call it

Re: [PATCH 2/3] arm: mvebu: Espressobin: move network setup into a separate function

2023-10-20 Thread Robert Marko
On Fri, Oct 20, 2023 at 8:46 AM Stefan Roese wrote: > > Hi Robert, > > On 9/18/23 08:47, Stefan Roese wrote: > > On 9/14/23 12:16, Robert Marko wrote: > >> Currently, Esspresobin switch is being setup directly in > >> last_stage_init() > >> which mak

[PATCH v2 3/3] arm: mvebu: eDPU: support new board revision

2023-10-20 Thread Robert Marko
. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese --- arch/arm/dts/armada-3720-eDPU-u-boot.dtsi | 13 ++- arch/arm/dts/armada-3720-eDPU.dts | 47 board/Marvell/mvebu_armada-37xx/board.c | 125 ++ configs/eDPU_defconfig| 1 + 4 files

[PATCH v2 2/3] arm: mvebu: Espressobin: move network setup into a separate function

2023-10-20 Thread Robert Marko
-by: Robert Marko Reviewed-by: Stefan Roese --- Changes in v2: * Rebase on top of current master and resolve conflicts board/Marvell/mvebu_armada-37xx/board.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell

[PATCH v2 1/3] arm: mvebu: Espressobin: move FDT fixup into a separate function

2023-10-20 Thread Robert Marko
-by: Robert Marko Reviewed-by: Stefan Roese --- board/Marvell/mvebu_armada-37xx/board.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c index 04124d8014..1471caa9a6 100644 --- a/board

Re: [PATCH] kbuild: use which $(DTC) as a dependency

2023-10-17 Thread Robert Marko
On 17. 10. 2023. 12:44, Richard Marko wrote: If we try to build using external dtc using make DTC=dtc we get a confusing error like make[2]: *** No rule to make target 'arch/x86/dts/bayleybay.dtb', needed by 'dtbs'. Stop. Workaround is to use make DTC=$( which dtc ) Can you please

[PATCH 3/3] arm: mvebu: eDPU: support new board revision

2023-09-14 Thread Robert Marko
. Signed-off-by: Robert Marko --- arch/arm/dts/armada-3720-eDPU-u-boot.dtsi | 13 ++- arch/arm/dts/armada-3720-eDPU.dts | 47 board/Marvell/mvebu_armada-37xx/board.c | 125 ++ configs/eDPU_defconfig| 2 + 4 files changed, 182 insertions(+), 5

[PATCH 2/3] arm: mvebu: Espressobin: move network setup into a separate function

2023-09-14 Thread Robert Marko
-by: Robert Marko --- board/Marvell/mvebu_armada-37xx/board.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c index da325e8c75..6527155c6e 100644 --- a/board/Marvell/mvebu_armada-37xx

[PATCH 1/3] arm: mvebu: Espressobin: move FDT fixup into a separate function

2023-09-14 Thread Robert Marko
-by: Robert Marko --- board/Marvell/mvebu_armada-37xx/board.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c index 3ab6e8873d..da325e8c75 100644 --- a/board/Marvell/mvebu_armada-37xx

[PATCH 2/2] net: mv88e6xxx: add Clause 45 support

2023-08-08 Thread Robert Marko
and being able to actually read the register. Signed-off-by: Robert Marko --- drivers/net/mv88e6xxx.c | 69 +++-- 1 file changed, 67 insertions(+), 2 deletions(-) diff --git a/drivers/net/mv88e6xxx.c b/drivers/net/mv88e6xxx.c index deb72772d19..b9ee093c3af 100644

[PATCH 1/2] net: mv88e6xxx: use generic bitfield macros for MDIO

2023-08-08 Thread Robert Marko
Driver is currently defining the mask and bit shifting itself, there is no need for that as U-Boot has generic bitfield macros that help us achieve the same result but in a cleaner way. Signed-off-by: Robert Marko --- drivers/net/mv88e6xxx.c | 25 + 1 file changed, 13

Re: [PATCH] arm64: a37xx: pinctrl: probe after binding

2023-02-13 Thread Robert Marko
On Mon, Feb 13, 2023 at 12:36 AM Simon Glass wrote: > > Hi, > > On Thu, 19 Jan 2023 at 00:00, Stefan Roese wrote: > > > > On 1/17/23 15:08, Robert Marko wrote: > > > Currently, pinctrl drivers are getting probed during post-bind, however > > > that is b

[PATCH] arm64: a37xx: pinctrl: probe after binding

2023-01-17 Thread Robert Marko
to always get registered. Signed-off-by: Robert Marko --- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 25fbe39abd1..1be6252227d 100644

Re: [PATCH] dm: pinctrl: Revert "pinctrl: probe pinctrl drivers during post-bind"

2023-01-17 Thread Robert Marko
On Fri, Jan 13, 2023 at 12:43 AM Simon Glass wrote: > > Hi, > > On Tue, 3 Jan 2023 at 10:05, Simon Glass wrote: > > > > Hi Robert, > > > > On Fri, 30 Dec 2022 at 13:26, Robert Marko wrote: > > > > > > > > > > > > O

Re: [PATCH] dm: pinctrl: Revert "pinctrl: probe pinctrl drivers during post-bind"

2022-12-30 Thread Robert Marko
gt; > > > > Simon > > > > > > > > Seems that it is not such simple. armada_37xx_gpiochip_register() > > > > depends on initialized and bound pinctrl part of driver. So before > > > > binding gpio you need to bind pinctrl as they share internal >

Re: [PATCH v2 2/2] ipq40xx/snapdragon: Merge the two, more than 90% overlapping Qualcomm's Snapdrgon based arches, into one: "mach-snapdragon".

2022-11-08 Thread Robert Marko
dev/null > @@ -1,15 +0,0 @@ > -if ARCH_IPQ40XX > - > -config SYS_SOC > - default "ipq40xx" > - > -config SYS_MALLOC_F_LEN > - default 0x2000 > - > -config TEXT_BASE > - default 0x8730 > - > -config NR_DRAM_BANKS > - default

Re: [PATCH 1/2] mach-snapdragon/mach-ipq40xx: fix, merge and refactoring

2022-11-08 Thread Robert Marko
On Tue, Nov 8, 2022 at 4:20 PM Tom Rini wrote: > > On Sun, Nov 06, 2022 at 02:52:56AM +0100, Andrey VOLKOV wrote: > > Hi Robert, Tom, > > > > Updated patches are following, could you review/accept them? > > > > Le 04/11/2022 à 12:05, Robert Marko a écrit : &

Re: [PATCH 1/2] mach-snapdragon/mach-ipq40xx: fix, merge and refactoring

2022-11-04 Thread Robert Marko
; > > -U_BOOT_DRIVER(pinctrl_snapdraon) = { > +U_BOOT_DRIVER(pinctrl_snapdragon) = { > .name= "pinctrl_msm", > .id= UCLASS_PINCTRL, > .of_match= msm_pinctrl_ids, > diff --git a/drivers/reset/reset-qcom.c b/drivers/reset/reset-qcom.

Re: Unable to boot sandbox64 with test dtb

2022-10-18 Thread Robert Marko
Thanks. I see that you already sent a patch, so I won't repeat myself. Is sandbox64 not covered by tests? Regards, Robert > > > -sughosh > -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 1 Zagreb, Croatia Email: <http://goog_1951392730>robert.ma...@sartura.hr Web: www.sartura.hr

Re: [PATCH] thermal: sandbox: Don't build sandbox thermal driver for sandbox64

2022-10-18 Thread Robert Marko
64),) > obj-$(CONFIG_SANDBOX) += thermal_sandbox.o > +endif > obj-$(CONFIG_IMX_THERMAL) += imx_thermal.o > obj-$(CONFIG_IMX_SCU_THERMAL) += imx_scu_thermal.o > obj-$(CONFIG_TI_DRA7_THERMAL) += ti-bandgap.o > -- > 2.34.1 > > -- Robert Marko Staff Embed

[PATCH] smem: msm: add missing

2022-10-07 Thread Robert Marko
mem->regions[0].size - SZ_4K; Signed-off-by: Robert Marko Cc: luka.per...@sartura.hr --- drivers/smem/msm_smem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/smem/msm_smem.c b/drivers/smem/msm_smem.c index 6395b61b0d..17ee6c837c 100644 --- a/drivers/smem/msm_smem.c +++ b/driver

Re: [PATCH v2 4/4] test: cmd: add test for temperature command

2022-09-07 Thread Robert Marko
On Tue, Sep 6, 2022 at 11:18 PM Simon Glass wrote: > > Hi Robert, > H > On Tue, 6 Sept 2022 at 04:50, Robert Marko wrote: > > > > On Sat, Sep 3, 2022 at 3:54 AM Tom Rini wrote: > > > > > > On Fri, Aug 12, 2022 at 08:15:50PM +0200, Robert

[PATCH v3 4/4] test: cmd: add test for temperature command

2022-09-06 Thread Robert Marko
Add simple test for the temperature command. Signed-off-by: Robert Marko Reviewed-by: Simon Glass --- test/cmd/Makefile | 1 + test/cmd/temperature.c | 39 +++ 2 files changed, 40 insertions(+) create mode 100644 test/cmd/temperature.c diff --git

[PATCH v3 3/4] thermal: add sandbox driver

2022-09-06 Thread Robert Marko
Provide a simple sandbox driver for the thermal uclass. It simply registers and returns 100 degrees C if requested. Signed-off-by: Robert Marko Reviewed-by: Simon Glass --- Changes in v3: * Enable thermal class and temperature command in Sandbox SPL, flattree and noinstall defconfigs as well

[PATCH v3 2/4] doc: cmd: temperature: add documentation

2022-09-06 Thread Robert Marko
Add documentation for the temperature command. Signed-off-by: Robert Marko Reviewed-by: Simon Glass --- doc/usage/cmd/temperature.rst | 50 +++ doc/usage/index.rst | 1 + 2 files changed, 51 insertions(+) create mode 100644 doc/usage/cmd

[PATCH v3 1/4] cmd: add temperature command

2022-09-06 Thread Robert Marko
ivers seem to return. Signed-off-by: Robert Marko Reviewed-by: Simon Glass --- Changes in v2: * Drop by using uclass_get_device_by_name() * Make the unit clear in help * Expand Kconfig boolean and help * Drop degree symbol as test doesnt work with it. --- cmd/Kconfig | 6 cmd/Makefile

[PATCH v3 4/4] test: cmd: add test for temperature command

2022-09-06 Thread Robert Marko
Add simple test for the temperature command. Signed-off-by: Robert Marko Reviewed-by: Simon Glass --- test/cmd/Makefile | 1 + test/cmd/temperature.c | 39 +++ 2 files changed, 40 insertions(+) create mode 100644 test/cmd/temperature.c diff --git

[PATCH v3 3/4] thermal: add sandbox driver

2022-09-06 Thread Robert Marko
Provide a simple sandbox driver for the thermal uclass. It simply registers and returns 100 degrees C if requested. Signed-off-by: Robert Marko Reviewed-by: Simon Glass --- Changes in v3: * Enable thermal class and temperature command in Sandbox SPL, flattree and noinstall defconfigs as well

[PATCH v3 2/4] doc: cmd: temperature: add documentation

2022-09-06 Thread Robert Marko
Add documentation for the temperature command. Signed-off-by: Robert Marko Reviewed-by: Simon Glass --- doc/usage/cmd/temperature.rst | 50 +++ doc/usage/index.rst | 1 + 2 files changed, 51 insertions(+) create mode 100644 doc/usage/cmd

[PATCH v3 1/4] cmd: add temperature command

2022-09-06 Thread Robert Marko
ivers seem to return. Signed-off-by: Robert Marko Reviewed-by: Simon Glass --- Changes in v2: * Drop by using uclass_get_device_by_name() * Make the unit clear in help * Expand Kconfig boolean and help * Drop degree symbol as test doesnt work with it. --- cmd/Kconfig | 6 cmd/Makefile

Re: [PATCH v2 4/4] test: cmd: add test for temperature command

2022-09-06 Thread Robert Marko
On Sat, Sep 3, 2022 at 3:54 AM Tom Rini wrote: > > On Fri, Aug 12, 2022 at 08:15:50PM +0200, Robert Marko wrote: > > > Add simple test for the temperature command. > > > > Signed-off-by: Robert Marko > > Reviewed-by: Simon Glass > > --- > >

[PATCH v2 3/4] thermal: add sandbox driver

2022-08-12 Thread Robert Marko
Provide a simple sandbox driver for the thermal uclass. It simply registers and returns 100 degrees C if requested. Signed-off-by: Robert Marko --- arch/sandbox/dts/sandbox.dtsi | 4 arch/sandbox/dts/test.dts | 4 configs/sandbox_defconfig | 2 ++ drivers

[PATCH v2 4/4] test: cmd: add test for temperature command

2022-08-12 Thread Robert Marko
Add simple test for the temperature command. Signed-off-by: Robert Marko --- test/cmd/Makefile | 1 + test/cmd/temperature.c | 39 +++ 2 files changed, 40 insertions(+) create mode 100644 test/cmd/temperature.c diff --git a/test/cmd/Makefile b/test

[PATCH v2 1/4] cmd: add temperature command

2022-08-12 Thread Robert Marko
ivers seem to return. Signed-off-by: Robert Marko --- Changes in v2: * Drop by using uclass_get_device_by_name() * Make the unit clear in help * Expand Kconfig boolean and help * Drop degree symbol as test doesnt work with it. --- cmd/Kconfig | 6 cmd/Makefile | 1 + cmd/temperat

[PATCH v2 2/4] doc: cmd: temperature: add documentation

2022-08-12 Thread Robert Marko
Add documentation for the temperature command. Signed-off-by: Robert Marko --- doc/usage/cmd/temperature.rst | 50 +++ doc/usage/index.rst | 1 + 2 files changed, 51 insertions(+) create mode 100644 doc/usage/cmd/temperature.rst diff --git a/doc

Re: [PATCH] cmd: add temperature command

2022-08-12 Thread Robert Marko
On Fri, Aug 12, 2022 at 5:11 PM Simon Glass wrote: > > Hi Robert, > > On Fri, 12 Aug 2022 at 06:19, Robert Marko wrote: > > > > Currently, there is no way for users to check the readings from thermal > > sensors from U-boot console, only some boards print it dur

  1   2   3   >