Re: [PATCH v2 5/5] video: Fill video handoff in video post probe

2023-11-02 Thread Simon Glass
as those were missing earlier and u-boot U-Boot > framework expects them to be filled for some of the > functionalities. > > Reported-by: Simon Glass > Signed-off-by: Devarsh Thakkar > --- > V2: No change > --- > drivers/video/video-uclass.c | 25 +++--

Re: [PATCH v2 4/5] video: Skip framebuffer reservation if already reserved

2023-11-02 Thread Simon Glass
On Tue, 31 Oct 2023 at 13:12, Devarsh Thakkar wrote: > > Skip framebufer reservation if it was already reserved > from previous stage and whose information was passed > using a bloblist. > > Signed-off-by: Devarsh Thakkar > Reviewed-by: Simon Glass > --- > V2: &

Re: [PATCH v2 2/2] rng: add dm_rng_read_default() helper

2023-11-02 Thread Simon Glass
Hi Alexey, On Thu, 2 Nov 2023 at 12:57, Alexey Romanov wrote: > > Add dm_rng_read_default() function, which obtain a series > of random bytes. In some cases, such function would be > useful because it allows the caller to abstract away from > RNG device. It should not do that. It should create

Re: [PATCH v3 4/4] sunxi: Enable SPL FIT loading for 32-bit SoCs

2023-11-02 Thread Simon Glass
istency, enable it everywhere. > > Signed-off-by: Samuel Holland > --- > > (no changes since v2) > > Changes in v2: > - New patch for v2, split from the .dtsi changes > > arch/arm/Kconfig | 1 + > common/spl/Kconfig | 3 +-- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH v3 3/4] sunxi: binman: Support FIT generation for 32-bit SoCs

2023-11-02 Thread Simon Glass
ely on binman min-size instead of using explicit offsets > - Use Kconfig for firmware addresses instead of an #ifdef staircase > > arch/arm/dts/sunxi-u-boot.dtsi | 23 ++- > 1 file changed, 18 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH v2 1/5] arm: mach-k3: common: Reserve video memory from end of the RAM

2023-11-02 Thread Simon Glass
p > the pre-reserved area from previous stage right from the end of RAM > without having to make any gaps/holes to accommodate those > regions which was the case before as previous stage > reserved region not from the end of RAM. > > Suggested-by: Simon Glass > Signed-

Re: [PATCH v2 1/2] rng: move platform_get_rng_device() to rng-uclass.c

2023-11-02 Thread Simon Glass
Hi Alexey, On Thu, 2 Nov 2023 at 12:58, Alexey Romanov wrote: > > The correct declaration place for platform_get_rng_device() > function is here. Also, this function is re-implemented to provide > the first successfully probed RNG device. > > Signed-off-by: Alexey Romanov > --- >

Re: U-boot env in binary format

2023-11-01 Thread Simon Glass
Hi Simon, On Tue, 31 Oct 2023 at 17:07, SIMON BABY wrote: > > Hello , > Can I know if I could generate uboot env file in binary format as part of my > build process ? > Currently it generate as a text file . There is the tools/mkenvimage program: mkenvimage [-h] [-r] [-b] [-p ] -s -o This

[PATCH v2] x86: serial: ns16550: Allow the UART to be silently disabled

2023-11-01 Thread Simon Glass
up and operation from the display, instead of hanging on start-up. This could perhaps be hidden behind a Kconfig option to reduce code size. Signed-off-by: Simon Glass --- Changes in v2: - Drop RFC tag since there were no comments drivers/serial/ns16550.c | 17 +++-- drivers

[PATCH] u_boot_pylib: Ensure subprocess is closed down

2023-11-01 Thread Simon Glass
into the ChromeOS chromiumos/platform/crosutils repo in the bin/cros_image_to_target.py file. The addition of the extra code path came later, so that is chosen for the fixes tag. [1] https://codereview.chromium.org/3391008 Signed-off-by: Simon Glass Fixes: a10fd93cbc patman: Make command methods return

Re: [PATCH] bootstd: Skip over bad device during bootflows scanning

2023-11-01 Thread Simon Glass
Hi Tony, On Tue, 31 Oct 2023 at 13:45, Tony Dinh wrote: > > On Tue, Oct 31, 2023 at 12:26 PM Tony Dinh wrote: > > > > Hi Simon, > > > > On Mon, Oct 30, 2023 at 12:47 PM Tony Dinh wrote: > > > > > > During scanning for the next bootdev, if bootdev_next_prio() encounters > > > a device error

Re bootstd: Skip over bad device during bootflows scanning

2023-10-31 Thread Simon Glass
Hi Tony, Sorry I cannot reply to the patch[1]. Can you please send the console trace for this situation? I don't want to ignore errors completely, so wonder if there is a special error code which could be produced when a device is missing? Regards, Simon [1]

Re: [PATCH v7 2/2] schemas: Add some common reserved-memory usages

2023-10-31 Thread Simon Glass
Hi Rob, On Mon, 16 Oct 2023 at 15:54, Simon Glass wrote: > > Hi Rob, > > On Mon, 16 Oct 2023 at 10:50, Rob Herring wrote: > > > > On Fri, Oct 13, 2023 at 4:09 PM Simon Glass wrote: > > > > > > Hi Rob, > > > > > > On Fri, 13 Oct 2023

[PATCH] buildman: Support upstream branch name containing /

2023-10-30 Thread Simon Glass
. Signed-off-by: Simon Glass --- tools/patman/gitutil.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/patman/gitutil.py b/tools/patman/gitutil.py index b0a12f2e8c06..10ea5ff39f5c 100644 --- a/tools/patman/gitutil.py +++ b/tools/patman/gitutil.py @@ -147,8 +147,9

[PATCH 3/3] tpm: Drop unwanted special cases for sandbox

2023-10-28 Thread Simon Glass
These don't seem to be needed. Add a few notes about what to do next. Also mention parallel tests in at the top of thefile. Signed-off-by: Simon Glass --- test/py/tests/test_tpm2.py | 44 +- 1 file changed, 10 insertions(+), 34 deletions(-) diff --git

[PATCH 2/3] tpm: Convert sandbox-focussed tests to C

2023-10-28 Thread Simon Glass
the Python tpm_init test to use 'tpm autostart', since this deals with starting up ready for the tests below. Signed-off-by: Simon Glass --- test/dm/tpm.c | 77 +- test/py/tests/test_tpm2.py | 57 +--- 2 files changed, 77

[PATCH 1/3] tpm: sandbox: Support self-test continue in emulator

2023-10-28 Thread Simon Glass
Add support for the self-test continue command in the TPM v1.2 emulator, to match the functionality in the TPM v2 emulator. Signed-off-by: Simon Glass --- drivers/tpm/tpm_tis_sandbox.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tpm/tpm_tis_sandbox.c b/drivers/tpm

[PATCH 0/3] tpm: Start to tidy up TPM tests

2023-10-28 Thread Simon Glass
is to have a few tests which do init, then have the rest of the tests assume that the init is done. Tests that depend on the TPM already being inited can use 'tpm autostart' which works OK on sandbox and real hardware. Simon Glass (3): tpm: sandbox: Support self-test continue in emulator tpm

Re: [PATCH v2] smbios: arm64: Allow table to be written at a fixed addr

2023-10-28 Thread Simon Glass
[unfortunately I am not receiving email from the list at present] Hi Heinrich, On Wed, 25 Oct 2023 at 21:39, Heinrich Schuchardt wrote: > > On 10/25/23 04:49, Simon Glass wrote: > > Hi Heinrich, > > > > On Tue, 24 Oct 2023 at 18:22, Heinrich Schuchardt > > wr

Re: [PATCH 3/3] arm64: boot: Support Flat Image Tree

2023-10-28 Thread Simon Glass
Hi Masahiro, On Fri, Oct 27, 2023 at 2:25 AM Masahiro Yamada wrote: > > On Thu, Oct 26, 2023 at 4:28 PM Simon Glass wrote: > > > > Add a script which produces a Flat Image Tree (FIT), a single file > > containing the built kernel and associated devicetree files. > >

Re: [PATCH 00/14] bloblist: Align to firmware handoff

2023-10-27 Thread Simon Glass
Hi Michal, On Wed, 6 Sept 2023 at 12:22, Michal Simek wrote: > > Hi Simon, > > út 25. 7. 2023 v 23:36 odesílatel Simon Glass napsal: > > > > In moving from v0.8 to v0.9 the Firmware Handoff specification made some > > changes, including: > > > >-

Re: [PATCH] test/py: always use autostart on tpm2 selftests

2023-10-27 Thread Simon Glass
Hi Ilias, On Wed, 25 Oct 2023 at 18:23, Simon Glass wrote: > > Hi Ilias, > > On Wed, 25 Oct 2023 at 07:25, Ilias Apalodimas > wrote: > > > > commit 789ed2784256 ("test/py: replace 'tpm2 init, startup, selftest' > > sequences") > > changed s

Re: quick question about TPM

2023-10-26 Thread Simon Glass
Cause I wouldn't have > thought I needed an option tugged away under Library routines. Thank you for the feedback. I added Ilias to take a look. - Simon > > Anyhow Thanks! > Niek > > > > ____ > 差出人: Simon Glass > 送信日時: 2023年10月26日 03:23

[PATCH 3/3] arm64: boot: Support Flat Image Tree

2023-10-26 Thread Simon Glass
to change the compression other than by editing the rule for $(obj)/image.fit While FIT supports a ramdisk / initrd, no attempt is made to support this here, since it must be built separately from the Linux build. Signed-off-by: Simon Glass --- MAINTAINERS | 7 + arch/arm64/Makefile

[PATCH 2/3] kbuild: arm64: Add BOOT_TARGETS variable

2023-10-26 Thread Simon Glass
Add a new variable containing a list of possible targets. Mark them as phony. This matches the approach taken for arch/arm Signed-off-by: Simon Glass --- arch/arm64/Makefile | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index

[PATCH 1/3] kbuild: Correct missing architecture-specific hyphens

2023-10-26 Thread Simon Glass
These should add a hyphen to indicate that it makes a adjective. Fix them. Signed-off-by: Simon Glass --- Makefile | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 690cde550acd..b63796e6f94a 100644 --- a/Makefile +++ b/Makefile @@ -675,7

[PATCH 0/3] arm64: Add a build target for Flat Image Tree

2023-10-26 Thread Simon Glass
clean-up patches. Simon Glass (3): kbuild: Correct missing architecture-specific hyphens kbuild: arm64: Add BOOT_TARGETS variable arm64: boot: Support Flat Image Tree MAINTAINERS | 7 + Makefile | 10 +- arch/arm64/Makefile | 7 +- arch/arm64/boot

[PATCH v6 3/3] dt-bindings: mtd: binman-partitions: Add alignment properties

2023-10-25 Thread Simon Glass
that alignment constraints are not violated. Therefore they are provided as part of the schema. Signed-off-by: Simon Glass --- Changes in v6: - Correct schema-validation errors missed due to older dt-schema (enum fix and reg addition) Changes in v5: - Add value ranges - Consistently mention

[PATCH v6 2/3] dt-bindings: mtd: binman-partition: Add binman compatibles

2023-10-25 Thread Simon Glass
-by: Simon Glass --- (no changes since v5) Changes in v5: - Add mention of why 'binman' is the vendor - Drop 'select: false' - Tidy up the compatible setings - Use 'tfa-bl31' instead of 'atf-bl31' Changes in v4: - Correct selection of multiple compatible strings Changes in v3: - Drop fixed

[PATCH v6 1/3] dt-bindings: mtd: partitions: Add binman compatible

2023-10-25 Thread Simon Glass
Add a compatible string for binman, so we can extend fixed-partitions in various ways. Signed-off-by: Simon Glass --- (no changes since v5) Changes in v5: - Add #address/size-cells and parternProperties - Drop $ref to fixed-partitions.yaml - Drop 'select: false' Changes in v4: - Change

Re: [PATCH v4 1/1] efi_loader: expose the device-tree file name

2023-10-25 Thread Simon Glass
Hi Heinrich, On Wed, 25 Oct 2023 at 20:51, Heinrich Schuchardt wrote: > > On 10/25/23 22:28, Mark Kettenis wrote: > >> Date: Wed, 25 Oct 2023 21:57:44 +0200 > >> From: Heinrich Schuchardt > >> > >> On 10/25/23 20:23, Simon Glass wrote: > >>>

Re: [PATCH v4 2/3] dt-bindings: mtd: binman-partition: Add binman compatibles

2023-10-25 Thread Simon Glass
Hi Miquel, On Wed, 25 Oct 2023 at 08:11, Miquel Raynal wrote: > > Hi Simon, > > s...@chromium.org wrote on Tue, 24 Oct 2023 14:40:54 -0700: > > > Hi Rob, > > > > On Tue, 24 Oct 2023 at 09:16, Rob Herring wrote: > > > > > > On Mon, Oct 09, 2023

Re: [PATCH] test/py: always use autostart on tpm2 selftests

2023-10-25 Thread Simon Glass
Hi Ilias, On Wed, 25 Oct 2023 at 07:25, Ilias Apalodimas wrote: > > commit 789ed2784256 ("test/py: replace 'tpm2 init, startup, selftest' > sequences") > changed some of the tpm2 init sequences to 'tpm2 autostart' instead of > calling 'tpm init', 'tpm startup TPM2_SU_CLEAR', 'tpm2 self_test

Re: quick question about TPM

2023-10-25 Thread Simon Glass
fig to add CONFIG_TPM and whatever driver you need. Regards, Simon > > Niek > > 差出人: Simon Glass > 送信日時: 2023年10月25日 03:03 > 宛先: Niek Nooijens / OC-IAB PBD-C DEVEL 1-1 > CC: u-boot@lists.denx.de > 件名: Re: quick question about TPM > >

Re: [PATCH v4 1/1] efi_loader: expose the device-tree file name

2023-10-25 Thread Simon Glass
Hi Heinrich, On Tue, 24 Oct 2023 at 18:02, Simon Glass wrote: > > Hi Heinrich, > > On Mon, 23 Oct 2023 at 23:20, Heinrich Schuchardt > wrote: > > > > Forward and backward compatibility of Linux kernel device-trees is > > sometimes missing. One solution appr

Re: Failedto read big file with "Invald FAT entry' from USB disk (FAT16)

2023-10-24 Thread Simon Glass
+Heinrich Schuchardt On Tue, 24 Oct 2023 at 19:34, target wrote: > > I am using u-boot 2017.03 in my system and enabled the debug in fs/fat/fat.c > I had a USB disk formatted in FAT16 in Linux, I put a bigfile.bin into / in > the USB disk and plugged the disk into by board. > Then I want to

Re: [PATCH v2] smbios: arm64: Allow table to be written at a fixed addr

2023-10-24 Thread Simon Glass
Hi Heinrich, On Tue, 24 Oct 2023 at 18:22, Heinrich Schuchardt wrote: > > > > Am 25. Oktober 2023 01:31:19 MESZ schrieb Simon Glass : > >U-Boot typically sets up its malloc() pool near the top of memory. On > >ARM64 systems this can result in an SMBIOS table above 4GB w

Re: [PATCH] smbios: arm64: Allow table to be written at a fixed addr

2023-10-24 Thread Simon Glass
Hi Tom, On Tue, 24 Oct 2023 at 17:44, Tom Rini wrote: > > On Wed, Oct 25, 2023 at 02:19:59AM +0200, Heinrich Schuchardt wrote: > > > > > > Am 25. Oktober 2023 01:28:10 MESZ schrieb Simon Glass : > > >Hi Tom, > > > > > >On Tue, 24 Oct 2023 at 1

[PATCH v2] smbios: arm64: Allow table to be written at a fixed addr

2023-10-24 Thread Simon Glass
-by: Simon Glass --- Changes in v2: - Update to search for a suitable area automatically, if enabled lib/Kconfig | 12 +++ lib/efi_loader/efi_smbios.c | 63 - 2 files changed, 74 insertions(+), 1 deletion(-) diff --git a/lib/Kconfig b/lib

Re: [PATCH] smbios: arm64: Allow table to be written at a fixed addr

2023-10-24 Thread Simon Glass
Hi Tom, On Tue, 24 Oct 2023 at 15:34, Tom Rini wrote: > > On Mon, Oct 23, 2023 at 05:31:19PM +0200, Mark Kettenis wrote: > > > From: Simon Glass > > > Date: Mon, 23 Oct 2023 00:04:14 -0700 > > > > > > Hi Caleb, > > > > > >

[PATCH v5 3/3] dt-bindings: mtd: binman-partitions: Add alignment properties

2023-10-24 Thread Simon Glass
that alignment constraints are not violated. Therefore they are provided as part of the schema. Signed-off-by: Simon Glass --- Changes in v5: - Add value ranges - Consistently mention alignment must be power-of-2 - Mention that alignment refers to bytes Changes in v2: - Fix 'a' typo in commit

[PATCH v5 2/3] dt-bindings: mtd: binman-partition: Add binman compatibles

2023-10-24 Thread Simon Glass
-by: Simon Glass --- Changes in v5: - Add mention of why 'binman' is the vendor - Drop 'select: false' - Tidy up the compatible setings - Use 'tfa-bl31' instead of 'atf-bl31' Changes in v4: - Correct selection of multiple compatible strings Changes in v3: - Drop fixed-partitions from the example

[PATCH v5 1/3] dt-bindings: mtd: partitions: Add binman compatible

2023-10-24 Thread Simon Glass
Add a compatible string for binman, so we can extend fixed-partitions in various ways. Signed-off-by: Simon Glass --- Changes in v5: - Add #address/size-cells and parternProperties - Drop $ref to fixed-partitions.yaml - Drop 'select: false' Changes in v4: - Change subject line Changes in v3

Re: [PATCH v4 2/3] dt-bindings: mtd: binman-partition: Add binman compatibles

2023-10-24 Thread Simon Glass
Hi Rob, On Tue, 24 Oct 2023 at 09:16, Rob Herring wrote: > > On Mon, Oct 09, 2023 at 04:04:14PM -0600, Simon Glass wrote: > > Add two compatible for binman entries, as a starting point for the > > schema. > > > > Note that, after discussion on v2, we decided to

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-24 Thread Simon Glass
Hi Tom, On Tue, 24 Oct 2023 at 11:07, Tom Rini wrote: > > On Tue, Oct 24, 2023 at 11:02:06AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 23 Oct 2023 at 10:28, Tom Rini wrote: > > > > > > On Mon, Oct 23, 2023 at 10:13:52AM -0700, Simon G

Re: [PATCH] arm: init: add an option to use FDT from previous bootloader

2023-10-24 Thread Simon Glass
Hi Caleb, On Tue, 24 Oct 2023 at 11:10, Caleb Connolly wrote: > > > > On 24/10/2023 19:03, Simon Glass wrote: > > Hi Caleb, > > > > On Tue, 24 Oct 2023 at 04:32, Caleb Connolly > > wrote: > >> > >> Add a new config option to allow u-boot t

[PATCH 2/2] bootstd: cros: Correct condition for read method

2023-10-24 Thread Simon Glass
This has a typo which makes the method inoperable. Correct it so that 'bootflow read' works correctly for ChromeOS. Signed-off-by: Simon Glass --- boot/bootmeth_cros.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/boot/bootmeth_cros.c b/boot/bootmeth_cros.c index

[PATCH 1/2] bootstd: Handle a few special cases in cmdline_set_arg()

2023-10-24 Thread Simon Glass
Two bugs have appeared: - arguments can have an equals sign embedded in them, which must be considered part of the value - arguments must fully match the name; partial matches should be ignored Fix these and add a test to cover both. Signed-off-by: Simon Glass --- boot/bootflow.c

[PATCH 0/2] bootstd: Fix a few minor bugs

2023-10-24 Thread Simon Glass
This series fixes a few bugs noticed recently: - handling of certain command-line updates with 'bootflow cmdline' - support for 'bootflow read' in ChromeOS Simon Glass (2): bootstd: Handle a few special cases in cmdline_set_arg() bootstd: cros: Correct condition for read method boot

Re: [PATCH v4 2/2] DONOTMERGE: arm: dts: k3-j7200-binman: Enable split mode for MCU R5

2023-10-24 Thread Simon Glass
rm/dts/k3-j7200-binman.dtsi | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH 1/1] tools: mkimage: fix sfspl_image_extract_subimage()

2023-10-24 Thread Simon Glass
support") > Signed-off-by: Heinrich Schuchardt > --- > tools/sfspl.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH] arm: init: add an option to use FDT from previous bootloader

2023-10-24 Thread Simon Glass
Hi Caleb, On Tue, 24 Oct 2023 at 04:32, Caleb Connolly wrote: > > Add a new config option to allow u-boot to reuse the FDT provided by the U-Boot (please fix throughout) > previous stage bootloader when available. > > On some boards the previous stage bootloader can populate >

Re: [PATCH v4 1/2] binman: openssl: x509: ti_secure_rom: Add support for bootcore_opts

2023-10-24 Thread Simon Glass
> > tools/binman/btool/openssl.py | 6 -- > tools/binman/entries.rst| 1 + > tools/binman/etype/ti_secure_rom.py | 11 +-- > tools/binman/etype/x509_cert.py | 3 ++- > tools/binman/test/297_ti_secure_rom.dts | 1 + > 5 files changed, 17 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 1/1] mkimage: do not write incorrect error message

2023-10-24 Thread Simon Glass
t;) > Signed-off-by: Heinrich Schuchardt > --- > tools/renesas_spkgimage.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Simon Glass

Re: [PATCH] doc: gpt: fix example of echoing variable

2023-10-24 Thread Simon Glass
On Tue, 24 Oct 2023 at 05:00, Tom Fitzhenry wrote: > > --- > doc/usage/cmd/gpt.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass It could use 'print' instead, I suppose. > diff --git a/doc/usage/cmd/gpt.rst b/doc/usage/cmd/gpt.rst &

Re: quick question about TPM

2023-10-24 Thread Simon Glass
Hi Niek, On Tue, 24 Oct 2023 at 04:51, niek.nooij...@omron.com wrote: > > Hi > > Just a quick question. I'm developing a platform using the > socfpga_cyclone5_defconfig > everything is working, linux boots, but we decided to add a TPM to it's SPI > bus. > For some reason the TPM support menu

Re: [PATCH] doc: usage: fix ordering of shell commands

2023-10-24 Thread Simon Glass
On Tue, 24 Oct 2023 at 05:03, Tom Fitzhenry wrote: > > I initially didn't find the bootz docs when I went looking for them. :) > --- > doc/usage/index.rst | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Simon Glass

Re: [PATCH v3 1/1] sandbox: eliminate unused functions from binaries

2023-10-24 Thread Simon Glass
Hi Heinrich, On Mon, 23 Oct 2023 at 23:31, Heinrich Schuchardt wrote: > > The sandbox should closely mimic other architectures. > > Place each function or data in a separate section and let the linker > eliminate unused ones. This will reduce the binary size. > > In the linker script mark that

Re: [PATCH v4 1/1] efi_loader: expose the device-tree file name

2023-10-24 Thread Simon Glass
); > +} > + > /** > * efi_init_platform_lang() - define supported languages > * > @@ -250,6 +273,13 @@ efi_status_t efi_init_obj_list(void) > if (ret != EFI_SUCCESS) > goto out; > > + /* Define EFI variable FdtFile */ > + if (!CONFIG_IS_ENABLED(GENERATE_ACPI_TABLE)) { > + ret = efi_init_fdtfile(); > + if (ret != EFI_SUCCESS) > + goto out; > + } > + > /* Indicate supported features */ > ret = efi_init_os_indications(); > if (ret != EFI_SUCCESS) > -- > 2.40.1 > Assuming my concerns above are figured out: Reviewed-by: Simon Glass Regards, SImon

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-24 Thread Simon Glass
Hi Tom, On Mon, 23 Oct 2023 at 10:28, Tom Rini wrote: > > On Mon, Oct 23, 2023 at 10:13:52AM -0700, Simon Glass wrote: > > [snip] > > BTW buildman supports -L which disabled LTO using the NO_LTO=1 option > > I worry about putting sandbox-specific flags in buildman. Outsi

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-24 Thread Simon Glass
Hi Tom, On Mon, 23 Oct 2023 at 10:45, Tom Rini wrote: > > On Mon, Oct 23, 2023 at 10:13:54AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 23 Oct 2023 at 06:16, Tom Rini wrote: > > > > > > On Mon, Oct 23, 2023 at 12:05:28A

Re: [PATCH v2 1/1] sandbox: eliminate unused functions from binaries

2023-10-24 Thread Simon Glass
Hi, On Mon, 23 Oct 2023 at 10:24, Tom Rini wrote: > > On Mon, Oct 23, 2023 at 10:13:55AM -0700, Simon Glass wrote: > > Hi, > > > > On Mon, 23 Oct 2023 at 10:03, Tom Rini wrote: > > > > > > On Mon, Oct 23, 2023 at 01:37:27AM +0200, Heinrich Schuchardt

Re: [PATCH 0/4] bootstd: Test and boot_targets improvements

2023-10-23 Thread Simon Glass
Hi Ivan, On Mon, 23 Oct 2023 at 02:44, Ivan T. Ivanov wrote: > > On 10-23 00:02, Simon Glass wrote: > > > > This series makes another attempt to support things like "mmc" in the > > boot_targets variable. The previous attempt introduced a bug which made &g

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-23 Thread Simon Glass
Hi Tom, On Mon, 23 Oct 2023 at 06:16, Tom Rini wrote: > > On Mon, Oct 23, 2023 at 12:05:28AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Sun, 22 Oct 2023 at 16:45, Tom Rini wrote: > > > > > > On Sun, Oct 22, 2023 at 02:55:32PM -0700, Simon Glass

Re: [PATCH v2 1/1] sandbox: eliminate unused functions from binaries

2023-10-23 Thread Simon Glass
Hi, On Mon, 23 Oct 2023 at 10:03, Tom Rini wrote: > > On Mon, Oct 23, 2023 at 01:37:27AM +0200, Heinrich Schuchardt wrote: > > The sandbox should closely mimic other architectures. > > > > Place each function or data in a separate section and let the linker > > eliminate unused ones. This will

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-23 Thread Simon Glass
Hi Tom, On Mon, 23 Oct 2023 at 06:37, Tom Rini wrote: > > On Mon, Oct 23, 2023 at 12:05:34AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Sat, 21 Oct 2023 at 11:34, Tom Rini wrote: > > > > > > On Sat, Oct 21, 2023 at 08:43:00AM -0700, Simon Glass w

Re: [PATCH] CI: Re-enable maintainer check

2023-10-23 Thread Simon Glass
+- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH v3 1/2] binman: openssl: x509: ti_secure_rom: Add support for bootcore_opts

2023-10-23 Thread Simon Glass
Hi Neha, On Mon, 23 Oct 2023 at 00:06, Neha Malcom Francis wrote: > > Hi Simon > > On 19/10/23 19:25, Simon Glass wrote: > > Hi Neha, > > > > On Tue, 17 Oct 2023 at 23:20, Neha Malcom Francis wrote: > >> > >> Hi Simon > >>

[PATCH] buildman: Include symbols in the read-only data section

2023-10-23 Thread Simon Glass
. Add 'r' to the list of symbols types that are recorded, to correct this problem. Add a constant to make it easier to find this code next time. Signed-off-by: Simon Glass --- tools/buildman/builder.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/buildman

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-23 Thread Simon Glass
Hi Heinrich, On Sat, 21 Oct 2023 at 21:53, Heinrich Schuchardt wrote: > > On 10/21/23 17:42, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 20 Oct 2023 at 09:24, Tom Rini wrote: > >> > >> On Fri, Oct 20, 2023 at 05:40:03PM +0200, Heinrich Schuchardt w

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-23 Thread Simon Glass
Hi Tom, On Sat, 21 Oct 2023 at 11:34, Tom Rini wrote: > > On Sat, Oct 21, 2023 at 08:43:00AM -0700, Simon Glass wrote: > > On Fri, 20 Oct 2023 at 14:53, Tom Rini wrote: > > > > > > The primary motivation for having a sandbox without LTO build in CI is >

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-23 Thread Simon Glass
Hi Tom, On Sun, 22 Oct 2023 at 16:45, Tom Rini wrote: > > On Sun, Oct 22, 2023 at 02:55:32PM -0700, Simon Glass wrote: > > Hi, > > > > On Sun, 22 Oct 2023 at 07:59, Tom Rini wrote: > > > > > > On Sun, Oct 22, 2023 at 10:29:22AM -0400, Tom Rini wrote:

Re: [PATCH 1/1] general: fix GPL-2.0-or-later SPDX headers

2023-10-23 Thread Simon Glass
Hi Heinrich, On Sun, 22 Oct 2023 at 10:48, Heinrich Schuchardt wrote: > > SPDX headers should use GPL-2.0-or-later and not GPL-2.0+. > > Signed-off-by: Heinrich Schuchardt > --- > Makefile | 2 +- > README

Re: [PATCH 1/1] efi_loader: fix efi_dp_from_eth

2023-10-23 Thread Simon Glass
e changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH] smbios: arm64: Allow table to be written at a fixed addr

2023-10-23 Thread Simon Glass
Hi Caleb, On Sat, 21 Oct 2023 at 01:43, Caleb Connolly wrote: > > Hi Simon, > > On 21/10/2023 01:45, Simon Glass wrote: > > U-Boot typically sets up its malloc() pool near the top of memory. On > > ARM64 systems this can result in an SMBIOS table above 4GB which is >

[PATCH 4/4] bootstd: Scan all bootdevs in a boot_targets entry (take 2)

2023-10-23 Thread Simon Glass
the uclass, i.e.: boot_targets="mmc" The intention is that this should scan all MMC devices, but in fact it currently only scans the first. Update the logic to handle this case, without required BOOTSTD_FULL to be enabled. Signed-off-by: Simon Glass Reported-by: Date Huang Reporte

[PATCH 3/4] bootstd: Correct logic for single uclass

2023-10-23 Thread Simon Glass
The current logic for "bootflow mmc" is flawed since it checks the uclass of the bootdev instead of its parent, the media device. Correct this and add a test that covers this scenario. Signed-off-by: Simon Glass --- boot/bootflow.c | 24 ++-- test/boot/boot

[PATCH 2/4] bootstd: Expand boot-ordering test to include USB

2023-10-23 Thread Simon Glass
Scan the USB bus as well, so we can check that different uclasses work correctly in boot_targets update the function comment with more detail. Signed-off-by: Simon Glass --- test/boot/bootdev.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/test/boot

[PATCH 1/4] Revert "bootstd: Scan all bootdevs in a boot_targets entry"

2023-10-23 Thread Simon Glass
e824d0d0c219bc6da767f13f90c5b00eefe929f0. Signed-off-by: Simon Glass --- boot/bootdev-uclass.c | 3 +-- boot/bootflow.c | 21 ++--- test/boot/bootdev.c | 10 -- 3 files changed, 3 insertions(+), 31 deletions(-) diff --git a/boot/bootdev-uclass.c b/boot/bootdev-uclass.c index 44ae98a9269c

[PATCH 0/4] bootstd: Test and boot_targets improvements

2023-10-23 Thread Simon Glass
This series makes another attempt to support things like "mmc" in the boot_targets variable. The previous attempt introduced a bug which made iteration fail. New test coverage is provided for some previously untested behaviour, to prevent regressions. Simon Glass (4): Revert &quo

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-22 Thread Simon Glass
Hi, On Sun, 22 Oct 2023 at 07:59, Tom Rini wrote: > > On Sun, Oct 22, 2023 at 10:29:22AM -0400, Tom Rini wrote: > > On Sun, Oct 22, 2023 at 08:08:11AM +0200, Heinrich Schuchardt wrote: > > > On 10/21/23 20:26, Tom Rini wrote: > > > > On Sat, Oct 21, 2023 at 08

Re: [PATCH v3 32/32] sandbox: Add a test for disabling CONFIG_CMDLINE

2023-10-21 Thread Simon Glass
Hi Tom, On Thu, 19 Oct 2023 at 07:57, Tom Rini wrote: > > On Thu, Oct 19, 2023 at 08:00:00AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 18 Oct 2023 at 20:32, Tom Rini wrote: > > > > > > On Mon, Oct 16, 2023 at 04:28:23PM -0600, Simon Glas

Re: [PATCH v2 30/32] fdt: Allow the devicetree to come from a bloblist

2023-10-21 Thread Simon Glass
Hi Raymond, On Fri, 20 Oct 2023 at 15:15, Raymond Mao wrote: > > Hi Simon, > > On Thu, 21 Sept 2023 at 04:58, Simon Glass wrote: > > > > Standard passage provides for a bloblist to be passed from one firmware > > phase to the next. That can be used to pass the dev

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-21 Thread Simon Glass
Hi, On Thu, 19 Oct 2023 at 17:30, AKASHI Takahiro wrote: > > On Thu, Oct 19, 2023 at 08:01:11AM -0600, Simon Glass wrote: > > Hi Heinrich, > > > > On Wed, 18 Oct 2023 at 06:55, Heinrich Schuchardt > > wrote: > > > > > > On 10/17/23 16:09, Tom R

Re: [v4.1 2/2] CI, pytest: Add a test for sandbox without LTO

2023-10-21 Thread Simon Glass
I think is more > reasonable than reworking the introduction of > test/py/tests/test_sandbox_opts.py > > Cc: Simon Glass > --- > .azure-pipelines.yml | 3 --- > .gitlab-ci.yml | 12 > test/py/tests/test_sandbox_opts.py

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-21 Thread Simon Glass
Hi Tom, On Fri, 20 Oct 2023 at 09:24, Tom Rini wrote: > > On Fri, Oct 20, 2023 at 05:40:03PM +0200, Heinrich Schuchardt wrote: > > On 20.10.23 15:21, Simon Glass wrote: > > > +Doug Anderson > > > > > > Hi Heinrich, > > > > > > On Th

[PATCH] smbios: arm64: Allow table to be written at a fixed addr

2023-10-20 Thread Simon Glass
U-Boot typically sets up its malloc() pool near the top of memory. On ARM64 systems this can result in an SMBIOS table above 4GB which is not supported by SMBIOSv2. Work around this problem by providing a new option to choose an address just below 4GB, if needed. Signed-off-by: Simon Glass

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-20 Thread Simon Glass
Trying again to add Doug as we chatted briefly about this yesterday. On Fri, Oct 20, 2023, 07:21 Simon Glass wrote: > > +Doug Anderson > > Hi Heinrich, > > On Thu, 19 Oct 2023 at 09:09, Heinrich Schuchardt > wrote: > > > > On 19.10.23 15:55, Sim

Re: [PATCH 30/32] fdt: Allow the devicetree to come from a bloblist

2023-10-20 Thread Simon Glass
Hi Ilias, On Fri, 20 Oct 2023 at 01:22, Ilias Apalodimas wrote: > > Hi Simon, > > On Wed, 18 Oct 2023 at 18:26, Simon Glass wrote: > > > > Hi Ilias, > > > > On Mon, 25 Sept 2023 at 04:19, Ilias Apalodimas > > wrote: > > > > > > Hi S

Re: [PATCH v2 1/1] efi_loader: expose the device-tree file name

2023-10-20 Thread Simon Glass
+Doug Anderson Hi Heinrich, On Thu, 19 Oct 2023 at 09:09, Heinrich Schuchardt wrote: > > On 19.10.23 15:55, Simon Glass wrote: > > Hi Heinrich, > > > > On Wed, 18 Oct 2023 at 02:15, Heinrich Schuchardt > > wrote: > >> > >> On 10/1

Re: U-Boot 2023.10 does not boot from uSD on RPi4

2023-10-19 Thread Simon Glass
Hi Ivan, On Thu, 19 Oct 2023 at 08:29, Ivan Ivanov wrote: > > On Thu, 2023-10-19 at 08:00 -0600, Simon Glass wrote: > > > > > > > > [2] > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230923205017.1754340-1-...@chromium.org/ > > >

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-19 Thread Simon Glass
Hi Heinrich, On Wed, 18 Oct 2023 at 06:55, Heinrich Schuchardt wrote: > > On 10/17/23 16:09, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:28:13PM -0600, Simon Glass wrote: > > > >> Since efi_device_path.c calls eth_get_dev() and assumes that Ethernet is > >&

Re: [PATCH v3 22/32] efi: Update EFI_LOADER to depend on DM_ETH

2023-10-19 Thread Simon Glass
Hi Peter, On Thu, 19 Oct 2023 at 04:40, Peter Robinson wrote: > > On Wed, Oct 18, 2023 at 4:29 PM Simon Glass wrote: > > > > Hi Tom, > > > > On Wed, 18 Oct 2023 at 07:37, Tom Rini wrote: > > > > > > On Mon, Oct 16, 2023 at 04:28:13

Re: U-Boot 2023.10 does not boot from uSD on RPi4

2023-10-19 Thread Simon Glass
x.de/pipermail/u-boot/2023-October/533158.html > > > > > > > > > 'git bisect' points to: > > > > > ** > > > > > commit c771e5b8c2a186fb072b6c6f571d4a3cc86efba9 > > > > > Author: Simon Glass > > > > > Date: Thu Jul 27 15

Re: [PATCH v3 32/32] sandbox: Add a test for disabling CONFIG_CMDLINE

2023-10-19 Thread Simon Glass
Hi Tom, On Wed, 18 Oct 2023 at 20:32, Tom Rini wrote: > > On Mon, Oct 16, 2023 at 04:28:23PM -0600, Simon Glass wrote: > > > Now that everything is working, add a test to make sure that this > > builds correctly. > > > > Signed-off-by: Simon

Re: [PATCH v3 04/32] cmd: Add a few more dependencies on CMDLINE

2023-10-19 Thread Simon Glass
Hi Heinrich, On Wed, 18 Oct 2023 at 07:14, Heinrich Schuchardt wrote: > > On 10/17/23 00:27, Simon Glass wrote: > > Add this to some more commands to avoid build errors with sandbox. > > > > Note that this is a temporary solution to expose more problems. A later >

Re: [PATCH v3 14/32] bootm: Allow building when cleanup functions are missing

2023-10-19 Thread Simon Glass
Hi Tom, On Wed, 18 Oct 2023 at 06:39, Tom Rini wrote: > > On Tue, Oct 17, 2023 at 09:31:04PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 17 Oct 2023 at 08:02, Tom Rini wrote: > > > > > > On Mon, Oct 16, 2023 at 04:28:05PM -0600, Simon Glass

Re: [RFC PATCH 4/5] video: Skip framebuffer reservation if already reserved

2023-10-19 Thread Simon Glass
c | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Simon Glass > > diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c > index f743ed74c8..bac30187e7 100644 > --- a/drivers/video/video-uclass.c > +++ b/drivers/video/video-uclass.c > @@ -12

Re: [PATCH v3 1/2] binman: openssl: x509: ti_secure_rom: Add support for bootcore_opts

2023-10-19 Thread Simon Glass
Hi Neha, On Tue, 17 Oct 2023 at 23:20, Neha Malcom Francis wrote: > > Hi Simon > > On 18/10/23 09:03, Simon Glass wrote: > > Hi Neha, > > > > On Tue, 17 Oct 2023 at 03:58, Neha Malcom Francis wrote: > >> > >> Hi Simon > >>

Re: [RFC PATCH 1/5] arm: mach-k3: common: Reserve video memory from end of the RAM

2023-10-19 Thread Simon Glass
s the case if previous stage > reserved region say somewhere in the middle and not at > the end of RAM. > > Suggested-by: Simon Glass > Signed-off-by: Devarsh Thakkar > --- > arch/arm/mach-k3/common.c | 21 + > 1 file changed, 21 insertions(+) > &g

<    10   11   12   13   14   15   16   17   18   19   >