Re: [PATCH v5 11/23] mkeficapsule: Add support for generating empty capsules

2022-06-16 Thread Sughosh Ganu
hi Takahiro, On Thu, 16 Jun 2022 at 06:31, Takahiro Akashi wrote: > > Sughosh, > > On Wed, Jun 15, 2022 at 04:19:56PM +0530, Sughosh Ganu wrote: > > On Wed, 15 Jun 2022 at 10:41, Takahiro Akashi > > wrote: > > > > > > On Thu, Jun 09, 20

Re: [PATCH v5 23/23] sandbox: fwu: Add support for testing FWU feature on sandbox

2022-06-15 Thread Sughosh Ganu
On Wed, 15 Jun 2022 at 12:00, Takahiro Akashi wrote: > > On Thu, Jun 09, 2022 at 06:00:10PM +0530, Sughosh Ganu wrote: > > Add a python test script for testing the FWU Multi Bank Update > > functionality on the sandbox platform. The script has test cases for > > updat

Re: [PATCH v5 23/23] sandbox: fwu: Add support for testing FWU feature on sandbox

2022-06-15 Thread Sughosh Ganu
On Wed, 15 Jun 2022 at 11:07, Takahiro Akashi wrote: > > On Thu, Jun 09, 2022 at 06:00:10PM +0530, Sughosh Ganu wrote: > > Add a python test script for testing the FWU Multi Bank Update > > functionality on the sandbox platform. The script has test cases for > > updat

Re: [PATCH v5 11/23] mkeficapsule: Add support for generating empty capsules

2022-06-15 Thread Sughosh Ganu
On Wed, 15 Jun 2022 at 10:41, Takahiro Akashi wrote: > > On Thu, Jun 09, 2022 at 05:59:58PM +0530, Sughosh Ganu wrote: > > The Dependable Boot specification[1] describes the structure of the > > firmware accept and revert capsules. These are empty capsules which > >

Re: [PATCH v5 10/23] FWU: cmd: Add a command to read FWU metadata

2022-06-13 Thread Sughosh Ganu
hi Ilias, On Fri, 10 Jun 2022 at 17:37, Ilias Apalodimas wrote: > > On Thu, Jun 09, 2022 at 05:59:57PM +0530, Sughosh Ganu wrote: > > Add a command to read the metadata as specified in the FWU > > specification and print the fields of the metadata. > > > &g

Re: [PATCH v5 06/23] FWU: stm32mp1: Add helper functions for accessing FWU metadata

2022-06-13 Thread Sughosh Ganu
hi Ilias, On Fri, 10 Jun 2022 at 17:23, Ilias Apalodimas wrote: > > Hi Sughosh, > > On Thu, Jun 09, 2022 at 05:59:53PM +0530, Sughosh Ganu wrote: > > Add helper functions needed for accessing the FWU metadata which > > contains information on the updatable images. These

Re: [PATCH v5 11/23] mkeficapsule: Add support for generating empty capsules

2022-06-13 Thread Sughosh Ganu
On Thu, 9 Jun 2022 at 21:58, Heinrich Schuchardt wrote: > > On 6/9/22 14:29, Sughosh Ganu wrote: > > The Dependable Boot specification[1] describes the structure of the > > firmware accept and revert capsules. These are empty capsules which > > are used for signalling the

[PATCH v5 23/23] sandbox: fwu: Add support for testing FWU feature on sandbox

2022-06-09 Thread Sughosh Ganu
. Signed-off-by: Sughosh Ganu --- arch/sandbox/Kconfig | 6 + arch/sandbox/dts/test.dts | 45 ++- board/sandbox/sandbox.c | 49 +++ configs/sandbox64_defconfig | 12 +- include/fwu.h

[PATCH v5 22/23] [TEMP]configs: synquacer: Add FWU support for DeveloperBox

2022-06-09 Thread Sughosh Ganu
ove unused CONFIG_FWU_INIT_BROKEN_METADATA and add CONFIG_TOOLS_MKFWUMDATA. Signed-off-by: Sughosh Ganu --- configs/synquacer_developerbox_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/configs/synquacer_developerbox_defconfig b/configs/synquacer_developerbox_defconfig index 29b1e11401..

[PATCH v5 21/23] doc: synquacer: Add how to enable FWU Multi Bank Update

2022-06-09 Thread Sughosh Ganu
From: Masami Hiramatsu Add a section for the instruction of building the FWU Multi Bank Update supported U-Boot and installation. Signed-off-by: Masami Hiramatsu Signed-off-by: Sughosh Ganu --- doc/board/socionext/developerbox.rst | 110 +++ 1 file changed, 110

[PATCH v5 20/23] FWU: synquacer: Generate dfu_alt_info from devicetree partition

2022-06-09 Thread Sughosh Ganu
platforms. Signed-off-by: Masami Hiramatsu Signed-off-by: Sughosh Ganu --- .../synquacer-sc2a11-developerbox-u-boot.dtsi | 3 + board/socionext/developerbox/Kconfig | 1 + board/socionext/developerbox/fwu_plat.c | 79 include/configs/synquacer.h | 6

[PATCH v5 19/23] FWU: synquacer: Add FWU Multi bank update support for DeveloperBox

2022-06-09 Thread Sughosh Ganu
-by: Sughosh Ganu --- .../synquacer-sc2a11-developerbox-u-boot.dtsi | 15 +- board/socionext/developerbox/Kconfig | 13 ++ board/socionext/developerbox/Makefile | 1 + board/socionext/developerbox/fwu_plat.c | 207 ++ include/configs/synquacer.h

[PATCH v5 18/23] developerbox: synquacer: Use FIP as the updatable image

2022-06-09 Thread Sughosh Ganu
-off-by: Sughosh Ganu --- board/socionext/developerbox/developerbox.c | 17 +++-- include/configs/synquacer.h | 13 ++--- 2 files changed, 5 insertions(+), 25 deletions(-) diff --git a/board/socionext/developerbox/developerbox.c b/board/socionext/developerbox

[PATCH v5 16/23] FWU: doc: Update documentation for the FWU non-GPT MTD

2022-06-09 Thread Sughosh Ganu
From: Masami Hiramatsu Update documentation for the FWU non-GPT MTD device and mkfwumdata command. Signed-off-by: Masami Hiramatsu Signed-off-by: Sughosh Ganu --- doc/develop/uefi/fwu_updates.rst | 82 +++- 1 file changed, 70 insertions(+), 12 deletions(-) diff

[PATCH v5 17/23] synquacer: Update for TBBR (BL2) based new FIP layout

2022-06-09 Thread Sughosh Ganu
an incombatible change to the synquacer_developerbox_defconfig. If you want to build U-Boot for booting from legacy FIP image, you need to specify previous configuration. Signed-off-by: Masami Hiramatsu Signed-off-by: Sughosh Ganu --- .../synquacer-sc2a11-developerbox-u-boot.dtsi | 26

[PATCH v5 15/23] tools: Add mkfwumdata tool for FWU metadata image

2022-06-09 Thread Sughosh Ganu
instead of UUID. This option is useful if the platform uses GPT partiotion. In this case, the UUID list (for an image) becomes; DiskGUID,ParitionTypeGUID,UniquePartitionGUID,... Signed-off-by: Masami Hiramatsu Signed-off-by: Sughosh Ganu --- tools/Kconfig | 9 ++ tools/Makefile

[PATCH v5 13/23] FWU: Add FWU metadata access driver for non-GPT MTD devices

2022-06-09 Thread Sughosh Ganu
-by: Masami Hiramatsu Signed-off-by: Sughosh Ganu --- drivers/fwu-mdata/Kconfig | 8 + drivers/fwu-mdata/Makefile| 1 + drivers/fwu-mdata/fwu_mdata_mtd.c | 308 ++ 3 files changed, 317 insertions(+) create mode 100644 drivers/fwu-mdata/fwu_mdata_mtd.c diff

[PATCH v5 14/23] dt/bindings: firmware: Add FWU metadata on MTD devices binding

2022-06-09 Thread Sughosh Ganu
From: Masami Hiramatsu Add a devicetree-binding YAML file for the FWU metadata on MTD devices without GPT. Signed-off-by: Masami Hiramatsu Signed-off-by: Sughosh Ganu --- .../firmware/uboot,fwu-mdata-mtd.yaml | 38 +++ 1 file changed, 38 insertions(+) create mode

[PATCH v5 11/23] mkeficapsule: Add support for generating empty capsules

2022-06-09 Thread Sughosh Ganu
://git.codelinaro.org/linaro/dependable-boot/mbfw/uploads/6f7ddfe3be24e18d4319e108a758d02e/mbfw.pdf Signed-off-by: Sughosh Ganu --- doc/mkeficapsule.1 | 29 ++--- tools/eficapsule.h | 8 +++ tools/mkeficapsule.c | 139 +-- 3 files changed, 151 insertions

[PATCH v5 12/23] FWU: doc: Add documentation for the FWU feature

2022-06-09 Thread Sughosh Ganu
Add documentattion for the FWU Multi Bank Update feature. The document describes the steps needed for setting up the platform for the feature, as well as steps for enabling the feature on the platform. Signed-off-by: Sughosh Ganu --- doc/develop/uefi/fwu_updates.rst | 142

[PATCH v5 09/23] FWU: Add support for the FWU Multi Bank Update feature

2022-06-09 Thread Sughosh Ganu
to set the updated bank as active bank to subsequently boot from. Signed-off-by: Sughosh Ganu --- include/fwu.h| 12 +- lib/Kconfig | 6 + lib/Makefile | 1 + lib/efi_loader/efi_capsule.c | 231 ++- lib/efi_loader

[PATCH v5 10/23] FWU: cmd: Add a command to read FWU metadata

2022-06-09 Thread Sughosh Ganu
Add a command to read the metadata as specified in the FWU specification and print the fields of the metadata. Signed-off-by: Sughosh Ganu --- cmd/Kconfig | 7 + cmd/Makefile| 1 + cmd/fwu_mdata.c | 74 + 3 files changed, 82

[PATCH v5 08/23] FWU: Add boot time checks as highlighted by the FWU specification

2022-06-09 Thread Sughosh Ganu
. If the system boots in the Trial State for more than a specified number of boot counts, change the Active Bank to be booting the platform from. Add these checks in the board initialisation sequence, invoked after relocation. Signed-off-by: Sughosh Ganu --- common/board_r.c | 5 ++ include

[PATCH v5 07/23] FWU: STM32MP1: Add support to read boot index from backup register

2022-06-09 Thread Sughosh Ganu
, this value is passed through one of the SoC's backup register. Add a function to read the boot index value from the backup register. Signed-off-by: Sughosh Ganu --- arch/arm/mach-stm32mp/include/mach/stm32.h | 4 board/st/stm32mp1/stm32mp1.c | 7 +++ include/fwu.h

[PATCH v5 06/23] FWU: stm32mp1: Add helper functions for accessing FWU metadata

2022-06-09 Thread Sughosh Ganu
Add helper functions needed for accessing the FWU metadata which contains information on the updatable images. These functions have been added for the STM32MP157C-DK2 board which has the updatable images on the uSD card, formatted as GPT partitions. Signed-off-by: Sughosh Ganu --- board/st

[PATCH v5 03/23] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-06-09 Thread Sughosh Ganu
based partition scheme. Signed-off-by: Sughosh Ganu --- drivers/fwu-mdata/Kconfig | 9 + drivers/fwu-mdata/Makefile| 1 + drivers/fwu-mdata/fwu_mdata_gpt_blk.c | 404 ++ include/fwu.h | 2 + 4 files changed, 416

[PATCH v5 05/23] stm32mp1: dk2: Add image information for capsule updates

2022-06-09 Thread Sughosh Ganu
Enabling capsule update functionality on the platform requires populating information on the images that are to be updated using the functionality. Do so for the DK2 board. Signed-off-by: Sughosh Ganu --- board/st/stm32mp1/stm32mp1.c | 19 +++ include/configs

[PATCH v5 02/23] FWU: Add FWU metadata structure and driver for accessing metadata

2022-06-09 Thread Sughosh Ganu
, and implementations can be added based on parameters like how the metadata partition is accessed and what type of storage device houses the metadata. Signed-off-by: Sughosh Ganu --- drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/fwu-mdata/Kconfig

[PATCH v5 04/23] stm32mp1: dk2: Add a node for the FWU metadata device

2022-06-09 Thread Sughosh Ganu
The FWU metadata structure is accessed through the driver model interface. On the stm32mp157c-dk2 board, the FWU metadata is stored on the uSD card. Add the fwu-mdata node on the u-boot specifc dtsi file for accessing the metadata structure. Signed-off-by: Sughosh Ganu --- arch/arm/dts

[PATCH v5 01/23] dt/bindings: Add bindings for FWU Metadata storage device

2022-06-09 Thread Sughosh Ganu
devices. Signed-off-by: Sughosh Ganu --- .../firmware/fwu-mdata.txt | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 doc/device-tree-bindings/firmware/fwu-mdata.txt diff --git a/doc/device-tree-bindings/firmware/fwu-mdata.txt b/doc/device-tree

[PATCH v5 00/23] FWU: Add FWU Multi Bank Update feature support

2022-06-09 Thread Sughosh Ganu
Multi bank update support for DeveloperBox FWU: synquacer: Generate dfu_alt_info from devicetree partition doc: synquacer: Add how to enable FWU Multi Bank Update [TEMP]configs: synquacer: Add FWU support for DeveloperBox Sughosh Ganu (13): dt/bindings: Add bindings for FWU Metadata storage

[PATCH v2 4/4] EFI: FMP: Use a common GetImageInfo function for FIT and raw images

2022-06-01 Thread Sughosh Ganu
The GetImageInfo function definitions for the FIT images and raw images are the same. Use a common function for the both the Firmware Management Protocol(FMP) instances for raw and FIT images. Signed-off-by: Sughosh Ganu --- Changes since V1: None lib/efi_loader/efi_firmware.c | 80

[PATCH v2 3/4] EFI: Update the documentation to reflect the correct value of OsIndications

2022-06-01 Thread Sughosh Ganu
The OsIndications is a 64 bit variable, and the current code expects the value of the variable to be 64 bit. Update the documentation to reflect this fact. Signed-off-by: Sughosh Ganu Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- Changes since V1: None doc/develop/uefi

[PATCH v2 2/4] EFI: Do not consider OsIndications variable if CONFIG_EFI_IGNORE_OSINDICATIONS is enabled

2022-06-01 Thread Sughosh Ganu
the EFI_IGNORE_OSINDICATIONS config is enabled. Return an error code on not being able to read the variable only when EFI_IGNORE_OSINDICATIONS is not enabled. Signed-off-by: Sughosh Ganu --- Changes since V1: * Read the OsIndications variable, if present and clear

[PATCH v2 1/4] EFI: Populate descriptor_count value only when image_info_size is not zero

2022-06-01 Thread Sughosh Ganu
the descriptor_count value before it is known that the call to GetImageInfo has been made with the allocated buffer for the image descriptors. Signed-off-by: Sughosh Ganu Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- Changes since V1: None lib/efi_loader/efi_firmware.c | 5 ++--- 1

[PATCH v2 0/4] EFI: Miscellaneous capsule update fixes

2022-06-01 Thread Sughosh Ganu
for both FIT and raw image FMP instances. Sughosh Ganu (4): EFI: Populate descriptor_count value only when image_info_size is not zero EFI: Do not consider OsIndications variable if CONFIG_EFI_IGNORE_OSINDICATIONS is enabled EFI: Update the documentation to reflect the correct value

Re: [PATCH 2/3] EFI: Do not read OsIndications variable if EFI_IGNORE_OSINDICATIONS is enabled

2022-06-01 Thread Sughosh Ganu
hi Heinrich, On Wed, 1 Jun 2022 at 11:33, Heinrich Schuchardt wrote: > > On 5/31/22 09:15, Sughosh Ganu wrote: > > The EFI_IGNORE_OSINDICATIONS config symbol was introduced as a > > mechanism to have capsule updates work even on platforms where the > > Set

Re: efi_firmware_raw_get_image_info and efi_firmware_fit_get_image_info

2022-06-01 Thread Sughosh Ganu
hello Heinrich, On Wed, 1 Jun 2022 at 11:11, Heinrich Schuchardt wrote: > > Hello Sughosh, > > I can't see any difference between efi_firmware_raw_get_image_info() and > efi_firmware_fit_get_image_info(). Shouldn't we replace them by a single > function to avoid maintaining duplicate code? The

[PATCH 3/3] EFI: Update the documentation to reflect the correct value of OsIndications

2022-05-31 Thread Sughosh Ganu
The OsIndications is a 64 bit variable, and the current code expects the value of the variable to be 64 bit. Update the documentation to reflect this fact. Signed-off-by: Sughosh Ganu --- doc/develop/uefi/uefi.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/develop

[PATCH 2/3] EFI: Do not read OsIndications variable if EFI_IGNORE_OSINDICATIONS is enabled

2022-05-31 Thread Sughosh Ganu
the EFI_IGNORE_OSINDICATIONS config is enabled. Move the check to see if the config symbol is enabled at the beginning of the function. If the config is enabled, return a success code without checking for the existence of the variable. Signed-off-by: Sughosh Ganu --- lib/efi_loader/efi_capsule.c | 5 +++-- 1 file

[PATCH 1/3] EFI: Populate descriptor_count value only when image_info_size is not zero

2022-05-31 Thread Sughosh Ganu
the descriptor_count value before it is known that the call to GetImageInfo has been made with the allocated buffer for the image descriptors. Signed-off-by: Sughosh Ganu --- lib/efi_loader/efi_firmware.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/efi_loader/efi_firmware.c b

[PATCH 0/3] EFI: Miscellaneous capsule update fixes

2022-05-31 Thread Sughosh Ganu
when the OsIndications variable is not set with EFI_IGNORE_OSINDICATIONS config enabled. The third patch updates the capsule update documentation to highlight the 64 bit value of OsIndications that needs to be set. Sughosh Ganu (3): EFI: Populate descriptor_count value only when image_info_size

Re: [PATCH] RockPi4: Add UEFI capsule update support

2022-05-16 Thread Sughosh Ganu
hi Peter, On Sat, 14 May 2022 at 13:44, Peter Robinson wrote: > > On Fri, May 13, 2022 at 7:50 AM Sughosh Ganu wrote: > > > > Add support for updating the idbloader and u-boot images through the > > UEFI capsule update functionality. Enable the modules req

[PATCH] RockPi4: Add UEFI capsule update support

2022-05-13 Thread Sughosh Ganu
values defined in the platform's config header(ROCKPI_4{B,C}_IDBLOADER_IMAGE_GUID and ROCKPI_4{B,C}_UBOOT_IMAGE_GUID). Signed-off-by: Sughosh Ganu --- arch/arm/mach-rockchip/Kconfig | 1 + board/rockchip/evb_rk3399/evb-rk3399.c | 190 - configs/rock-pi-4

[PATCH v8 8/8] doc: uefi: Update the capsule update related documentation

2022-04-15 Thread Sughosh Ganu
Update the capsule update functionality related documentation to refect the additional definitions that need to be made per platform for supporting the capsule update feature. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu --- Changes since V7: * Add a comment about using

[PATCH v8 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-04-15 Thread Sughosh Ganu
the EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID and EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID values superfluous. Remove the --raw and --fit command line options as well. Also modify the mkeficapsule man page to reflect this change. Signed-off-by: Sughosh Ganu --- Changes since V7: None doc/mkeficapsule.1 | 12

[PATCH v8 6/8] FMP: Remove GUIDs for FIT and raw images

2022-04-15 Thread Sughosh Ganu
The capsule update code has been modified for getting the image GUID values from the platform code. With this, each image now has a unique GUID value. With this change, there is no longer a need for defining GUIDs for FIT and raw images. Remove these GUID values. Signed-off-by: Sughosh Ganu

[PATCH v8 5/8] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-04-15 Thread Sughosh Ganu
variant for testing capsule update for FIT images. This is being done by splitting the capsule update script for FIT and raw images. Signed-off-by: Sughosh Ganu --- Changes since V7: None configs/sandbox64_defconfig | 1 - configs/sandbox_defconfig | 1

[PATCH v8 4/8] efi: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-04-15 Thread Sughosh Ganu
-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu --- Changes since V7: None lib/efi_loader/Kconfig| 2 ++ lib/efi_loader/efi_firmware.c | 5 + 2 files changed, 7 insertions(+) diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index 559b95a599..d50cd2563d 100644

[PATCH v8 3/8] capsule: Put a check for image index before the update

2022-04-15 Thread Sughosh Ganu
through the capsule, since the image_index is used to determine the location of the update on the storage device. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu Reviewed-by: Ilias Apalodimas --- Changes since V7: None lib/efi_loader/efi_capsule.c | 8 +--- 1 file changed, 5

[PATCH v8 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-04-15 Thread Sughosh Ganu
of the EFI_SYSTEM_RESOURCE_ENTRY. Currently, all images are assigned a single GUID value, either an FIT GUID or a raw image GUID. This is fixed by obtaining the GUID values from the efi_fw_images array defined per platform. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu --- Changes since V7

[PATCH v8 1/8] capsule: board: Add information needed for capsule updates

2022-04-15 Thread Sughosh Ganu
. Initialise this structure in the board file, and use the information for the capsule updates. Signed-off-by: Sughosh Ganu --- Changes since V7: None .../imx8mp_rsb3720a1/imx8mp_rsb3720a1.c | 29 +++ .../imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c | 28 +++ board

[PATCH v8 0/8] efi: capsule: Capsule Update fixes and enhancements

2022-04-15 Thread Sughosh Ganu
. * Add the capsule update test case for FIT images on sandbox64 and sandbox_flattree variants. * Add capsule update support on sandbox_flattree variant for enabling FIT capsule update testing as part of the python tests Sughosh Ganu (8): capsule: board: Add information needed for capsule

[PATCH v7 8/8] doc: uefi: Update the capsule update related documentation

2022-04-14 Thread Sughosh Ganu
Update the capsule update functionality related documentation to refect the additional definitions that need to be made per platform for supporting the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V6: * Add example for the struct efi_fw_image array and struct

[PATCH v7 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-04-14 Thread Sughosh Ganu
the EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID and EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID values superfluous. Remove the --raw and --fit command line options as well. Also modify the mkeficapsule man page to reflect this change. Signed-off-by: Sughosh Ganu --- Changes since V6: * Reword the commit message to highlight

[PATCH v7 5/8] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-04-14 Thread Sughosh Ganu
variant for testing capsule update for FIT images. This is being done by splitting the capsule update script for FIT and raw images. Signed-off-by: Sughosh Ganu --- Changes since V6: None configs/sandbox64_defconfig | 1 - configs/sandbox_defconfig | 1

[PATCH v7 6/8] FMP: Remove GUIDs for FIT and raw images

2022-04-14 Thread Sughosh Ganu
The capsule update code has been modified for getting the image GUID values from the platform code. With this, each image now has a unique GUID value. With this change, there is no longer a need for defining GUIDs for FIT and raw images. Remove these GUID values. Signed-off-by: Sughosh Ganu

[PATCH v7 4/8] efi: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-04-14 Thread Sughosh Ganu
-off-by: Sughosh Ganu --- Changes since V6: None lib/efi_loader/Kconfig| 2 ++ lib/efi_loader/efi_firmware.c | 5 + 2 files changed, 7 insertions(+) diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index 559b95a599..d50cd2563d 100644 --- a/lib/efi_loader/Kconfig +++ b

[PATCH v7 3/8] capsule: Put a check for image index before the update

2022-04-14 Thread Sughosh Ganu
through the capsule, since the image_index is used to determine the location of the update on the storage device. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu Reviewed-by: Ilias Apalodimas --- Changes since V6: None lib/efi_loader/efi_capsule.c | 8 +--- 1 file changed, 5

[PATCH v7 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-04-14 Thread Sughosh Ganu
of the EFI_SYSTEM_RESOURCE_ENTRY. Currently, all images are assigned a single GUID value, either an FIT GUID or a raw image GUID. This is fixed by obtaining the GUID values from the efi_fw_images array defined per platform. Signed-off-by: Sughosh Ganu --- Changes since V6: * Use renamed struct efi_fw_image

[PATCH v7 1/8] capsule: board: Add information needed for capsule updates

2022-04-14 Thread Sughosh Ganu
. Initialise this structure in the board file, and use the information for the capsule updates. Signed-off-by: Sughosh Ganu --- Changes since V6: * Renamed struct efi_fw_images as struct efi_fw_image as suggested by Takahiro * Made corresponding change in all board files based on the rename done

[PATCH v7 0/8] efi: capsule: Capsule Update fixes and enhancements

2022-04-14 Thread Sughosh Ganu
for enabling FIT capsule update testing as part of the python tests Sughosh Ganu (8): capsule: board: Add information needed for capsule updates capsule: FMP: Populate the image descriptor array from platform data capsule: Put a check for image index before the update efi: Define

Re: [PATCH v6 5/8] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-04-13 Thread Sughosh Ganu
On Wed, 13 Apr 2022 at 12:05, AKASHI Takahiro wrote: > > On Tue, Apr 12, 2022 at 06:34:44PM +0530, Sughosh Ganu wrote: > > The current UEFI capsule updation code uses two GUID values, one for > > FIT images, and one for raw images across platforms. This logic is > > be

Re: [PATCH v6 8/8] doc: uefi: Update the capsule update related documentation

2022-04-13 Thread Sughosh Ganu
On Wed, 13 Apr 2022 at 11:48, AKASHI Takahiro wrote: > > On Tue, Apr 12, 2022 at 06:34:47PM +0530, Sughosh Ganu wrote: > > Update the capsule update functionality related documentation to > > refect the additional definitions that need to be made per platform > > for suppo

Re: [PATCH v6 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-04-13 Thread Sughosh Ganu
On Wed, 13 Apr 2022 at 11:53, AKASHI Takahiro wrote: > > On Wed, Apr 13, 2022 at 11:44:18AM +0530, Sughosh Ganu wrote: > > On Wed, 13 Apr 2022 at 11:35, AKASHI Takahiro > > wrote: > > > > > > On Tue, Apr 12, 2022 at 06:34:46PM +0530, Sughosh Ganu wrote: > &

Re: [PATCH v6 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-04-13 Thread Sughosh Ganu
On Wed, 13 Apr 2022 at 11:35, AKASHI Takahiro wrote: > > On Tue, Apr 12, 2022 at 06:34:46PM +0530, Sughosh Ganu wrote: > > While building a capsule, the GUID value of that specific image is to > > be passed through the --guid command option to the mkeficapsule >

[PATCH v6 8/8] doc: uefi: Update the capsule update related documentation

2022-04-12 Thread Sughosh Ganu
Update the capsule update functionality related documentation to refect the additional definitions that need to be made per platform for supporting the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V5: None doc/develop/uefi/uefi.rst | 51

[PATCH v6 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-04-12 Thread Sughosh Ganu
options as well. Signed-off-by: Sughosh Ganu Acked-by: Ilias Apalodimas --- Changes since V5: None tools/eficapsule.h | 8 tools/mkeficapsule.c | 26 +- 2 files changed, 1 insertion(+), 33 deletions(-) diff --git a/tools/eficapsule.h b/tools/eficapsule.h

[PATCH v6 6/8] FMP: Remove GUIDs for FIT and raw images

2022-04-12 Thread Sughosh Ganu
The capsule update code has been modified for getting the image GUID values from the platform code. With this, each image now has a unique GUID value. With this change, there is no longer a need for defining GUIDs for FIT and raw images. Remove these GUID values. Signed-off-by: Sughosh Ganu

[PATCH v6 5/8] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-04-12 Thread Sughosh Ganu
variant for testing capsule update for FIT images. This is being done by splitting the capsule update script for FIT and raw images. Signed-off-by: Sughosh Ganu --- Changes since V5: * Restart the platform before starting the tests. This is done to clear out any stale state from a previously run

[PATCH v6 4/8] efi: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-04-12 Thread Sughosh Ganu
-off-by: Sughosh Ganu --- Changes since V5: * Simplify the set_dfu_alt_info function definition to set the variable directly from dfu_string, as suggested by Heinrich. lib/efi_loader/Kconfig| 2 ++ lib/efi_loader/efi_firmware.c | 5 + 2 files changed, 7 insertions(+) diff --git

[PATCH v6 3/8] capsule: Put a check for image index before the update

2022-04-12 Thread Sughosh Ganu
through the capsule, since the image_index is used to determine the location of the update on the storage device. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu Reviewed-by: Ilias Apalodimas --- Changes since V5: None lib/efi_loader/efi_capsule.c | 8 +--- 1 file changed, 5

[PATCH v6 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-04-12 Thread Sughosh Ganu
of the EFI_SYSTEM_RESOURCE_ENTRY. Currently, all images are assigned a single GUID value, either an FIT GUID or a raw image GUID. This is fixed by obtaining the GUID values from the efi_fw_images array defined per platform. Signed-off-by: Sughosh Ganu --- Changes since V5: None lib/efi_loader

[PATCH v6 1/8] capsule: board: Add information needed for capsule updates

2022-04-12 Thread Sughosh Ganu
. Initialise this structure in the board file, and use the information for the capsule updates. Signed-off-by: Sughosh Ganu --- Changes since V5: * Create a separate entry in fw_images array per config for boards with multiple configs as suggested by Heinrich. * Removed CONFIG_IS_ENABLED

[PATCH v6 0/8] efi: capsule: Capsule Update fixes and enhancements

2022-04-12 Thread Sughosh Ganu
update support on sandbox_flattree variant for enabling FIT capsule update testing as part of the python tests Sughosh Ganu (8): capsule: board: Add information needed for capsule updates capsule: FMP: Populate the image descriptor array from platform data capsule: Put a check for image index

Re: [PATCH v5 4/8] efi: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-04-11 Thread Sughosh Ganu
On Sat, 2 Apr 2022 at 15:00, Heinrich Schuchardt wrote: > > On 4/1/22 21:17, Sughosh Ganu wrote: > > Currently, there are a bunch of boards which enable the UEFI capsule > > update feature. The actual update of the firmware images is done > > through the dfu framework whi

Re: [PATCH v5 1/8] capsule: board: Add information needed for capsule updates

2022-04-11 Thread Sughosh Ganu
On Sat, 2 Apr 2022 at 14:34, Heinrich Schuchardt wrote: > > On 4/1/22 21:17, Sughosh Ganu wrote: > > Add a structure which defines the information that is needed for > > executing capsule updates on a platform. Some information in the > > structure is used for making

[PATCH v5 6/8] FMP: Remove GUIDs for FIT and raw images

2022-04-01 Thread Sughosh Ganu
The capsule update code has been modified for getting the image GUID values from the platform code. With this, each image now has a unique GUID value. With this change, there is no longer a need for defining GUIDs for FIT and raw images. Remove these GUID values. Signed-off-by: Sughosh Ganu

[PATCH v5 8/8] doc: uefi: Update the capsule update related documentation

2022-04-01 Thread Sughosh Ganu
Update the capsule update functionality related documentation to refect the additional definitions that need to be made per platform for supporting the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V4: * Change the description of the platform data based on the changes

[PATCH v5 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-04-01 Thread Sughosh Ganu
options as well. Signed-off-by: Sughosh Ganu Acked-by: Ilias Apalodimas --- Changes since V4: None tools/eficapsule.h | 8 tools/mkeficapsule.c | 26 +- 2 files changed, 1 insertion(+), 33 deletions(-) diff --git a/tools/eficapsule.h b/tools/eficapsule.h

[PATCH v5 5/8] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-04-01 Thread Sughosh Ganu
for testing the capsule update code. Install the FMP instance for the FIT images on the sandbox64 and sandbox_flattree variant for testing capsule update for FIT images. This is being done by splitting the capsule update script for FIT and raw images. Signed-off-by: Sughosh Ganu --- Changes since V4

[PATCH v5 3/8] capsule: Put a check for image index before the update

2022-04-01 Thread Sughosh Ganu
through the capsule, since the image_index is used to determine the location of the update on the storage device. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu Reviewed-by: Ilias Apalodimas --- Changes since V4: None lib/efi_loader/efi_capsule.c | 8 +--- 1 file changed, 5

[PATCH v5 4/8] efi: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-04-01 Thread Sughosh Ganu
-off-by: Sughosh Ganu --- Changes since V4: * Define a weak function set_dfu_alt_info for setting the variable in a non board specific file as suggested by Ilias * Drop the definitions of set_dfu_alt_info that were being added in the board files lib/efi_loader/Kconfig| 2 ++ lib

[PATCH v5 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-04-01 Thread Sughosh Ganu
of the EFI_SYSTEM_RESOURCE_ENTRY. Currently, all images are assigned a single GUID value, either an FIT GUID or a raw image GUID. This is fixed by obtaining the GUID values from the efi_fw_images array defined per platform. Signed-off-by: Sughosh Ganu --- Changes since V4: * Drop the image_count variable

[PATCH v5 1/8] capsule: board: Add information needed for capsule updates

2022-04-01 Thread Sughosh Ganu
the information for the capsule updates. Signed-off-by: Sughosh Ganu --- Changes since V1: * Define a structure efi_capsule_update_info which includes the string for populating dfu_alt_info * Initialise the string for dfu_alt_info in the board file .../imx8mp_rsb3720a1/imx8mp_rsb3720a1.c

[PATCH v5 0/8] efi: capsule: Capsule Update fixes and enhancements

2022-04-01 Thread Sughosh Ganu
of the python tests Sughosh Ganu (8): capsule: board: Add information needed for capsule updates capsule: FMP: Populate the image descriptor array from platform data capsule: Put a check for image index before the update efi: Define set_dfu_alt_info() for boards with UEFI capsule update

Re: [PATCH v4 4/8] board: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-04-01 Thread Sughosh Ganu
hi Ilias, On Fri, 1 Apr 2022 at 01:05, Ilias Apalodimas wrote: > > Hi Sughosh, > > Some nots below > > On Thu, Mar 31, 2022 at 06:57:46PM +0530, Sughosh Ganu wrote: > > Currently, there are a bunch of boards which enable the UEFI capsule > > update feature. The

Re: [PATCH v4 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-03-31 Thread Sughosh Ganu
hi Ilias, On Thu, 31 Mar 2022 at 20:38, Ilias Apalodimas wrote: > > Hi Sughosh, > > On Thu, Mar 31, 2022 at 06:57:44PM +0530, Sughosh Ganu wrote: > > Currently, the image descriptor array that has been passed to the > > GetImageInfo function of the Firmware Manag

[PATCH v4 8/8] doc: uefi: Update the capsule update related documentation

2022-03-31 Thread Sughosh Ganu
Update the capsule update functionality related documentation to refect the additional definitions that need to be made per platform for supporting the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V3: * Rephrase the commit message to indicate that the doc changes

[PATCH v4 5/8] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-03-31 Thread Sughosh Ganu
for testing the capsule update code. Install the FMP instance for the FIT images on the sandbox64 and sandbox_flattree variant for testing capsule update for FIT images. This is being done by splitting the capsule update script for FIT and raw images. Signed-off-by: Sughosh Ganu --- Changes since V3

[PATCH v4 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-03-31 Thread Sughosh Ganu
options as well. Signed-off-by: Sughosh Ganu --- Changes since V3: None tools/eficapsule.h | 8 tools/mkeficapsule.c | 26 +- 2 files changed, 1 insertion(+), 33 deletions(-) diff --git a/tools/eficapsule.h b/tools/eficapsule.h index 69c9c58c2f..d63b831443

[PATCH v4 4/8] board: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-03-31 Thread Sughosh Ganu
-by: Sughosh Ganu --- Changes since V3: * Do not remove the existing dfu_alt_info definitions made by platforms in the config files, as discussed with Masami. * Squash the selection of the SET_DFU_ALT_INFO config symbol for capsule update feature as part of this patch. .../imx8mp_rsb3720a1

[PATCH v4 6/8] FMP: Remove GUIDs for FIT and raw images

2022-03-31 Thread Sughosh Ganu
The capsule update code has been modified for getting the image GUID values from the platform code. With this, each image now has a unique GUID value. With this change, there is no longer a need for defining GUIDs for FIT and raw images. Remove these GUID values. Signed-off-by: Sughosh Ganu

[PATCH v4 1/8] capsule: Add Image GUIDs and image index for platforms using capsule updates

2022-03-31 Thread Sughosh Ganu
-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu Acked-by: Michal Simek --- Changes since V3: None .../imx8mp_rsb3720a1/imx8mp_rsb3720a1.c | 20 + .../imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c | 19 + board/emulation/qemu-arm/qemu-arm.c | 20

[PATCH v4 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-03-31 Thread Sughosh Ganu
or a raw image GUID. This is fixed by obtaining the GUID values from the efi_fw_images array defined per platform. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu --- Changes since V3: None include/efi_loader.h | 3 ++ lib/efi_loader/efi_firmware.c | 91

[PATCH v4 3/8] capsule: Put a check for image index before the update

2022-03-31 Thread Sughosh Ganu
through the capsule, since the image_index is used to determine the location of the update on the storage device. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu --- Changes since V3: None lib/efi_loader/efi_capsule.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

[PATCH v4 0/8] efi: capsule: Capsule Update fixes and enhancements

2022-03-31 Thread Sughosh Ganu
update testing as part of the python tests Sughosh Ganu (8): capsule: Add Image GUIDs and image index for platforms using capsule updates capsule: FMP: Populate the image descriptor array from platform data capsule: Put a check for image index before the update board: Define set_dfu_alt_info

Re: [PATCH v3 5/9] capsule: kconfig: Select SET_DFU_ALT_INFO config symbol for capsule update

2022-03-31 Thread Sughosh Ganu
hi Masami, On Thu, 31 Mar 2022 at 13:11, Sughosh Ganu wrote: > > hi Masami, > > On Thu, 31 Mar 2022 at 08:18, Masami Hiramatsu > wrote: > > > > Hi, > > > > Even with this patch, if the platform configuration doesn't select > > EFI_CAPSULE

Re: [PATCH v3 5/9] capsule: kconfig: Select SET_DFU_ALT_INFO config symbol for capsule update

2022-03-31 Thread Sughosh Ganu
> > 2022年3月30日(水) 23:51 Sughosh Ganu : > > > > The capsule update code uses the dfu_alt_info variable for the actual > > update of the firmware component. The dfu_alt_info variable gives > > information needed to perform the update, like the device on which the > >

Re: [PATCH v3 4/9] board: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-03-31 Thread Sughosh Ganu
CONFIG_SET_DFU_ALT_INFO in the board's defconfig file, I will make that change in my next version. Thanks. -sughosh > > Thank you, > > 2022年3月30日(水) 23:51 Sughosh Ganu : > > > > Currently, there are a bunch of boards which enable the UEFI capsule > > update feature. The ac

<    3   4   5   6   7   8   9   10   11   12   >