Re: [U-Boot] [PATCH] spi: cadence_qspi: Add quad write support

2019-02-26 Thread Vignesh R
On 26/02/19 1:59 PM, Ley Foon Tan wrote: > Use quad write if SPI_TX_QUAD flag is set. > How was the patch tested? Could you add that info to commit msg? > Signed-off-by: Ley Foon Tan > --- > drivers/spi/cadence_qspi.c | 2 +- > drivers/spi/cadence_qspi.h | 2 +- >

Re: [U-Boot] [PATCH] usb: udc-uclass: Fixed problem when no alias is defined in DT

2019-02-26 Thread Vignesh R
ice on DRA7xx/AM57xx platforms. Since, this patch fixes a regression, could this be picked up for next -rc? Tested-by: Vignesh R > drivers/usb/gadget/udc/udc-uclass.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/udc/udc-uclass.c

[U-Boot] [PATCH] am57xx_evm_defconfig: Enable configs to support QSPI boot

2019-02-21 Thread Vignesh R
AM57xx IDK EVMs can boot out of QSPI. Enable configs to support QSPI boot. Also enable configs for updating QSPI boot images over DFU. Tested on AM572x IDK EVM. Signed-off-by: Vignesh R --- configs/am57xx_evm_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/configs

Re: [U-Boot] [PATCH] configs: am57xx_evm: define CONFIG_SPL_LOAD_FIT_ADDRESS for SPL-DFU

2019-02-21 Thread Vignesh R
Hi Bin, On 08/02/19 10:31 PM, Bin Liu wrote: > Define CONFIG_SPL_LOAD_FIT_ADDRESS to enable SPL-DFU for am57x platform. > > Signed-off-by: Bin Liu > --- With this patch DFU args are no longer available at U-Boot prompt > include/configs/am57xx_evm.h | 11 +++ > 1 file changed, 11

Re: [U-Boot] [PATCH v4 00/25] MTD defconfigs/Kconfigs/Makefiles heavy cleanup

2019-02-19 Thread Vignesh R
Hi Jagan, On 09/12/18 11:37 PM, Miquel Raynal wrote: > Hello, > > During my last project about SPI-NAND support in U-Boot, I discovered > when modifying Makefiles a confusing organization where: > * Sub-directories/files are compiled from the root Makefile > * Commands are at the root of

Re: [U-Boot] [PATCH] treewide: Replace CONFIG_DM_SPI_FLASH with CONFIG_IS_ENABLED(DM_SPI_FLASH)

2019-02-19 Thread Vignesh R
On 19/02/19 10:37 AM, Marek Vasut wrote: > Perform the replacement to allow platforms use non-DM SPI flash access > in SPL/TPL. This is thus far needed on platforms with size constraints. > > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Vignesh R > --- I have a s

Re: [U-Boot] [PATCH v2 1/1] mtd: added missing GigaDevice chips

2019-02-19 Thread Vignesh R
Hi, On 18/02/19 3:30 PM, Jiri Kastner wrote: > Vocore2 (mt7688 based device) has g25q128 chip > from GigaDevice, which i've found in kernel tree. > added chips are gd25q128 and gd25q256. > > Cc: Jagan Teki > Cc: Vignesh R > --- > drivers/mtd/spi/spi-nor-ids.c | 10

Re: [U-Boot] [PATCH] sf: Add Macronix MX25R6435F SPI NOR flash to flash parameters array

2019-02-14 Thread Vignesh R
On 14/02/19 10:39 PM, Jagan Teki wrote: > + Vignesh > > On Mon, Jan 7, 2019 at 11:05 AM Ye Li wrote: >> >> On i.MX7ULP EVK board, we use MX25R6435F NOR flash, add its parameters >> and IDs to flash parameter array. Otherwise, the flash probe will fails. >> >> Signed-off-by: Ye Li >> --- >>

Re: [U-Boot] [PATCH v4 14/20] mtd: spi: Switch to new SPI NOR framework

2019-02-12 Thread Vignesh R
On 13/02/19 1:54 AM, Adam Ford wrote: > On Tue, Feb 12, 2019 at 1:20 PM Adam Ford wrote: >> >> On Sun, Feb 10, 2019 at 10:37 PM Vignesh R wrote: >>> >>> >>> >>> On 11/02/19 9:01 AM, Adam Ford wrote: >>>> On Tue, Feb 5, 2

Re: [U-Boot] [PATCH v1 1/2] configs: k2g_evm: Enable CONFIG_BLK

2019-02-12 Thread Vignesh R
On 08/02/19 3:25 PM, Jean-Jacques Hiblot wrote: > CONFIG_BLK can be safely enabled as DM_MMC and DM_USB are already enabled. > > Signed-off-by: Jean-Jacques Hiblot > --- > Thanks for the patch! Tested-by: Vignesh R Tom, This fix is required for booting kernel from MMC/S

Re: [U-Boot] [PATCH 1/3] spi: Kconfig: Mark CONFIG_SPI as Legacy spi support

2019-02-12 Thread Vignesh R
_SPI enablement for > dm version spi drivers. > > Cc: Vignesh R > Signed-off-by: Jagan Teki Acked-by: Vignesh R > --- > drivers/spi/Kconfig | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/drivers/spi/Kconfig b/drivers/

Re: [U-Boot] [PATCH 2/3] mtd: spi: Kconfig: Update CONFIG_SPI_FLASH

2019-02-12 Thread Vignesh R
s on legacy SPI, >so remove the 'depends on SPI' > > Cc: Vignesh R > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/Kconfig | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig > index e3b4

Re: [U-Boot] [PATCH 3/3] mtd: spi: Kconfig: Select SPI_FLASH if DM_SPI_FLASH

2019-02-11 Thread Vignesh R
DM_SPI_FLASH being used. > > Cc: Vignesh R > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig > index 605f60c713..43f597ec29 100644 > --- a/drivers

[U-Boot] [PATCH 1/2] spi: ti_qspi: Drop non DM code

2019-02-11 Thread Vignesh R
Now that all boards using TI QSPI have moved to DM and DT, drop non DM code completely. Signed-off-by: Vignesh R --- drivers/spi/Kconfig| 12 +- drivers/spi/Makefile | 2 +- drivers/spi/ti_qspi.c | 231 ++--- include/configs

[U-Boot] [PATCH 2/2] spi: ti_qspi: Convert to spi-mem ops

2019-02-11 Thread Vignesh R
Convert driver to use spi-mem ops in order to support accelerated MMIO flash interface in generic way and for better performance. Signed-off-by: Vignesh R --- drivers/spi/ti_qspi.c | 132 ++ 1 file changed, 68 insertions(+), 64 deletions(-) diff --git

[U-Boot] [PATCH 0/2] ti_qspi: Move to spi-mem framework

2019-02-11 Thread Vignesh R
cl-som-am57x_defconfig*, as defconfig does not enable even basic CONFIG_DM and would surely be dropped in next merge window. Tested on AM43xx, dra7xx EVMs Vignesh R (2): spi: ti_qspi: Drop non DM code spi: ti_qspi: Convert to spi-mem ops drivers/spi/Kconfig| 12 +- drivers/spi

[U-Boot] cl-som-am57x_defconfig will be dropped

2019-02-10 Thread Vignesh R
Hi Uri, I see following warnings when building configs/cl-som-am57x_defconfig[1] which means board has not be moved to U-Boot Driver Model and Device Tree. Do you have plans to move configs/cl-som-am57x_defconfig to DM and enable CONFIG_DM and other DM framework? This is coming in the way of

Re: [U-Boot] [PATCH v2] mtd: add spi flash id s25fl064l

2019-02-10 Thread Vignesh R
On 08/02/19 3:33 PM, Heiko Schocher wrote: > Add support for SPANSION s25fl064l > > Signed-off-by: Heiko Schocher > --- > > Changes in v2: > - s/s25f064l/s25fl064l > as Vignesh R suggested > > drivers/mtd/spi/spi-nor-ids.c | 1 + > 1 file changed, 1 inser

Re: [U-Boot] [PATCH] mtd: qspi: support read the flag status in fspi driver

2019-02-10 Thread Vignesh R
Hi, On 09/02/19 10:59 PM, Jagan Teki wrote: > On Mon, Jan 7, 2019 at 2:24 PM Ye Li wrote: >> >> From: Han Xu >> >> Support to read the flag status in driver to avoid the spi-nor framework >> wait_for_ready hang issue. >> >> Signed-off-by: Han Xu >> --- >> drivers/spi/fsl_qspi.c | 47

Re: [U-Boot] [PATCH v4 14/20] mtd: spi: Switch to new SPI NOR framework

2019-02-10 Thread Vignesh R
On 11/02/19 9:01 AM, Adam Ford wrote: > On Tue, Feb 5, 2019 at 12:00 AM Vignesh R wrote: >> >> Switch spi_flash_* interfaces to call into new SPI NOR framework via MTD >> layer. Fix up sf_dataflash to work in legacy way. And update sandbox to >> use new interfaces/d

Re: [U-Boot] [PATCH v4 00/20] SF: Migrate to Linux SPI NOR framework

2019-02-08 Thread Vignesh R
On 07/02/19 6:13 PM, Jagan Teki wrote: > On Tue, Feb 5, 2019 at 11:29 AM Vignesh R wrote: [...] >> >> Vignesh R (20): >> configs: Move CONFIG_SPI_FLASH into defconfigs >> bitops: Fix GENMASK definition for Sandbox >> spi: spi-mem: Allow use of spi_mem_e

Re: [U-Boot] [PATCH] mtd: add spi flash id s25f064l

2019-02-08 Thread Vignesh R
Hi, On 08/02/19 1:34 PM, Heiko Schocher wrote: > Add support for SPANSION s25f064l > s/s25f064l/s25fl064l as per: https://www.cypress.com/file/316661/download > Signed-off-by: Heiko Schocher > --- > > drivers/mtd/spi/spi-nor-ids.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [U-Boot] [PATCH v4 00/20] SF: Migrate to Linux SPI NOR framework

2019-02-06 Thread Vignesh R
On 06-Feb-19 1:43 PM, Simon Goldschmidt wrote: > On Tue, Feb 5, 2019 at 6:58 AM Vignesh R wrote: >> >> Here is the v4 of SPI NOR migration(github branch at [1]) with minor >> cleanups > > I've just sanity-checked this again on socfpga_socrates: Everything > s

[U-Boot] [PATCH v4 7/7] configs: am65x_evm_a53: Enable DMA related configs

2019-02-05 Thread Vignesh R
From: Grygorii Strashko Enable TI K3 AM65x PSI-L, Ring Accelerator and UDMA drivers Signed-off-by: Grygorii Strashko Signed-off-by: Vignesh R Reviewed-by: Tom Rini --- configs/am65x_evm_a53_defconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configs

[U-Boot] [PATCH v4 5/7] soc: keystone: Merge into ti specific directory

2019-02-05 Thread Vignesh R
Merge drivers/soc/keystone/ into drivers/soc/ti/ and convert CONFIG_TI_KEYSTONE_SERDES into Kconfig. Signed-off-by: Vignesh R Reviewed-by: Tom Rini --- arch/arm/mach-keystone/Kconfig | 8 drivers/soc/Makefile | 1 - drivers/soc/keystone

[U-Boot] [PATCH v4 6/7] arm64: dts: ti: k3-am65: add mcu navss nodes

2019-02-05 Thread Vignesh R
From: Grygorii Strashko Add DT node for MCU NAVSS its components to get DMA working on AM654 SoC. Signed-off-by: Grygorii Strashko Signed-off-by: Vignesh R Reviewed-by: Tom Rini --- arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 47 1 file changed, 47 insertions

[U-Boot] [PATCH v4 4/7] dma: ti: add driver to K3 UDMA

2019-02-05 Thread Vignesh R
Signed-off-by: Vignesh R --- drivers/dma/Kconfig |2 + drivers/dma/Makefile |2 + drivers/dma/ti/Kconfig| 14 + drivers/dma/ti/Makefile |3 + drivers/dma/ti/k3-udma-hwdef.h| 184 +++ drivers/dma/ti/k3-udma.c | 1730

[U-Boot] [PATCH v4 1/7] firmware: ti_sci: Add support for NAVSS resource management

2019-02-05 Thread Vignesh R
firmware. Signed-off-by: Peter Ujfalusi Signed-off-by: Grygorii Strashko Reviewed-by: Tom Rini Signed-off-by: Vignesh R --- arch/arm/dts/k3-am65-wakeup.dtsi | 2 +- drivers/firmware/ti_sci.c | 760 - drivers/firmware/ti_sci.h | 642

[U-Boot] [PATCH v4 2/7] soc: ti: k3: add navss ringacc driver

2019-02-05 Thread Vignesh R
this way because, Linux driver implements two stage Rings allocation and configuration (allocate ring and configure ring) while TI-SCI Message Protocol supports only one combined operation (allocate+configure). Signed-off-by: Grygorii Strashko Signed-off-by: Vignesh R --- drivers/Kconfig

[U-Boot] [PATCH v4 3/7] soc: ti: k3: add CPPI5 description and helpers

2019-02-05 Thread Vignesh R
From: Grygorii Strashko Add TI Communications Port Programming Interface (CPPI) 5 interface description and helpers Signed-off-by: Grygorii Strashko Signed-off-by: Vignesh R Reviewed-by: Tom Rini --- include/linux/soc/ti/cppi5.h | 995 +++ 1 file changed

[U-Boot] [PATCH v4 0/7] AM65x: Add DMA support

2019-02-05 Thread Vignesh R
: ti: k3-am65: add mcu navss nodes configs: am65x_evm_a53: Enable DMA related configs Vignesh R (2): dma: ti: add driver to K3 UDMA soc: keystone: Merge into ti specific directory arch/arm/dts/k3-am65-wakeup.dtsi |2 +- arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 47

Re: [U-Boot] [PULL] Please pull u-boot-rockchip:tags/for-master-20190201

2019-02-05 Thread Vignesh R
On 01/02/19 10:45 PM, Philipp Tomsich wrote: > Tom, > > I am a little late this time with our changes for rc1. Hope this doesn’t > impact your workflow too much. > Things got a bit messy this time, as some of the series introduced unexpected > isses during testing > (such as the debug UART

[U-Boot] [PATCH v4 14/20] mtd: spi: Switch to new SPI NOR framework

2019-02-04 Thread Vignesh R
Switch spi_flash_* interfaces to call into new SPI NOR framework via MTD layer. Fix up sf_dataflash to work in legacy way. And update sandbox to use new interfaces/definitions Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur Reviewed

[U-Boot] [PATCH v4 15/20] mtd: spi: Remove unused files

2019-02-04 Thread Vignesh R
spi_flash and spi_flash_ids are no longer needed after SPI NOR migration. Remove them. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur Reviewed-by: Jagan Teki Tested-by: Jagan Teki #zynq-microzed --- drivers/mtd/spi/spi_flash.c

[U-Boot] [PATCH v4 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-02-04 Thread Vignesh R
. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur Reviewed-by: Jagan Teki Tested-by: Jagan Teki #zynq-microzed --- arch/arm/mach-omap2/am33xx/Kconfig | 1 - configs/alt_defconfig| 1 - configs

[U-Boot] [PATCH v4 16/20] mtd: spi: Add lightweight SPI flash stack for SPL

2019-02-04 Thread Vignesh R
of reducing spi flash id table by Simon Goldschmidt Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur Reviewed-by: Jagan Teki Tested-by: Jagan Teki #zynq-microzed --- common/spl/Kconfig | 11 +- drivers/mtd/spi/Makefile

[U-Boot] [PATCH v4 17/20] spl: Kconfig: Enable SPI_FLASH_TINY by default for SPL

2019-02-04 Thread Vignesh R
SPI_FLASH_BAR, SPI_FLASH_TINY is not enabled for boards with SPI controllers that cannot support 4 byte addressing. Signed-off-by: Vignesh R Reviewed-by: Jagan Teki Tested-by: Jagan Teki #zynq-microzed --- common/spl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/common/spl/Kconfig b

[U-Boot] [PATCH v4 18/20] configs: Remove SF_DUAL_FLASH

2019-02-04 Thread Vignesh R
SF_DUAL_FLASH claims to enable support for SF_DUAL_STACKED_FLASH and SF_DUAL_PARALLEL_FLASH. But, in current U-Boot code, grepping for above enums yield no user and therefore support seems to be incomplete. Remove these configs so as to avoid confusion. Signed-off-by: Vignesh R Reviewed

[U-Boot] [PATCH v4 10/20] mtd: spi: spi-nor-core: Add 4 Byte addressing support

2019-02-04 Thread Vignesh R
Sync changes from Linux SPI NOR framework to add 4 byte addressing support. This is required in order to support flashes like MT35x that no longer support legacy Bank Address Register(BAR) way of accessing >16MB region. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Ste

[U-Boot] [PATCH v4 20/20] MAINTAINERS: Add an entry for SPI NOR

2019-02-04 Thread Vignesh R
Add myself as co-maintainer for U-Boot SPI NOR subsystem. Signed-off-by: Vignesh R Reviewed-by: Jagan Teki --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e3a15868bcad..e5f897b39d59 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[U-Boot] [PATCH v4 11/20] mtd: spi: spi-nor-core: Add SFDP support

2019-02-04 Thread Vignesh R
Sync Serial Flash Discoverable Parameters (SFDP) parsing support from Linux. This allows auto detection and configuration of Flash parameters. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur Reviewed-by: Jagan Teki Tested-by: Jagan Teki

[U-Boot] [PATCH v4 13/20] mtd: spi: sf_probe: Add "jedec, spi-nor" compatible string

2019-02-04 Thread Vignesh R
Linux uses "jedec,spi-nor" as compatible string for JEDEC compatible SPI Flash device nodes. Therefore make U-Boot also to look for the same compatible string so that we can use Linux DTS files as is. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roe

[U-Boot] [PATCH v4 12/20] mtd: spi: spi-nor-core: Add back U-Boot specific features

2019-02-04 Thread Vignesh R
For legacy reasons, we will have to keep around U-Boot specific SPI_FLASH_BAR and SPI_TX_BYTE. Add them back to the new framework Signed-off-by: Vignesh R Reviewed-by: Jagan Teki Tested-by: Jagan Teki #zynq-microzed --- drivers/mtd/spi/spi-nor-core.c | 162

[U-Boot] [PATCH v4 08/20] mtd: spi: Port SPI NOR framework from Linux

2019-02-04 Thread Vignesh R
So, sync SPI NOR framework from Linux v4.19 that supports all the above features. Start with basic sync up that brings in basic framework subsequent commits will bring in more features. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur Revie

[U-Boot] [PATCH v4 09/20] mtd: spi: spi-nor-core: Add SPI MEM support

2019-02-04 Thread Vignesh R
controllers with MMIO interface. SPI MEM layer takes care of translating spi_mem_ops to spi_xfer()s in case of legacy SPI controllers. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur Reviewed-by: Jagan Teki Tested-by: Jagan Teki #zynq-microzed

[U-Boot] [PATCH v4 05/20] spi: spi-mem: Claim SPI bus before spi mem access

2019-02-04 Thread Vignesh R
It is necessary to call spi_claim_bus() before starting any SPI transactions and this restriction would also apply when calling spi-mem operations. Therefore claim and release bus before requesting transfer via exec_op. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan

[U-Boot] [PATCH v4 07/20] sh: bitops: add hweight*() macros

2019-02-04 Thread Vignesh R
Add hweight*() macros required for moving to new SF layer Signed-off-by: Vignesh R Reviewed-by: Jagan Teki --- arch/sh/include/asm/bitops.h | 4 1 file changed, 4 insertions(+) diff --git a/arch/sh/include/asm/bitops.h b/arch/sh/include/asm/bitops.h index 8cb8385d76db..765f28f116bc

[U-Boot] [PATCH v4 06/20] spi: Add non DM version of SPI_MEM

2019-02-04 Thread Vignesh R
Add non DM version of SPI_MEM to support easy migration to new SPI NOR framework. This can be removed once DM_SPI conversion is complete. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur Reviewed-by: Jagan Teki Tested-by: Jagan Teki

[U-Boot] [PATCH v4 04/20] spi: spi-mem: Extend spi_mem_adjust_op_size() to honor max xfer size

2019-02-04 Thread Vignesh R
Extend spi_mem_adjust_op_size() to take spi->max_write_size and spi->max_read_size into account. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur Reviewed-by: Jagan Teki Tested-by: Jagan Teki #zynq-microzed --- drivers/spi/spi

[U-Boot] [PATCH v4 02/20] bitops: Fix GENMASK definition for Sandbox

2019-02-04 Thread Vignesh R
CONFIG_SANDBOX_BITS_PER_LONG which is set to 64/32 based on the host machine on which its being compiled. Without this patch: GENMASK(14,0) => 0x7fff After this patch: GENMASK(14,0) => 0x7fff Signed-off-by: Vignesh R Reviewed-by: Simon Glass --- Note: this patch is merged to u-boot-dm.git at

[U-Boot] [PATCH v4 03/20] spi: spi-mem: Allow use of spi_mem_exec_op for all SPI modes

2019-02-04 Thread Vignesh R
SPI controllers support all types of SPI modes including dual/quad bus widths. Therefore remove constraint wrt SPI mode from spi-mem layer. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur Reviewed-by: Jagan Teki Tested-by: Jagan Teki

[U-Boot] [PATCH v4 01/20] configs: Move CONFIG_SPI_FLASH into defconfigs

2019-02-04 Thread Vignesh R
Completely move CONFIG_SPI_FLASH from remaining board header files to defconfigs Signed-off-by: Vignesh R Reviewed-by: Jagan Teki Tested-by: Jagan Teki #zynq-microzed --- configs/cgtqmx6eval_defconfig| 1 + configs/chromebit_mickey_defconfig | 1 + configs

[U-Boot] [PATCH v4 00/20] SF: Migrate to Linux SPI NOR framework

2019-02-04 Thread Vignesh R
her platforms. Complete series with dependencies here[1] [1] https://github.com/r-vignesh/u-boot.git branch: spi-nor-mig-patch-v4 Vignesh R (20): configs: Move CONFIG_SPI_FLASH into defconfigs bitops: Fix GENMASK definition for Sandbox spi: spi-mem: Allow use of spi_mem_exec_op for all SPI mo

Re: [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-02-01 Thread Vignesh R
[...] >>> Yes, zynq qspi ia unable to handle larger than 16MiB flashes so we used >>> BAR to access those. >>> >> >> I wonder how those boards work in kernel that does not support BAR. >> Anyways, if you provide a list of SPI controllers on zynq SoCs, I will >> add an imply SPI_FLASH_BAR for such

Re: [U-Boot] [PATCH v3 16/20] mtd: spi: Add lightweight SPI flash stack for SPL

2019-02-01 Thread Vignesh R
On 01-Feb-19 9:18 PM, Jagan Teki wrote: > On Thu, Jan 31, 2019 at 11:20 PM Vignesh R wrote: >> [...] >>> >>> This doesn't look good to me, this change is part of 08/20 and now it >>> removed. better do the same change in 08/20 by adding new file >>>

Re: [U-Boot] [PATCH v3 00/20] SF: Migrate to Linux SPI NOR framework

2019-02-01 Thread Vignesh R
On 31/01/19 8:15 PM, Jagan Teki wrote: > On Thu, Jan 31, 2019 at 8:12 PM Tom Rini wrote: >> >> On Thu, Jan 31, 2019 at 08:10:53PM +0530, Jagan Teki wrote: >>> On Tue, Jan 29, 2019 at 11:19 AM Vignesh R wrote: >>>> >>>> Here is the v3 of

Re: [U-Boot] [PATCH v3 16/20] mtd: spi: Add lightweight SPI flash stack for SPL

2019-01-31 Thread Vignesh R
On 31/01/19 5:36 PM, Jagan Teki wrote: > On Tue, Jan 29, 2019 at 11:29 AM Vignesh R wrote: >> >> Add a tiny SPI flash stack that just supports reading data/images from >> SPI flash. This is useful for boards that have SPL size constraints and >> would need to u

Re: [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-01-31 Thread Vignesh R
On 31/01/19 7:20 PM, Jagan Teki wrote: > On Thu, 31 Jan, 2019, 7:16 PM Vignesh R <mailto:vigne...@ti.com> wrote: > > On 31/01/19 7:06 PM, Jagan Teki wrote: > [...] > >     >>  configs/xilinx_zynqmp_mini_qspi_defconfig       

Re: [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-01-31 Thread Vignesh R
On 31/01/19 7:06 PM, Jagan Teki wrote: [...] > >>  configs/xilinx_zynqmp_mini_qspi_defconfig        | 1 - > >>  configs/xilinx_zynqmp_zc1232_revA_defconfig      | 1 - > >>  configs/xilinx_zynqmp_zc1254_revA_defconfig      | 1 - > >>  configs/xilinx_zynqmp_zc1275_revA_defconfig     

Re: [U-Boot] [PATCH v3 02/20] bitops: Fix GENMASK definition for Sandbox

2019-01-31 Thread Vignesh R
On 31/01/19 6:11 AM, Simon Glass wrote: > On Mon, 28 Jan 2019 at 22:49, Vignesh R wrote: >> >> In arch/sandbox/include/asm/types.h we have >> Therefore for 32 bit Sandbox build BITS_PER_LONG turns out to be 32 as >> CONFIG_PHYS64 is not set >> >> This

Re: [U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-01-31 Thread Vignesh R
On 31/01/19 6:48 PM, Jagan Teki wrote: > On Tue, Jan 29, 2019 at 11:28 AM Vignesh R wrote: >> >> Now that new SPI NOR layer uses stateless 4 byte opcodes by default, >> don't enable SPI_FLASH_BAR. For SPI controllers that cannot support >> 4-byte addressing

Re: [U-Boot] [PATCH v3 14/20] mtd: spi: Switch to new SPI NOR framework

2019-01-31 Thread Vignesh R
On 31/01/19 6:09 PM, Jagan Teki wrote: > On Thu, Jan 31, 2019 at 6:08 PM Vignesh R wrote: >> >> >> >> On 31/01/19 5:53 PM, Jagan Teki wrote: >>> On Tue, Jan 29, 2019 at 11:28 AM Vignesh R wrote: >>>> >>>> Switch spi_flash_* interface

Re: [U-Boot] [PATCH v3 14/20] mtd: spi: Switch to new SPI NOR framework

2019-01-31 Thread Vignesh R
On 31/01/19 5:53 PM, Jagan Teki wrote: > On Tue, Jan 29, 2019 at 11:28 AM Vignesh R wrote: >> >> Switch spi_flash_* interfaces to call into new SPI NOR framework via MTD >> layer. Fix up sf_dataflash to work in legacy way. And update sandbox to >> use new interfaces/d

Re: [U-Boot] [PATCH v3 00/20] SF: Migrate to Linux SPI NOR framework

2019-01-29 Thread Vignesh R
On 29/01/19 1:45 PM, Simon Goldschmidt wrote: > On Tue, Jan 29, 2019 at 6:49 AM Vignesh R wrote: >> >> Here is the v3 of SPI NOR migration(github branch at [1]). I have >> retained Tested-by from v2 as this is just re split of patches and >> minor fixups. > &g

[U-Boot] [PATCH v3 2/7] soc: ti: k3: add navss ringacc driver

2019-01-28 Thread Vignesh R
this way because, Linux driver implements two stage Rings allocation and configuration (allocate ring and configure ring) while TI-SCI Message Protocol supports only one combined operation (allocate+configure). Signed-off-by: Grygorii Strashko Signed-off-by: Vignesh R --- drivers/Kconfig

[U-Boot] [PATCH v3 3/7] soc: ti: k3: add CPPI5 description and helpers

2019-01-28 Thread Vignesh R
From: Grygorii Strashko Add TI Communications Port Programming Interface (CPPI) 5 interface description and helpers Signed-off-by: Grygorii Strashko Signed-off-by: Vignesh R --- include/linux/soc/ti/cppi5.h | 995 +++ 1 file changed, 995 insertions(+) create

[U-Boot] [PATCH v3 5/7] soc: keystone: Merge into TI specific directory

2019-01-28 Thread Vignesh R
Merge drivers/soc/keystone/ into drivers/soc/ti/ and convert CONFIG_TI_KEYSTONE_SERDES into Kconfig. Signed-off-by: Vignesh R --- arch/arm/mach-keystone/Kconfig | 8 drivers/soc/Makefile | 1 - drivers/soc/keystone/Makefile | 3

[U-Boot] [PATCH v3 6/7] arm64: dts: ti: k3-am65: add mcu navss nodes

2019-01-28 Thread Vignesh R
From: Grygorii Strashko Add DT node for MCU NAVSS its components to get DMA working on AM654 SoC. Signed-off-by: Grygorii Strashko Signed-off-by: Vignesh R --- arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 46 1 file changed, 46 insertions(+) diff --git a/arch/arm/dts

[U-Boot] [PATCH v3 1/7] firmware: ti_sci: Add support for NAVSS resource management

2019-01-28 Thread Vignesh R
firmware. Signed-off-by: Peter Ujfalusi Signed-off-by: Grygorii Strashko Reviewed-by: Tom Rini Signed-off-by: Vignesh R --- arch/arm/dts/k3-am65-wakeup.dtsi | 2 +- drivers/firmware/ti_sci.c | 760 - drivers/firmware/ti_sci.h | 642

[U-Boot] [PATCH v3 0/7] AM65x: Add DMA support

2019-01-28 Thread Vignesh R
: am65x_evm_a53: Enable DMA related configs Vignesh R (2): dma: ti: add driver to K3 UDMA soc: keystone: Merge into ti specific directory arch/arm/dts/k3-am65-wakeup.dtsi |2 +- arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 46 + arch/arm/mach-keystone/Kconfig|8

[U-Boot] [PATCH v3 7/7] configs: am65x_evm_a53: Enable DMA related configs

2019-01-28 Thread Vignesh R
From: Grygorii Strashko Enable TI K3 AM65x PSI-L, Ring Accelerator and UDMA drivers Signed-off-by: Grygorii Strashko Signed-off-by: Vignesh R --- configs/am65x_evm_a53_defconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configs/am65x_evm_a53_defconfig b/configs

[U-Boot] [PATCH v3 16/20] mtd: spi: Add lightweight SPI flash stack for SPL

2019-01-28 Thread Vignesh R
of reducing spi flash id table by Simon Goldschmidt Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur --- common/spl/Kconfig | 11 +- drivers/mtd/spi/Makefile | 10 +- drivers/mtd/spi/sf_internal.h | 2 + drivers/mtd/spi

[U-Boot] [PATCH v3 4/7] dma: ti: add driver to K3 UDMA

2019-01-28 Thread Vignesh R
Signed-off-by: Vignesh R --- drivers/dma/Kconfig |2 + drivers/dma/Makefile |2 + drivers/dma/ti/Kconfig| 14 + drivers/dma/ti/Makefile |3 + drivers/dma/ti/k3-udma-hwdef.h| 184 +++ drivers/dma/ti/k3-udma.c | 1737

[U-Boot] [PATCH v3 18/20] configs: Remove SF_DUAL_FLASH

2019-01-28 Thread Vignesh R
SF_DUAL_FLASH claims to enable support for SF_DUAL_STACKED_FLASH and SF_DUAL_PARALLEL_FLASH. But, in current U-Boot code, grepping for above enums yield no user and therefore support seems to be incomplete. Remove these configs so as to avoid confusion. Signed-off-by: Vignesh R --- configs

[U-Boot] [PATCH v3 13/20] mtd: spi: sf_probe: Add "jedec, spi-nor" compatible string

2019-01-28 Thread Vignesh R
Linux uses "jedec,spi-nor" as compatible string for JEDEC compatible SPI Flash device nodes. Therefore make U-Boot also to look for the same compatible string so that we can use Linux DTS files as is. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roe

[U-Boot] [PATCH v3 19/20] configs: Don't use SPI_FLASH_BAR as default

2019-01-28 Thread Vignesh R
. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur --- arch/arm/mach-omap2/am33xx/Kconfig | 1 - configs/alt_defconfig| 1 - configs/am57xx_evm_defconfig | 1 - configs

[U-Boot] [PATCH v3 12/20] mtd: spi: spi-nor-core: Add back U-Boot specific features

2019-01-28 Thread Vignesh R
For legacy reasons, we will have to keep around U-Boot specific SPI_FLASH_BAR and SPI_TX_BYTE. Add them back to the new framework Signed-off-by: Vignesh R --- drivers/mtd/spi/spi-nor-core.c | 162 - include/linux/mtd/spi-nor.h| 9 ++ 2 files changed, 168

[U-Boot] [PATCH v3 20/20] MAINTAINERS: Add an entry for SPI NOR

2019-01-28 Thread Vignesh R
Add myself as co-maintainer for U-Boot SPI NOR subsystem. Signed-off-by: Vignesh R --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 33f1127e50a4..e06089133731 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -668,6 +668,15 @@ F: drivers

[U-Boot] [PATCH v3 15/20] mtd: spi: Remove unused files

2019-01-28 Thread Vignesh R
spi_flash and spi_flash_ids are no longer needed after SPI NOR migration. Remove them. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur --- drivers/mtd/spi/spi_flash.c | 1337 --- drivers/mtd/spi

[U-Boot] [PATCH v3 17/20] spl: Kconfig: Enable SPI_FLASH_TINY by default for SPL

2019-01-28 Thread Vignesh R
SPI_FLASH_BAR, SPI_FLASH_TINY is not enabled for boards with SPI controllers that cannot support 4 byte addressing. Signed-off-by: Vignesh R --- common/spl/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/common/spl/Kconfig b/common/spl/Kconfig index 416f5933b0d9..39a38a138b6b 100644

[U-Boot] [PATCH v3 14/20] mtd: spi: Switch to new SPI NOR framework

2019-01-28 Thread Vignesh R
Switch spi_flash_* interfaces to call into new SPI NOR framework via MTD layer. Fix up sf_dataflash to work in legacy way. And update sandbox to use new interfaces/definitions Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur --- drivers

[U-Boot] [PATCH v3 11/20] mtd: spi: spi-nor-core: Add SFDP support

2019-01-28 Thread Vignesh R
Sync Serial Flash Discoverable Parameters (SFDP) parsing support from Linux. This allows auto detection and configuration of Flash parameters. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur --- common/spl/Kconfig | 13

[U-Boot] [PATCH v3 08/20] mtd: spi: Port SPI NOR framework from Linux

2019-01-28 Thread Vignesh R
So, sync SPI NOR framework from Linux v4.19 that supports all the above features. Start with basic sync up that brings in basic framework subsequent commits will bring in more features. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur --- Ja

[U-Boot] [PATCH v3 06/20] spi: Add non DM version of SPI_MEM

2019-01-28 Thread Vignesh R
Add non DM version of SPI_MEM to support easy migration to new SPI NOR framework. This can be removed once DM_SPI conversion is complete. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur --- drivers/spi/Kconfig| 4 +- drivers

[U-Boot] [PATCH v3 04/20] spi: spi-mem: Extend spi_mem_adjust_op_size() to honor max xfer size

2019-01-28 Thread Vignesh R
Extend spi_mem_adjust_op_size() to take spi->max_write_size and spi->max_read_size into account. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur --- drivers/spi/spi-mem.c | 19 +++ 1 file changed, 19 insertions(+)

[U-Boot] [PATCH v3 09/20] mtd: spi: spi-nor-core: Add SPI MEM support

2019-01-28 Thread Vignesh R
controllers with MMIO interface. SPI MEM layer takes care of translating spi_mem_ops to spi_xfer()s in case of legacy SPI controllers. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur --- drivers/mtd/spi/spi-nor-core.c | 97

[U-Boot] [PATCH v3 07/20] sh: bitops: add hweight*() macros

2019-01-28 Thread Vignesh R
Add hweight*() macros required for moving to new SF layer Signed-off-by: Vignesh R --- arch/sh/include/asm/bitops.h | 4 1 file changed, 4 insertions(+) diff --git a/arch/sh/include/asm/bitops.h b/arch/sh/include/asm/bitops.h index 8cb8385d76db..765f28f116bc 100644 --- a/arch/sh/include

[U-Boot] [PATCH v3 05/20] spi: spi-mem: Claim SPI bus before spi mem access

2019-01-28 Thread Vignesh R
It is necessary to call spi_claim_bus() before starting any SPI transactions and this restriction would also apply when calling spi-mem operations. Therefore claim and release bus before requesting transfer via exec_op. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan

[U-Boot] [PATCH v3 10/20] mtd: spi: spi-nor-core: Add 4 Byte addressing support

2019-01-28 Thread Vignesh R
Sync changes from Linux SPI NOR framework to add 4 byte addressing support. This is required in order to support flashes like MT35x that no longer support legacy Bank Address Register(BAR) way of accessing >16MB region. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Ste

[U-Boot] [PATCH v3 02/20] bitops: Fix GENMASK definition for Sandbox

2019-01-28 Thread Vignesh R
CONFIG_SANDBOX_BITS_PER_LONG which is set to 64/32 based on the host machine on which its being compiled. Without this patch: GENMASK(14,0) => 0x7fff After this patch: GENMASK(14,0) => 0x7fff Signed-off-by: Vignesh R --- include/linux/bitops.h | 5 + 1 file changed, 5 insertions(+) diff

[U-Boot] [PATCH v3 03/20] spi: spi-mem: Allow use of spi_mem_exec_op for all SPI modes

2019-01-28 Thread Vignesh R
SPI controllers support all types of SPI modes including dual/quad bus widths. Therefore remove constraint wrt SPI mode from spi-mem layer. Signed-off-by: Vignesh R Tested-by: Simon Goldschmidt Tested-by: Stefan Roese Tested-by: Horatiu Vultur --- drivers/spi/spi-mem.c | 9 - 1 file

[U-Boot] [PATCH v3 00/20] SF: Migrate to Linux SPI NOR framework

2019-01-28 Thread Vignesh R
ion to defconfigs [2] [1] https://github.com/r-vignesh/u-boot.git branch: spi-nor-mig-patch-v3 [2] https://patchwork.ozlabs.org/patch/1007485/ Vignesh R (20): configs: Move CONFIG_SPI_FLASH into defconfigs bitops: Fix GENMASK definition for Sandbox spi: spi-mem: Allow use of spi_mem_exec_op for all

[U-Boot] [PATCH v3 01/20] configs: Move CONFIG_SPI_FLASH into defconfigs

2019-01-28 Thread Vignesh R
Completely move CONFIG_SPI_FLASH from remaining board header files to defconfigs Signed-off-by: Vignesh R --- configs/cgtqmx6eval_defconfig| 1 + configs/chromebit_mickey_defconfig | 1 + configs/chromebook_jerry_defconfig | 1 + configs/chromebook_minnie_defconfig

Re: [U-Boot] [PATCH v2 04/11] mtd: spi: Port SPI NOR framework from Linux

2019-01-28 Thread Vignesh R
ts by you and Simon on this version. [1] https://github.com/r-vignesh/u-boot.git branch: spi-nor-mig-patch-v3 Let me know if there are any additional comments. Thanks for the review! > On Fri, Dec 21, 2018 at 12:15 PM Vignesh R wrote: >> >> Current U-Boot SPI NOR support (sf

Re: [U-Boot] [PATCH 03/16] spi: Add non DM version of SPI_MEM

2019-01-28 Thread Vignesh R
On 28/01/19 12:27 PM, Jagan Teki wrote: > On Wed, Dec 12, 2018 at 11:08 PM Vignesh R wrote: >> >> Add non DM version of SPI_MEM to support easy migration to new SPI NOR >> framework. This can be removed once DM_SPI conversion is complete. >> >> Signed-off-by:

Re: [U-Boot] [PATCH v2 01/11] spi-mem: Claim SPI bus before spi mem access

2019-01-28 Thread Vignesh R
On 28/01/19 12:24 PM, Jagan Teki wrote: > On Fri, Dec 21, 2018 at 12:08 PM Vignesh R wrote: >> >> It is necessary to call spi_claim_bus() before starting any SPI >> transactions and this restriction would also apply when calling spi-mem >> operationss. Therefore c

Re: [U-Boot] [PATCH 2/3] spi: Add support for the Aspeed ast2500 SPI controllers

2019-01-26 Thread Vignesh R
Hi Cédric, On 25/01/19 11:30 PM, Boris Brezillon wrote: > +Vignesh > [...] >> The first is about performing direct accesses on the AHB window on which >> the flash contents is mapped. > > We have introduced the dirmap API/interface exactly for this purpose, > and the SPI NOR layer will use it

Re: [U-Boot] [PATCH v2 09/11] configs: Remove SF_DUAL_FLASH

2019-01-25 Thread Vignesh R
On 25/01/19 8:17 PM, Jagan Teki wrote: > On Fri, Dec 21, 2018 at 12:18 PM Vignesh R wrote: >> >> SF_DUAL_FLASH claims to enable support for SF_DUAL_STACKED_FLASH and >> SF_DUAL_PARALLEL_FLASH. But, in current U-Boot code, grepping for above >> enums yield no user

Re: [U-Boot] [PATCH] configs: Move CONFIG_SPI_FLASH into defconfigs

2019-01-25 Thread Vignesh R
On 04/12/18 2:15 PM, Vignesh R wrote: > Completely move CONFIG_SPI_FLASH from remaining board header files to > defconfigs > > Signed-off-by: Vignesh R > --- > Done with the help of moveconfig.py. Compile tested on travis-ci: > https://travis-ci.org/r-vignesh/u-boot/builds

Re: [U-Boot] [PATCH 4/6] dma: ti: add driver to K3 UDMA

2019-01-25 Thread Vignesh R
On 23/01/19 7:26 PM, Tom Rini wrote: > On Wed, Jan 23, 2019 at 07:13:11PM +0530, Vignesh R wrote: >> Tom, >> >> On 23/01/19 4:05 PM, Peter Ujfalusi wrote: >>> Tom, >>> >>> On 22/01/2019 20.56, Tom Rini wrote: >>>> On Tue, Jan 22, 2019

  1   2   3   4   5   6   7   >