El Wed, Nov 08, 2023 at 10:59:13AM -0500, Sean Anderson deia:
>
> OK, what about
>
> @offset: Offset to read from in bytes. This must be a multiple of
> @load->bl_len.
>
> --Sean
Great. Thank you.
El Mon, Nov 06, 2023 at 08:54:03AM -0500, Sean Anderson deia:
> On 11/6/23 07:35, Xavier Drudis Ferran wrote:
> > Thanks for your work. I'm still reading... but...
> >
> >
> > El Sun, Nov 05, 2023 at 09:25:46PM -0500, Sean Anderson deia:
> > > diff -
Thanks for your work. I'm still reading... but...
El Sun, Nov 05, 2023 at 09:25:46PM -0500, Sean Anderson deia:
> diff --git a/include/spl.h b/include/spl.h
> index 951e136b9ea..ecfc50e0095 100644
> --- a/include/spl.h
> +++ b/include/spl.h
> @@ -297,10 +297,10 @@ struct spl_load_info {
>
uchardt
Reviewed-by: Xavier Drudis Ferran
> ---
> doc/arch/arm64.ffa.rst | 20 ++--
> doc/board/AndesTech/ae350.rst | 2 +-
> doc/board/actions/cubieboard7.rst | 4 ++--
> doc/board/actions/index.rst| 2 +-
> doc/boa
El Mon, Oct 23, 2023 at 10:21:52AM +0200, Heinrich Schuchardt deia:
>
> We will need separate patches for LGPL-2.0+ and LGPL-2.1+, too.
>
That'd be for LGPL-2.1+
The only case of LGPL-2.0+ in code is included in the patch you sent.
Well, there's another appearance of LGPL-2.0+ in
El Sun, Oct 22, 2023 at 07:47:07PM +0200, Heinrich Schuchardt deia:
> diff --git a/drivers/sound/tegra_ahub.c b/drivers/sound/tegra_ahub.c
> index 495a29c513..28f392504d 100644
> --- a/drivers/sound/tegra_ahub.c
> +++ b/drivers/sound/tegra_ahub.c
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier:
El Wed, Oct 11, 2023 at 09:56:20PM -0400, Sean Anderson deia:
> This add some basic functions to create images, and a test for said
> functions. This is not intended to be a test of the image parsing
> functions, but rather a framework for creating minimal images for testing
> load methods. That
d clk_release_all()")
> Signed-off-by: Eugen Hristev
Reviewed-by: Xavier Drudis Ferran
> ---
> drivers/clk/clk-uclass.c | 7 ---
> include/clk.h| 4 ++--
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clk/clk-uclass.
El Wed, Sep 06, 2023 at 02:25:11PM +0200, Heinrich Schuchardt deia:
> spl_blk_load_image() should not return an uninitialized value if
> blk_get_devnum_by_uclass_id() fails.
>
> Fixes: 8ce6a2e17577 ("spl: blk: Support loading images from fs")
> Reported-by: Xavier Drudis
El Tue, Sep 05, 2023 at 11:02:44AM -0400, Sean Anderson deia:
> On 9/4/23 08:59, Xavier Drudis Ferran wrote:
> > El Sun, Sep 03, 2023 at 08:17:26AM +, Jonas Karlman deia:
> >
> >> > Fundamentally, we can't really deal with unaligned images without a
> >&
El Mon, Sep 04, 2023 at 02:20:21PM +0200, Fabrice Gasnier deia:
> Make usage of clock and reset bulk API in order to simplify the code
>
> Reviewed-by: Marek Vasut
Reviewed-by: Xavier Drudis Ferran
Sorry. I don't know why I used the wrong address before.
> Signed-off-by: Fab
El Sun, Sep 03, 2023 at 08:17:26AM +, Jonas Karlman deia:
> > Fundamentally, we can't really deal with unaligned images without a
> > bounce-buffer. The method used by SPL_LOAD_FIT_IMAGE_BUFFER_SIZE will
> > continue working, since we call into the FIT routines to load the image.
Yes
> > I
El Mon, Sep 04, 2023 at 11:25:06AM +0200, Fabrice Gasnier deia:
>
> IMHO, the OHCI should have failed too in this example, instead of
> silently ignoring the error. Hopefully it has probed.
>
> The clk_get_bulk() code does a similar job compared to ohci current
> code. It counts all clock
Is the change of behaviour intended when a clock or reset is not found ?
(see below)
El Wed, Aug 30, 2023 at 10:01:49AM +0200, Fabrice Gasnier deia:
> Make usage of clock and reset bulk API in order to simplify the code
>
> Signed-off-by: Fabrice Gasnier
> ---
>
>
El Mon, Jul 31, 2023 at 06:43:02PM -0400, Sean Anderson deia:
> This converts the spi load method to use spl_load. As a consequence, it
> also adds support for LOAD_FIT_FULL.
>
> Signed-off-by: Sean Anderson
> ---
>
> Changes in v5:
> - Rework to load header in spl_load
>
>
El Mon, Jul 31, 2023 at 06:43:01PM -0400, Sean Anderson deia:
> This converts the semihosting load method to use spl_load. As a result, it
> also adds support for LOAD_FIT_FULL and IMX images.
>
> Signed-off-by: Sean Anderson
> ---
>
> Changes in v5:
> - Rework to load header in spl_load
>
>
El Mon, Jul 31, 2023 at 06:43:00PM -0400, Sean Anderson deia:
> This converts the nor load method to use spl_load. As a result it also
> adds support for LOAD_FIT_FULL.
>
> Signed-off-by: Sean Anderson
> ---
>
> Changes in v5:
> - Rework to load header in spl_load
>
> common/spl/spl_nor.c |
El Mon, Jul 31, 2023 at 06:42:59PM -0400, Sean Anderson deia:
> This converts the blk load method (used exclusively by NVMe) to use
> spl_load. As a consequence, it also adds support for LOAD_FIT_FULL and
> IMX images.
>
> Signed-off-by: Sean Anderson
> ---
>
> Changes in v5:
> - New
>
>
El Mon, Jul 31, 2023 at 06:42:57PM -0400, Sean Anderson deia:
> This converts the mmc loader to spl_load. Legacy images are handled by
> spl_load (via spl_parse_image_header), so mmc_load_legacy can be
> omitted.
>
Yes. I haven't used the legacy case, but by looking at the code, it
seems to me
El Mon, Jul 31, 2023 at 06:42:56PM -0400, Sean Anderson deia:
> This converts the fat loader to use spl_load. Some platforms are very
> tight on space, so we take care to only include the code we really need.
>
> Signed-off-by: Sean Anderson
> ---
>
> Changes in v5:
> - Rework to load header in
El Fri, Jun 30, 2023 at 05:41:40PM +0530, Manoj Sai deia:
> If GZIP Compression support is enabled, GZIP compressed U-Boot raw binary will
> be at a specified RAM location which is defined at
> UBOOT_COMPRESSED_BINARY_FIT_USER_DEF_ADDR and will be assign it as
> the source address.
>
> gunzip
tionality (like UCLASS_BLK and
UCLASS_BOOTDEV are now).
Signed-off-by: Xavier Drudis Ferran
Reviewed-by: Simon Glass
Reviewed-by: Marek Vasut
Tested-by: Marek Vasut
---
v2: added UCLASS_BOOTDEV check (discussion of v1 dried up without much
evident consensus, so hopefully Simon Glass likes i
El Tue, Jun 20, 2023 at 11:03:57AM +0100, Simon Glass deia:
> Hi Xavier,
>
Hi Simon,
> >
> > It is also possible that one day a device that is not UCLASS_BLK,
> > UCLASS_BOOTDEV or UCLASS_USB_EMUL is put as children of a usb storage
> > device (just imagine a future system similar to bootstd for
El Tue, Jun 20, 2023 at 11:49:36AM +0200, Marek Vasut deia:
>
> Default, see:
> $ git grep CONFIG_BOOTCOMMAND configs/
>
I'm lost.
I called default what Kconfig used as default.
You seem to call default what's in board specific config files.
Whatever. Fix the wording in the commit message if
El Mon, Jun 19, 2023 at 11:49:18PM +0200, Marek Vasut deia:
> On 6/19/23 12:12, Xavier Drudis Ferran wrote:
>
> It seems the email addresses are being constantly corrupted in each email.
> This time the ML address is wrong and missing an e at the end. There is some
> e@ nonexisten
El Tue, Jun 20, 2023 at 02:50:48AM +0200, Marek Vasut deia:
> On 6/13/23 08:52, Xavier Drudis Ferran wrote:
> >
> > U-Boot TPL 2023.07-rc2-00144-g497967f1ee (Jun 12 2023 - 11:15:47)
>
> Next is already at rc4 , what's this rc2 ?
It's a test I did last week (June 12th).
El Mon, Jun 19, 2023 at 02:58:50PM +0530, Jagan Teki deia:
> On Mon, Jun 19, 2023 at 2:39 PM Marek Vasut wrote:
> >
> > On 6/19/23 09:24, Xavier Drudis Ferran wrote:
> > > Thanks to Jagan Teki for noting that three functions should be static
> > > and comme
ust abstractions of functionality (like UCLASS_BLK and
UCLASS_BOOTDEV are now).
Signed-off-by: Xavier Drudis Ferran
---
v2: added UCLASS_BOOTDEV check (discussion of v1 dried up without much
evident consensus, so hopefully Simon Glass likes it better now)
[
https://patchwork.ozlabs.org/proj
Thanks to Jagan Teki for noting that three functions should be static
and comments from uclass_clk are redundant.
Signed-off-by: Xavier Drudis Ferran
---
drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 25 +++
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git
El Mon, Jun 19, 2023 at 12:04:51PM +0530, Jagan Teki deia:
>
> Please merge these two asap. Better would these two be part of the
> coming release?
>
How do you mean ?
They're both in master and next now.
see commits:
e81512ac30c154c320b54036919cd3a6f4cc1516
Glass deia:
> Hi Xavier,
>
> On Tue, 13 Jun 2023 at 17:04, Xavier Drudis Ferran wrote:
> >
> > El Tue, Jun 13, 2023 at 03:58:22PM +0100, Simon Glass deia:
> > >
> > > Yes that's right. So 'usb info' should ignore UCLASS_BOOTDEV devices.
> >
> &
El Tue, Jun 13, 2023 at 03:58:22PM +0100, Simon Glass deia:
>
> Yes that's right. So 'usb info' should ignore UCLASS_BOOTDEV devices.
That's a possibility, yes. It should work until someone adds another
device there for some other purpose.
> That is better than checking for the NULL pointer.
>
Ok. New test.
This uses yesterday morning's next branch.
commit 5b589e139620214f
Merge: cc5a940923 32d2461e04
Merge branch 'next_net/phy_connect_dev'
USB2 does not work for rk3399 in next (fixes are in master, thanks),
but USB3 is enough.
I compiled for rock-pi-4-rk3399_defconfig
flashed
El Mon, Jun 12, 2023 at 10:17:38PM +0100, Simon Glass deia:
>
> I'm not sure what is going on here. Which version are you testing? Do
> you have these two commits?
>
> 8c29b73278d6 bootstd: usb: Avoid initing USB twice
> 9fea3a799dde usb: Tidy up the usb_start flag
>
> Regards,
> Simon
Yes, I
Sorry, I replied to Marek only but meant to reply to all.
El Fri, Jun 09, 2023 at 03:20:33AM +0200, Marek Vasut deia:
> > No. Well, in some tests yes and some no, but I got the error in all cases.
>
> This is doubtful. It is mandatory to run 'usb start' or 'usb reset' before
> you would get any
El Thu, Jun 08, 2023 at 12:05:18AM +0200, Marek Vasut deia:
> On 6/5/23 17:20, Xavier Drudis Ferran wrote:
> > Add a check to avoid dommed (by null pointer dereference) recursive
> > call, not only for UCLASS_BLK.
> >
> > When booting my Rock Pi 4B+ with a USB
El Wed, Jun 07, 2023 at 11:42:40PM +0200, Marek Vasut deia:
> On 6/5/23 17:04, Xavier Drudis Ferran wrote:
> > EHCI probing in Rock pi 4 currently fails.
> >
> > Add a clock driver for usb2phy so that probing EHCI does not fail when
> > missing one of the clocks in th
El Tue, Jun 06, 2023 at 10:39:16PM +0530, Jagan Teki deia:
> USB2.0 Host and OTG controllers in RK3328 are using USB2PHY.
>
> Add support for it.
>
> Signed-off-by: Jagan Teki
Reviewed-by: Xavier Drudis Ferran
(fwiw, I just compared it with linux)
I just wanted to note this p
El Mon, Jun 05, 2023 at 08:11:07AM +0530, Jagan Teki deia:
> On Sun, Jun 4, 2023 at 1:42 PM Xavier Drudis Ferran wrote:
> >
> > EHCI probing in Rock pi 4 currently fails.
> >
> > Add a clock driver for usb2phy so that probing EHCI does not fail when
> > missin
Maybe we can improve it
later?
Cc: Simon Glass
Cc: Lukasz Majewski
Cc: Marek Vasut
Signed-off-by: Xavier Drudis Ferran
---
cmd/usb.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/cmd/usb.c b/cmd/usb.c
index 73addb04c4..7e6065aa51 100644
--- a/cmd/usb.c
+++ b/cmd/us
ph Fritz
Cc: Jagan Teki
Signed-off-by: Xavier Drudis Ferran
---
V7: improve error handling. Call device_chld_unbind() on error.
Remove unnecessary if.
v6: just retested over current next branch and some corrections
to message and headers
(no changes to code).
---
dr
/project/uboot/patch/Y5IWpjYLB4aXMy9o@localhost/
Cc: Simon Glass
Cc: Philipp Tomsich
Cc: Kever Yang
Cc: Lukasz Majewski
Cc: Sean Anderson
Cc: Marek Vasut
Cc: Christoph Fritz
Cc: Jagan Teki
Signed-off-by: Xavier Drudis Ferran
---
v7: add clkout_ctl values for rk3568 (from linux
EHCI probing in Rock pi 4 currently fails.
Add a clock driver for usb2phy so that probing EHCI does not fail when
missing one of the clocks in the bundle for usb_host0_ehci, since
usb2phy is UCLASS_PHY but not UCLASS_CLK.
Xavier Drudis Ferran (2):
phy: rockchip-inno-usb2: Add usb2phy clock
Thanks for looking at this.
El Sun, Jun 04, 2023 at 11:33:21AM +0200, Marek Vasut deia:
> > diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> > b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> > index 2f31350134..451841b025 100644
> > ---
Thanks for your feedback.
El Sun, Jun 04, 2023 at 11:31:28AM +0200, Marek Vasut deia:
> > diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> > b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> > index 55e1dbcfef..2f31350134 100644
> > ---
El Sat, Jun 03, 2023 at 09:23:36AM +0200, Xavier Drudis Ferran deia:
> El Fri, Jun 02, 2023 at 03:34:37PM +0530, Jagan Teki deia:
> > On Fri, Jun 2, 2023 at 2:54 PM Xavier Drudis Ferran
> > wrote:
> > >
> > > Should I try again with the current next branch a
/project/uboot/patch/Y5IWpjYLB4aXMy9o@localhost/
Cc: Simon Glass
Cc: Philipp Tomsich
Cc: Kever Yang
Cc: Lukasz Majewski
Cc: Sean Anderson
Cc: Marek Vasut
Cc: Christoph Fritz
Cc: Jagan Teki
Signed-off-by: Xavier Drudis Ferran
---
v6: just retested over current next branch and some
Cc: Christoph Fritz
Cc: Jagan Teki
Signed-off-by: Xavier Drudis Ferran
---
drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
b/drivers/phy/rockchip/phy-rockchip
EHCI probing in Rock pi 4 currently fails.
Add a clock driver for usb2phy so that probing EHCI does not fail when
missing one of the clocks in the bundle for usb_host0_ehci, since
usb2phy is UCLASS_PHY but not UCLASS_CLK.
Xavier Drudis Ferran (2):
arm: dts: rockchip: rk3399: usb: ehci: Fix
El Fri, Jun 02, 2023 at 03:34:37PM +0530, Jagan Teki deia:
> On Fri, Jun 2, 2023 at 2:54 PM Xavier Drudis Ferran wrote:
> >
> > Should I try again with the current next branch and send v6 ?
>
> Please send.
>
> Thanks,
> Jagan.
I will try asap, thanks.
El Fri, Jun 02, 2023 at 12:11:13PM +0530, Jagan Teki deia:
>
> Any news about the next revision of this patch? RK3399 has broken
> since release due to this issue. This fix might make upcoming release
> workable.
>
> Please let us know.
>
Sorry, I'm not sure you meant to send this to me ?
For
El Wed, Mar 08, 2023 at 01:59:54PM +0200, Eugen Hristev deia:
> On 3/8/23 13:30, Xavier Drudis Ferran wrote:
> > El Fri, Mar 03, 2023 at 09:31:33AM +0200, Eugen Hristev deia:
> > > @@ -105,6 +130,17 @@ static int rockchip_usb2phy_power_off(struct phy
> > > *phy)
>
be correctly in patchwork, should I resend ?
I guess I messed up subject lines ?
I think there are other rk3399 boards that have similar .dtsi files,
but I haven't investigated thoroughly. Do they all have broken EHCI ?
If someone has a rk3399 board with working EHCI maybe they should test
your patch and try usb start ; usb stop and usb start ; usb reset ?
[1] https://lists.denx.de/pipermail/u-boot/2023-February/510672.html
Thanks,
--
Xavier Drudis Ferran
I'm sorry but I haven't been able to reproduce your issue.
El Fri, Mar 03, 2023 at 11:26:46AM +0100, Xavier Drudis Ferran deia:
> El Fri, Mar 03, 2023 at 10:42:20AM +0100, Christoph Fritz deia:
>
> Unfortunately I don't think I have any usb-ethernet dongle here to test...
>
[...
El Fri, Mar 03, 2023 at 10:42:20AM +0100, Christoph Fritz deia:
> > Changes:
> >
> > v5: fixes a bug that Christoph Fritz discovered, consisting in the
> > wrong eror code returned when enabling or disabling the clock
> > because property_enable() returns an error code in
: Lukasz Majewski
Cc: Sean Anderson
Cc: Marek Vasut
Signed-off-by: Xavier Drudis Ferran
---
v5: ignores the return value from property_enable() which is not
an error code in U-Boot (unlike in linux). This avoid a false
failure of rockchip_usb2phy_clk_disable() that interfered
Majewski
Cc: Sean Anderson
Cc: Marek Vasut
Cc: Christoph Fritz
Signed-off-by: Xavier Drudis Ferran
---
drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
b/drivers/phy/ro
c: Sean Anderson
Cc: Marek Vasut
Cc: Christoph Fritz
Signed-off-by: Xavier Drudis Ferran
---
Changes:
v5: fixes a bug that Christoph Fritz discovered, consisting in the
wrong eror code returned when enabling or disabling the clock
because property_enable() returns an erro
output
clock is correctly enabled or disabled when everything seems to work
fine already without enabling it, but it needs to be enabled simply
because of a dts coming from linux where it seems to have effects on
suspend/resume.
Thanks,
--
Xavier Drudis Ferran
El Tue, Jan 24, 2023 at 09:07:58AM +0100, Patrice CHOTARD deia:
> Hi Marek
>
> On 1/23/23 23:32, Marek Vasut wrote:
> > In case CONFIG_DM_RESET=n, reset_get_bulk() returns -ENOTSUPP.
> > Do not fail in that case either. This is a valid use case, e.g.
> > in case the reset driver is a no-op and
El Sun, Dec 11, 2022 at 06:20:41AM +0100, Marek Vasut deia:
> On 12/9/22 16:47, Xavier Drudis Ferran wrote:
> > This clock has no users but appears in a phandle list used by
> > ehci-generic.c to bulk enable it. The phandle list comes from linux,
> > where it is needed for s
/patch/Y5IWpjYLB4aXMy9o@localhost/#3018135
Cc: Simon Glass
Cc: Philipp Tomsich
Cc: Kever Yang
Cc: Lukasz Majewski
Cc: Sean Anderson
Cc: Marek Vasut
Signed-off-by: Xavier Drudis Ferran
---
drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 79 ++-
1 file changed, 77
s
Cc: Philipp Tomsich
Cc: Kever Yang
Cc: Lukasz Majewski
Cc: Sean Anderson
Cc: Marek Vasut
Signed-off-by: Xavier Drudis Ferran
---
drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/rockchip/p
Cc: Sean Anderson
Cc: Marek Vasut
Signed-off-by: Xavier Drudis Ferran
---
Changes:
v4: move v3 to one patch in the series and add a second patch
to add operations to enable disable the usb2phy 480Mhz clock.
Also, honour clock-output-names for what is worth.
v3: implement opt
El Thu, Dec 08, 2022 at 09:12:08PM +0100, Marek Vasut deia:
> On 12/8/22 17:53, Xavier Drudis Ferran wrote:
>
> [...]
>
> > +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c
> > @@ -7,7 +7,7 @@
> >*/
> > #include
> > -#include
>
[2]
https://patchwork.ozlabs.org/project/uboot/patch/20220701185959.GC1700@begut/#2954536
[3]
https://patchwork.ozlabs.org/project/uboot/patch/Y44+ayJfUlI08ptM@localhost/#3016099
Cc: Simon Glass
Cc: Philipp Tomsich
Cc: Kever Yang
Cc: Lukasz Majewski
Cc: Sean Anderson
Cc: M
El Thu, Dec 08, 2022 at 08:56:57AM +1300, Simon Glass deia:
> + @tee-SEQ {
> + fit,operation = "split-elf";
> + description = "TEE";
> + type = "tee";
> +
El Mon, Dec 05, 2022 at 08:08:40PM +0100, Marek Vasut deia:
> On 12/5/22 19:54, Xavier Drudis Ferran wrote:
> > 5- Trying to replicate linux and have usb2phy somehow provide a clk,
> > or have a separate clock device for usb2phy in addition to the phy
> > devi
//lkml.kernel.org/lkml/1731551.Q6cHK6n5ZM@phil/T/
[2]
https://patchwork.ozlabs.org/project/uboot/patch/20220701185959.GC1700@begut/#2954536
Cc: Simon Glass
Cc: Philipp Tomsich
Cc: Kever Yang
Cc: Lukasz Majewski
Cc: Sean Anderson
Cc: Marek Vasut
Signed-off-by: Xavier Drudis Ferran
-
El Sat, Aug 27, 2022 at 11:20:17AM +0800, Kever Yang deia:
> The idea for dtsi now is to sync the kernel and U-Boot dts, and Linux
> distribution will
> use the dts from U-Boot. If we change the dts property in -u-boot.dts, it
> will also pass
> to kernel, which make kernel function not available.
El Mon, Aug 08, 2022 at 11:22:49PM +0530, Jagan Teki deia:
>
> If I remember correctly when I work with YouMin on LPDDR4 the initial
> code to start to check with was 50MHz (It was not working at that time
> with 48MHz). Not sure what to make other changes to fix that to try on
> 48MHz.
>
Not
El Sun, Aug 07, 2022 at 04:33:26PM -0600, Simon Glass deia:
> This is an attempt to answer the comments provided by Xavier [1].
>
Thank you. Sorry if I point out silly things too. No agony intended.
>
> +Note that binman can itself can create a FIT. This helps to move mkimage
one "can" too
El Sun, Aug 07, 2022 at 04:44:04PM +0200, Michal Suchánek deia:
> Hello,
>
> when compiled with clock debug rk3399 cannot be booted because memory
> setup code triggers clock assertion:
>
> U-Boot TPL 2022.07-00038-g61e11a8e9f-dirty (Aug 07 2022 - 16:13:17)
> TPL PLL at ff76: fbdiv=50,
El Tue, Aug 02, 2022 at 06:41:40AM -0600, Simon Glass deia:
>
> It seems we need a lot more guidance here. I can help write more into
> the packaging docs, perhaps:
>
> https://u-boot.readthedocs.io/en/latest/develop/package/binman.html#motivation
>
> Can you please suggest a few questions to
El Mon, Aug 01, 2022 at 01:13:27PM -0600, Simon Glass deia:
> >
> > Am I completely lost or does what I want to do make some kind of sense?
>
> Well I still feel that we should handle this properly in binman.
>
I respect your feelings but would you care explaining the goal of binman?
I first
El Tue, Jul 26, 2022 at 09:08:25PM +0200, Xavier Drudis Ferran deia:
> want u-boot.itb it runs binman -a of-list="rk3399-rock-pi-4b.dts
> rockchip-itb-u-boot.dts"
Sorry. I mistook the parameter. That would only generate two config entries and
2 fdts in the .itb image.
W
El Tue, Jul 26, 2022 at 09:15:10PM +0200, Jerome Forissier deia:
>
> > I'm sending a patch below that adds a couple of configuration properties to
> > binman so that split-elf can fill the properties. How many segments are
> > in bl31.elf or optee is not something that we have in CONFIGs, I
};
#ifdef CONFIG_ROCKCHIP_SPI_IMAGE
simple-bin-spi {
filename = "u-boot-rockchip-spi.bin";
pad-byte = <0xff>;
mkimage {
args = "-n", CONFIG_SYS_SOC, "-T", "rkspi";
#ifd
El Tue, Jul 26, 2022 at 02:39:09PM +0530, Pratyush Yadav deia:
>
> Yes, this is indeed a chicken and egg problem of sorts. The octal mode
> soft reset I added is a hack that gets _some_ flashes working but not
> all. I see 3 possible ways to solve this:
>
But it was a hack that solved a
Thank you for your time looking at the patch.
El Tue, Jul 26, 2022 at 12:43:06PM +0530, Pratyush Yadav deia:
>
> Please don't put the changelog in the commit message. Put it below the 3
> dashed lines below.
>
Sorry. Will try to remember it next time. Not sure there's a next version of
this
El Mon, Jul 25, 2022 at 07:29:53PM +0200, Xavier Drudis Ferran deia:
>
> I copy here the rockchip-u-boot.dtsi file and then 2 patches on top of yours.
>
Sorry I copied a dirty version that din't work. The patches were correct, the
dtsi wasn't.
> #else
>
};
#endif
u-boot-spl {
};
};
#ifdef CONFIG_ARM64
#ifdef CONFIG_USE_SPL_FIT_GENERATOR
blob {
filename = "u-boot.itb";
#else
collection {
content = <&/binman/itb>;
#endif
El Mon, Jul 25, 2022 at 12:54:04PM +0200, Quentin Schulz deia:
> You'd need a new binman entry I assume for calling mkenvimage.
>
> It's not a super safe assumption that CONFIG_ENV_OFFSET will be used for
> declaring where the environment is stored. E.g., CONFIG_ENV_OFFSET for Puma
> declares
Note: I removed a few recipients from Cc: with a quite random criteria,
just to avoid error messages from the list software that there were
too many addresses in Cc:. I hope those will get it from the list anyway
and sorry if this is a problem.
> I'm sure I'm just missing out on something
El Fri, Jul 22, 2022 at 01:34:58PM +0200, Quentin Schulz deia:
> From: Quentin Schulz
>
> This migrates the generation of u-boot-rockchip.bin from Makefile to binman
> completely. There is therefore no idbloader.img anymore as it is created on
> the fly by binman.
>
Thanks a lot.
I've tested
El Sat, Jul 23, 2022 at 02:07:30PM +0200, Johan Jonker deia:
>
> > + mkimage {
> > + args = "-n", CONFIG_SYS_SOC, "-T", "rksd";
>
> > +#ifndef CONFIG_TPL
> > + u-boot-spl {
> > + };
> > };
> > +#else
> > +
.
Changed since v2:
- no changes
Changed since v1:
- no changes
Signed-off-by: Xavier Drudis Ferran
Cc: Jagan Teki
---
drivers/spi/spi-mem.c | 34 ++
1 file changed, 26 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi
odes until SNOR_PROTO_1_1_1 works and then remember the reset_proto.
This tries to be useful for other boards, but I still don't know any
other that needs it and what would work there.
Signed-off-by: Xavier Drudis Ferran
Cc: Jagan Teki
Cc: Vignesh R
---
drivers/mtd/spi/spi-nor-c
: Philipp Tomsich
Cc: Kever Yang
Signed-off-by: Xavier Drudis Ferran
---
arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi | 18 ++
configs/rock-pi-4-rk3399_defconfig| 22 ++
2 files changed, 40 insertions(+)
diff --git a/arch/arm/dts/rk3399-rock-pi-4-u-boot.dtsi
-off-by: Xavier Drudis Ferran
Cc: Jagan Teki
Cc: Vignesh R
---
drivers/mtd/spi/spi-nor-ids.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index 4fe8b0d92c..b09df00bab 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers
The Radxa Rock Pi 4 board is sold from revision 1.4 with a soldered
4Mb SPI NOR Flash. This series allows to use it from U-Boot and boot
from it.
This series applies to u-boot/master.
Changes since v2:
- rebased on master
- droped 5th path, and enabled CONFIG_SPL_DM_SEQ_ALIAS instead
The Radxa Rock Pi 4 board is sold from revision 1.4 with a soldered
4Mb SPI NOR Flash. This series allows to use it from U-Boot and boot
from it.
This series applies to u-boot/master.
Changes since v2:
- rebased on master
- droped 5th path, and enabled CONFIG_SPL_DM_SEQ_ALIAS instead
nd boot_devices
> node paths.
>
> Cc: Quentin Schulz
> Signed-off-by: Quentin Schulz
> ---
Tested on a Rock-Pi-4B and didn't see any regression.
Tested-by: Xavier Drudis Ferran
Reviewed-by: Xavier Drudis Ferran
> arch/arm/mach-rockchip/rk3399/rk3399.c | 2 +-
> 1 file
t been consistent, and I'd do it like in this patch,
but I don't feel strongly about any option nor pretend to stop any
discussion.
Tested on a Rock-Pi-4B and didn't see any regression.
Tested-by: Xavier Drudis Ferran
> ---
> arch/arm/mach-rockchip/rk3399/rk3399.c | 4 ++--
> 1 file cha
> no need to do this in the rk3399-specific code, so let's remove it.
>
> Cc: Quentin Schulz
> Signed-off-by: Quentin Schulz
> ---
>
Tested on a Rock-Pi-4B and didn't see any regression.
Tested-by: Xavier Drudis Ferran
> - This patch depends on
> https://lore.ke
ossible loading media for U-Boot proper.
>
> Cc: Quentin Schulz
> Signed-off-by: Quentin Schulz
> ---
>
Tested on a Rock-Pi-4B and didn't see any regression.
Tested-by: Xavier Drudis Ferran
> - RFC because only tested on Puma Haikou RK3399
>
> common/spl/spl.c | 12
with the small correction:
Tested-by: Xavier Drudis Ferran
> Fixes: 07586ee4322a ("rockchip: rk3399: Support common spl_board_init")
> Cc: Quentin Schulz
> Signed-off-by: Quentin Schulz
> ---
>
> v2:
> - use IS_ENABLED checks,
>
> arch/arm/mach-rockc
haven't seen any regression. So, with this small correction:
Tested-by: Xavier Drudis Ferran
> v2:
> - use IS_ENABLED checks,
>
> arch/arm/mach-rockchip/rk3399/rk3399.c | 45 ++
> 1 file changed, 24 insertions(+), 21 deletions(-)
>
> diff --git a/arc
El Mon, Jul 18, 2022 at 01:00:03PM +0200, Michal Suchánek deia:
> mmc@fe31: 3
> mmc@fe32: 1 (SD)
> mmc@fe33: 0 (eMMC)
>
> This is not consistent with any of the above.
>
I agree, but this is mmc, and this thread was about spi.
El Fri, Jul 15, 2022 at 05:09:49PM +0200, Quentin Schulz deia:
> From: Quentin Schulz
>
> The check to perform is on CONFIG_SPL_GPIO and not SPL_GPIO.
> Because this was never compiled in, it missed an include of cru.h that
> was not detected before. Let's include it too.
>
> Also switch to
1 - 100 of 135 matches
Mail list logo
