Re: [PATCH] cmd: mem: fix range of bitflip test

2020-09-09 Thread Ralph Siemsen
Hi Stefan, On Wed, Sep 09, 2020 at 05:13:49PM +0200, Stefan Roese wrote: Usually the RB is only added, when not too many further changes are made by the committer. There is no strict rule here AFAIK. In that case I'll omit your RB on v3 as the change is somewhat larger, and includes the "unr

Re: [PATCH] cmd: mem: fix range of bitflip test

2020-09-09 Thread Stefan Roese
Hi Ralph, On 09.09.20 17:07, Ralph Siemsen wrote: Hi Stefan, On Wed, Sep 09, 2020 at 03:53:08PM +0200, Stefan Roese wrote: Hi Ralph, On 09.09.20 15:49, Ralph Siemsen wrote: Very good, I will send a separate patch that adds a Kconfig option. As it turns out, doing a separate patch for this

Re: [PATCH] cmd: mem: fix range of bitflip test

2020-09-09 Thread Ralph Siemsen
Hi Stefan, On Wed, Sep 09, 2020 at 03:53:08PM +0200, Stefan Roese wrote: Hi Ralph, On 09.09.20 15:49, Ralph Siemsen wrote: Very good, I will send a separate patch that adds a Kconfig option. As it turns out, doing a separate patch for this gets messy, and also would introduce a dependency

Re: [PATCH] cmd: mem: fix range of bitflip test

2020-09-09 Thread Stefan Roese
Hi Ralph, On 09.09.20 15:49, Ralph Siemsen wrote: Hi Stefan, On Wed, Sep 09, 2020 at 03:34:35PM +0200, Stefan Roese wrote: I agree that it's too time consuming (usually) for a manufacturing test. Either you are okay with disabling CONFIG_SYS_ALT_MEMTEST on your board, which will also disable

Re: [PATCH] cmd: mem: fix range of bitflip test

2020-09-09 Thread Ralph Siemsen
Hi Stefan, On Wed, Sep 09, 2020 at 03:34:35PM +0200, Stefan Roese wrote: I agree that it's too time consuming (usually) for a manufacturing test. Either you are okay with disabling CONFIG_SYS_ALT_MEMTEST on your board, which will also disable this bitflip test. Or please continue adding a new K

Re: [PATCH] cmd: mem: fix range of bitflip test

2020-09-09 Thread Stefan Roese
Hi Ralph, On 09.09.20 15:06, Ralph Siemsen wrote: Hi Stefan, On Wed, Sep 09, 2020 at 10:49:29AM +0200, Stefan Roese wrote: Hi Ralph, Thanks for finding and fixing this: I've sent a v2 with the suggested changes. Yes, thanks. Have also noticed that mtest takes considerably longer when doi

Re: [PATCH] cmd: mem: fix range of bitflip test

2020-09-09 Thread Ralph Siemsen
Hi Stefan, On Wed, Sep 09, 2020 at 10:49:29AM +0200, Stefan Roese wrote: Hi Ralph, Thanks for finding and fixing this: I've sent a v2 with the suggested changes. Have also noticed that mtest takes considerably longer when doing the bitflip test. To the point where using it for manufacturing

Re: [PATCH] cmd: mem: fix range of bitflip test

2020-09-09 Thread Stefan Roese
Hi Ralph, On 09.09.20 03:33, Ralph Siemsen wrote: The bitflip test uses two equal sized memory buffers. This is achived by splitting the range of memory into two pieces. The address of the second buffer was not correctly calulated, thus the bitflip test would calculated accessing memory beyo

[PATCH] cmd: mem: fix range of bitflip test

2020-09-08 Thread Ralph Siemsen
The bitflip test uses two equal sized memory buffers. This is achived by splitting the range of memory into two pieces. The address of the second buffer was not correctly calulated, thus the bitflip test would accessing memory beyond the end of the specified range. A second problem arises because