Re: [PATCH] common: update_tftp: remove unnecessary build check

2020-05-26 Thread Heinrich Schuchardt
On 2/28/20 1:06 AM, AKASHI Takahiro wrote: > Logically, the current update_tftp() should and does compile and work > correctly even without satisfying the following condition: > >> #if defined(CONFIG_UPDATE_TFTP) && !defined(CONFIG_MTD_NOR_FLASH) >> #error "CONFIG_UPDATE_TFTP and

Re: [PATCH] common: update_tftp: remove unnecessary build check

2020-03-01 Thread AKASHI Takahiro
On Mon, Mar 02, 2020 at 08:12:09AM +0100, Heinrich Schuchardt wrote: > On 3/2/20 1:11 AM, AKASHI Takahiro wrote: > > On Fri, Feb 28, 2020 at 07:26:25PM +0100, Heinrich Schuchardt wrote: > > > On 2/28/20 1:06 AM, AKASHI Takahiro wrote: > > > > Logically, the current update_tftp() should and does

Re: [PATCH] common: update_tftp: remove unnecessary build check

2020-03-01 Thread Heinrich Schuchardt
On 3/2/20 1:11 AM, AKASHI Takahiro wrote: On Fri, Feb 28, 2020 at 07:26:25PM +0100, Heinrich Schuchardt wrote: On 2/28/20 1:06 AM, AKASHI Takahiro wrote: Logically, the current update_tftp() should and does compile and work correctly even without satisfying the following condition: #if

Re: [PATCH] common: update_tftp: remove unnecessary build check

2020-03-01 Thread AKASHI Takahiro
On Fri, Feb 28, 2020 at 07:26:25PM +0100, Heinrich Schuchardt wrote: > On 2/28/20 1:06 AM, AKASHI Takahiro wrote: > > Logically, the current update_tftp() should and does compile and work > > correctly even without satisfying the following condition: > > > > > #if defined(CONFIG_UPDATE_TFTP) &&

Re: [PATCH] common: update_tftp: remove unnecessary build check

2020-02-28 Thread Heinrich Schuchardt
On 2/28/20 1:06 AM, AKASHI Takahiro wrote: Logically, the current update_tftp() should and does compile and work correctly even without satisfying the following condition: #if defined(CONFIG_UPDATE_TFTP) && !defined(CONFIG_MTD_NOR_FLASH) #error "CONFIG_UPDATE_TFTP and !CONFIG_MTD_NOR_FLASH

[PATCH] common: update_tftp: remove unnecessary build check

2020-02-27 Thread AKASHI Takahiro
Logically, the current update_tftp() should and does compile and work correctly even without satisfying the following condition: > #if defined(CONFIG_UPDATE_TFTP) && !defined(CONFIG_MTD_NOR_FLASH) > #error "CONFIG_UPDATE_TFTP and !CONFIG_MTD_NOR_FLASH needed for > legacy behaviour" > #endif It