Re: [PATCH] dm: rtc: Avoid a race in the rtc_reset test

2022-08-02 Thread Simon Glass
Hi Heinrich, On Tue, 2 Aug 2022 at 07:51, Heinrich Schuchardt wrote: > > On 8/1/22 21:13, Simon Glass wrote: > > Hi Heinrich, > > > > On Mon, 1 Aug 2022 at 08:58, Heinrich Schuchardt wrote: > >> > >> On 8/1/22 15:59, Simon Glass wrote: > >>> Hi Heinrich, > >>> > >>> On Mon, 1 Aug 2022 at 02:11,

Re: [PATCH] dm: rtc: Avoid a race in the rtc_reset test

2022-08-02 Thread Heinrich Schuchardt
On 8/1/22 21:13, Simon Glass wrote: Hi Heinrich, On Mon, 1 Aug 2022 at 08:58, Heinrich Schuchardt wrote: On 8/1/22 15:59, Simon Glass wrote: Hi Heinrich, On Mon, 1 Aug 2022 at 02:11, Heinrich Schuchardt wrote: On 7/31/22 20:27, Simon Glass wrote: Since resetting the RTC on sandbox cause

Re: [PATCH] dm: rtc: Avoid a race in the rtc_reset test

2022-08-02 Thread Simon Glass
Hi Rasmus, On Tue, 2 Aug 2022 at 01:08, Rasmus Villemoes wrote: > > On 01/08/2022 21.13, Simon Glass wrote: > > Hi Heinrich, > > > > On Mon, 1 Aug 2022 at 08:58, Heinrich Schuchardt wrote: > >> > >> On 8/1/22 15:59, Simon Glass wrote: > >>> Hi Heinrich, > >>> > >>> On Mon, 1 Aug 2022 at 02:11, H

Re: [PATCH] dm: rtc: Avoid a race in the rtc_reset test

2022-08-02 Thread Rasmus Villemoes
On 01/08/2022 21.13, Simon Glass wrote: > Hi Heinrich, > > On Mon, 1 Aug 2022 at 08:58, Heinrich Schuchardt wrote: >> >> On 8/1/22 15:59, Simon Glass wrote: >>> Hi Heinrich, >>> >>> On Mon, 1 Aug 2022 at 02:11, Heinrich Schuchardt wrote: On 7/31/22 20:27, Simon Glass wrote: > Since

Re: [PATCH] dm: rtc: Avoid a race in the rtc_reset test

2022-08-01 Thread Simon Glass
Hi Heinrich, On Mon, 1 Aug 2022 at 08:58, Heinrich Schuchardt wrote: > > On 8/1/22 15:59, Simon Glass wrote: > > Hi Heinrich, > > > > On Mon, 1 Aug 2022 at 02:11, Heinrich Schuchardt wrote: > >> > >> On 7/31/22 20:27, Simon Glass wrote: > >>> Since resetting the RTC on sandbox causes it to read

Re: [PATCH] dm: rtc: Avoid a race in the rtc_reset test

2022-08-01 Thread Heinrich Schuchardt
On 8/1/22 15:59, Simon Glass wrote: Hi Heinrich, On Mon, 1 Aug 2022 at 02:11, Heinrich Schuchardt wrote: On 7/31/22 20:27, Simon Glass wrote: Since resetting the RTC on sandbox causes it to read the base time from the system, we cannot rely on this being unchanged since it was last read. All

Re: [PATCH] dm: rtc: Avoid a race in the rtc_reset test

2022-08-01 Thread Simon Glass
Hi Heinrich, On Mon, 1 Aug 2022 at 02:11, Heinrich Schuchardt wrote: > > On 7/31/22 20:27, Simon Glass wrote: > > Since resetting the RTC on sandbox causes it to read the base time from > > the system, we cannot rely on this being unchanged since it was last read. > > Allow for a one-second delay

Re: [PATCH] dm: rtc: Avoid a race in the rtc_reset test

2022-08-01 Thread Heinrich Schuchardt
On 7/31/22 20:27, Simon Glass wrote: Since resetting the RTC on sandbox causes it to read the base time from the system, we cannot rely on this being unchanged since it was last read. Allow for a one-second delay. Fixes: https://source.denx.de/u-boot/u-boot/-/issues/4 Reported-by: Bin Meng Repo

[PATCH] dm: rtc: Avoid a race in the rtc_reset test

2022-07-31 Thread Simon Glass
Since resetting the RTC on sandbox causes it to read the base time from the system, we cannot rely on this being unchanged since it was last read. Allow for a one-second delay. Fixes: https://source.denx.de/u-boot/u-boot/-/issues/4 Reported-by: Bin Meng Reported-by: Tom Rini Suggested-by: Rasmus