Re: [PATCH] efi_loader: Avoid emitting efi_var_buf to .GOT

2021-01-16 Thread Ilias Apalodimas
On Fri, Jan 15, 2021 at 11:33:40AM -0800, Atish Patra wrote: > On Fri, Jan 15, 2021 at 8:00 AM Ilias Apalodimas > wrote: > > > > Atish reports than on RISC-V, accessing the EFI variables causes > > a kernel panic. An objdump of the file verifies that, since the > > global pointer for efi_var_buf

Re: [PATCH] efi_loader: Avoid emitting efi_var_buf to .GOT

2021-01-15 Thread Atish Patra
On Fri, Jan 15, 2021 at 8:00 AM Ilias Apalodimas wrote: > > Atish reports than on RISC-V, accessing the EFI variables causes > a kernel panic. An objdump of the file verifies that, since the > global pointer for efi_var_buf ends up in .GOT section which is > not mapped in virtual address space

Re: [PATCH] efi_loader: Avoid emitting efi_var_buf to .GOT

2021-01-15 Thread Atish Patra
On Fri, Jan 15, 2021 at 11:11 AM Ilias Apalodimas wrote: > > Hi Heinrich, > > [...] > > > Atish can you give it a spin and let me know if this fixes the issue for > > > you? > > > The objdump seems to be correct now, but I am not familiar with RISC-V. > > > No regressions on Arm with TEE or

Re: [PATCH] efi_loader: Avoid emitting efi_var_buf to .GOT

2021-01-15 Thread Ilias Apalodimas
Hi Heinrich, [...] > > Atish can you give it a spin and let me know if this fixes the issue for > > you? > > The objdump seems to be correct now, but I am not familiar with RISC-V. > > No regressions on Arm with TEE or memory backed variables. > > include/efi_variable.h| 12

Re: [PATCH] efi_loader: Avoid emitting efi_var_buf to .GOT

2021-01-15 Thread Heinrich Schuchardt
On 15.01.21 17:00, Ilias Apalodimas wrote: > Atish reports than on RISC-V, accessing the EFI variables causes > a kernel panic. An objdump of the file verifies that, since the > global pointer for efi_var_buf ends up in .GOT section which is > not mapped in virtual address space for Linux. > > >

[PATCH] efi_loader: Avoid emitting efi_var_buf to .GOT

2021-01-15 Thread Ilias Apalodimas
Atish reports than on RISC-V, accessing the EFI variables causes a kernel panic. An objdump of the file verifies that, since the global pointer for efi_var_buf ends up in .GOT section which is not mapped in virtual address space for Linux. 0084 : 84: 715daddi