Re: [PATCH] efi_loader: FMP cleanups

2021-06-15 Thread Ilias Apalodimas
[...] > > > > > Yes. > > > > > We may have different *firmware* for different software components > > > > > and different devices. For example, > > > > > You have firmare like U-Boot binary and default variable storage > > > > > in different partitions. > > > > > On the other hand, you have an

Re: [PATCH] efi_loader: FMP cleanups

2021-06-15 Thread AKASHI Takahiro
On Tue, Jun 15, 2021 at 09:56:10AM +0300, Ilias Apalodimas wrote: > > > > > > [...] > > > > > They are fixing "different" problems relating ESRT generation. > > > > That is my point. > > > > > > > > > > Sure, but it's a minor clean up really. As I said the current code works > > > fine. So I

Re: [PATCH] efi_loader: FMP cleanups

2021-06-15 Thread Ilias Apalodimas
> > > [...] > > > They are fixing "different" problems relating ESRT generation. > > > That is my point. > > > > > > > Sure, but it's a minor clean up really. As I said the current code works > > fine. So I dont really mind the fact that it breaks a sentence of the spec. > > Hence I

Re: [PATCH] efi_loader: FMP cleanups

2021-06-15 Thread AKASHI Takahiro
On Tue, Jun 15, 2021 at 09:22:31AM +0300, Ilias Apalodimas wrote: > On Tue, Jun 15, 2021 at 02:55:38PM +0900, AKASHI Takahiro wrote: > > On Tue, Jun 15, 2021 at 08:23:35AM +0300, Ilias Apalodimas wrote: > > > On Tue, Jun 15, 2021 at 01:44:58PM +0900, AKASHI Takahiro wrote: > > > > On Tue, Jun 15,

Re: [PATCH] efi_loader: FMP cleanups

2021-06-15 Thread Ilias Apalodimas
On Tue, Jun 15, 2021 at 02:55:38PM +0900, AKASHI Takahiro wrote: > On Tue, Jun 15, 2021 at 08:23:35AM +0300, Ilias Apalodimas wrote: > > On Tue, Jun 15, 2021 at 01:44:58PM +0900, AKASHI Takahiro wrote: > > > On Tue, Jun 15, 2021 at 06:55:50AM +0300, Ilias Apalodimas wrote: > > > > Akashi-san, > >

Re: [PATCH] efi_loader: FMP cleanups

2021-06-14 Thread AKASHI Takahiro
On Tue, Jun 15, 2021 at 08:23:35AM +0300, Ilias Apalodimas wrote: > On Tue, Jun 15, 2021 at 01:44:58PM +0900, AKASHI Takahiro wrote: > > On Tue, Jun 15, 2021 at 06:55:50AM +0300, Ilias Apalodimas wrote: > > > Akashi-san, > > > > > > On Tue, Jun 15, 2021 at 10:51:01AM +0900, AKASHI Takahiro wrote:

Re: [PATCH] efi_loader: FMP cleanups

2021-06-14 Thread Ilias Apalodimas
On Tue, Jun 15, 2021 at 01:44:58PM +0900, AKASHI Takahiro wrote: > On Tue, Jun 15, 2021 at 06:55:50AM +0300, Ilias Apalodimas wrote: > > Akashi-san, > > > > On Tue, Jun 15, 2021 at 10:51:01AM +0900, AKASHI Takahiro wrote: > > > Ilias, > > > > > > In this patch, you are trying to address a couple

Re: [PATCH] efi_loader: FMP cleanups

2021-06-14 Thread AKASHI Takahiro
On Tue, Jun 15, 2021 at 06:55:50AM +0300, Ilias Apalodimas wrote: > Akashi-san, > > On Tue, Jun 15, 2021 at 10:51:01AM +0900, AKASHI Takahiro wrote: > > Ilias, > > > > In this patch, you are trying to address a couple of independent > > issues in a single commit. > > Please split. > > (Heinrich

Re: [PATCH] efi_loader: FMP cleanups

2021-06-14 Thread Ilias Apalodimas
On Tue, Jun 15, 2021 at 09:49:58AM +0900, Masami Hiramatsu wrote: > 2021年6月15日(火) 0:10 Ilias Apalodimas : > > > > > Right now we allow both of the FMPs (RAW and FIT based) to be installed at > > the same time. Moreover we only install those if a CapsuleUpdate is > > requested. Since we now have

Re: [PATCH] efi_loader: FMP cleanups

2021-06-14 Thread Ilias Apalodimas
Akashi-san, On Tue, Jun 15, 2021 at 10:51:01AM +0900, AKASHI Takahiro wrote: > Ilias, > > In this patch, you are trying to address a couple of independent > issues in a single commit. > Please split. > (Heinrich doesn't like that.) > > On Mon, Jun 14, 2021 at 06:10:14PM +0300, Ilias Apalodimas

Re: [PATCH] efi_loader: FMP cleanups

2021-06-14 Thread AKASHI Takahiro
Ilias, In this patch, you are trying to address a couple of independent issues in a single commit. Please split. (Heinrich doesn't like that.) On Mon, Jun 14, 2021 at 06:10:14PM +0300, Ilias Apalodimas wrote: > Right now we allow both of the FMPs (RAW and FIT based) to be installed at > the same

Re: [PATCH] efi_loader: FMP cleanups

2021-06-14 Thread Masami Hiramatsu
2021年6月15日(火) 0:10 Ilias Apalodimas : > > Right now we allow both of the FMPs (RAW and FIT based) to be installed at > the same time. Moreover we only install those if a CapsuleUpdate is > requested. Since we now have an ESRT table, it makes more sense to > unconditionally install the FMP, so

Re: [PATCH] efi_loader: FMP cleanups

2021-06-14 Thread Ilias Apalodimas
Too fast on the trigger. The efi_load_capsule_drivers() must go into an IS_ENABLED. I'll wait for any other comments and send a V2 On Mon, 14 Jun 2021 at 18:10, Ilias Apalodimas wrote: > > Right now we allow both of the FMPs (RAW and FIT based) to be installed at > the same time. Moreover we

[PATCH] efi_loader: FMP cleanups

2021-06-14 Thread Ilias Apalodimas
Right now we allow both of the FMPs (RAW and FIT based) to be installed at the same time. Moreover we only install those if a CapsuleUpdate is requested. Since we now have an ESRT table, it makes more sense to unconditionally install the FMP, so any userspace applications (e.g fwupd) can make