Re: [PATCH] fdt_support: fix fdt_copy_fixed_partitions function()

2024-03-12 Thread Patrice CHOTARD
On 3/11/24 12:37, Dan Carpenter wrote: > On Fri, Mar 08, 2024 at 02:34:04PM +0100, Patrice Chotard wrote: >> Move variable declaration at the beginning of the function. >> > > The problem, presumably, is that when declarations are in the middle of > a block then it triggers a GCC warning.

Re: [PATCH] fdt_support: fix fdt_copy_fixed_partitions function()

2024-03-11 Thread Dragan Simic
On 2024-03-11 12:37, Dan Carpenter wrote: On Fri, Mar 08, 2024 at 02:34:04PM +0100, Patrice Chotard wrote: Move variable declaration at the beginning of the function. The problem, presumably, is that when declarations are in the middle of a block then it triggers a GCC warning. "declarations

Re: [PATCH] fdt_support: fix fdt_copy_fixed_partitions function()

2024-03-11 Thread Dan Carpenter
On Fri, Mar 08, 2024 at 02:34:04PM +0100, Patrice Chotard wrote: > Move variable declaration at the beginning of the function. > The problem, presumably, is that when declarations are in the middle of a block then it triggers a GCC warning. "declarations after code" or whatever... The commit

Re: [PATCH] fdt_support: fix fdt_copy_fixed_partitions function()

2024-03-08 Thread Dragan Simic
Hello Patrice, Please, see my comment below. On 2024-03-08 14:34, Patrice Chotard wrote: Move variable declaration at the beginning of the function. Fixes: 163c5f60ebb4 ("fdt_support: add fdt_copy_fixed_partitions function") Signed-off-by: Patrice Chotard --- boot/fdt_support.c | 6

[PATCH] fdt_support: fix fdt_copy_fixed_partitions function()

2024-03-08 Thread Patrice Chotard
Move variable declaration at the beginning of the function. Fixes: 163c5f60ebb4 ("fdt_support: add fdt_copy_fixed_partitions function") Signed-off-by: Patrice Chotard --- boot/fdt_support.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/boot/fdt_support.c