c...@gmail.com>>
>> Sent: 2023年3月23日 17:34
>> To: Bough Chen mailto:haibo.c...@nxp.com>>
>> Cc: h...@denx.de <mailto:h...@denx.de>; ma...@denx.de
>> <mailto:ma...@denx.de>; u-boot@lists.denx.de <mailto:u-boot@lists.denx.de>;
>> dl-uboot-imx
&g
> -Original Message-
> From: Alexander Kochetkov
> Sent: 2023年3月23日 17:34
> To: Bough Chen
> Cc: h...@denx.de; ma...@denx.de; u-boot@lists.denx.de; dl-uboot-imx
> ; xypron.g...@gmx.de
> Subject: Re: [PATCH] i2c: correct I2C deblock logic
>
> Or even simple
Or even simpler. Like your original patch. If we take into accout Patrik’s
comment from another message:
> but if I assume that GPIO_ACTIVE_HIGH is NOT activated in DT
static void i2c_gpio_set_pin(struct gpio_desc *pin, int bit)
{
if (bit) {
dm_gpio_set_dir_flags(pin, GPIOD_IS_IN);
Hello Haibo Chen!
Setting GPIOD_ACTIVE_LOW has no effect. It filtered out by
dm_gpio_set_dir_flags().
>
>
> if (bit)
> - dm_gpio_set_dir_flags(pin, GPIOD_IS_IN);
> + dm_gpio_set_dir_flags(pin, GPIOD_IS_IN |
> +GPIOD_ACTIVE_LOW);
Here in original code GPIOD_ACTIVE_LOW has not effect.
else
> -Original Message-
> From: Alexander Kochetkov
> Sent: 2023年3月21日 17:50
> To: Bough Chen
> Cc: h...@denx.de; ma...@denx.de; u-boot@lists.denx.de; dl-uboot-imx
> ; xypron.g...@gmx.de; Simon Glass
>
> Subject: Re: [PATCH] i2c: correct I2C deblock logic
>
г., в 11:37, Bough Chen написал(а):
>
>> -Original Message-
>> From: Alexander Kochetkov
>> Sent: 2023年3月20日 16:03
>> To: h...@denx.de
>> Cc: Bough Chen ; ma...@denx.de;
>> u-boot@lists.denx.de; dl-uboot-imx ;
>> xypron.g...@gmx.de; Simon Glas
> -Original Message-
> From: Alexander Kochetkov
> Sent: 2023年3月20日 16:03
> To: h...@denx.de
> Cc: Bough Chen ; ma...@denx.de;
> u-boot@lists.denx.de; dl-uboot-imx ;
> xypron.g...@gmx.de; Simon Glass
> Subject: Re: [PATCH] i2c: correct I2C deblock logic
>
>
Chen
>>> Sent: 2023年2月10日 17:27
>>> To: h...@denx.de; al.koc...@gmail.com; ma...@denx.de
>>> Cc: u-boot@lists.denx.de; dl-uboot-imx ;
>>> xypron.g...@gmx.de; Bough Chen
>>> Subject: [PATCH] i2c: correct I2C deblock logic
>>>
>>> From: H
Hi!
On 13.03.23 03:55, Bough Chen wrote:
>> -Original Message-
>> From: Bough Chen
>> Sent: 2023年2月10日 17:27
>> To: h...@denx.de; al.koc...@gmail.com; ma...@denx.de
>> Cc: u-boot@lists.denx.de; dl-uboot-imx ;
>> xypron.g...@gmx.de; Bough Chen
>>
> -Original Message-
> From: Bough Chen
> Sent: 2023年2月10日 17:27
> To: h...@denx.de; al.koc...@gmail.com; ma...@denx.de
> Cc: u-boot@lists.denx.de; dl-uboot-imx ;
> xypron.g...@gmx.de; Bough Chen
> Subject: [PATCH] i2c: correct I2C deblock logic
>
> From: Ha
From: Haibo Chen
Current code use dm_gpio_get_value() to get SDA and SCL value, and the
value depends on the flag GPIOD_ACTIVE_LOW. When toggle SCL to wait
slave release SDA, the SDA are config as GPIOD_IS_IN, and whether contain
the GPIOD_ACTIVE_LOW depends on the DTS setting. Usually, for I2C
11 matches
Mail list logo
