Re: [PATCH] ifwitool: Fix member access

2023-01-27 Thread Tom Rini
On Wed, Jan 18, 2023 at 01:13:17PM -0700, Simon Glass wrote: > On a second and third look, a recent patch seems to be writing to the > wrong place - updating offsets from the address of the pointer instead > of what the pointer points to. > > Fix it. > > Signed-off-by: Simon Glass > Fixes:

Re: [PATCH] ifwitool: Fix member access

2023-01-21 Thread Sean Anderson
On 1/21/23 13:17, Sean Anderson wrote: On Wed, 18 Jan 2023 13:13:17 -0700, Simon Glass wrote: On a second and third look, a recent patch seems to be writing to the wrong place - updating offsets from the address of the pointer instead of what the pointer points to. Fix it. [...] Applied,

Re: [PATCH] ifwitool: Fix member access

2023-01-21 Thread Sean Anderson
On Wed, 18 Jan 2023 13:13:17 -0700, Simon Glass wrote: > On a second and third look, a recent patch seems to be writing to the > wrong place - updating offsets from the address of the pointer instead > of what the pointer points to. > > Fix it. > > > [...] Applied, thanks! [1/1] ifwitool: Fix

Re: [PATCH] ifwitool: Fix member access

2023-01-21 Thread Sean Anderson
On 1/18/23 15:13, Simon Glass wrote: On a second and third look, a recent patch seems to be writing to the wrong place - updating offsets from the address of the pointer instead of what the pointer points to. Fix it. Signed-off-by: Simon Glass Fixes: 2d1b2ac13fe ("tool: ifwitool: Fix buffer

[PATCH] ifwitool: Fix member access

2023-01-18 Thread Simon Glass
On a second and third look, a recent patch seems to be writing to the wrong place - updating offsets from the address of the pointer instead of what the pointer points to. Fix it. Signed-off-by: Simon Glass Fixes: 2d1b2ac13fe ("tool: ifwitool: Fix buffer overflow") --- tools/ifwitool.c | 40