Re: [PATCH] nvme: add cache flush in get/set_features

2021-03-02 Thread Andre Przywara
On Fri, 26 Feb 2021 17:11:07 +0100 Neil Armstrong wrote: Hi Neil, > On 26/02/2021 16:22, André Przywara wrote: > > On 26/02/2021 14:13, Neil Armstrong wrote: > > > > Hi, > > > [..] > > > > > And if this seems to fix something, how? > > Good question... sorry for the noise my patch is to

Re: [PATCH] nvme: add cache flush in get/set_features

2021-02-26 Thread Neil Armstrong
Hi Andre, Bin, On 26/02/2021 16:22, André Przywara wrote: > On 26/02/2021 14:13, Neil Armstrong wrote: > > Hi, > [..] > > And if this seems to fix something, how? Good question... sorry for the noise my patch is totally wrong, but it fixed something somehow. But, "nvme: Always invalidate wh

Re: [PATCH] nvme: add cache flush in get/set_features

2021-02-26 Thread André Przywara
On 26/02/2021 14:13, Neil Armstrong wrote: Hi, > On Amlogic G12A platforms, the NVME probe timeouts at get/set_feature(), > adding a cache flush solves the timeout. I am puzzled how this is supposed to work ... > > Signed-off-by: Neil Armstrong > --- > drivers/nvme/nvme.c | 7 --- > 1 fi

Re: [PATCH] nvme: add cache flush in get/set_features

2021-02-26 Thread Bin Meng
Hi Neil, On Fri, Feb 26, 2021 at 10:13 PM Neil Armstrong wrote: > > On Amlogic G12A platforms, the NVME probe timeouts at get/set_feature(), > adding a cache flush solves the timeout. > > Signed-off-by: Neil Armstrong > --- > drivers/nvme/nvme.c | 7 --- > 1 file changed, 4 insertions(+), 3

[PATCH] nvme: add cache flush in get/set_features

2021-02-26 Thread Neil Armstrong
On Amlogic G12A platforms, the NVME probe timeouts at get/set_feature(), adding a cache flush solves the timeout. Signed-off-by: Neil Armstrong --- drivers/nvme/nvme.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index 5d633