Re: [PATCH] rockchip: spl: Cache boot source id for later use

2024-03-19 Thread Jonas Karlman
Hi Quentin, On 2024-03-19 11:19, Quentin Schulz wrote: > Hi Jonas, > > On 3/15/24 18:34, Jonas Karlman wrote: >> Rockchip BROM write a boot source id at CFG_IRAM_BASE + 0x10, the id >> indicate from what storage media TPL/SPL was loaded from. >> >> SPL use this value to determine what device

Re: [PATCH] rockchip: spl: Cache boot source id for later use

2024-03-19 Thread Dragan Simic
On 2024-03-19 16:59, Jonas Karlman wrote: On 2024-03-19 10:44, Dragan Simic wrote: On 2024-03-15 18:34, Jonas Karlman wrote: diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c index 1586a093fc37..27e996b504e7 100644 --- a/arch/arm/mach-rockchip/spl.c +++

Re: [PATCH] rockchip: spl: Cache boot source id for later use

2024-03-19 Thread Jonas Karlman
Hi Dragan, On 2024-03-19 10:44, Dragan Simic wrote: > Hello Jonas, > > Please see a few comments below. > > On 2024-03-15 18:34, Jonas Karlman wrote: >> Rockchip BROM write a boot source id at CFG_IRAM_BASE + 0x10, the id >> indicate from what storage media TPL/SPL was loaded from. > >

Re: [PATCH] rockchip: spl: Cache boot source id for later use

2024-03-19 Thread Dragan Simic
Hello Quentin, On 2024-03-19 11:19, Quentin Schulz wrote: On 3/15/24 18:34, Jonas Karlman wrote: Rockchip BROM write a boot source id at CFG_IRAM_BASE + 0x10, the id indicate from what storage media TPL/SPL was loaded from. SPL use this value to determine what device "same-as-spl" represent

Re: [PATCH] rockchip: spl: Cache boot source id for later use

2024-03-19 Thread Quentin Schulz
Hi Jonas, On 3/15/24 18:34, Jonas Karlman wrote: Rockchip BROM write a boot source id at CFG_IRAM_BASE + 0x10, the id indicate from what storage media TPL/SPL was loaded from. SPL use this value to determine what device "same-as-spl" represent when determining from where FIT should be loaded.

Re: [PATCH] rockchip: spl: Cache boot source id for later use

2024-03-19 Thread Dragan Simic
Hello Jonas, Please see a few comments below. On 2024-03-15 18:34, Jonas Karlman wrote: Rockchip BROM write a boot source id at CFG_IRAM_BASE + 0x10, the id indicate from what storage media TPL/SPL was loaded from. s/write/writes/ s/indicate/indicates/ There are also a few more similar

Re: [PATCH] rockchip: spl: Cache boot source id for later use

2024-03-19 Thread Kever Yang
On 2024/3/16 01:34, Jonas Karlman wrote: Rockchip BROM write a boot source id at CFG_IRAM_BASE + 0x10, the id indicate from what storage media TPL/SPL was loaded from. SPL use this value to determine what device "same-as-spl" represent when determining from where FIT should be loaded. This

[PATCH] rockchip: spl: Cache boot source id for later use

2024-03-15 Thread Jonas Karlman
Rockchip BROM write a boot source id at CFG_IRAM_BASE + 0x10, the id indicate from what storage media TPL/SPL was loaded from. SPL use this value to determine what device "same-as-spl" represent when determining from where FIT should be loaded. This works as long as the boot_devices array contain