Re: [PATCH] rtc: add support for rv3028 rtc

2021-03-09 Thread Heiko Schocher
Hi stefan, On 09.03.21 17:10, Stefan Roese wrote: > Hi Heiko, > > On 09.03.21 14:45, Heiko Schocher wrote: >> add support for rtc3028 rtc from microcrystal. >> based on linux dirver: >> commit a38fd8748464: ("Linux 5.12-rc2") > > Nitpicking: You might want to start a sentence in upper-case? ;)

Re: [PATCH] rtc: add support for rv3028 rtc

2021-03-09 Thread Alexandre Belloni
On 09/03/2021 17:10:21+0100, Stefan Roese wrote: > Hi Heiko, > > On 09.03.21 14:45, Heiko Schocher wrote: > > add support for rtc3028 rtc from microcrystal. > > based on linux dirver: > > commit a38fd8748464: ("Linux 5.12-rc2") > > Nitpicking: You might want to start a sentence in upper-case? ;)

Re: [PATCH] rtc: add support for rv3028 rtc

2021-03-09 Thread Stefan Roese
Hi Heiko, On 09.03.21 14:45, Heiko Schocher wrote: add support for rtc3028 rtc from microcrystal. based on linux dirver: commit a38fd8748464: ("Linux 5.12-rc2") Nitpicking: You might want to start a sentence in upper-case? ;) Another minor comment below... Signed-off-by: Heiko Schocher

[PATCH] rtc: add support for rv3028 rtc

2021-03-09 Thread Heiko Schocher
add support for rtc3028 rtc from microcrystal. based on linux dirver: commit a38fd8748464: ("Linux 5.12-rc2") Signed-off-by: Heiko Schocher --- driver is based on code in linux, but with already corrected weekday usage. linux codes the weekday bitwise, while the weekday register has only 3