Re: [PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-06 Thread Simon Glass
Hi Ilias, On Mon, 5 Jul 2021 at 11:31, Ilias Apalodimas wrote: > > Simon, Bin, > > As Heinrich points out some of the CONFIG_SYS_* values are not representing > the devices properly. Maybe it's a better idea to only check the .dts? > If the values are missing we can pop a runtime warning and

Re: [PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-05 Thread Ilias Apalodimas
Simon, Bin, As Heinrich points out some of the CONFIG_SYS_* values are not representing the devices properly. Maybe it's a better idea to only check the .dts? If the values are missing we can pop a runtime warning and keep using 'Unknown'. On Mon, Jul 05, 2021 at 09:29:57AM -0600, Simon Glass

Re: [PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-05 Thread Simon Glass
On Mon, 5 Jul 2021 at 02:49, Ilias Apalodimas wrote: > > SMBIOS entries for manufacturer and board can't be empty, as the spec > explicitly requires a value. > Instead of passing "Unknown" and "Unknown product" for the manufacturer and > product name if the .dts options are missing, try to use

Re: [PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-05 Thread Ilias Apalodimas
Hi Heinrich, On Mon, Jul 05, 2021 at 12:25:47PM +0200, Heinrich Schuchardt wrote: > On 7/5/21 10:49 AM, Ilias Apalodimas wrote: > > SMBIOS entries for manufacturer and board can't be empty, as the spec > > explicitly requires a value. > > Instead of passing "Unknown" and "Unknown product" for

Re: [PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-05 Thread Heinrich Schuchardt
On 7/5/21 10:49 AM, Ilias Apalodimas wrote: SMBIOS entries for manufacturer and board can't be empty, as the spec explicitly requires a value. Instead of passing "Unknown" and "Unknown product" for the manufacturer and product name if the .dts options are missing, try to use CONFIG_SYS_VENDOR

Re: [PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-05 Thread Bin Meng
On Mon, Jul 5, 2021 at 4:49 PM Ilias Apalodimas wrote: > > SMBIOS entries for manufacturer and board can't be empty, as the spec > explicitly requires a value. > Instead of passing "Unknown" and "Unknown product" for the manufacturer and > product name if the .dts options are missing, try to use

[PATCH] smbios: Try CONFIG_SYS_ options before using "Unknow" as a value

2021-07-05 Thread Ilias Apalodimas
SMBIOS entries for manufacturer and board can't be empty, as the spec explicitly requires a value. Instead of passing "Unknown" and "Unknown product" for the manufacturer and product name if the .dts options are missing, try to use CONFIG_SYS_VENDOR and CONFIG_SYS_BOARD respectively. If those are