Re: [PATCH] usb: gadget: UMS: fix 64-bit division on ARM32

2024-03-22 Thread Mattijs Korpershoek
Hi Caleb, On jeu., mars 21, 2024 at 17:01, Caleb Connolly wrote: > On 21/03/2024 16:48, Mattijs Korpershoek wrote: >> Hi Caleb, >> >> Thank you for the patch. >> >> On jeu., mars 21, 2024 at 15:28, Caleb Connolly >> wrote: >> >>> The patch introducing support for dynamic sector sizes

Re: [PATCH] usb: gadget: UMS: fix 64-bit division on ARM32

2024-03-21 Thread Caleb Connolly
On 21/03/2024 16:48, Mattijs Korpershoek wrote: > Hi Caleb, > > Thank you for the patch. > > On jeu., mars 21, 2024 at 15:28, Caleb Connolly > wrote: > >> The patch introducing support for dynamic sector sizes changed the types >> used in some divisions, resulting in the compiler

Re: [PATCH] usb: gadget: UMS: fix 64-bit division on ARM32

2024-03-21 Thread Mattijs Korpershoek
Hi Caleb, Thank you for the patch. On jeu., mars 21, 2024 at 15:28, Caleb Connolly wrote: > The patch introducing support for dynamic sector sizes changed the types > used in some divisions, resulting in the compiler attempting to use > libgcc helpers (__aeabi_ldivmod). Replace these

[PATCH] usb: gadget: UMS: fix 64-bit division on ARM32

2024-03-21 Thread Caleb Connolly
The patch introducing support for dynamic sector sizes changed the types used in some divisions, resulting in the compiler attempting to use libgcc helpers (__aeabi_ldivmod). Replace these divisions with calls to lldiv() to handle this correctly. Fixes: 74e56e0c5065 ("usb: gadget: UMS: support