Re: [PATCH] usb: onboard-hub: Don't disable regulator in remove() callback

2023-04-18 Thread Patrice CHOTARD
Hi On 4/18/23 13:53, Marek Vasut wrote: > On 4/18/23 13:49, Fabio Estevam wrote: >> Hi Patrice and Marek, >> >> On Tue, Apr 18, 2023 at 4:22 AM Patrice CHOTARD >> wrote: >> Isn't the regulator enable/disable refcounted ? >>> >>> There is no refcount on regulator that's why we let regulator

Re: [PATCH] usb: onboard-hub: Don't disable regulator in remove() callback

2023-04-18 Thread Marek Vasut
On 4/18/23 13:49, Fabio Estevam wrote: Hi Patrice and Marek, On Tue, Apr 18, 2023 at 4:22 AM Patrice CHOTARD wrote: Isn't the regulator enable/disable refcounted ? There is no refcount on regulator that's why we let regulator enable. There is a recent patch from Eugen that adds regulator

Re: [PATCH] usb: onboard-hub: Don't disable regulator in remove() callback

2023-04-18 Thread Fabio Estevam
Hi Patrice and Marek, On Tue, Apr 18, 2023 at 4:22 AM Patrice CHOTARD wrote: > > Isn't the regulator enable/disable refcounted ? > > There is no refcount on regulator that's why we let regulator enable. There is a recent patch from Eugen that adds regulator refcount support:

Re: [PATCH] usb: onboard-hub: Don't disable regulator in remove() callback

2023-04-18 Thread Marek Vasut
On 4/18/23 11:14, Patrice CHOTARD wrote: Hi Marek Hello Patrice, On 4/18/23 10:25, Marek Vasut wrote: On 4/18/23 09:21, Patrice CHOTARD wrote: Hi Marek Hello Patrice, On 4/17/23 19:00, Marek Vasut wrote: On 4/17/23 18:56, Patrice Chotard wrote: In case USB hub regulator is shared,

Re: [PATCH] usb: onboard-hub: Don't disable regulator in remove() callback

2023-04-18 Thread Patrice CHOTARD
Hi Marek On 4/18/23 10:25, Marek Vasut wrote: > On 4/18/23 09:21, Patrice CHOTARD wrote: >> Hi Marek > > Hello Patrice, > >> On 4/17/23 19:00, Marek Vasut wrote: >>> On 4/17/23 18:56, Patrice Chotard wrote: In case USB hub regulator is shared, unexpected behavior occurs. On

Re: [PATCH] usb: onboard-hub: Don't disable regulator in remove() callback

2023-04-18 Thread Marek Vasut
On 4/18/23 09:21, Patrice CHOTARD wrote: Hi Marek Hello Patrice, On 4/17/23 19:00, Marek Vasut wrote: On 4/17/23 18:56, Patrice Chotard wrote: In case USB hub regulator is shared, unexpected behavior occurs. On stm32mp135f-dk, stm32mp157c-ev1 and stm32mp157x-dkx, regulator v3v3 is shared

Re: [PATCH] usb: onboard-hub: Don't disable regulator in remove() callback

2023-04-18 Thread Patrice CHOTARD
Hi Marek On 4/17/23 19:00, Marek Vasut wrote: > On 4/17/23 18:56, Patrice Chotard wrote: >> In case USB hub regulator is shared, unexpected behavior occurs. >> On stm32mp135f-dk, stm32mp157c-ev1 and stm32mp157x-dkx, regulator >> v3v3 is shared between several IP/devices (USB, panel, ethernet phy,

Re: [PATCH] usb: onboard-hub: Don't disable regulator in remove() callback

2023-04-17 Thread Marek Vasut
On 4/17/23 18:56, Patrice Chotard wrote: In case USB hub regulator is shared, unexpected behavior occurs. On stm32mp135f-dk, stm32mp157c-ev1 and stm32mp157x-dkx, regulator v3v3 is shared between several IP/devices (USB, panel, ethernet phy, camera, ...). Running command "usb stop", v3v3

[PATCH] usb: onboard-hub: Don't disable regulator in remove() callback

2023-04-17 Thread Patrice Chotard
In case USB hub regulator is shared, unexpected behavior occurs. On stm32mp135f-dk, stm32mp157c-ev1 and stm32mp157x-dkx, regulator v3v3 is shared between several IP/devices (USB, panel, ethernet phy, camera, ...). Running command "usb stop", v3v3 regulator is switched off and the splashscreen