Re: [PATCH 06/12] net: smc911x: Inline all functions from header file

2020-03-17 Thread Masahiro Yamada
On Mon, Mar 16, 2020 at 2:00 AM Marek Vasut wrote: > > Inline all the functions from the header file, as they are not used > outside of the driver or the standalone EEPROM example. Meh for 'static inline' in .c files, but you will rip it off in the next commit. So, the resulted code seems good.

Re: [PATCH 06/12] net: smc911x: Inline all functions from header file

2020-03-16 Thread Joe Hershberger
On Sun, Mar 15, 2020 at 12:00 PM Marek Vasut wrote: > > Inline all the functions from the header file, as they are not used > outside of the driver or the standalone EEPROM example. > > Note that this does introduce considerable amount of duplication in > the standalone EEPROM example, however

[PATCH 06/12] net: smc911x: Inline all functions from header file

2020-03-15 Thread Marek Vasut
Inline all the functions from the header file, as they are not used outside of the driver or the standalone EEPROM example. Note that this does introduce considerable amount of duplication in the standalone EEPROM example, however that one has to be rewritten anyway, roughly such that the SMC911x