Re: [PATCH 1/1] fs: fix smh_fs_read_at()

2023-06-02 Thread Sean Anderson
On 6/2/23 12:54, Heinrich Schuchardt wrote: > On 6/2/23 18:43, Sean Anderson wrote: >> On 6/2/23 12:21, Heinrich Schuchardt wrote: >>> On 6/2/23 17:56, Sean Anderson wrote: On 6/2/23 04:48, Heinrich Schuchardt wrote: > > > On 5/18/23 17:17, Sean Anderson wrote: >> On 5/17/23

Re: [PATCH 1/1] fs: fix smh_fs_read_at()

2023-06-02 Thread Heinrich Schuchardt
On 6/2/23 18:43, Sean Anderson wrote: On 6/2/23 12:21, Heinrich Schuchardt wrote: On 6/2/23 17:56, Sean Anderson wrote: On 6/2/23 04:48, Heinrich Schuchardt wrote: On 5/18/23 17:17, Sean Anderson wrote: On 5/17/23 06:23, Heinrich Schuchardt wrote: The return value of smh_flen() is written

Re: [PATCH 1/1] fs: fix smh_fs_read_at()

2023-06-02 Thread Sean Anderson
On 6/2/23 12:21, Heinrich Schuchardt wrote: > On 6/2/23 17:56, Sean Anderson wrote: >> On 6/2/23 04:48, Heinrich Schuchardt wrote: >>> >>> >>> On 5/18/23 17:17, Sean Anderson wrote: On 5/17/23 06:23, Heinrich Schuchardt wrote: > The return value of smh_flen() is written to size and not to

Re: [PATCH 1/1] fs: fix smh_fs_read_at()

2023-06-02 Thread Heinrich Schuchardt
On 6/2/23 17:56, Sean Anderson wrote: On 6/2/23 04:48, Heinrich Schuchardt wrote: On 5/18/23 17:17, Sean Anderson wrote: On 5/17/23 06:23, Heinrich Schuchardt wrote: The return value of smh_flen() is written to size and not to ret. But ret is checked. We can avoid calling smh_flen() by

Re: [PATCH 1/1] fs: fix smh_fs_read_at()

2023-06-02 Thread Sean Anderson
On 6/2/23 04:48, Heinrich Schuchardt wrote: > > > On 5/18/23 17:17, Sean Anderson wrote: >> On 5/17/23 06:23, Heinrich Schuchardt wrote: >>> The return value of smh_flen() is written to size and not to ret. But ret >>> is checked. We can avoid calling smh_flen() by setting maxsize to LONG_MAX

Re: [PATCH 1/1] fs: fix smh_fs_read_at()

2023-06-02 Thread Heinrich Schuchardt
On 5/18/23 17:17, Sean Anderson wrote: On 5/17/23 06:23, Heinrich Schuchardt wrote: The return value of smh_flen() is written to size and not to ret. But ret is checked. We can avoid calling smh_flen() by setting maxsize to LONG_MAX if it is not set yet. Check input parameters. Fixes:

Re: [PATCH 1/1] fs: fix smh_fs_read_at()

2023-05-18 Thread Sean Anderson
On 5/17/23 06:23, Heinrich Schuchardt wrote: > The return value of smh_flen() is written to size and not to ret. But ret > is checked. We can avoid calling smh_flen() by setting maxsize to LONG_MAX > if it is not set yet. > > Check input parameters. > > Fixes: f676b45151c3 ("fs: Add semihosting

[PATCH 1/1] fs: fix smh_fs_read_at()

2023-05-17 Thread Heinrich Schuchardt
The return value of smh_flen() is written to size and not to ret. But ret is checked. We can avoid calling smh_flen() by setting maxsize to LONG_MAX if it is not set yet. Check input parameters. Fixes: f676b45151c3 ("fs: Add semihosting filesystem") Signed-off-by: Heinrich Schuchardt ---