On Tue, Mar 10, 2020 at 12:37 PM Tom Rini wrote:
>
> On Tue, Mar 10, 2020 at 09:47:33AM +, Alex Kiernan wrote:
> > On Sat, Feb 8, 2020 at 12:06 AM Tom Rini wrote:
> > >
> > > On Sun, Jan 05, 2020 at 08:10:56PM +0100, Luka Kovacic wrote:
> > >
> > > > Use the correct return value in function
On Tue, Mar 10, 2020 at 09:47:33AM +, Alex Kiernan wrote:
> On Sat, Feb 8, 2020 at 12:06 AM Tom Rini wrote:
> >
> > On Sun, Jan 05, 2020 at 08:10:56PM +0100, Luka Kovacic wrote:
> >
> > > Use the correct return value in function do_gpio() and update
> > > commands documentation with the
On Sat, Feb 8, 2020 at 12:06 AM Tom Rini wrote:
>
> On Sun, Jan 05, 2020 at 08:10:56PM +0100, Luka Kovacic wrote:
>
> > Use the correct return value in function do_gpio() and update
> > commands documentation with the return values from command_ret_t enum.
> >
> > CMD_RET_SUCCESS is returned on
On Sun, Jan 05, 2020 at 08:10:56PM +0100, Luka Kovacic wrote:
> Use the correct return value in function do_gpio() and update
> commands documentation with the return values from command_ret_t enum.
>
> CMD_RET_SUCCESS is returned on command success and CMD_RET_FAILURE is
> returned on command
Hi Tom,
On Fri, 31 Jan 2020 at 13:59, Tom Rini wrote:
>
> On Thu, Jan 30, 2020 at 07:27:57PM -0700, Simon Glass wrote:
> > Hi Tom.
> >
> > On Thu, 30 Jan 2020 at 11:52, Tom Rini wrote:
> > >
> > > On Wed, Jan 29, 2020 at 07:17:09PM -0700, Simon Glass wrote:
> > > > Hi Tom,
> > > >
> > > > On
On Thu, Jan 30, 2020 at 07:27:57PM -0700, Simon Glass wrote:
> Hi Tom.
>
> On Thu, 30 Jan 2020 at 11:52, Tom Rini wrote:
> >
> > On Wed, Jan 29, 2020 at 07:17:09PM -0700, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Thu, 23 Jan 2020 at 14:12, Tom Rini wrote:
> > > >
> > > > On Thu, Jan 23,
Hi Tom.
On Thu, 30 Jan 2020 at 11:52, Tom Rini wrote:
>
> On Wed, Jan 29, 2020 at 07:17:09PM -0700, Simon Glass wrote:
> > Hi Tom,
> >
> > On Thu, 23 Jan 2020 at 14:12, Tom Rini wrote:
> > >
> > > On Thu, Jan 23, 2020 at 10:04:05PM +0100, Luka Kovačič wrote:
> > >
> > > > Hello Tom,
> > > >
> >
On Wed, Jan 29, 2020 at 07:17:09PM -0700, Simon Glass wrote:
> Hi Tom,
>
> On Thu, 23 Jan 2020 at 14:12, Tom Rini wrote:
> >
> > On Thu, Jan 23, 2020 at 10:04:05PM +0100, Luka Kovačič wrote:
> >
> > > Hello Tom,
> > >
> > > thank you for feedback and review. I understand the implications.
> > >
Hi Tom,
On Thu, 23 Jan 2020 at 14:12, Tom Rini wrote:
>
> On Thu, Jan 23, 2020 at 10:04:05PM +0100, Luka Kovačič wrote:
>
> > Hello Tom,
> >
> > thank you for feedback and review. I understand the implications.
> > Would it make sense to document this somewhere to avoid any future
> >
On Thu, Jan 23, 2020 at 10:04:05PM +0100, Luka Kovačič wrote:
> Hello Tom,
>
> thank you for feedback and review. I understand the implications.
> Would it make sense to document this somewhere to avoid any future confusion?
Yes, along with a standalone patch to update the document to use
Hello Tom,
thank you for feedback and review. I understand the implications.
Would it make sense to document this somewhere to avoid any future confusion?
Thanks,
Luka
On Thu, Jan 23, 2020 at 1:31 PM Tom Rini wrote:
>
> On Sun, Jan 05, 2020 at 08:10:56PM +0100, Luka Kovacic wrote:
>
> > Use
On Sun, Jan 05, 2020 at 08:10:56PM +0100, Luka Kovacic wrote:
> Use the correct return value in function do_gpio() and update
> commands documentation with the return values from command_ret_t enum.
>
> CMD_RET_SUCCESS is returned on command success and CMD_RET_FAILURE is
> returned on command
Use the correct return value in function do_gpio() and update
commands documentation with the return values from command_ret_t enum.
CMD_RET_SUCCESS is returned on command success and CMD_RET_FAILURE is
returned on command failure.
The command was returning the pin value, which caused confusion
13 matches
Mail list logo
