Re: [PATCH 1/2] rc4: mark key as const

2022-12-18 Thread Kever Yang
On 2022/11/19 00:13, John Keeping wrote: Key data is never written so the parameter can be const, which allows putting fixed keys in .rodata. Signed-off-by: John Keeping Reviewed-by: Kever Yang Thanks, - Kever --- include/rc4.h | 2 +- lib/rc4.c | 2 +- 2 files changed, 2 insertio

Re: [PATCH 1/2] rc4: mark key as const

2022-11-18 Thread Philipp Tomsich
On Fri, 18 Nov 2022 at 17:13, John Keeping wrote: > > Key data is never written so the parameter can be const, which allows > putting fixed keys in .rodata. > > Signed-off-by: John Keeping Reviewed-by: Philipp Tomsich

[PATCH 1/2] rc4: mark key as const

2022-11-18 Thread John Keeping
Key data is never written so the parameter can be const, which allows putting fixed keys in .rodata. Signed-off-by: John Keeping --- include/rc4.h | 2 +- lib/rc4.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/rc4.h b/include/rc4.h index c1ff1349d4..d1257f20