Re: [PATCH 1/2] spi: Remove unnecessary #ifdefs in header file

2020-07-08 Thread Simon Glass
Hi Bin, On Tue, 7 Jul 2020 at 19:05, Bin Meng wrote: > > Hi Simon, > > On Tue, Jul 7, 2020 at 3:58 PM Bin Meng wrote: > > > > On Tue, Jul 7, 2020 at 3:56 PM Bin Meng wrote: > > > > > > On Mon, Jul 6, 2020 at 10:16 AM Simon Glass wrote: > > > > > > > > These prevent use of compile-time checks

Re: [PATCH 1/2] spi: Remove unnecessary #ifdefs in header file

2020-07-07 Thread Bin Meng
Hi Simon, On Tue, Jul 7, 2020 at 3:58 PM Bin Meng wrote: > > On Tue, Jul 7, 2020 at 3:56 PM Bin Meng wrote: > > > > On Mon, Jul 6, 2020 at 10:16 AM Simon Glass wrote: > > > > > > These prevent use of compile-time checks such as: > > > > > > if (CONFIG_IS_ENABLED(DM_SPI)) > > > > > > since,

Re: [PATCH 1/2] spi: Remove unnecessary #ifdefs in header file

2020-07-07 Thread Bin Meng
On Tue, Jul 7, 2020 at 3:56 PM Bin Meng wrote: > > On Mon, Jul 6, 2020 at 10:16 AM Simon Glass wrote: > > > > These prevent use of compile-time checks such as: > > > > if (CONFIG_IS_ENABLED(DM_SPI)) > > > > since, for example, if CONFIG_SPL_DM_SPI is not enabled then the > > definitions are

Re: [PATCH 1/2] spi: Remove unnecessary #ifdefs in header file

2020-07-07 Thread Bin Meng
On Mon, Jul 6, 2020 at 10:16 AM Simon Glass wrote: > > These prevent use of compile-time checks such as: > > if (CONFIG_IS_ENABLED(DM_SPI)) > > since, for example, if CONFIG_SPL_DM_SPI is not enabled then the > definitions are not included by spi.h and the C code will not build. > > The

[PATCH 1/2] spi: Remove unnecessary #ifdefs in header file

2020-07-05 Thread Simon Glass
These prevent use of compile-time checks such as: if (CONFIG_IS_ENABLED(DM_SPI)) since, for example, if CONFIG_SPL_DM_SPI is not enabled then the definitions are not included by spi.h and the C code will not build. The #ifdefs are unnecessary since there are no conflicts with the pre-DM