Re: [PATCH 1/2] spi: nxp_fspi: Fix error reporting

2021-02-26 Thread Jagan Teki
On Tue, Feb 23, 2021 at 6:29 PM Adam Ford wrote: > > On Tue, Jan 19, 2021 at 6:12 AM Pratyush Yadav wrote: > > > > On 18/01/21 03:32PM, Adam Ford wrote: > > > On the i.MX8M Mini, ret = clk_set_rate() sets ret to the value of the > > > rate the clock was able to set. When checking for errors, it

Re: [PATCH 1/2] spi: nxp_fspi: Fix error reporting

2021-02-23 Thread Adam Ford
On Tue, Jan 19, 2021 at 6:12 AM Pratyush Yadav wrote: > > On 18/01/21 03:32PM, Adam Ford wrote: > > On the i.MX8M Mini, ret = clk_set_rate() sets ret to the value of the > > rate the clock was able to set. When checking for errors, it only > > checks that it is not NULL. Since positive numbers

Re: [PATCH 1/2] spi: nxp_fspi: Fix error reporting

2021-01-19 Thread Pratyush Yadav
On 18/01/21 03:32PM, Adam Ford wrote: > On the i.MX8M Mini, ret = clk_set_rate() sets ret to the value of the > rate the clock was able to set. When checking for errors, it only > checks that it is not NULL. Since positive numbers are not errors, > only check for negative numbers when handling

[PATCH 1/2] spi: nxp_fspi: Fix error reporting

2021-01-18 Thread Adam Ford
On the i.MX8M Mini, ret = clk_set_rate() sets ret to the value of the rate the clock was able to set. When checking for errors, it only checks that it is not NULL. Since positive numbers are not errors, only check for negative numbers when handling errors. Fixes: 383fded70c4f ("spi: nxp_fspi: