Re: [PATCH 1/3] usb: dwc3: handle return value of clk_get_rate() correctly

2024-02-05 Thread Yang Xiwen
On 2/5/2024 3:25 PM, Dan Carpenter wrote: On Sat, Feb 03, 2024 at 07:01:54AM +0800, Yang Xiwen via B4 Relay wrote: From: Yang Xiwen clk_get_rate() return -ve on error, not 0. Fix it by replacing judging NULL with IS_ERR_VALUE(). s/NULL/zero/. I'd be surprised if clk_get_rate()

Re: [PATCH 1/3] usb: dwc3: handle return value of clk_get_rate() correctly

2024-02-04 Thread Dan Carpenter
On Sat, Feb 03, 2024 at 07:01:54AM +0800, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen > > clk_get_rate() return -ve on error, not 0. Fix it by replacing judging > NULL with IS_ERR_VALUE(). s/NULL/zero/. I'd be surprised if clk_get_rate() *never* returns zero. The Linux kernel's

[PATCH 1/3] usb: dwc3: handle return value of clk_get_rate() correctly

2024-02-02 Thread Yang Xiwen via B4 Relay
From: Yang Xiwen clk_get_rate() return -ve on error, not 0. Fix it by replacing judging NULL with IS_ERR_VALUE(). Fixes: 6bae0eb5b8bd("usb: dwc3: Calculate REFCLKPER based on reference clock") Signed-off-by: Yang Xiwen --- drivers/usb/dwc3/core.c | 2 +- 1 file changed, 1 insertion(+), 1