Re: [PATCH 11/11] roc-rk3399-pc: Add SPI boot support

2020-01-07 Thread Kever Yang
Hi Jagan, On 2019/12/30 下午3:52, Jagan Teki wrote: On Mon, Dec 30, 2019 at 8:35 AM Kever Yang wrote: On 2019/12/21 下午3:54, Jagan Teki wrote: Add SPI boot support for ROC-RK3399-PC board. This would add separate config file What is the key reason to have a new separate config file? I think

Re: [PATCH 11/11] roc-rk3399-pc: Add SPI boot support

2019-12-29 Thread Jagan Teki
On Mon, Dec 30, 2019 at 8:35 AM Kever Yang wrote: > > > On 2019/12/21 下午3:54, Jagan Teki wrote: > > Add SPI boot support for ROC-RK3399-PC board. > > > > This would add separate config file > > What is the key reason to have a new separate config file? I think it > would be much better > > to use

Re: [PATCH 11/11] roc-rk3399-pc: Add SPI boot support

2019-12-29 Thread Kever Yang
On 2019/12/21 下午3:54, Jagan Teki wrote: Add SPI boot support for ROC-RK3399-PC board. This would add separate config file What is the key reason to have a new separate config file? I think it would be much better to use the same defconfig, spi boot is one of features like other

[PATCH 11/11] roc-rk3399-pc: Add SPI boot support

2019-12-20 Thread Jagan Teki
Add SPI boot support for ROC-RK3399-PC board. This would add separate config file for SPI along with dts changes. Signed-off-by: Jagan Teki --- arch/arm/dts/rk3399-roc-pc-u-boot.dtsi | 12 - board/rockchip/evb_rk3399/MAINTAINERS | 2 + configs/roc-pc-rk3399-spi_defconfig| 62