Re: [PATCH 2/2] phy: rockchip-inno-usb2: Limit changes made to regs

2024-03-13 Thread Kever Yang
On 2024/2/26 06:10, Jonas Karlman wrote: The USB2PHY regs already contain working default reset values for RK3328 and RK35xx as evidenced by the fact that this driver never has changed a single value for these SoCs. Reduce to only configure utmi_suspend_n and utmi_sel bits similar to what is

Re: [PATCH 2/2] phy: rockchip-inno-usb2: Limit changes made to regs

2024-03-08 Thread Jonas Karlman
Hi Kever, On 2024-03-08 10:06, Kever Yang wrote: > Hi Jonas, > > On 2024/2/26 06:10, Jonas Karlman wrote: >> The USB2PHY regs already contain working default reset values for RK3328 >> and RK35xx as evidenced by the fact that this driver never has changed a >> single value for these SoCs. > > I

Re: [PATCH 2/2] phy: rockchip-inno-usb2: Limit changes made to regs

2024-03-08 Thread Kever Yang
Hi Jonas, On 2024/2/26 06:10, Jonas Karlman wrote: The USB2PHY regs already contain working default reset values for RK3328 and RK35xx as evidenced by the fact that this driver never has changed a single value for these SoCs. I would prefer to keep it as is for now, I think these configs are

[PATCH 2/2] phy: rockchip-inno-usb2: Limit changes made to regs

2024-02-25 Thread Jonas Karlman
The USB2PHY regs already contain working default reset values for RK3328 and RK35xx as evidenced by the fact that this driver never has changed a single value for these SoCs. Reduce to only configure utmi_suspend_n and utmi_sel bits similar to what is currently done on RK3399. Also add missing