Re: [PATCH 2/2] sf: Simplify probe for dm code

2020-07-08 Thread Jagan Teki
On Thu, May 14, 2020 at 11:39 PM Jagan Teki wrote: > > Handling probing code for a particular uclass between > dm vs nodm always confusing and requires additional > ifdefs to handle them properly. > > But, having separate low-level code bases for dm and > nodm can make it easy for the command leve

Re: [PATCH 2/2] sf: Simplify probe for dm code

2020-05-26 Thread Jagan Teki
On Tue, May 26, 2020 at 5:11 AM Tom Rini wrote: > > On Mon, May 25, 2020 at 03:48:22PM -0600, Simon Glass wrote: > > Hi Jagan, > > > > On Mon, 25 May 2020 at 02:14, Jagan Teki wrote: > > > > > > Hi Simon, > > > > > > On Fri, May 22, 2020 at 10:20 PM Simon Glass wrote: > > > > > > > > Hi Jagan, >

Re: [PATCH 2/2] sf: Simplify probe for dm code

2020-05-26 Thread Jagan Teki
On Tue, May 26, 2020 at 3:18 AM Simon Glass wrote: > > Hi Jagan, > > On Mon, 25 May 2020 at 02:14, Jagan Teki wrote: > > > > Hi Simon, > > > > On Fri, May 22, 2020 at 10:20 PM Simon Glass wrote: > > > > > > Hi Jagan, > > > > > > On Fri, 22 May 2020 at 08:41, Jagan Teki > > > wrote: > > > > > >

Re: [PATCH 2/2] sf: Simplify probe for dm code

2020-05-25 Thread Tom Rini
On Mon, May 25, 2020 at 03:48:22PM -0600, Simon Glass wrote: > Hi Jagan, > > On Mon, 25 May 2020 at 02:14, Jagan Teki wrote: > > > > Hi Simon, > > > > On Fri, May 22, 2020 at 10:20 PM Simon Glass wrote: > > > > > > Hi Jagan, > > > > > > On Fri, 22 May 2020 at 08:41, Jagan Teki > > > wrote: > >

Re: [PATCH 2/2] sf: Simplify probe for dm code

2020-05-25 Thread Simon Glass
Hi Jagan, On Mon, 25 May 2020 at 02:14, Jagan Teki wrote: > > Hi Simon, > > On Fri, May 22, 2020 at 10:20 PM Simon Glass wrote: > > > > Hi Jagan, > > > > On Fri, 22 May 2020 at 08:41, Jagan Teki wrote: > > > > > > Hi Simon, > > > > > > On Fri, May 22, 2020 at 7:55 PM Simon Glass wrote: > > > >

Re: [PATCH 2/2] sf: Simplify probe for dm code

2020-05-25 Thread Jagan Teki
Hi Simon, On Fri, May 22, 2020 at 10:20 PM Simon Glass wrote: > > Hi Jagan, > > On Fri, 22 May 2020 at 08:41, Jagan Teki wrote: > > > > Hi Simon, > > > > On Fri, May 22, 2020 at 7:55 PM Simon Glass wrote: > > > > > > Hi Jagan, > > > > > > On Thu, 14 May 2020 at 12:09, Jagan Teki > > > wrote:

Re: [PATCH 2/2] sf: Simplify probe for dm code

2020-05-22 Thread Tom Rini
On Fri, May 22, 2020 at 10:50:35AM -0600, Simon Glass wrote: > Hi Jagan, > > On Fri, 22 May 2020 at 08:41, Jagan Teki wrote: > > > > Hi Simon, > > > > On Fri, May 22, 2020 at 7:55 PM Simon Glass wrote: > > > > > > Hi Jagan, > > > > > > On Thu, 14 May 2020 at 12:09, Jagan Teki > > > wrote: > >

Re: [PATCH 2/2] sf: Simplify probe for dm code

2020-05-22 Thread Simon Glass
Hi Jagan, On Fri, 22 May 2020 at 08:41, Jagan Teki wrote: > > Hi Simon, > > On Fri, May 22, 2020 at 7:55 PM Simon Glass wrote: > > > > Hi Jagan, > > > > On Thu, 14 May 2020 at 12:09, Jagan Teki wrote: > > > > > > Handling probing code for a particular uclass between > > > dm vs nodm always conf

Re: [PATCH 2/2] sf: Simplify probe for dm code

2020-05-22 Thread Jagan Teki
Hi Simon, On Fri, May 22, 2020 at 7:55 PM Simon Glass wrote: > > Hi Jagan, > > On Thu, 14 May 2020 at 12:09, Jagan Teki wrote: > > > > Handling probing code for a particular uclass between > > dm vs nodm always confusing and requires additional > > ifdefs to handle them properly. > > > > But, ha

Re: [PATCH 2/2] sf: Simplify probe for dm code

2020-05-22 Thread Tom Rini
On Fri, May 22, 2020 at 08:24:58AM -0600, Simon Glass wrote: > Hi Jagan, > > On Thu, 14 May 2020 at 12:09, Jagan Teki wrote: > > > > Handling probing code for a particular uclass between > > dm vs nodm always confusing and requires additional > > ifdefs to handle them properly. > > > > But, havin

Re: [PATCH 2/2] sf: Simplify probe for dm code

2020-05-22 Thread Simon Glass
Hi Jagan, On Thu, 14 May 2020 at 12:09, Jagan Teki wrote: > > Handling probing code for a particular uclass between > dm vs nodm always confusing and requires additional > ifdefs to handle them properly. > > But, having separate low-level code bases for dm and > nodm can make it easy for the comm

[PATCH 2/2] sf: Simplify probe for dm code

2020-05-14 Thread Jagan Teki
Handling probing code for a particular uclass between dm vs nodm always confusing and requires additional ifdefs to handle them properly. But, having separate low-level code bases for dm and nodm can make it easy for the command level to use same function name to probe the devices. This would inde