Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-19 Thread Anatolij Gustschin
On Wed, 20 May 2020 00:05:01 +0200 Anatolij Gustschin ag...@denx.de wrote: ... > When uclass_get_device_by_name() is used, then > imx_sc_thermal_ofdata_to_platdata() > is called for "cpu-thermal0" device, here getting the list works > and alert/critical pdata values are initialized properly. This

Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-19 Thread Anatolij Gustschin
On Tue, 19 May 2020 11:45:55 + Peng Fan peng@nxp.com wrote: ... > Do you have more insights about uclass_get_device and > uclass_get_device_byname? > uclass_get_device not work, but uclass_get_device_byname work. well, we have three thermal uclass devices on i.MX8QXP: thermal 0 [

Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-19 Thread Fabio Estevam
Hi Heiko, On Tue, May 19, 2020 at 1:18 AM Heiko Schocher wrote: > I am happy to add boards! > > @Anatolij: Do we have this board in our vlab? Or somehow remote accessible? > > @Fabio: I am sure you have some boards for testing, do you have a CI >setup for them? With the approach to report te

RE: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-19 Thread Peng Fan
+Simon > -Original Message- > From: Anatolij Gustschin > Sent: 2020年5月19日 18:27 > To: Peng Fan > Cc: u-boot@lists.denx.de; Ye Li ; Frank Li > ; sba...@denx.de > Subject: Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert > property value > >

Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-19 Thread Anatolij Gustschin
On Tue, 19 May 2020 10:05:21 + Peng Fan peng@nxp.com wrote: ... > Would this help? > > diff --git a/drivers/cpu/imx8_cpu.c b/drivers/cpu/imx8_cpu.c > index 95c14c98d8..6c949ccbd4 100644 > --- a/drivers/cpu/imx8_cpu.c > +++ b/drivers/cpu/imx8_cpu.c > @@ -68,10 +68,13 @@ static int cpu_imx_g

RE: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-19 Thread Peng Fan
> Subject: Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert > property value > > Hi Peng, > > On Sun, 17 May 2020 16:53:17 +0200 > Anatolij Gustschin ag...@denx.de wrote: > ... > > Will try to bisect later. > > bise

Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-19 Thread Anatolij Gustschin
Hi Peng, On Sun, 17 May 2020 16:53:17 +0200 Anatolij Gustschin ag...@denx.de wrote: ... > Will try to bisect later. bisecting leads to: # first bad commit: [3ee6ea443eb466399ab325a58b377326ac5c57b5] cpu: imx_cpu: Print the CPU temperature for iMX8QM A72 -- Anatolij

Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-19 Thread Anatolij Gustschin
Hi Heiko, On Tue, 19 May 2020 06:17:58 +0200 Heiko Schocher h...@denx.de wrote: ... > > Would it be possible to add this i.MX8QXP capricorn/giedi board into > > Heiko's boot farm? > > I am happy to add boards! > > @Anatolij: Do we have this board in our vlab? Or somehow remote accessible? No,

Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-19 Thread Anatolij Gustschin
Hi Fabio, On Mon, 18 May 2020 20:32:06 -0300 Fabio Estevam feste...@gmail.com wrote: ... > Would it be possible to add this i.MX8QXP capricorn/giedi board into > Heiko's boot farm? this board requires a very special power supply and I have only one power supply unit of that type and can't share i

Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-18 Thread Heiko Schocher
Hello Fabio, Anatolij, Am 19.05.2020 um 01:32 schrieb Fabio Estevam: Hi Anatolij and Heiko, On Sun, May 17, 2020 at 8:19 AM Anatolij Gustschin wrote: I've tested i.MX8QXP based capricorn/giedi board (giedi_defconfig, imx8-giedi.dts) and it was not booting: U-Boot SPL 2020.07-rc2-00124-g515

Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-18 Thread Fabio Estevam
Hi Anatolij and Heiko, On Sun, May 17, 2020 at 8:19 AM Anatolij Gustschin wrote: > I've tested i.MX8QXP based capricorn/giedi board (giedi_defconfig, > imx8-giedi.dts) > and it was not booting: > > U-Boot SPL 2020.07-rc2-00124-g515f613253 (May 16 2020 - 09:22:49 +0200) > Trying to boot from MMC

Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-17 Thread Anatolij Gustschin
On Sun, 17 May 2020 14:43:39 + Peng Fan peng@nxp.com wrote: ... > > CPU Temperature (35000C) has beyond alert (0C), close to critical (0C) > > waiting... > > Sorry for not be clear, I mean which code change breaks the boot? I didn't bisect this, so I do not know exactly. Last working re

RE: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-17 Thread Peng Fan
> Subject: Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert > property value > > Hi Peng, > > On Sun, 17 May 2020 10:04:58 + > Peng Fan peng@nxp.com wrote: > > > Hi Anatolij, > > > > > Subject: [PATCH 2/2] thermal: imx_scu

Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-17 Thread Anatolij Gustschin
Hi Peng, On Sun, 17 May 2020 10:04:58 + Peng Fan peng@nxp.com wrote: > Hi Anatolij, > > > Subject: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property > > value > > > > Fix boot hang with endless loop outputting: > > CPU Temperature (

RE: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-17 Thread Peng Fan
Hi Anatolij, > Subject: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property > value > > Fix boot hang with endless loop outputting: > CPU Temperature (47200C) has beyond alert (0C), close to critical (0C) > waiting... Could you share more info which part w

[PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-16 Thread Anatolij Gustschin
Fix boot hang with endless loop outputting: CPU Temperature (47200C) has beyond alert (0C), close to critical (0C) waiting... Signed-off-by: Anatolij Gustschin --- i.MX8QXP is broken again, this should be appied ASAP! drivers/thermal/imx_scu_thermal.c | 101 -- 1 fi