Re: [PATCH 2/3] image-cipher: Fix FIT_CIPHER linking

2020-12-07 Thread Joel Stanley
On Mon, 7 Dec 2020 at 17:07, Philippe REYNES wrote: > > Hi Joel, > > sorry for this very late answer .. > > > This patch fix this issue when only the ciphering is enabled. > But it breaks the compilation when signature and ciphering are > enabled, because both functions image_set_host_blob and >

Re: [PATCH 2/3] image-cipher: Fix FIT_CIPHER linking

2020-12-07 Thread Philippe REYNES
Hi Joel, sorry for this very late answer .. This patch fix this issue when only the ciphering is enabled. But it breaks the compilation when signature and ciphering are enabled, because both functions image_set_host_blob and image_get_host_blob are defined twice. So it is a NAK for me. A

[PATCH 2/3] image-cipher: Fix FIT_CIPHER linking

2020-11-11 Thread Joel Stanley
When CONFIG_FIT_CIPHER=y and CONFIG_FIT_SIGNATURE=n is there is no implementation of image_get_host_blob for mkimage or dumpimage: /usr/bin/ld: tools/common/image-cipher.o: in function `fit_image_decrypt_data': image-cipher.c:(.text+0x9a): undefined reference to `image_get_host_blob' The