Re: [PATCH 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-09 Thread Eugen Hristev
On 3/9/23 11:11, Xavier Drudis Ferran wrote: El Wed, Mar 08, 2023 at 01:59:54PM +0200, Eugen Hristev deia: On 3/8/23 13:30, Xavier Drudis Ferran wrote: El Fri, Mar 03, 2023 at 09:31:33AM +0200, Eugen Hristev deia: @@ -105,6 +130,17 @@ static int rockchip_usb2phy_power_off(struct phy *phy)

Re: [PATCH 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-09 Thread Xavier Drudis Ferran
El Wed, Mar 08, 2023 at 01:59:54PM +0200, Eugen Hristev deia: > On 3/8/23 13:30, Xavier Drudis Ferran wrote: > > El Fri, Mar 03, 2023 at 09:31:33AM +0200, Eugen Hristev deia: > > > @@ -105,6 +130,17 @@ static int rockchip_usb2phy_power_off(struct phy > > > *phy) > > > struct udevice *par

Re: [PATCH 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-08 Thread Eugen Hristev
On 3/8/23 13:30, Xavier Drudis Ferran wrote: El Fri, Mar 03, 2023 at 09:31:33AM +0200, Eugen Hristev deia: @@ -105,6 +130,17 @@ static int rockchip_usb2phy_power_off(struct phy *phy) struct udevice *parent = dev_get_parent(phy->dev); struct rockchip_usb2phy *priv = dev_get_priv(p

Re: [PATCH 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-08 Thread Xavier Drudis Ferran
El Fri, Mar 03, 2023 at 09:31:33AM +0200, Eugen Hristev deia: > @@ -105,6 +130,17 @@ static int rockchip_usb2phy_power_off(struct phy *phy) > struct udevice *parent = dev_get_parent(phy->dev); > struct rockchip_usb2phy *priv = dev_get_priv(parent); > const struct rockchip_usb2phy_

Re: [PATCH 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-07 Thread Vasily Khoruzhick
On Thu, Mar 2, 2023 at 11:32 PM Eugen Hristev wrote: > > Add initial support for the rk3588 PHY variant. > The driver now looks for phy-supply and enables/disables the vbus > accordingly. > The lookup for the host-port reg inside the struct now does a do {} while() > instead of a while() {} in ord

Re: [PATCH 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-07 Thread Kever Yang
On 2023/3/3 15:31, Eugen Hristev wrote: Add initial support for the rk3588 PHY variant. The driver now looks for phy-supply and enables/disables the vbus accordingly. The lookup for the host-port reg inside the struct now does a do {} while() instead of a while() {} in order to allow a first ch

[PATCH 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-02 Thread Eugen Hristev
Add initial support for the rk3588 PHY variant. The driver now looks for phy-supply and enables/disables the vbus accordingly. The lookup for the host-port reg inside the struct now does a do {} while() instead of a while() {} in order to allow a first check for reg == 0. Co-developed-by: Frank Wa