Re: [PATCH 4/4] rockchip: Enable HDMI output on rk3399 board w/ HDMI

2020-03-02 Thread Peter Robinson
> +#define ROCKCHIP_DEVICE_SETTINGS \ > + "stdin=serial,cros-ec-keyb\0" \ This should likely be a usb keyboard and not the CrOS EC keyboard. > + "stdout=serial,vidconsole\0" \ > + "stderr=serial,vidconsole\0" > + > #include > > #if

Re: [PATCH 4/4] rockchip: Enable HDMI output on rk3399 board w/ HDMI

2020-02-03 Thread Anatolij Gustschin
On Mon, 3 Feb 2020 09:47:08 -0500 Tom Rini tr...@konsulko.com wrote: ... > > yes, this evb board config is common across most of the rk3399 > > defconfig boards. this patch enable hdmi on few rk3399 boards all use > > same config file, evb_rk3399.h > > Yes, the ROCKCHIP_DEVICE_SETTINGS part

Re: [PATCH 4/4] rockchip: Enable HDMI output on rk3399 board w/ HDMI

2020-02-03 Thread Tom Rini
On Mon, Feb 03, 2020 at 04:55:27PM +0530, Jagan Teki wrote: > On Fri, Jan 24, 2020 at 8:57 PM Tom Rini wrote: > > > > On Thu, Jan 23, 2020 at 09:58:45PM +0530, Jagan Teki wrote: > > > > > Enable config options and console setting to respective > > > rk3399 board for HDMI output. > > > > > >

Re: [PATCH 4/4] rockchip: Enable HDMI output on rk3399 board w/ HDMI

2020-02-03 Thread Jagan Teki
On Fri, Jan 24, 2020 at 8:57 PM Tom Rini wrote: > > On Thu, Jan 23, 2020 at 09:58:45PM +0530, Jagan Teki wrote: > > > Enable config options and console setting to respective > > rk3399 board for HDMI output. > > > > Boards supported and tested on this patch are: > > - NanoPc T4 > > - NanoPi M4 >

Re: [PATCH 4/4] rockchip: Enable HDMI output on rk3399 board w/ HDMI

2020-01-24 Thread Anatolij Gustschin
On Fri, 24 Jan 2020 10:27:35 -0500 Tom Rini tr...@konsulko.com wrote: > This seems like another commit (along with the question I saw about > i.MX FB not showing the right colors) 2cc393f32fd9 needs to be reworked > so that we default to enabling everything still but let boards opt out > rather

Re: [PATCH 4/4] rockchip: Enable HDMI output on rk3399 board w/ HDMI

2020-01-24 Thread Tom Rini
On Thu, Jan 23, 2020 at 09:58:45PM +0530, Jagan Teki wrote: > Enable config options and console setting to respective > rk3399 board for HDMI output. > > Boards supported and tested on this patch are: > - NanoPc T4 > - NanoPi M4 > - NanoPi Neo4 > - ROC-RK3399-PC > > Signed-off-by: Jagan Teki >

[PATCH 4/4] rockchip: Enable HDMI output on rk3399 board w/ HDMI

2020-01-23 Thread Jagan Teki
Enable config options and console setting to respective rk3399 board for HDMI output. Boards supported and tested on this patch are: - NanoPc T4 - NanoPi M4 - NanoPi Neo4 - ROC-RK3399-PC Signed-off-by: Jagan Teki --- configs/nanopc-t4-rk3399_defconfig | 6 ++