Re: [PATCH 4/5] eficonfig: include EFI_STATUS string in error message

2023-02-13 Thread Masahisa Kojima
On Mon, 13 Feb 2023 at 18:46, Heinrich Schuchardt wrote: > > On 2/13/23 10:42, Masahisa Kojima wrote: > > Hi Heinrich, > > > > On Mon, 13 Feb 2023 at 16:44, Heinrich Schuchardt > > wrote: > >> > >> On 2/13/23 06:50, Masahisa Kojima wrote: > >>> On Fri, 10 Feb 2023 at 20:57, Heinrich Schuchardt

Re: [PATCH 4/5] eficonfig: include EFI_STATUS string in error message

2023-02-13 Thread Heinrich Schuchardt
On 2/13/23 10:42, Masahisa Kojima wrote: Hi Heinrich, On Mon, 13 Feb 2023 at 16:44, Heinrich Schuchardt wrote: On 2/13/23 06:50, Masahisa Kojima wrote: On Fri, 10 Feb 2023 at 20:57, Heinrich Schuchardt wrote: On 2/2/23 10:24, Masahisa Kojima wrote: Current eficonfig_print_msg() does not

Re: [PATCH 4/5] eficonfig: include EFI_STATUS string in error message

2023-02-13 Thread Masahisa Kojima
Hi Heinrich, On Mon, 13 Feb 2023 at 16:44, Heinrich Schuchardt wrote: > > On 2/13/23 06:50, Masahisa Kojima wrote: > > On Fri, 10 Feb 2023 at 20:57, Heinrich Schuchardt > > wrote: > >> > >> On 2/2/23 10:24, Masahisa Kojima wrote: > >>> Current eficonfig_print_msg() does not show the return >

Re: [PATCH 4/5] eficonfig: include EFI_STATUS string in error message

2023-02-12 Thread Heinrich Schuchardt
On 2/13/23 06:50, Masahisa Kojima wrote: On Fri, 10 Feb 2023 at 20:57, Heinrich Schuchardt wrote: On 2/2/23 10:24, Masahisa Kojima wrote: Current eficonfig_print_msg() does not show the return value of EFI Boot/Runtime Services when the service call fails. With this commit, user can know

Re: [PATCH 4/5] eficonfig: include EFI_STATUS string in error message

2023-02-12 Thread Masahisa Kojima
On Fri, 10 Feb 2023 at 20:57, Heinrich Schuchardt wrote: > > On 2/2/23 10:24, Masahisa Kojima wrote: > > Current eficonfig_print_msg() does not show the return > > value of EFI Boot/Runtime Services when the service call fails. > > With this commit, user can know EFI_STATUS in the error message.

Re: [PATCH 4/5] eficonfig: include EFI_STATUS string in error message

2023-02-10 Thread Heinrich Schuchardt
On 2/2/23 10:24, Masahisa Kojima wrote: Current eficonfig_print_msg() does not show the return value of EFI Boot/Runtime Services when the service call fails. With this commit, user can know EFI_STATUS in the error message. Why do we need function eficonfig_print_msg()? I cannot see why the

[PATCH 4/5] eficonfig: include EFI_STATUS string in error message

2023-02-02 Thread Masahisa Kojima
Current eficonfig_print_msg() does not show the return value of EFI Boot/Runtime Services when the service call fails. With this commit, user can know EFI_STATUS in the error message. Signed-off-by: Masahisa Kojima --- cmd/eficonfig.c | 95 +--