Re: [PATCH V4 3/7] rockchip: boot_mode: Allow rockchip_dnl_key_pressed() in SPL

2024-02-05 Thread Kever Yang
On 2024/1/25 06:55, Chris Morgan wrote: On Fri, Jan 19, 2024 at 05:01:38PM +0800, Kever Yang wrote: Hi Chris, On 2024/1/18 23:06, Chris Morgan wrote: On Thu, Jan 18, 2024 at 03:20:52PM +0800, Kever Yang wrote: Hi Chris, On 2024/1/2 23:46, Chris Morgan wrote: From: Chris Morgan Update

Re: [PATCH V4 3/7] rockchip: boot_mode: Allow rockchip_dnl_key_pressed() in SPL

2024-01-24 Thread Chris Morgan
On Fri, Jan 19, 2024 at 05:01:38PM +0800, Kever Yang wrote: > Hi Chris, > > On 2024/1/18 23:06, Chris Morgan wrote: > > On Thu, Jan 18, 2024 at 03:20:52PM +0800, Kever Yang wrote: > > > Hi Chris, > > > > > > On 2024/1/2 23:46, Chris Morgan wrote: > > > > From: Chris Morgan > > > > > > > >

Re: [PATCH V4 3/7] rockchip: boot_mode: Allow rockchip_dnl_key_pressed() in SPL

2024-01-19 Thread Kever Yang
Hi Chris, On 2024/1/18 23:06, Chris Morgan wrote: On Thu, Jan 18, 2024 at 03:20:52PM +0800, Kever Yang wrote: Hi Chris, On 2024/1/2 23:46, Chris Morgan wrote: From: Chris Morgan Update the rockchip_dnl_key_pressed() so that it can run in SPL. Also change the ADC channel to a define that can

Re: [PATCH V4 3/7] rockchip: boot_mode: Allow rockchip_dnl_key_pressed() in SPL

2024-01-18 Thread Chris Morgan
On Thu, Jan 18, 2024 at 03:20:52PM +0800, Kever Yang wrote: > Hi Chris, > > On 2024/1/2 23:46, Chris Morgan wrote: > > From: Chris Morgan > > > > Update the rockchip_dnl_key_pressed() so that it can run in > > SPL. Also change the ADC channel to a define that can be > > overridden by a board

Re: [PATCH V4 3/7] rockchip: boot_mode: Allow rockchip_dnl_key_pressed() in SPL

2024-01-17 Thread Kever Yang
Hi Chris, On 2024/1/2 23:46, Chris Morgan wrote: From: Chris Morgan Update the rockchip_dnl_key_pressed() so that it can run in SPL. Also change the ADC channel to a define that can be overridden by a board specific option. I should ask this earlier. Why you have to enable the download key

[PATCH V4 3/7] rockchip: boot_mode: Allow rockchip_dnl_key_pressed() in SPL

2024-01-02 Thread Chris Morgan
From: Chris Morgan Update the rockchip_dnl_key_pressed() so that it can run in SPL. Also change the ADC channel to a define that can be overridden by a board specific option. Signed-off-by: Chris Morgan --- arch/arm/mach-rockchip/Makefile| 4 ++-- arch/arm/mach-rockchip/boot_mode.c | 11