Re: [PATCH V7 14/14] common: Replace #ifdef and #if with if's

2023-04-18 Thread Nikhil M Jain
On 17/04/23 11:09, Devarsh Thakkar wrote: Hi Nikhil, Thanks for the patch. On 10/04/23 12:58, Nikhil M Jain wrote: Remove #ifdef in header file to avoid multiple definitions while multiple definitions doesnt seem to be right phrase as that will give compilation error anyway. compilation.

Re: [PATCH V7 14/14] common: Replace #ifdef and #if with if's

2023-04-18 Thread Nikhil M Jain
Hi Devarsh On 17/04/23 11:09, Devarsh Thakkar wrote: Hi Nikhil, Thanks for the patch. On 10/04/23 12:58, Nikhil M Jain wrote: Remove #ifdef in header file to avoid multiple definitions while multiple definitions doesnt seem to be right phrase as that will give compilation error anyway. com

Re: [PATCH V7 14/14] common: Replace #ifdef and #if with if's

2023-04-16 Thread Devarsh Thakkar
Hi Nikhil, Thanks for the patch. On 10/04/23 12:58, Nikhil M Jain wrote: > Remove #ifdef in header file to avoid multiple definitions while multiple definitions doesnt seem to be right phrase as that will give compilation error anyway. > compilation. To improve code readability use if() rather t

[PATCH V7 14/14] common: Replace #ifdef and #if with if's

2023-04-10 Thread Nikhil M Jain
Remove #ifdef in header file to avoid multiple definitions while compilation. To improve code readability use if() rather than if's and '#ifdef's'. Signed-off-by: Nikhil M Jain --- V7(patch introduced): - Replace #ifdef and #if with if's. common/bmp.c | 12 +++- common/splash.c | 1