Re: [PATCH V8 14/14] common: Replace #ifdef and #if with if's

2023-04-19 Thread Devarsh Thakkar
Hi Nikhil, Thanks for the patch. On 19/04/23 11:40, Nikhil M Jain wrote: > Avoid using preprocessor compilation directives and instead use simple > logical expressions for better readability since compiler will anyway > optimize out the respective code block if condition is not satisfied. > >

Re: [PATCH V8 14/14] common: Replace #ifdef and #if with if's

2023-04-19 Thread Simon Glass
On Wed, 19 Apr 2023 at 18:11, Nikhil M Jain wrote: > > Avoid using preprocessor compilation directives and instead use simple > logical expressions for better readability since compiler will anyway > optimize out the respective code block if condition is not satisfied. > > Signed-off-by: Nikhil M

[PATCH V8 14/14] common: Replace #ifdef and #if with if's

2023-04-19 Thread Nikhil M Jain
Avoid using preprocessor compilation directives and instead use simple logical expressions for better readability since compiler will anyway optimize out the respective code block if condition is not satisfied. Signed-off-by: Nikhil M Jain --- V8: - Update as per review comments. - Call