RE: [PATCH v1] arm: socfpga: fix Gen5 enable of EMAC via FPGA

2020-10-19 Thread Tan, Ley Foon
> -Original Message- > From: Ralph Siemsen > Sent: Tuesday, October 20, 2020 1:43 AM > To: Tan, Ley Foon > Cc: Dinh Nguyen ; Marek Vasut ; > Simon Goldschmidt ; u- > b...@lists.denx.de; Tom Rini > Subject: Re: [PATCH v1] arm: socfpga: fix Gen5 enable of EMAC v

Re: [PATCH v1] arm: socfpga: fix Gen5 enable of EMAC via FPGA

2020-10-19 Thread Ralph Siemsen
On Tue, Sep 29, 2020 at 02:52:05PM -0400, Ralph Siemsen wrote: Fixes: db5741f7a85ec3ee79b64496172afaa7dc2cb225 ("arm: socfpga: Convert system manager from struct to defines") Just curious if you have had a chance to look over this patch?

[PATCH v1] arm: socfpga: fix Gen5 enable of EMAC via FPGA

2020-09-29 Thread Ralph Siemsen
An earlier conversion from struct to defines introduced two errors, both related to setup of EMAC routed via the FPGA. One of the offsets was incorrect, and the EMAC0/EMAC1 were swapped. The effect of this was rather odd: both ports could operate at gigabit, but one of them would fail to transmit