Re: [PATCH v1] riscv: cpu: improve multi-letter extension detection in supports_extension()

2024-03-05 Thread Conor Dooley
On Tue, Mar 05, 2024 at 09:10:59AM +0100, Heinrich Schuchardt wrote: > On 3/5/24 08:54, Conor Dooley wrote: > > On Tue, Mar 05, 2024 at 08:34:20AM +0100, Heinrich Schuchardt wrote: > > > On 3/5/24 00:28, Conor Dooley wrote: > > > > From: Conor Dooley > > > According to > > >

Re: [PATCH v1] riscv: cpu: improve multi-letter extension detection in supports_extension()

2024-03-05 Thread Heinrich Schuchardt
On 3/5/24 08:54, Conor Dooley wrote: On Tue, Mar 05, 2024 at 08:34:20AM +0100, Heinrich Schuchardt wrote: On 3/5/24 00:28, Conor Dooley wrote: From: Conor Dooley According to https://github.com/riscv/riscv-isa-manual/blob/main/src/naming.adoc the ISA string is case insensitive. Why can we

Re: [PATCH v1] riscv: cpu: improve multi-letter extension detection in supports_extension()

2024-03-04 Thread Conor Dooley
On Tue, Mar 05, 2024 at 08:34:20AM +0100, Heinrich Schuchardt wrote: > On 3/5/24 00:28, Conor Dooley wrote: > > From: Conor Dooley > According to > https://github.com/riscv/riscv-isa-manual/blob/main/src/naming.adoc the > ISA string is case insensitive. Why can we assume here that it is lower >

Re: [PATCH v1] riscv: cpu: improve multi-letter extension detection in supports_extension()

2024-03-04 Thread Heinrich Schuchardt
On 3/5/24 00:28, Conor Dooley wrote: From: Conor Dooley The first multi-letter extension after the single-letter extensions does not have to be preceded by an underscore, which could cause the parser to mistakenly find a single-letter extension after the start of the multi-letter portion of

[PATCH v1] riscv: cpu: improve multi-letter extension detection in supports_extension()

2024-03-04 Thread Conor Dooley
From: Conor Dooley The first multi-letter extension after the single-letter extensions does not have to be preceded by an underscore, which could cause the parser to mistakenly find a single-letter extension after the start of the multi-letter portion of the string. Three letters precede