Re: [PATCH v1 3/3] arm: npcm8xx: support dcache off

2023-10-03 Thread Jim Liu
Hi Tom Thanks for your reply. I will create another thread for this topic. Best regards, Jim On Mon, Oct 2, 2023 at 7:04 AM Tom Rini wrote: > > On Mon, Oct 02, 2023 at 12:40:54AM -0700, Jim Liu wrote: > > > Hi Tom > > > > I followed your suggestion to modify the code. > > but still have

Re: [PATCH v1 3/3] arm: npcm8xx: support dcache off

2023-10-02 Thread Tom Rini
On Mon, Oct 02, 2023 at 12:40:54AM -0700, Jim Liu wrote: > Hi Tom > > I followed your suggestion to modify the code. > but still have errors. > Should I use my workaround? No, please figure out the errors, or at least post what you've got, thanks. > > Best regards, > Jim > > On Thu, Sep 28,

Re: [PATCH v1 3/3] arm: npcm8xx: support dcache off

2023-10-02 Thread Jim Liu
Hi Tom I followed your suggestion to modify the code. but still have errors. Should I use my workaround? Best regards, Jim On Thu, Sep 28, 2023 at 9:17 AM Tom Rini wrote: > > On Thu, Sep 28, 2023 at 10:32:51PM +0800, Jim Liu wrote: > > Hi Tom > > > > Thanks for your understanding. > > but

Re: [PATCH v1 3/3] arm: npcm8xx: support dcache off

2023-09-28 Thread Tom Rini
On Thu, Sep 28, 2023 at 10:32:51PM +0800, Jim Liu wrote: > Hi Tom > > Thanks for your understanding. > but this patch is an incomplete patch. > After I applied this patch I had another error. > > arch/arm/cpu/armv8/cache_v8.c:773:2: error: #error Please describe > your MMU layout in

Re: [PATCH v1 3/3] arm: npcm8xx: support dcache off

2023-09-28 Thread Jim Liu
Hi Tom Thanks for your understanding. but this patch is an incomplete patch. After I applied this patch I had another error. arch/arm/cpu/armv8/cache_v8.c:773:2: error: #error Please describe your MMU layout in CONFIG_SYS_MEM_MAP and enable dcache. 773 | #error Please describe your MMU

Re: [PATCH v1 3/3] arm: npcm8xx: support dcache off

2023-09-28 Thread Tom Rini
On Thu, Sep 28, 2023 at 08:49:23AM +0800, Jim Liu wrote: > Hi Tom > > Thanks for the quick review. > > if we set the CONFIG_SYS_DCACHE_OFF the armv8 will build error. > So we added a workaround for our bmc uboot. > > the error message as below: > > CONFIG_SYS_DCACHE_OFF can't be enabled on

Re: [PATCH v1 3/3] arm: npcm8xx: support dcache off

2023-09-27 Thread Jim Liu
Hi Tom Thanks for the quick review. if we set the CONFIG_SYS_DCACHE_OFF the armv8 will build error. So we added a workaround for our bmc uboot. the error message as below: CONFIG_SYS_DCACHE_OFF can't be enabled on armv8, or the following build error would happen. arch/arm/cpu/armv8/cpu.o: in

Re: [PATCH v1 3/3] arm: npcm8xx: support dcache off

2023-09-26 Thread Tom Rini
On Tue, Sep 26, 2023 at 04:56:50PM +0800, Jim Liu wrote: > do not enable dcache by setting CONFIG_SYS_NPCM_DCACHE_OFF=y > > Signed-off-by: Jim Liu > --- > arch/arm/mach-npcm/npcm8xx/Kconfig | 4 > arch/arm/mach-npcm/npcm8xx/cpu.c | 12 +++- > 2 files changed, 15 insertions(+),

[PATCH v1 3/3] arm: npcm8xx: support dcache off

2023-09-26 Thread Jim Liu
do not enable dcache by setting CONFIG_SYS_NPCM_DCACHE_OFF=y Signed-off-by: Jim Liu --- arch/arm/mach-npcm/npcm8xx/Kconfig | 4 arch/arm/mach-npcm/npcm8xx/cpu.c | 12 +++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-npcm/npcm8xx/Kconfig