Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-10-03 Thread Jassi Brar
Hi Ilias, On Mon, Oct 3, 2022 at 7:21 AM Ilias Apalodimas wrote: > > Hi Jassi, > > On Wed, Sep 28, 2022 at 10:16:53AM -0500, Jassi Brar wrote: > > Hi Etienne, > > > > On Wed, Sep 28, 2022 at 2:30 AM Etienne Carriere > > wrote: > > > Hello Jassi, Sughosh and all, > > > > > > >>> But a malicious

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-10-03 Thread Ilias Apalodimas
Hi Jassi, On Wed, Sep 28, 2022 at 10:16:53AM -0500, Jassi Brar wrote: > Hi Etienne, > > On Wed, Sep 28, 2022 at 2:30 AM Etienne Carriere > wrote: > > Hello Jassi, Sughosh and all, > > > > >>> But a malicious user may force some old vulnerable image back into use > > >>> by updating all but

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-10-03 Thread Etienne Carriere
Hello Jassi, On Wed, 28 Sept 2022 at 17:17, Jassi Brar wrote: > > Hi Etienne, > > On Wed, Sep 28, 2022 at 2:30 AM Etienne Carriere > wrote: > > Hello Jassi, Sughosh and all, > > > > >>> But a malicious user may force some old vulnerable image back into use > > >>> by updating all but that

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-28 Thread Jassi Brar
Hi Etienne, On Wed, Sep 28, 2022 at 2:30 AM Etienne Carriere wrote: > Hello Jassi, Sughosh and all, > > >>> But a malicious user may force some old vulnerable image back into use > >>> by updating all but that image. > > When the system boots with accepted images (referring to fwu-mdata >

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-28 Thread Etienne Carriere
Hello Jassi, Sughosh and all, On Wed, 28 Sept 2022 at 08:23, Sughosh Ganu wrote: > > On Tue, 27 Sept 2022 at 22:19, Jassi Brar wrote: > > > > On Tue, Sep 27, 2022 at 2:22 AM Sughosh Ganu > > wrote: > > > > > > On Mon, 26 Sept 2022 at 20:24, Jassi Brar > > > wrote: > > > > > > > > On Mon,

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-28 Thread Sughosh Ganu
On Tue, 27 Sept 2022 at 22:19, Jassi Brar wrote: > > On Tue, Sep 27, 2022 at 2:22 AM Sughosh Ganu wrote: > > > > On Mon, 26 Sept 2022 at 20:24, Jassi Brar wrote: > > > > > > On Mon, Sep 26, 2022 at 4:01 AM Sughosh Ganu > > > wrote: > > > > On Mon, 26 Sept 2022 at 08:25, Jassi Brar > > > >

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-27 Thread Jassi Brar
On Tue, Sep 27, 2022 at 2:22 AM Sughosh Ganu wrote: > > On Mon, 26 Sept 2022 at 20:24, Jassi Brar wrote: > > > > On Mon, Sep 26, 2022 at 4:01 AM Sughosh Ganu > > wrote: > > > On Mon, 26 Sept 2022 at 08:25, Jassi Brar > > > wrote: > > > > > > . > > > > > > > > > > +static __maybe_unused

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-27 Thread Sughosh Ganu
On Mon, 26 Sept 2022 at 20:24, Jassi Brar wrote: > > On Mon, Sep 26, 2022 at 4:01 AM Sughosh Ganu wrote: > > On Mon, 26 Sept 2022 at 08:25, Jassi Brar wrote: > > > > . > > > > > > > > +static __maybe_unused efi_status_t fwu_post_update_process(bool > > > > fw_accept_os) > > > > +{ > > > >

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-26 Thread Jassi Brar
On Mon, Sep 26, 2022 at 4:01 AM Sughosh Ganu wrote: > On Mon, 26 Sept 2022 at 08:25, Jassi Brar wrote: > > . > > > > > > +static __maybe_unused efi_status_t fwu_post_update_process(bool > > > fw_accept_os) > > > +{ > > > + int status; > > > + u32 update_index; > > > +

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-26 Thread Sughosh Ganu
On Mon, 26 Sept 2022 at 08:25, Jassi Brar wrote: > > On Thu, Sep 15, 2022 at 3:17 AM Sughosh Ganu wrote: > > > + > > +static __maybe_unused void fwu_post_update_checks( > > + struct efi_capsule_header *capsule, > > + bool *fw_accept_os, bool *capsule_update) > > +{ > > +

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-25 Thread Jassi Brar
On Thu, Sep 15, 2022 at 3:17 AM Sughosh Ganu wrote: > + > +static __maybe_unused void fwu_post_update_checks( > + struct efi_capsule_header *capsule, > + bool *fw_accept_os, bool *capsule_update) > +{ > + if (fwu_empty_capsule(capsule)) > + *capsule_update =

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-21 Thread Takahiro Akashi
On Wed, Sep 21, 2022 at 04:56:20PM +0530, Sughosh Ganu wrote: > hi Takahiro, > > On Wed, 21 Sept 2022 at 10:58, Takahiro Akashi > wrote: > > > > Sughosh, > > > > On Tue, Sep 20, 2022 at 06:34:12PM +0530, Sughosh Ganu wrote: > > > On Tue, 20 Sept 2022 at 13:46, Takahiro Akashi > > > wrote: > > >

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-21 Thread Sughosh Ganu
hi Takahiro, On Wed, 21 Sept 2022 at 10:58, Takahiro Akashi wrote: > > Sughosh, > > On Tue, Sep 20, 2022 at 06:34:12PM +0530, Sughosh Ganu wrote: > > On Tue, 20 Sept 2022 at 13:46, Takahiro Akashi > > wrote: > > > > > > On Fri, Sep 16, 2022 at 04:24:35PM +0530, Sughosh Ganu wrote: > > > > hi

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-20 Thread Takahiro Akashi
Sughosh, On Tue, Sep 20, 2022 at 06:34:12PM +0530, Sughosh Ganu wrote: > On Tue, 20 Sept 2022 at 13:46, Takahiro Akashi > wrote: > > > > On Fri, Sep 16, 2022 at 04:24:35PM +0530, Sughosh Ganu wrote: > > > hi Takahiro, > > > > > > On Fri, 16 Sept 2022 at 12:20, Takahiro Akashi > > > wrote: > > >

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-20 Thread Sughosh Ganu
On Tue, 20 Sept 2022 at 13:46, Takahiro Akashi wrote: > > On Fri, Sep 16, 2022 at 04:24:35PM +0530, Sughosh Ganu wrote: > > hi Takahiro, > > > > On Fri, 16 Sept 2022 at 12:20, Takahiro Akashi > > wrote: > > > > > > On Fri, Sep 16, 2022 at 10:52:11AM +0530, Sughosh Ganu wrote: > > > > () hi

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-20 Thread Takahiro Akashi
On Fri, Sep 16, 2022 at 04:24:35PM +0530, Sughosh Ganu wrote: > hi Takahiro, > > On Fri, 16 Sept 2022 at 12:20, Takahiro Akashi > wrote: > > > > On Fri, Sep 16, 2022 at 10:52:11AM +0530, Sughosh Ganu wrote: > > > () hi Takahiro, > > > > > > On Fri, 16 Sept 2022 at 07:17, Takahiro Akashi > > >

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-16 Thread Sughosh Ganu
hi Takahiro, On Fri, 16 Sept 2022 at 12:20, Takahiro Akashi wrote: > > On Fri, Sep 16, 2022 at 10:52:11AM +0530, Sughosh Ganu wrote: > > () hi Takahiro, > > > > On Fri, 16 Sept 2022 at 07:17, Takahiro Akashi > > wrote: > > > > > > Hi Sughosh, > > > > > > On Thu, Sep 15, 2022 at 01:44:46PM

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-16 Thread Takahiro Akashi
On Fri, Sep 16, 2022 at 10:52:11AM +0530, Sughosh Ganu wrote: > () hi Takahiro, > > On Fri, 16 Sept 2022 at 07:17, Takahiro Akashi > wrote: > > > > Hi Sughosh, > > > > On Thu, Sep 15, 2022 at 01:44:46PM +0530, Sughosh Ganu wrote: > > > The FWU Multi Bank Update feature supports updation of

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-15 Thread Sughosh Ganu
() hi Takahiro, On Fri, 16 Sept 2022 at 07:17, Takahiro Akashi wrote: > > Hi Sughosh, > > On Thu, Sep 15, 2022 at 01:44:46PM +0530, Sughosh Ganu wrote: > > The FWU Multi Bank Update feature supports updation of firmware images > > to one of multiple sets(also called banks) of images. The

Re: [PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-15 Thread Takahiro Akashi
Hi Sughosh, On Thu, Sep 15, 2022 at 01:44:46PM +0530, Sughosh Ganu wrote: > The FWU Multi Bank Update feature supports updation of firmware images > to one of multiple sets(also called banks) of images. The firmware > images are clubbed together in banks, with the system booting images > from the

[PATCH v10 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-09-15 Thread Sughosh Ganu
The FWU Multi Bank Update feature supports updation of firmware images to one of multiple sets(also called banks) of images. The firmware images are clubbed together in banks, with the system booting images from the active bank. Information on the images such as which bank they belong to is stored