Re: [PATCH v2] pci: Do not enable PCIe GEN3 link retrain workaround by default

2022-09-17 Thread Maciej W. Rozycki
On Tue, 30 Aug 2022, Pali Rohár wrote: > > Agreed. But I also understand the reasoning from Maciej, at least in > > parts. Thinking a bit more about this, my preference would be to still > > include this workaround per default in U-Boot proper though. To not > > make things too complicated here.

Re: [PATCH v2] pci: Do not enable PCIe GEN3 link retrain workaround by default

2022-09-17 Thread Maciej W. Rozycki
On Tue, 30 Aug 2022, Stefan Roese wrote: > > I think I wrote it. One issue is that it is increasing size of SPL image > > and we really should not include into SPL things which are not required > > for all target platforms. Lot of boards have size constrained memory > > requirements and

Re: [PATCH v2] pci: Do not enable PCIe GEN3 link retrain workaround by default

2022-09-17 Thread Maciej W. Rozycki
On Tue, 30 Aug 2022, Pali Rohár wrote: > > > Moreover this workaround is enabled for all existing hardware and also all > > > future PCIe hardware, which opens a hole that other PCIe vendors may > > > introduce same HW issue as on systems where this workaround is required > > > and > > > nobody

Re: [PATCH v2] pci: Do not enable PCIe GEN3 link retrain workaround by default

2022-08-30 Thread Pali Rohár
On Tuesday 30 August 2022 13:15:26 Stefan Roese wrote: > On 30.08.22 11:19, Pali Rohár wrote: > > On Tuesday 30 August 2022 10:04:51 Maciej W. Rozycki wrote: > > > On Sat, 27 Aug 2022, Pali Rohár wrote: > > > > > > > Moreover this workaround is enabled for all existing hardware and also > > > >

Re: [PATCH v2] pci: Do not enable PCIe GEN3 link retrain workaround by default

2022-08-30 Thread Stefan Roese
On 30.08.22 11:19, Pali Rohár wrote: On Tuesday 30 August 2022 10:04:51 Maciej W. Rozycki wrote: On Sat, 27 Aug 2022, Pali Rohár wrote: Moreover this workaround is enabled for all existing hardware and also all future PCIe hardware, which opens a hole that other PCIe vendors may introduce

Re: [PATCH v2] pci: Do not enable PCIe GEN3 link retrain workaround by default

2022-08-30 Thread Pali Rohár
On Tuesday 30 August 2022 10:04:51 Maciej W. Rozycki wrote: > On Sat, 27 Aug 2022, Pali Rohár wrote: > > > Moreover this workaround is enabled for all existing hardware and also all > > future PCIe hardware, which opens a hole that other PCIe vendors may > > introduce same HW issue as on systems

Re: [PATCH v2] pci: Do not enable PCIe GEN3 link retrain workaround by default

2022-08-30 Thread Maciej W. Rozycki
On Sat, 27 Aug 2022, Pali Rohár wrote: > Moreover this workaround is enabled for all existing hardware and also all > future PCIe hardware, which opens a hole that other PCIe vendors may > introduce same HW issue as on systems where this workaround is required and > nobody would notice it because

Re: [PATCH v2] pci: Do not enable PCIe GEN3 link retrain workaround by default

2022-08-29 Thread Simon Glass
On Sat, 27 Aug 2022 at 06:30, Pali Rohár wrote: > > PCIe GEN3 link retrain workaround, specially designed for system with PCIe > ASMedia ASM2824 Switch and other Endpoint devices, unconditionally increase > size of all SPL binaries with PCIe support, even those which do not require > it. > >

[PATCH v2] pci: Do not enable PCIe GEN3 link retrain workaround by default

2022-08-27 Thread Pali Rohár
PCIe GEN3 link retrain workaround, specially designed for system with PCIe ASMedia ASM2824 Switch and other Endpoint devices, unconditionally increase size of all SPL binaries with PCIe support, even those which do not require it. Moreover this workaround is enabled for all existing hardware and