Re: [PATCH v2] powerpc: mpc: Put U-Boot version string at correct place by linker script

2021-09-16 Thread Tom Rini
On Sun, Aug 08, 2021 at 01:20:38PM +0200, Pali Rohár wrote: > It is unknown why version string is placed at specific position on these > powerpc mpc platforms. But there is no need to overload version_string > symbol. Just use common definition of version_string and modify linker > script to put

Re: [PATCH v2] powerpc: mpc: Put U-Boot version string at correct place by linker script

2021-08-24 Thread Pali Rohár
On Tuesday 24 August 2021 07:28:07 Christophe Leroy wrote: > Le 08/08/2021 à 13:20, Pali Rohár a écrit : > > It is unknown why version string is placed at specific position on these > > powerpc mpc platforms. But there is no need to overload version_string > > symbol. Just use common definition of

Re: [PATCH v2] powerpc: mpc: Put U-Boot version string at correct place by linker script

2021-08-24 Thread Wolfgang Denk
Dear Christophe, In message <75ae39aa-3762-6b90-c39a-7595fc417...@csgroup.eu> you wrote: > > > Also, could you look at this, why version string is at specific location > > of u-boot.bin header? > > I have no idea. AFAIKS it's been like that since the first version > in git in 2002. Maybe

Re: [PATCH v2] powerpc: mpc: Put U-Boot version string at correct place by linker script

2021-08-23 Thread Christophe Leroy
Le 08/08/2021 à 13:20, Pali Rohár a écrit : It is unknown why version string is placed at specific position on these powerpc mpc platforms. But there is no need to overload version_string symbol. Just use common definition of version_string and modify linker script to put it at "correct

Re: [PATCH v2] powerpc: mpc: Put U-Boot version string at correct place by linker script

2021-08-23 Thread Christophe Leroy
Le 08/08/2021 à 13:36, Pali Rohár a écrit : Christophe, could you please review this change? According to your commit https://source.denx.de/u-boot/u-boot/-/commit/907208c452999427cb2f43450308045bf8b42958 mpc8xx code will have to be maintained until at least 2027. On Sunday 08 August 2021

Re: [PATCH v2] powerpc: mpc: Put U-Boot version string at correct place by linker script

2021-08-08 Thread Pali Rohár
Christophe, could you please review this change? According to your commit https://source.denx.de/u-boot/u-boot/-/commit/907208c452999427cb2f43450308045bf8b42958 mpc8xx code will have to be maintained until at least 2027. On Sunday 08 August 2021 13:20:38 Pali Rohár wrote: > It is unknown why

[PATCH v2] powerpc: mpc: Put U-Boot version string at correct place by linker script

2021-08-08 Thread Pali Rohár
It is unknown why version string is placed at specific position on these powerpc mpc platforms. But there is no need to overload version_string symbol. Just use common definition of version_string and modify linker script to put it at "correct place". Signed-off-by: Pali Rohár --- Changes in